bible270 1.1.4 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a1d5f984616aed86326fe24bdb808b539bbd6cc8fe28e61f58838e6fba6573ca
-  data.tar.gz: 661d698c8eaacee191eb27eda7fa75bc83cf0df94ef5dfc85ae18974a26ead0d
+  metadata.gz: 1a655ad0a130cd6a4106374efb885fa76856b7f93c7fc05284062648a330125e
+  data.tar.gz: d23e6b7180c152f1b452e6eac5db9523f0e8cb7683ee50492fc8bbdc00d271cb
 SHA512:
-  metadata.gz: 60ccdd3d39fadb44e75c0eef05e18bc304032636e440f6d8d9b3b0a941b6c1a2a73bdc5231ae353de27d8b5aa8923f028e4dbd16d259ea9079bce20bf6b7bd9b
-  data.tar.gz: 0c41c6c130e93d42bc1d45dd1757c2f2216a378bf77cf5118dce25f28e72fceeb813f5064bb5ec93397afc077091f1a649b068b69f0616c964cfb2f700ab5cce
+  metadata.gz: 791373f6597dde62c9a6ce8eaab3251868f4b19bbf24615fec46613ebab7e918e4f90e3eb8f318ed85502b1a769eb71c7290adb4973f17d3400eb411d2664202
+  data.tar.gz: 71b588c2a184a1939ee9c7c79dce661fcc017e2199ea732e334ebc2ba49412ec3bfcd029880e4cdffe64724c21d33a5e157c7f9dc886feda1d583f9b56e64db4

data/CHANGELOG.md

@@ -4,6 +4,14 @@ All notable changes to bible270. Format follows [Keep a Changelog](https://keepa
 
 ## Unreleased Changes
 
+### Changed
+
+- reuse one dedicated browser tab for Bible Gateway and Blue Letter Bible Scripture links instead of opening an unlimited series of tabs
+
+### Removed
+
+- remove the unused `passage_url_builder` configuration hook; Bible Gateway and Blue Letter Bible are now the intentionally fixed passage providers
+
 **[Full Changelog](https://github.com/avonderluft/bible270/compare/v1.1.3...main)**
 
 ## [1.1.3] - 2026-08-23

data/README.md

@@ -415,9 +415,6 @@ Bible270.configure do |config|
   config.after_sign_out_path = nil
 
   config.bible_version = "NKJV"
-  config.passage_url_builder = ->(reference, version) {
-    "https://www.biblegateway.com/passage/?search=#{URI.encode_www_form_component(reference)}&version=#{version}"
-  }
 end
 ```
 ### Footer
@@ -460,7 +457,9 @@ It's emitted by the engine's layout, so if you point `config.layout` at your own
 References link to Bible Gateway by default. Readers choose Bible Gateway or Blue Letter Bible from
 their profile, and an admin can set the same source for any reader. The `HEB/GRK` option always uses
 Blue Letter Bible: WLC for Old Testament, Psalms, and Proverbs readings, and mGNT for New Testament
-readings. Set `passage_url_builder` to use another default reader, or a reader you host yourself.
+readings. Scripture links share one dedicated browser tab so moving among the day's passages does not
+leave a trail of open tabs; Ctrl-click, Cmd-click, middle-click, and the browser's context menu still
+open additional tabs when a reader wants to compare passages.
 
 ## With ComfortableMediaSurfer
 

data/app/helpers/bible270/plan_helper.rb

@@ -2,6 +2,8 @@
 
 module Bible270
   module PlanHelper
+    PASSAGE_LINK_TARGET = 'bible270_scripture'
+
     def b270_track(track)
       Plan::TRACKS.fetch(track.to_s)
     end
@@ -117,7 +119,18 @@ module Bible270
         return Translations.passage_url(reference, selected_version, blue_letter: true)
       end
 
-      Bible270.config.passage_url_builder.call(reference, selected_version)
+      Translations.passage_url(reference, selected_version)
+    end
+
+    # The named target and noopener are the secure no-JavaScript fallback.
+    # Interaction UI retains one opener-backed tab handle on desktop. iOS Safari
+    # cannot foreground a reused background tab, so it closes and replaces that
+    # script-opened tab on each click. The two fixed providers are intentionally
+    # trusted for this enhanced path.
+    def b270_passage_link(reference, **options)
+      data = options.fetch(:data, {}).merge(b270_passage_link: true)
+      options.merge!(data: data, target: PASSAGE_LINK_TARGET, rel: 'noopener')
+      link_to reference, b270_passage_url(reference), options
     end
 
     # Small grey "(NKJV)" after a reading, so it's clear which translation the
@@ -224,8 +237,7 @@ module Bible270
         reference = readings[track]
         next if reference.blank?
 
-        link_to reference, b270_passage_url(reference),
-                class: 'b270-reflink', target: '_blank', rel: 'noopener'
+        b270_passage_link reference, class: 'b270-reflink'
       end
 
       safe_join(links, ' · ')

data/app/views/bible270/days/_reading.html.erb

@@ -27,13 +27,13 @@
                                       b270_success: (part_done ? "Reading marked unread." : "Reading marked read."),
                                       b270_failure: "Couldn’t update that reading. Try again." } },
                       aria: { label: (part_done ? "Mark #{part_ref} unread" : "Mark #{part_ref} read") } do %>
-                  <span class="b270-check"><svg viewBox="0 0 24 24"><polyline points="20 6 9 17 4 12"/></svg></span>
+                  <span class="b270-check"><svg viewBox="0 0 24 24"><polyline points="20 6 9 17 4 12" /></svg></span>
                 <% end %>
               <% else %>
-                <span class="b270-check"><svg viewBox="0 0 24 24"><polyline points="20 6 9 17 4 12"/></svg></span>
+                <span class="b270-check"><svg viewBox="0 0 24 24"><polyline points="20 6 9 17 4 12" /></svg></span>
               <% end %>
               <span class="b270-ref">
-                <%= link_to part_ref, b270_passage_url(part_ref), target: "_blank", rel: "noopener" %>
+                <%= b270_passage_link part_ref %>
               </span>
             </li>
           <% end %>
@@ -51,14 +51,14 @@
                               b270_success: (done ? "Reading marked unread." : "Reading marked read."),
                               b270_failure: "Couldn’t update that reading. Try again." } },
               aria: { label: (done ? "Mark #{t[:label]} unread" : "Mark #{t[:label]} read") } do %>
-          <span class="b270-check"><svg viewBox="0 0 24 24"><polyline points="20 6 9 17 4 12"/></svg></span>
+          <span class="b270-check"><svg viewBox="0 0 24 24"><polyline points="20 6 9 17 4 12" /></svg></span>
         <% end %>
       <% else %>
-        <span class="b270-check"><svg viewBox="0 0 24 24"><polyline points="20 6 9 17 4 12"/></svg></span>
+        <span class="b270-check"><svg viewBox="0 0 24 24"><polyline points="20 6 9 17 4 12" /></svg></span>
       <% end %>
       <div class="b270-rbody">
         <div class="b270-cat"><%= t[:label] %></div>
-        <div class="b270-ref"><%= link_to ref, b270_passage_url(ref), target: "_blank", rel: "noopener" %> <%= b270_version_tag(track: track) %></div>
+        <div class="b270-ref"><%= b270_passage_link ref %> <%= b270_version_tag(track: track) %></div>
       </div>
     <% end %>
   </div>

data/app/views/bible270/shared/_interaction_ui.html.erb

@@ -30,6 +30,35 @@
       document.querySelectorAll("form[data-b270-submit='true']").forEach(resetForm);
     }
 
+    let scriptureWindow = null;
+    const replacesBackgroundTabs = /iPad|iPhone|iPod/.test(navigator.userAgent) ||
+      (navigator.platform === "MacIntel" && navigator.maxTouchPoints > 1);
+
+    document.addEventListener("click", (event) => {
+      const target = event.target;
+      const link = target.closest && target.closest("a[data-b270-passage-link='true']");
+      if (!link || event.defaultPrevented || event.button !== 0) return;
+      if (event.metaKey || event.ctrlKey || event.shiftKey || event.altKey) return;
+
+      try {
+        if (replacesBackgroundTabs && scriptureWindow && !scriptureWindow.closed) {
+          scriptureWindow.close();
+          scriptureWindow = null;
+        }
+
+        if (!scriptureWindow || scriptureWindow.closed) {
+          scriptureWindow = window.open(link.href, "_blank");
+          if (!scriptureWindow) return;
+        } else {
+          scriptureWindow.location = link.href;
+        }
+        event.preventDefault();
+        scriptureWindow.focus();
+      } catch (_error) {
+        scriptureWindow = null;
+      }
+    });
+
     document.addEventListener("submit", (event) => {
       const form = event.target.closest("form[data-b270-submit='true']");
       if (!form) return;

data/lib/bible270/configuration.rb

@@ -271,7 +271,6 @@ module Bible270
       PROVIDER_LABELS[key.to_sym] || key.to_s.tr('_', ' ').split.map(&:capitalize).join(' ')
     end
 
-    # Default Bible translation and a builder for external passage links.
     # Which translations readers may choose from. Defaults to all of
     # Bible270::Translations::VERSIONS; narrow it to offer fewer.
     attr_accessor :bible_versions
@@ -297,7 +296,7 @@ module Bible270
     # application owns scheduling the bible270:reminders:send task.
     attr_accessor :daily_reminders
 
-    attr_accessor :after_sign_out_path, :email_sign_in_max_per_window, :passage_url_builder, :tagline, :footer_html, :footer, :favicon, :avatar_max_bytes, :chapter_breaks, :admin_emails, :admin_resolver, :bible_version, :header_mark, :remember_for, :require_sign_in_to_participate
+    attr_accessor :after_sign_out_path, :email_sign_in_max_per_window, :tagline, :footer_html, :footer, :favicon, :avatar_max_bytes, :chapter_breaks, :admin_emails, :admin_resolver, :bible_version, :header_mark, :remember_for, :require_sign_in_to_participate
 
     # Public labels.
     attr_accessor :app_name
@@ -355,7 +354,6 @@ module Bible270
       @after_sign_out_path = nil
       @bible_version = 'NKJV'
       @bible_versions = Translations::VERSIONS.keys
-      @passage_url_builder = ->(reference, version) { Translations.passage_url(reference, version) }
       @app_name = 'Daily Bread'
       @tagline = 'Journeying through Scripture in 9 months'
       @time_zone = nil

data/lib/bible270/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bible270
-  VERSION = '1.1.4'
+  VERSION = '1.1.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bible270
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.5
 platform: ruby
 authors:
 - Andrew vonderLuft