bi-frost 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e2c0c05d4f226f4592d8b654a36e2a324dcf0042
-  data.tar.gz: 2a085487e7a616543e690d4d428d89087d1b750d
+  metadata.gz: 9bae9c137149abf5f29d00b38d46763ead852eec
+  data.tar.gz: 6dbd4e1370c6b62ce67bd7df6826b0a8d75e664b
 SHA512:
-  metadata.gz: 89b9ae01ccb0f14d03d926494afa83491b98cbc597b796a1e8eb48e606acc92b8bc23648b16548a7df71803b16b5536ec285262fde25d1a09cee58aebb3cb8cf
-  data.tar.gz: da58e3c72a1e34338089a4a253e56fe60871f5564538613379b6d510827a42682d8d51e8dca56b3742c556eeb1beed4aa3952a6eb479e8eb60dd8ffe274e5c94
+  metadata.gz: e07411b6991e054810097254fc39d2e5745ff2fccb2a75bdb0e9c4051c269feed887094c4e2eaef128a37d4978ba453c263da0c903e199163d6e4b7b1b0f3ea0
+  data.tar.gz: 105f3f014d5fb0d5444f03b6c258eb9fdc2e0cbaf65b97089b87167ddf0f728f9a78dda8dc7356736b043f1bc57d8f087e1eaec197cad6cd2339be00e9285962

data/lib/bifrost/bus.rb

@@ -10,15 +10,41 @@ module Bifrost
     def initialize
       Azure.sb_namespace = ENV['AZURE_BUS_NAMESPACE']
       host = "https://#{Azure.sb_namespace}.servicebus.windows.net"
-      signer = Azure::ServiceBus::Auth::SharedAccessSigner.new(ENV['AZURE_BUS_KEY_NAME'], ENV['AZURE_BUS_KEY_SECRET'])
+      signer = Azure::ServiceBus::Auth::SharedAccessSigner.new(key, secret)
       @interface ||= Azure::ServiceBus::ServiceBusService.new(host, signer: signer)
     end
 
+    # To encapsulate the underlying bus object we provide a custom interface
+    # for the methods of the Azure smb we use
+    def create_topic(name)
+      @interface.create_topic(name)
+    end
+
+    def delete_topic(name)
+      @interface.delete_topic(name)
+    end
+
     # This method returns a list of topics currently defined on the Bifrost
     def topics
       @interface.list_topics.map do |t|
         Topic.new(t.name)
       end
     end
+
+    # Tells us if the topic has already been defined
+    def topic_exists?(topic)
+      topics.include?(topic)
+    end
+
+    private
+
+    # Simple utlity method to keep the code legible
+    def key
+      ENV['AZURE_BUS_KEY_NAME']
+    end
+
+    def secret
+      ENV['AZURE_BUS_KEY_SECRET']
+    end
   end
 end

data/lib/bifrost/topic.rb

@@ -13,21 +13,12 @@ module Bifrost
       super()
     end
 
-    # If the topic has been defined this method returns true, if not
-    # it returns false
-    def exists?
-      @bus.topics.each do |topic|
-        return true if topic.name == name
-      end
-      false
-    end
-
     # If a topic has not been defined we can save it, so it becomes defined
     def save
       if exists?
         false
       else
-        @bus.interface.create_topic(name)
+        @bus.create_topic(name)
         true
       end
     end
@@ -35,7 +26,7 @@ module Bifrost
     # If a topic is defined, we can remove the definition
     def delete
       if exists?
-        @bus.interface.delete_topic(name)
+        @bus.delete_topic(name)
         true
       else
         false
@@ -71,5 +62,15 @@ module Bifrost
         false
       end
     end
+
+    def ==(another_topic)
+      self.name == another_topic.name && self.class == another_topic.class
+    end
+
+    # Topics are self aware, and know if they exist or not, but only with the help
+    # of the almighty bus
+    def exists?
+      @bus.topic_exists?(self)
+    end
   end
 end

data/lib/bifrost/version.rb

@@ -9,7 +9,7 @@ module Bifrost
 
   # The patch version of Bifrost, updated only for bug fixes from the last
   # feature release.
-  PATCH_VERSION = 3
+  PATCH_VERSION = 4
 
   # The full version as a string.
   VERSION = "#{MAJOR_VERSION}.#{MINOR_VERSION}.#{PATCH_VERSION}".freeze

data/spec/bifrost/bus_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe Bifrost::Bus do
+  let(:bus)   { Bifrost::Bus.new }
+
+  context 'for an undefined topic' do
+    it 'should return false for defined?' do
+      new_topic = Bifrost::Topic.new('new-topic')
+      expect(bus.topic_exists?(new_topic)).to be_falsey
+    end
+  end
+
+  context 'for a defined topic' do
+    it 'should return true for defined?' do
+      topic = Bifrost::Topic.new('bus-topic')
+      topic.save
+      dup_topic = Bifrost::Topic.new('bus-topic')
+      expect(bus.topic_exists?(dup_topic)).to be_truthy
+      topic.delete
+    end
+  end
+end

data/spec/bifrost/topic_spec.rb

@@ -5,7 +5,6 @@ describe Bifrost::Topic do
   subject(:topic) { Bifrost::Topic.new('topic_name') }
 
   it { is_expected.to respond_to(:name) }
-  it { is_expected.to respond_to(:exists?) }
   it { is_expected.to respond_to(:save) }
   it { is_expected.to respond_to(:delete) }
   it { is_expected.to respond_to(:add_subscriber) }
@@ -16,11 +15,23 @@ describe Bifrost::Topic do
     expect { invalid_topic.save }.to raise_error(TypeError)
   end
 
-  context 'for an undefined topic' do
-    it 'should return false for defined?' do
-      expect(topic.exists?).to be_falsey
+  describe 'equality' do
+    it 'should return true for the same object' do
+      expect(topic).to eq(topic)
+    end
+
+    it 'should return true for topics with the same name' do
+      same_topic = Bifrost::Topic.new('topic_name')
+      expect(same_topic).to eq(topic)
     end
 
+    it 'should return false for topics with disimilar names' do
+      different_topic = Bifrost::Topic.new('different_topic_name')
+      expect(different_topic).not_to eq(topic)
+    end
+  end
+
+  context 'for an undefined topic' do
     it 'should persist the topic' do
       new_topic = Bifrost::Topic.new('new_topic_name')
       expect(new_topic.save).to be_truthy
@@ -46,17 +57,15 @@ describe Bifrost::Topic do
     let(:new_topic) { Bifrost::Topic.new('test_donotdelete') }
 
     before(:all) do
+      bus = Bifrost::Bus.new
       tp = Bifrost::Topic.new('test_donotdelete')
-      tp.save unless tp.exists?
+      tp.save unless bus.topic_exists?(tp)
     end
 
     after(:all) do
+      bus = Bifrost::Bus.new
       tp = Bifrost::Topic.new('test_donotdelete')
-      tp.delete if tp.exists?
-    end
-
-    it 'should return true for defined?' do
-      expect(new_topic.exists?).to be_truthy
+      tp.delete if bus.topic_exists?(tp)
     end
 
     it 'should return false for save' do

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'azure'
+require 'bifrost'
 require 'byebug'
 require 'dotenv'
 require 'simplecov'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bi-frost
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Shirren Premaratne
@@ -171,6 +171,7 @@ files:
 - lib/bifrost/topic.rb
 - lib/bifrost/version.rb
 - lib/bifrost/worker.rb
+- spec/bifrost/bus_spec.rb
 - spec/bifrost/manager_spec.rb
 - spec/bifrost/message_spec.rb
 - spec/bifrost/subscriber_spec.rb
@@ -204,6 +205,7 @@ specification_version: 4
 summary: Bifrost is a pub/sub wrapper library which uses the Azure message bus and
   actors.
 test_files:
+- spec/bifrost/bus_spec.rb
 - spec/bifrost/manager_spec.rb
 - spec/bifrost/message_spec.rb
 - spec/bifrost/subscriber_spec.rb