bharat_filter_engine 0.1.2 → 0.2.0

data/spec/dynamic_filter_values_spec.rb

@@ -1,51 +1,51 @@
-require "spec_helper"
+# frozen_string_literal: true
 
-RSpec.describe BharatFilterEngine::DynamicFilterValues do
+require 'spec_helper'
 
+RSpec.describe BharatFilterEngine::DynamicFilterValues do
   let!(:client_one) do
     Client.create!(
-      name: "John"
+      name: 'John'
     )
   end
 
   let!(:client_two) do
     Client.create!(
-      name: "Jane"
+      name: 'Jane'
     )
   end
 
   let!(:lead_one) do
     Lead.create!(
-      source: "google",
+      source: 'google',
       client: client_one
     )
   end
 
   let!(:lead_two) do
     Lead.create!(
-      source: "referral",
+      source: 'referral',
       client: client_two
     )
   end
 
   before do
     Sale.create!(
-      stage: "qualified",
+      stage: 'qualified',
       lead: lead_one
     )
 
     Sale.create!(
-      stage: "new",
+      stage: 'new',
       lead: lead_two
     )
   end
 
-  it "returns direct values" do
-
+  it 'returns direct values' do
     result =
       described_class.new(
         scope: Sale.all,
-        field: "stage"
+        field: 'stage'
       ).call
 
     expect(result).to eq(
@@ -53,12 +53,11 @@ RSpec.describe BharatFilterEngine::DynamicFilterValues do
     )
   end
 
-  it "returns nested values" do
-
+  it 'returns nested values' do
     result =
       described_class.new(
         scope: Sale.all,
-        field: "lead__source"
+        field: 'lead__source'
       ).call
 
     expect(result).to eq(
@@ -66,12 +65,11 @@ RSpec.describe BharatFilterEngine::DynamicFilterValues do
     )
   end
 
-  it "returns multi-level nested values" do
-
+  it 'returns multi-level nested values' do
     result =
       described_class.new(
         scope: Sale.all,
-        field: "lead__client__name"
+        field: 'lead__client__name'
       ).call
 
     expect(result).to eq(
@@ -79,47 +77,54 @@ RSpec.describe BharatFilterEngine::DynamicFilterValues do
     )
   end
 
-  it "returns nil for invalid field" do
-
+  it 'returns nil for invalid field' do
     result =
       described_class.new(
         scope: Sale.all,
-        field: "invalid_field"
+        field: 'invalid_field'
       ).call
 
     expect(result).to be_nil
   end
 
-  it "returns nil for a valid association with an invalid column" do
-
+  it 'returns nil for a valid association with an invalid column' do
     result =
       described_class.new(
         scope: Sale.all,
-        field: "lead__something_wrong"
+        field: 'lead__something_wrong'
       ).call
 
     expect(result).to be_nil
   end
 
-  it "returns nil for an invalid association" do
+  it 'returns nil for an invalid association' do
+    result =
+      described_class.new(
+        scope: Sale.all,
+        field: 'something__name'
+      ).call
+
+    expect(result).to be_nil
+  end
 
+  it 'returns nil for an invalid association at a deeper level' do
     result =
       described_class.new(
         scope: Sale.all,
-        field: "something__name"
+        field: 'lead__something__name'
       ).call
 
     expect(result).to be_nil
   end
 
-  it "does not return blank values" do
-    Sale.create!(stage: "")
+  it 'does not return blank values' do
+    Sale.create!(stage: '')
     Sale.create!(stage: nil)
 
     result =
       described_class.new(
         scope: Sale.all,
-        field: "stage"
+        field: 'stage'
       ).call
 
     expect(result).to eq(
@@ -127,4 +132,131 @@ RSpec.describe BharatFilterEngine::DynamicFilterValues do
     )
   end
 
-end
+  it 'returns distinct values for an integer column' do
+    Sale.create!(project_id: 3)
+    Sale.create!(project_id: 1)
+    Sale.create!(project_id: 3)
+    Sale.create!(project_id: nil)
+
+    result = described_class.new(scope: Sale.all, field: 'project_id').call
+    expect(result).to eq([1, 3])
+  end
+
+  it 'keeps a zero value for a numeric column' do
+    Sale.create!(amount: 0)
+    Sale.create!(amount: 5)
+
+    result = described_class.new(scope: Sale.all, field: 'amount').call
+    expect(result).to eq([0, 5])
+  end
+
+  it 'returns distinct values for a datetime column' do
+    Sale.create!(actual_sale_date: Time.utc(2013, 1, 1))
+    Sale.create!(actual_sale_date: nil)
+
+    result = described_class.new(scope: Sale.all, field: 'actual_sale_date').call
+    expect(result.size).to eq(1)
+  end
+
+  it 'returns distinct values for a nested integer column' do
+    client = Client.create!(name: 'Nested Co')
+    lead = Lead.create!(source: 'web', client: client)
+    Sale.create!(lead: lead)
+    Sale.create!(lead: lead)
+    Sale.create!(lead: nil)
+
+    result = described_class.new(scope: Sale.all, field: 'lead__client_id').call
+    expected = Sale.joins(:lead).distinct.pluck('leads.client_id').compact.sort
+
+    expect(result).to include(client.id)
+    expect(result).to eq(expected)
+  end
+
+  it 'filters values by a partial term' do
+    Sale.create!(stage: 'closed')
+
+    result =
+      described_class.new(
+        scope: Sale.all,
+        field: 'stage',
+        term: 'qual'
+      ).call
+
+    expect(result).to eq(['qualified'])
+  end
+
+  it 'is case-insensitive when filtering by term' do
+    result =
+      described_class.new(
+        scope: Sale.all,
+        field: 'stage',
+        term: 'QUAL'
+      ).call
+
+    expect(result).to eq(['qualified'])
+  end
+
+  it 'escapes LIKE wildcards in the term' do
+    Sale.create!(stage: 'sale_2026')
+    Sale.create!(stage: 'saleX2026')
+
+    result =
+      described_class.new(
+        scope: Sale.all,
+        field: 'stage',
+        term: 'sale_2026'
+      ).call
+
+    expect(result).to eq(['sale_2026'])
+  end
+
+  it 'limits the number of returned values' do
+    Sale.create!(stage: 'closed')
+
+    result =
+      described_class.new(
+        scope: Sale.all,
+        field: 'stage',
+        limit: 2
+      ).call
+
+    expect(result).to eq(%w[closed new])
+  end
+
+  it 'ignores a limit of zero' do
+    result =
+      described_class.new(
+        scope: Sale.all,
+        field: 'stage',
+        limit: 0
+      ).call
+
+    expect(result).to eq(%w[new qualified])
+  end
+
+  it 'combines term and limit together' do
+    Sale.create!(stage: 'quarantined')
+    Sale.create!(stage: 'qualified_lead')
+
+    result =
+      described_class.new(
+        scope: Sale.all,
+        field: 'stage',
+        term: 'qua',
+        limit: 1
+      ).call
+
+    expect(result).to eq(['qualified'])
+  end
+
+  it 'works with a nested field and a term together' do
+    result =
+      described_class.new(
+        scope: Sale.all,
+        field: 'lead__client__name',
+        term: 'Jo'
+      ).call
+
+    expect(result).to eq(['John'])
+  end
+end