bfs-gs 0.7.2 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: afb6b88566a06b714276613bb998fb3d4d02dd8534ba2210a57b2a215d567c14
-  data.tar.gz: 26b4631d61959bd3d02c45fcd7a02e9c5d64e4aadfdce9f9beee6051185097f4
+  metadata.gz: 345994febf6083e1839a95b796da1b86075c831aa320eee9f9fff7ea13974099
+  data.tar.gz: '096620f7ada887459c5bbd94b46c94c8175523f03f2d47b33880068af3e7b2e2'
 SHA512:
-  metadata.gz: 37352e78eec850efe6aa791e25597bf17fec5efec0088826736865320ba99d1a6ae24e8c818df45ffe0fd10abe8111258603cb272c5116e9bec3d0b0792671fe
-  data.tar.gz: 1e3e729c4c231821a09e045d94f9e38f10b530de567e8bad1eacccb2ecc6abe79c4736dd6031a8e306adfe26d5565bb1b967c4dcfffb04f826aff3c3335ee890
+  metadata.gz: 7e65dd0c03fbedff21bf049bcd32db8e3e3a55456577cf1e28647ab109dab3e8b2123199b210c97e96e458263672ef1fe55c5c21008cfe5494330e9e2fb4e912
+  data.tar.gz: cbaf26fa087974a16d84bead6fdb88a99b66c17fc4876fbe7df70cd67ace72ed430345c175419c68fb6321896beddefe9ed15ff3a2d6abcaac2002cf8aad4e1f

data/lib/bfs/bucket/gs.rb

@@ -59,18 +59,11 @@ module BFS
       def create(path, encoding: self.encoding, perm: self.perm, **opts, &block)
         opts[:metadata] = norm_meta(opts[:metadata])
         path = full_path(path)
-        temp = BFS::TempWriter.new(path, encoding: encoding, perm: perm) do |t|
+        BFS::Writer.new(path, encoding: encoding, perm: perm) do |t|
           File.open(t, encoding: encoding) do |file|
             @bucket.create_file(file, path, **opts)
           end
-        end
-        return temp unless block
-
-        begin
-          yield temp
-        ensure
-          temp.close
-        end
+        end.perform(&block)
       end
 
       # Opens an existing file for reading

data/spec/bfs/bucket/gs_spec.rb

@@ -6,43 +6,39 @@ module Google::Auth::CredentialsLoader
   module_function :warn_if_cloud_sdk_credentials # rubocop:disable Style/AccessModifierDeclarations
 end
 
-sandbox  = { project: 'bogus', bucket: 'bsm-bfs-unittest' }.freeze
-run_spec = \
-  begin
-    s = Google::Cloud::Storage.new(project_id: sandbox[:project])
-    !s.bucket(sandbox[:bucket]).nil?
-  rescue Signet::AuthorizationError => e
-    warn "WARNING: unable to run #{File.basename __FILE__}: #{e.message}"
-    false
-  end
+bucket_name = 'bsm-bfs-unittest'
 
-RSpec.describe BFS::Bucket::GS, if: run_spec do
+RSpec.describe BFS::Bucket::GS, gs: true do
   let(:prefix) { "x/#{SecureRandom.uuid}/" }
 
   subject do
-    described_class.new sandbox[:bucket], project_id: sandbox[:project], prefix: prefix
+    described_class.new bucket_name, prefix: prefix
   end
+
   after :all do
-    bucket = described_class.new sandbox[:bucket], project_id: sandbox[:project], prefix: 'x/'
+    bucket = described_class.new bucket_name, prefix: 'x/'
     bucket.ls.each {|name| bucket.rm(name) }
   end
 
   it_behaves_like 'a bucket'
 
   it 'should resolve from URL' do
-    bucket = BFS.resolve("gs://#{sandbox[:bucket]}/?project_id=#{sandbox[:project]}")
+    bucket = BFS.resolve("gs://#{bucket_name}")
     expect(bucket).to be_instance_of(described_class)
-    expect(bucket.name).to eq(sandbox[:bucket])
+    expect(bucket.name).to eq(bucket_name)
     expect(bucket.instance_variable_get(:@prefix)).to be_nil
+    bucket.close
 
-    bucket = BFS.resolve("gs://#{sandbox[:bucket]}/a/b/")
+    bucket = BFS.resolve("gs://#{bucket_name}/a/b/")
     expect(bucket).to be_instance_of(described_class)
-    expect(bucket.name).to eq(sandbox[:bucket])
+    expect(bucket.name).to eq(bucket_name)
     expect(bucket.instance_variable_get(:@prefix)).to eq('a/b')
+    bucket.close
   end
 
   it 'should enumerate over a large number of files' do
-    bucket = described_class.new sandbox[:bucket], project_id: sandbox[:project], prefix: 'm/'
+    bucket = described_class.new bucket_name, prefix: 'm/'
     expect(bucket.ls('**/*').count).to eq(2121)
+    bucket.close
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bfs-gs
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.8.0
 platform: ruby
 authors:
 - Dimitrij Denissenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-02 00:00:00.000000000 Z
+date: 2020-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bfs
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.7.2
+        version: 0.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.7.2
+        version: 0.8.0
 - !ruby/object:Gem::Dependency
   name: google-cloud-storage
   requirement: !ruby/object:Gem::Requirement