bfs-gs 0.3.5 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f085d9122aad2d58755e5b94ba4e03a21134c45c0611c1b1b98fe1e655b68ee2
-  data.tar.gz: 6d292b456b09fd34a56dee9545502a10b6c5a60ab4a68608dc3c7b1860801c05
+  metadata.gz: eb617f85d661ff62241a6cdb341a1e2a049718f05b6387ac712d643c98f37411
+  data.tar.gz: 4055f79b180285672256b0bddac2ad3a95a02f41146139aa49fda1e0fd84a3b1
 SHA512:
-  metadata.gz: a66705ddc9154d273854c54b69969317b5fbecba962d0de67b8df85addeef31bead2c005543bba3e0c0ebc83bea8018bba696643ee8a36eea609d23563f7f10d
-  data.tar.gz: 1fafaa5f6866a5460ce6352677bf00bf6f35948fd5734f29143a1108cd93851482eb72524328b6eb541849c8174a0fcea20e14fb77ee58e62efc8234bc85d4f1
+  metadata.gz: 97ce3d3cca1b171fb9d02c43010bbff0b30e39516f1fdb97093cfadc2b58ab39a2152c5d380690469aa8fcfe396d3d1ca4dba2705a1ea3f49846011fa591a15b
+  data.tar.gz: 908a0dd616fcbb52f4f0de5df486c95e86d9c84a4be43e243b06c4852c11357ee89fd6524d52492017b21e09d92915f9a310c86964543458d131222dc908b965

data/bfs-gs.gemspec

@@ -15,8 +15,8 @@ Gem::Specification.new do |s|
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- spec/*`.split("\n")
   s.require_paths = ['lib']
-  s.required_ruby_version = '>= 2.2.0'
+  s.required_ruby_version = '>= 2.4.0'
 
   s.add_dependency 'bfs', s.version
-  s.add_dependency 'google-cloud-storage'
+  s.add_dependency 'google-cloud-storage', '~> 1.18'
 end

data/lib/bfs/bucket/gs.rb

@@ -12,7 +12,7 @@ module BFS
       #
       # @param [String] name the bucket name.
       # @param [Hash] opts options.
-      # @option opts [String] :project_id project ID. Defaults to GCP_PROJECT  env var. Required.
+      # @option opts [String] :project_id project ID. Defaults to GCP_PROJECT env var.
       # @option opts [String, Hash, Google::Auth::Credentials] :credentials
       #   the path to the keyfile as a String, the contents of the keyfile as a Hash, or a Google::Auth::Credentials object.
       # @option opts [String] :prefix custom namespace within the bucket
@@ -20,12 +20,14 @@ module BFS
       # @option opts [Integer] :timeout request timeout, in seconds.
       # @option opts [String] :acl set the default ACL.
       # @option opts [Google::Cloud::Storage] :client custom client.
+      # @option opts [String] :encoding default encoding to use, default: 'binary'
       def initialize(name, opts={})
         opts = opts.dup
         opts.keys.each do |key|
           val = opts.delete(key)
           opts[key.to_sym] = val unless val.nil?
         end
+        super(opts)
 
         @prefix = opts.delete(:prefix)
         acl     = opts.delete(:acl)
@@ -63,8 +65,9 @@ module BFS
       # Creates a new file and opens it for writing
       def create(path, opts={}, &block)
         path = full_path(path)
-        temp = BFS::TempWriter.new(path) do |t|
-          File.open(t, binmode: true) do |file|
+        enc  = opts.delete(:encoding) || @encoding
+        temp = BFS::TempWriter.new(path, encoding: enc) do |t|
+          File.open(t, encoding: enc) do |file|
             @bucket.create_file(file, path, opts)
           end
         end
@@ -80,21 +83,22 @@ module BFS
       # Opens an existing file for reading
       def open(path, opts={}, &block)
         path = full_path(path)
+        enc  = opts.delete(:encoding) || @encoding
         file = @bucket.file(path)
         raise BFS::FileNotFound, trim_prefix(path) unless file
 
-        temp = Tempfile.new(File.basename(path), binmode: true)
+        temp = Tempfile.new(File.basename(path), encoding: enc)
         temp.close
         file.download temp.path, opts
 
-        File.open(temp.path, binmode: true, &block)
+        File.open(temp.path, encoding: enc, &block)
       end
 
       # Deletes a file.
       def rm(path, opts={})
         path = full_path(path)
         file = @bucket.file(path)
-        file.delete(opts) if file
+        file&.delete(opts)
       end
 
       # Copies a file.
@@ -111,9 +115,13 @@ end
 
 BFS.register('gs') do |url|
   params = CGI.parse(url.query.to_s)
+  prefix = BFS.norm_path(params.key?('prefix') ? params['prefix'].first : url.path)
+  prefix = nil if prefix.empty?
 
   BFS::Bucket::GS.new url.host,
+    prefix: prefix,
     project_id: params.key?('project_id') ? params['project_id'].first : nil,
+    credentials: params.key?('credentials') ? params['credentials'].first : nil,
     acl: params.key?('acl') ? params['acl'].first : nil,
     timeout: params.key?('timeout') ? params['timeout'].first.to_i : nil,
     retries: params.key?('retries') ? params['retries'].first.to_i : nil

data/spec/bfs/bucket/gs_spec.rb

@@ -11,7 +11,8 @@ run_spec = \
   begin
     s = Google::Cloud::Storage.new(project_id: sandbox[:project])
     !s.bucket(sandbox[:bucket]).nil?
-  rescue Signet::AuthorizationError
+  rescue Signet::AuthorizationError => e
+    warn "WARNING: unable to run #{File.basename __FILE__}: #{e.message}"
     false
   end
 
@@ -29,9 +30,15 @@ RSpec.describe BFS::Bucket::GS, if: run_spec do
   it_behaves_like 'a bucket'
 
   it 'should resolve from URL' do
-    bucket = BFS.resolve("gs://#{sandbox[:bucket]}?acl=private&project_id=#{sandbox[:project]}")
+    bucket = BFS.resolve("gs://#{sandbox[:bucket]}/?acl=private&project_id=#{sandbox[:project]}")
     expect(bucket).to be_instance_of(described_class)
     expect(bucket.name).to eq(sandbox[:bucket])
+    expect(bucket.instance_variable_get(:@prefix)).to be_nil
+
+    bucket = BFS.resolve("gs://#{sandbox[:bucket]}/a/b/")
+    expect(bucket).to be_instance_of(described_class)
+    expect(bucket.name).to eq(sandbox[:bucket])
+    expect(bucket.instance_variable_get(:@prefix)).to eq('a/b')
   end
 
   it 'should enumerate over a large number of files' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bfs-gs
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.4.2
 platform: ruby
 authors:
 - Dimitrij Denissenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-30 00:00:00.000000000 Z
+date: 2019-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bfs
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.3.5
+        version: 0.4.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.3.5
+        version: 0.4.2
 - !ruby/object:Gem::Dependency
   name: google-cloud-storage
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.18'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.18'
 description: https://github.com/bsm/bfs.rb
 email: dimitrij@blacksquaremedia.com
 executables: []
@@ -60,15 +60,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: GS bucket adapter for bfs