bfi_player_search 0.0.2 → 0.0.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (4) hide show
  1. checksums.yaml +4 -4
  2. data/lib/bfi_player_search/result_parser.rb +1 -1
  3. data/spec/lib/bfi_player_search/result_parser_spec.rb +13 -0
  4. metadata +16 -16
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 1720bc250f6881e64c64249df35ba6d4442b06c6
4
- data.tar.gz: 0b62081df2424d1ce0074915fdbec9b3560d5beb
3
+ metadata.gz: 2514a200ea360d05ebf528a7d9c8a90a60ef668b
4
+ data.tar.gz: 19c2acb77d5962a5b6242bda8417e1cf947048c9
5
5
  SHA512:
6
- metadata.gz: d2c042c104b1343826837e349d89612a5ce90abd3784f4f2d2a624082cec1518432d8f4b232bd72fe357a4d1448997b1e6b60c4f129f9f517249af9f3d25b084
7
- data.tar.gz: d804ed0470879024ab4c5c7e0225cde7ab6a4582df0424e2764e4073c1b6ed56c3abfbbd0a2e4b3ca08bdd89b522f341ad22b8c3e82f0ec490f2db9e13849039
6
+ metadata.gz: d65ed7182013073c48f67d851f17eed507bbc00c707946df7d47cf0cc5e639f9040951096f2a96fac0f95f9ba218a6d4eddda48f36406408950286f49c2d6d10
7
+ data.tar.gz: 989af112e9bba2b3513e27a6050534a5de15cf2e91330999a4c3efa9077d12bfb280748775aa2176d8ce0ea230a822f74d19e424ba7981ff39d638a1e50dbc2c
data/lib/bfi_player_search/result_parser.rb CHANGED
@@ -48,7 +48,7 @@ module BFIPlayerSearch
48
48
  attr_reader :fragment
49
49
 
50
50
  def convert_to_url(path_or_url)
51
- u = URI.parse(path_or_url)
51
+ u = URI.parse(URI.escape(path_or_url))
52
52
  u.host ||= 'player.bfi.org.uk'
53
53
  u.scheme ||= 'http'
54
54
  u.to_s
data/spec/lib/bfi_player_search/result_parser_spec.rb CHANGED
@@ -35,6 +35,19 @@ describe BFIPlayerSearch::ResultParser do
35
35
 
36
36
  describe '#image_url' do
37
37
  it { expect(subject.image_url).to eq(image_url) }
38
+
39
+ context 'when it is unescaped' do
40
+ let(:image_url) { 'http://player.bfi.org.uk//media/images/stills/film/1812/friendships%20flip-320x180.jpg' }
41
+ let(:fragment) {
42
+ Nokogiri::HTML::DocumentFragment.parse("<article class='film'>
43
+ <figure>
44
+ <img src='//player.bfi.org.uk//media/images/stills/film/1812/friendships flip-320x180.jpg'>
45
+ </figure>
46
+ </article>")
47
+ }
48
+
49
+ it { expect(subject.image_url).to eq(image_url) }
50
+ end
38
51
  end
39
52
 
40
53
  describe '#year' do
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: bfi_player_search
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.0.2
4
+ version: 0.0.3
5
5
  platform: ruby
6
6
  authors:
7
7
  - Joel Chippindale
@@ -14,84 +14,84 @@ dependencies:
14
14
  name: nokogiri
15
15
  requirement: !ruby/object:Gem::Requirement
16
16
  requirements:
17
- - - ~>
17
+ - - "~>"
18
18
  - !ruby/object:Gem::Version
19
19
  version: '1.6'
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
- - - ~>
24
+ - - "~>"
25
25
  - !ruby/object:Gem::Version
26
26
  version: '1.6'
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: httpclient
29
29
  requirement: !ruby/object:Gem::Requirement
30
30
  requirements:
31
- - - ~>
31
+ - - "~>"
32
32
  - !ruby/object:Gem::Version
33
33
  version: '2.7'
34
34
  type: :runtime
35
35
  prerelease: false
36
36
  version_requirements: !ruby/object:Gem::Requirement
37
37
  requirements:
38
- - - ~>
38
+ - - "~>"
39
39
  - !ruby/object:Gem::Version
40
40
  version: '2.7'
41
41
  - !ruby/object:Gem::Dependency
42
42
  name: rake
43
43
  requirement: !ruby/object:Gem::Requirement
44
44
  requirements:
45
- - - ~>
45
+ - - "~>"
46
46
  - !ruby/object:Gem::Version
47
47
  version: '10'
48
48
  type: :development
49
49
  prerelease: false
50
50
  version_requirements: !ruby/object:Gem::Requirement
51
51
  requirements:
52
- - - ~>
52
+ - - "~>"
53
53
  - !ruby/object:Gem::Version
54
54
  version: '10'
55
55
  - !ruby/object:Gem::Dependency
56
56
  name: rspec
57
57
  requirement: !ruby/object:Gem::Requirement
58
58
  requirements:
59
- - - ~>
59
+ - - "~>"
60
60
  - !ruby/object:Gem::Version
61
61
  version: '3'
62
62
  type: :development
63
63
  prerelease: false
64
64
  version_requirements: !ruby/object:Gem::Requirement
65
65
  requirements:
66
- - - ~>
66
+ - - "~>"
67
67
  - !ruby/object:Gem::Version
68
68
  version: '3'
69
69
  - !ruby/object:Gem::Dependency
70
70
  name: webmock
71
71
  requirement: !ruby/object:Gem::Requirement
72
72
  requirements:
73
- - - ~>
73
+ - - "~>"
74
74
  - !ruby/object:Gem::Version
75
75
  version: '1.22'
76
76
  type: :development
77
77
  prerelease: false
78
78
  version_requirements: !ruby/object:Gem::Requirement
79
79
  requirements:
80
- - - ~>
80
+ - - "~>"
81
81
  - !ruby/object:Gem::Version
82
82
  version: '1.22'
83
83
  - !ruby/object:Gem::Dependency
84
84
  name: vcr
85
85
  requirement: !ruby/object:Gem::Requirement
86
86
  requirements:
87
- - - ~>
87
+ - - "~>"
88
88
  - !ruby/object:Gem::Version
89
89
  version: '3.0'
90
90
  type: :development
91
91
  prerelease: false
92
92
  version_requirements: !ruby/object:Gem::Requirement
93
93
  requirements:
94
- - - ~>
94
+ - - "~>"
95
95
  - !ruby/object:Gem::Version
96
96
  version: '3.0'
97
97
  description: Built with some wonky page scraping
@@ -119,17 +119,17 @@ require_paths:
119
119
  - lib
120
120
  required_ruby_version: !ruby/object:Gem::Requirement
121
121
  requirements:
122
- - - '>='
122
+ - - ">="
123
123
  - !ruby/object:Gem::Version
124
124
  version: '0'
125
125
  required_rubygems_version: !ruby/object:Gem::Requirement
126
126
  requirements:
127
- - - '>='
127
+ - - ">="
128
128
  - !ruby/object:Gem::Version
129
129
  version: '0'
130
130
  requirements: []
131
131
  rubyforge_project:
132
- rubygems_version: 2.4.8
132
+ rubygems_version: 2.5.2
133
133
  signing_key:
134
134
  specification_version: 4
135
135
  summary: A simple search API for BFI player