bf4-metric_fu 2.1.3.1

data/spec/base/ranking_spec.rb

@@ -0,0 +1,42 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Ranking do
+
+  context "with many items" do
+
+    specify "it should give top x items" do
+      ranking = Ranking.new
+      ranking[:a] = 10
+      ranking[:b] = 50
+      ranking[:c] = 1
+      ranking.top(2).should == [:b,:a]
+    end
+
+    specify "if gives all items if param is not numeric" do
+      ranking = Ranking.new
+      ranking[:a] = 10
+      ranking[:b] = 50
+      ranking[:c] = 1
+      ranking.top(nil).should == [:b,:a, :c]
+      ranking.top(:all).should == [:b,:a, :c]
+    end
+
+    specify "lowest item is at 0 percentile" do
+      ranking = Ranking.new
+      ranking[:a] = 10
+      ranking[:b] = 50
+      ranking.percentile(:a).should == 0
+    end
+
+    specify "highest item is at high percentile" do
+      ranking = Ranking.new
+      ranking[:a] = 10
+      ranking[:b] = 50
+      ranking[:c] = 0
+      ranking[:d] = 5
+      ranking.percentile(:b).should == 0.75
+    end
+
+  end
+
+end

data/spec/base/report_spec.rb

@@ -0,0 +1,146 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe MetricFu do
+
+  describe "#report" do
+    it 'should return an instance of Report' do
+      MetricFu.report.instance_of?(Report).should be(true)
+    end
+  end
+end
+
+describe MetricFu::Report do
+
+  before(:each) do
+    @report = MetricFu::Report.new
+  end
+
+  describe "#to_yaml" do
+    it 'should call #report_hash' do
+      report_hash = mock('report_hash')
+      report_hash.should_receive(:to_yaml)
+      @report.should_receive(:report_hash).and_return(report_hash)
+      @report.to_yaml
+    end
+  end
+
+  describe "#report_hash" do
+  end
+
+  describe "#save_templatized_report" do
+    it 'should create a new template class assign a report_hash '\
+       'to the template class, and ask it to write itself out' do
+      template_class = mock('template_class')
+      template_class.should_receive(:new).and_return(template_class)
+      MetricFu.should_receive(:template_class).and_return(template_class)
+      template_class.should_receive(:report=)
+      template_class.should_receive(:per_file_data=)
+      template_class.should_receive(:write)
+      @report.save_templatized_report
+    end
+  end
+
+  describe "#add" do
+    it 'should add a passed hash to the report_hash instance variable' do
+      report_type = mock('report_type')
+      report_type.should_receive(:to_s).any_number_of_times.and_return('type')
+
+      report_inst = mock('report_inst')
+      report_type.should_receive(:new).and_return(report_inst)
+
+      report_inst.should_receive(:generate_report).and_return({:a => 'b'})
+      report_inst.should_receive(:respond_to?).and_return(false)
+
+      MetricFu.should_receive(:const_get).
+               with('Type').and_return(report_type)
+      report_hash = mock('report_hash')
+      report_hash.should_receive(:merge!).with({:a => 'b'})
+      @report.should_receive(:report_hash).and_return(report_hash)
+      @report.add(report_type)
+    end
+  end
+
+  describe "#save_output" do
+    it 'should write the passed content to dir/index.html' do
+      f = mock('file')
+      content = 'content'
+      @report.should_receive(:open).with('dir/file', 'w').and_yield(f)
+      f.should_receive(:puts).with(content)
+      @report.save_output(content, 'dir', 'file')
+    end
+  end
+
+  describe '#open_in_browser? ' do
+
+    before(:each) do
+      @config = mock('configuration')
+    end
+
+    describe 'when the platform is os x ' do
+
+      before(:each) do
+        @config.should_receive(:platform).and_return('darwin')
+      end
+
+      describe 'and we are in cruise control ' do
+
+        before(:each) do
+          @config.should_receive(:is_cruise_control_rb?).and_return(true)
+          MetricFu.stub!(:configuration).and_return(@config)
+        end
+
+        it 'should return false' do
+          @report.open_in_browser?.should be_false
+        end
+      end
+
+      describe 'and we are not in cruise control' do
+
+        before(:each) do
+          @config.should_receive(:is_cruise_control_rb?).and_return(false)
+          MetricFu.stub!(:configuration).and_return(@config)
+        end
+
+        it 'should return true' do
+          @report.open_in_browser?.should be_true
+        end
+      end
+    end
+
+    describe 'when the platform is not os x ' do
+      before(:each) do
+        @config.should_receive(:platform).and_return('other')
+      end
+
+      describe 'and we are in cruise control' do
+        before(:each) do
+          MetricFu.stub!(:configuration).and_return(@config)
+        end
+
+        it 'should return false' do
+          @report.open_in_browser?.should be_false
+        end
+      end
+
+      describe 'and we are not in cruise control' do
+        before(:each) do
+          MetricFu.stub!(:configuration).and_return(@config)
+        end
+
+        it 'should return false' do
+          @report.open_in_browser?.should be_false
+        end
+      end
+    end
+  end
+
+
+  describe '#show_in_browser' do
+    it 'should call open with the passed directory' do
+      @report.should_receive(:open_in_browser?).and_return(true)
+      @report.should_receive(:system).with("open my_dir/index.html")
+      @report.show_in_browser('my_dir')
+    end
+
+  end
+end

data/spec/base/table_spec.rb

@@ -0,0 +1,36 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Table do
+
+  context 'rows_with' do
+
+    specify 'can select rows based on an optimized key (metric)' do
+      table = Table.new(:column_names => %w{foo metric})
+      table << {'metric' => 'flay', 'foo' => 1}
+      table << {'metric' => 'flay', 'foo' => 2}
+      table << {'metric' => 'flog', 'foo' => 1}
+      table << {'metric' => 'saikuro', 'foo' => 2}
+      matching_rows = table.rows_with(:metric => 'flay')
+      matching_rows.length.should == 2
+      matching_rows.each do |row|
+        row.metric.should == 'flay'
+      end
+    end
+
+    specify 'can select on arbitrary (non-optimized) field' do
+      table = Table.new(:column_names => %w{foo baz})
+      table << {'baz' => 'str1', 'foo' => 1}
+      table << {'baz' => 'str2', 'foo' => 2}
+      table << {'baz' => 'str3', 'foo' => 1}
+      table << {'baz' => 'str4', 'foo' => 3}
+      matching_rows = table.rows_with(:foo => 1)
+      matching_rows.length.should == 2
+      matching_rows.each do |row|
+        row.foo.should == 1
+      end
+
+    end
+
+  end
+
+end

data/spec/generators/churn_spec.rb

@@ -0,0 +1,41 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Churn do
+
+  describe "analyze method" do
+    before :each do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      @changes = {"lib/generators/flog.rb"=>2, "lib/metric_fu.rb"=>3}
+    end
+
+    it "should be empty on error" do
+      churn = MetricFu::Churn.new
+      churn.instance_variable_set(:@output, "Churning requires a subversion or git repo")
+      result = churn.analyze
+      result.should == [:churn => {}]
+    end
+
+    it "should return yaml results" do
+      churn = MetricFu::Churn.new
+      churn.instance_variable_set(:@output, "--- \n:churn: \n  :changed_files: \n  - spec/graphs/flog_grapher_spec.rb\n  - spec/base/graph_spec.rb\n  - lib/templates/awesome/layout.html.erb\n  - lib/graphs/rcov_grapher.rb\n  - lib/base/base_template.rb\n  - spec/graphs/grapher_spec.rb\n  - lib/templates/awesome/flog.html.erb\n  - lib/templates/awesome/flay.html.erb\n  - lib/graphs/roodi_grapher.rb\n  - lib/graphs/reek_grapher.rb\n  - HISTORY\n  - spec/graphs/roodi_grapher_spec.rb\n  - lib/generators/rcov.rb\n  - spec/graphs/engines/gchart_spec.rb\n  - spec/graphs/rcov_grapher_spec.rb\n  - lib/templates/javascripts/excanvas.js\n  - lib/templates/javascripts/bluff-min.js\n  - spec/graphs/reek_grapher_spec.rb\n")
+      result = churn.analyze
+      result.should == {:churn=>{:changed_files=>["spec/graphs/flog_grapher_spec.rb", "spec/base/graph_spec.rb", "lib/templates/awesome/layout.html.erb", "lib/graphs/rcov_grapher.rb", "lib/base/base_template.rb", "spec/graphs/grapher_spec.rb", "lib/templates/awesome/flog.html.erb", "lib/templates/awesome/flay.html.erb", "lib/graphs/roodi_grapher.rb", "lib/graphs/reek_grapher.rb", "HISTORY", "spec/graphs/roodi_grapher_spec.rb", "lib/generators/rcov.rb", "spec/graphs/engines/gchart_spec.rb", "spec/graphs/rcov_grapher_spec.rb", "lib/templates/javascripts/excanvas.js", "lib/templates/javascripts/bluff-min.js", "spec/graphs/reek_grapher_spec.rb"]}}
+    end
+
+  end
+
+  describe "to_h method" do
+    before :each do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+    end
+
+    it "should put the changes into a hash" do
+      churn = MetricFu::Churn.new
+      churn.instance_variable_set(:@churn, {:churn => 'results'})
+      churn.to_h[:churn].should == "results"
+    end
+  end
+end
+

data/spec/generators/flay_spec.rb

@@ -0,0 +1,105 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Flay do
+  describe "emit method" do
+    it "should look at the dirs" do
+      MetricFu::Configuration.run {|config| config.flay = { :dirs_to_flay => ['app', 'lib'], :filetypes => ['rb']  } }
+      File.stub!(:directory?).and_return(true)
+      @flay = MetricFu::Flay.new('base_dir')
+
+      @flay.should_receive(:`).with("flay  app lib")
+      output = @flay.emit
+    end
+
+    it "should limit flay scores by the minimum_score" do
+      MetricFu::Configuration.run {|config| config.flay = { :dirs_to_flay => [], :minimum_score => 99 } }
+      File.stub!(:directory?).and_return(true)
+      @flay = MetricFu::Flay.new('base_dir')
+
+      @flay.should_receive(:`).with("flay --mass 99  ")
+      output = @flay.emit
+    end
+  end
+
+  describe "analyze method" do
+    before :each do
+      lines = <<-HERE
+Total score (lower is better) = 246
+
+
+1) IDENTICAL code found in :or (mass*2 = 68)
+  app/controllers/link_targets_controller.rb:57
+  app/controllers/primary_sites_controller.rb:138
+
+2) Similar code found in :if (mass = 64)
+  app/controllers/primary_sites_controller.rb:75
+  app/controllers/primary_sites_controller.rb:76
+  app/controllers/primary_sites_controller.rb:88
+  app/controllers/primary_sites_controller.rb:89
+      HERE
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      @flay = MetricFu::Flay.new('base_dir')
+      @flay.instance_variable_set(:@output, lines)
+    end
+
+    it "should analyze and return matches" do
+      @flay.analyze.should == [ ["Total score (lower is better) = 246"],
+                                ["\n1) IDENTICAL code found in :or (mass*2 = 68)",
+                                  "app/controllers/link_targets_controller.rb:57",
+                                  "app/controllers/primary_sites_controller.rb:138"],
+                                ["2) Similar code found in :if (mass = 64)",
+                                  "app/controllers/primary_sites_controller.rb:75",
+                                  "app/controllers/primary_sites_controller.rb:76",
+                                  "app/controllers/primary_sites_controller.rb:88",
+                                  "app/controllers/primary_sites_controller.rb:89"] ]
+    end
+  end
+
+  describe "to_h method" do
+
+    before :each do
+      lines = [ ["Total score (lower is better) = 284"],
+                  ["\n1) IDENTICAL code found in :or (mass*2 = 68)",
+                    "app/controllers/link_targets_controller.rb:57",
+                    "app/controllers/primary_sites_controller.rb:138"],
+                  ["2) Similar code found in :if (mass = 64)",
+                    "app/controllers/primary_sites_controller.rb:75",
+                    "app/controllers/primary_sites_controller.rb:76",
+                    "app/controllers/primary_sites_controller.rb:88",
+                    "app/controllers/primary_sites_controller.rb:89"],
+                  ["3) Similar code found in :defn (mass = 40)",
+                    "app/controllers/link_targets_controller.rb:40",
+                    "app/controllers/primary_sites_controller.rb:98"],
+                  ["4) Similar code found in :defn (mass = 38)",
+                    "app/controllers/link_targets_controller.rb:13",
+                    "app/controllers/primary_sites_controller.rb:50"],
+                  ["5) Similar code found in :defn (mass = 38)",
+                    "app/models/primary_site.rb:104",
+                    "app/models/primary_site.rb:109"],
+                  ["6) Similar code found in :call (mass = 36)",
+                    "app/controllers/bookmarklet_integration_controller.rb:6",
+                    "app/controllers/bookmarklet_integration_controller.rb:17"]]
+
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      flay = MetricFu::Flay.new('base_dir')
+      flay.instance_variable_set(:@matches, lines)
+      @results = flay.to_h
+    end
+
+    it "should find the total_score" do
+      @results[:flay][:total_score].should == '284'
+    end
+
+    it "should have 6 matches" do
+      @results[:flay][:matches].size.should == 6
+    end
+
+    it "should capture info for match" do
+      @results[:flay][:matches].first[:reason].should =~ /IDENTICAL/
+      @results[:flay][:matches].first[:matches].first[:name].should =~ /link_targets_controller/
+      @results[:flay][:matches].first[:matches].first[:line].should == "57"
+    end
+  end
+end

data/spec/generators/flog_spec.rb

@@ -0,0 +1,70 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+describe Flog do
+  before :each do
+    MetricFu::Configuration.run {}
+    File.stub!(:directory?).and_return(true)
+    @flog = MetricFu::Flog.new('base_dir')
+  end
+
+  describe "emit method" do
+    it "should look for files and flog them" do
+      Dir.should_receive(:glob).with("lib/**/*.rb").and_return(["found/file.rb"])
+      ::Flog.should_receive(:parse_options).with(["--all", "--details"]).and_return("options")
+      ::Flog.should_receive(:new).with("options").and_return(flogger = mock('flogger'))
+      flogger.should_receive(:flog).with(["found/file.rb"])
+      @flog.emit
+    end
+  end
+
+  describe "analyze method" do
+    it "should harvest the flog information and put it into method_containers" do
+      first_full_method_name = "ClassName#first_method_name"
+      second_full_method_name = "ClassName#second_method_name"
+
+      flogger = mock('flogger', :calls => {first_full_method_name => {:branch => 11.1, :puts => 1.1},
+                                           second_full_method_name => {:branch => 22.2, :puts => 2.2}},
+                                :method_locations => {first_full_method_name => '/file/location.rb:11',
+                                                      second_full_method_name => '/file/location.rb:22'},
+                                :totals => {first_full_method_name => 11.11,
+                                            second_full_method_name => 22.22})
+      @flog.instance_variable_set(:@flogger, flogger)
+      @flog.analyze
+      method_containers = @flog.instance_variable_get(:@method_containers)
+      method_containers.size.should == 1
+
+      expected={:methods=>{"ClassName#first_method_name" => { :path=>"/file/location.rb:11",
+                                                              :score=>11.11,
+                                                              :operators=>{ :branch=>11.1,
+                                                                            :puts=>1.1}},
+                           "ClassName#second_method_name" => {:path=>"/file/location.rb:22",
+                                                              :score=>22.22,
+                                                              :operators=>{ :branch=>22.2,
+                                                                            :puts=>2.2}}},
+                :path=>"/file/location.rb",
+                :average_score=>((11.11 + 22.22) / 2.0),
+                :total_score=>33.33,
+                :highest_score=>22.22,
+                :name=>"ClassName"}
+
+      method_containers["ClassName"].to_h.should == expected
+    end
+  end
+
+  describe "to_h method" do
+    it "should make-a nice hash" do
+      flogger = mock('flogger', :total => 111.1, :average => 7.3)
+      @flog.instance_variable_set(:@flogger, flogger)
+      method_containers = {:ignore_me_1 =>  mock('container_1', :highest_score => 11.1, :to_h => 'container_1'),
+                           :ignore_me_2 =>  mock('container_2', :highest_score => 33.3, :to_h => 'container_2'),
+                           :ignore_me_3 =>  mock('container_3', :highest_score => 22.2, :to_h => 'container_3')}
+      @flog.instance_variable_set(:@method_containers, method_containers)
+
+      expected = {:flog => { :total => 111.1,
+                  :average => 7.3,
+                  :method_containers => ['container_2', 'container_3', 'container_1']}}
+
+      @flog.to_h.should == expected
+    end
+
+  end
+end

data/spec/generators/hotspots_spec.rb

@@ -0,0 +1,88 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Hotspots do
+
+  describe "analyze method" do
+    before :each do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      @yaml =<<END
+--- 
+:reek: 
+  :matches: 
+  - :file_path: lib/client/client.rb
+    :code_smells: 
+    - :type: Large Class
+      :message: has at least 27 methods
+      :method: Devver::Client
+    - :type: Long Method
+      :message: has approx 6 statements
+      :method: Devver::Client#client_requested_sync
+:flog: 
+  :method_containers: 
+  - :highest_score: 61.5870319141946
+    :path: /lib/client/client.rb
+    :methods: 
+      Client#client_requested_sync: 
+        :path: /lib/client/client.rb
+        :score: 37.9270319141946
+        :operators: 
+          :+: 1.70000000000001
+          :/: 1.80000000000001
+          :method_at_line: 1.90000000000001
+          :puts: 1.70000000000001
+          :assignment: 33.0000000000001
+          :in_method?: 1.70000000000001
+          :message: 1.70000000000001
+          :branch: 12.6
+          :<<: 3.40000000000001
+          :each: 1.50000000000001
+          :lit_fixnum: 1.45
+          :raise: 1.80000000000001
+          :each_pair: 1.3
+          :*: 1.60000000000001
+          :to_f: 2.00000000000001
+          :each_with_index: 3.00000000000001
+          :[]: 22.3000000000001
+          :new: 1.60000000000001
+    :average_score: 11.1209009055421
+    :total_score: 1817.6
+    :name: Client#client_requested_sync
+:churn: 
+  :changes: 
+  - :file_path: lib/client/client.rb
+    :times_changed: 54
+  - :file_path: lib/client/foo.rb
+    :times_changed: 52
+END
+    end
+
+    it "should be empty on error" do
+      hotspots = MetricFu::Hotspots.new
+      hotspots.instance_variable_set(:@analyzer, nil)
+      result = hotspots.analyze
+      result.should == {}
+    end
+
+    it "should return yaml results" do
+      hotspots = MetricFu::Hotspots.new
+      analyzer = MetricAnalyzer.new(@yaml)
+      hotspots.instance_variable_set(:@analyzer, analyzer)
+      result = hotspots.analyze
+      expected = JSON.parse("{\"methods\":[{\"location\":{\"class_name\":\"Client\",\"method_name\":\"Client#client_requested_sync\",\"file_path\":\"lib/client/client.rb\",\"hash\":7919384682,\"simple_method_name\":\"#client_requested_sync\"},\"details\":{\"reek\":\"found 1 code smells\",\"flog\":\"complexity is 37.9\"}}],\"classes\":[{\"location\":{\"class_name\":\"Client\",\"method_name\":null,\"file_path\":\"lib/client/client.rb\",\"hash\":7995629750},\"details\":{\"reek\":\"found 2 code smells\",\"flog\":\"complexity is 37.9\"}}],\"files\":[{\"location\":{\"class_name\":null,\"method_name\":null,\"file_path\":\"lib/client/client.rb\",\"hash\":-5738801681},\"details\":{\"reek\":\"found 2 code smells\",\"flog\":\"complexity is 37.9\",\"churn\":\"detected high level of churn (changed 54 times)\"}},{\"location\":{\"class_name\":null,\"method_name\":null,\"file_path\":\"lib/client/foo.rb\",\"hash\":-7081271905},\"details\":{\"churn\":\"detected high level of churn (changed 52 times)\"}}]}")
+      compare_hashes(JSON.parse(hotspots.to_h[:hotspots].to_json), expected)
+    end
+
+    it "should put the changes into a hash" do
+      hotspots = MetricFu::Hotspots.new
+      analyzer = MetricAnalyzer.new(@yaml)
+      hotspots.instance_variable_set(:@analyzer, analyzer)
+      hotspots.analyze
+      expected =  JSON.parse("{\"methods\":[{\"location\":{\"class_name\":\"Client\",\"method_name\":\"Client#client_requested_sync\",\"file_path\":\"lib/client/client.rb\",\"hash\":7919384682,\"simple_method_name\":\"#client_requested_sync\"},\"details\":{\"reek\":\"found 1 code smells\",\"flog\":\"complexity is 37.9\"}}],\"classes\":[{\"location\":{\"class_name\":\"Client\",\"method_name\":null,\"file_path\":\"lib/client/client.rb\",\"hash\":7995629750},\"details\":{\"reek\":\"found 2 code smells\",\"flog\":\"complexity is 37.9\"}}],\"files\":[{\"location\":{\"class_name\":null,\"method_name\":null,\"file_path\":\"lib/client/client.rb\",\"hash\":-5738801681},\"details\":{\"reek\":\"found 2 code smells\",\"flog\":\"complexity is 37.9\",\"churn\":\"detected high level of churn (changed 54 times)\"}},{\"location\":{\"class_name\":null,\"method_name\":null,\"file_path\":\"lib/client/foo.rb\",\"hash\":-7081271905},\"details\":{\"churn\":\"detected high level of churn (changed 52 times)\"}}]}")
+      compare_hashes(JSON.parse(hotspots.to_h[:hotspots].to_json), expected)
+    end
+  end
+end
+def compare_hashes(got,expected)
+  got.hash == expected.hash
+end