bettertabs 1.0 → 1.1

data/test/ruby_1_9/rails_3_0/public/stylesheets/bettertabs.css

@@ -17,6 +17,7 @@ div.bettertabs ul.tabs li a:link,
 div.bettertabs ul.tabs li a:visited { color: #444; }
 div.bettertabs ul.tabs li a:hover { color: black; }
 div.bettertabs ul.tabs li a:active { color: blue; }
+div.bettertabs ul.tabs li a.ajax-loading { color: #666; }
 
 div.bettertabs div.content { padding: 1em; border: 1px solid #999; background-color: #eee; clear: left; }
 div.bettertabs div.content.hidden { display: block; margin: 5px; border: 2px dashed #ccc; background-color: white; } /* display: none; to hide content */

data/test/ruby_1_9/rails_3_0/spec/requests/bettertabs_spec.rb

@@ -1,51 +1,112 @@
+# Some bettertabs specifications:
+#
+#  * Should always work with javascript disabled (using the urls of the tabs links)
+#  * The bettertabs hepler should accept:
+#    * args: (bettertabs_id, options)
+#    * options can be:
+#       * :selected_tab => tab_id to select by default
+#         * :selected_tab should be overridden with params[:"#{bettertabs_id}_selected_tab"] if present
+#       * any other option is used as wrapper html_options (wrapper is the top-level widget dom element).
+#  * The bettertabs helper should render clear markup:
+#     * A wrapper with class 'bettertabs'
+#     * Tabs markup
+#        * ul.tabs > li > a  
+#        * selected tab is ul.tabs > li.active > a
+#        * each a element has element attributes:
+#           * data-tab-type (for javascript: change click behavior depending on type "static", "link" or "ajax")
+#           * data-show-content-id (for javascript: element id to show when select this tab)
+#     * sections for each tab content.
+#     * use a unique html id (based on bettertabs_id and tab_id) for each Tab and Content
+#  * The bettertabs builder ".from" method should accept:
+#     * args: (tab_id, tab_name, options, &block)
+#     * args: (tab_id, options, &block)
+#    * If block_given? the block is used as content related to this tab
+#     * options can be:
+#       * :partial => to use as content. Defaults to tab_id
+#          * if block_given? this option can not be used (if used, raise an error)
+#       * :url => for the tab link, that should go to this selected tab when javascript is disabled. Defaults to { :"#{bettertabs_id}_selected_tab" => tab_id }
+#       * :tab_type => used in the markup as the link data-tab-type value. Can be :static, :link or :ajax (or the corresponding strings). Raise error otherwise. Defaults to :static.
+#  * The bettertabs builder ".static", ".link" and ".ajax" methods are only a convenient way to use ".for" method with :tab_type set to :static, :link or :ajax respectively.
+#  * Content is rendered only for active tab, except when tab_type is :static, where content is always rendered (ready to show when select that tab using javascript).
+#  * When ajax call (format.js), the bettertabs helper should return ONLY the content of the selected tab (to simplify the controller render partial calls.).
+#
+
 require 'spec_helper'
 
 describe "Bettertabs requests" do
   describe "GET /bettertabs/static" do
+    before(:all) { get '/bettertabs/static' } 
+    
     it "has a 200 status code" do
-      get '/bettertabs/static'
       response.status.should be(200)
     end
     
     it "should render all content even for hidden tabs" do
-      get '/bettertabs/static'
-      response.body.should include("Content for tab1")
-      response.body.should include("Content for tab2")
+      response.body.should include("Content for static_tab_1")
+      response.body.should include("Content for static_tab_2")
       response.body.should include("tab_content partial content")
     end
+    
+    it "should not include the attribute data-ajax-url in static tabs" do
+      response.body.should_not include("data-ajax-url")
+    end
   end
   
   describe "GET /bettertabs/link_tab_1" do
+    before(:all) { get '/bettertabs/link_tab_1' } 
     it "has a 200 status code" do
-      get '/bettertabs/link_tab_1'
       response.status.should be(200)
     end
+    
+    it "should not include the attribute data-ajax-url in link tabs" do
+      response.body.should_not include("data-ajax-url")
+    end
+    
   end
 
   describe "GET /bettertabs/link_tab_2" do
+    before(:all) { get '/bettertabs/link_tab_2' } 
     it "has a 200 status code" do
-      get '/bettertabs/link_tab_2'
       response.status.should be(200)
     end
   end
 
   describe "GET /bettertabs/ajax" do
+    before(:all) { get '/bettertabs/ajax' } 
     it "has a 200 status code" do
-      get '/bettertabs/ajax'
       response.status.should be(200)
     end
+    
+    it "should include the attribute data-ajax-url in ajax tabs" do
+      response.body.should include("data-ajax-url")
+    end
+    
+    it "should include the default ajax=true extra param in the data-ajax-url" do
+      response.body.should include("data-ajax-url=\"/bettertabs/ajax?ajax_selected_tab=ajax_tab_2&ajax=true\"")
+    end
+    
+    it "should render only the selected tab content" do
+      response.body.should include("Content for the ajax_tab_1")
+      response.body.should_not include("Content for the ajax_tab_2")
+    end
+    
+    it "should select another tab if requested in the URL" do
+      get '/bettertabs/ajax?ajax_selected_tab=ajax_tab_2'
+      response.body.should_not include("Content for the ajax_tab_1")
+      response.body.should include("Content for the ajax_tab_2")
+    end
   end
   
   describe "GET /bettertabs/mixed" do
+    before(:all) { get '/bettertabs/mixed' } 
     it "has a 200 status code" do
-      get '/bettertabs/mixed'
       response.status.should be(200)
     end
   end
   
   describe "GET /bettertabs/mixed_with_erb" do
+    before(:all) { get '/bettertabs/mixed_with_erb' } 
     it "has a 200 status code" do
-      get '/bettertabs/mixed_with_erb'
       response.status.should be(200)
     end
   end 

metadata

@@ -1,11 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: bettertabs
 version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 1
-  - 0
-  version: "1.0"
+  prerelease: 
+  version: "1.1"
 platform: ruby
 authors: 
 - Mario Izquierdo
@@ -13,11 +10,10 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-25 00:00:00 -04:00
-default_executable: 
+date: 2011-04-28 00:00:00 Z
 dependencies: []
 
-description: "The bettertabs helper defines the markup for a tabbed area in a easy and declarative way, using the appropiate JavaScript but ensuring accessibility and usability, no matter if the content is loaded statically, via ajax or the tabs are links. In the other hand, the CSS styles are up to you. "
+description: "Bettertabs Rails helper (and jQuery plugin) defines the markup for a tabbed area in a easy and declarative way, using the appropiate JavaScript but ensuring accessibility and usability, no matter if the content is loaded statically, via ajax or the tabs are links. In the other hand, the CSS styles are up to you. "
 email: 
 - tothemario@gmail.com
 executables: []
@@ -28,6 +24,8 @@ extra_rdoc_files: []
 
 files: 
 - .gitignore
+- CHANGELOG
+- EXAMPLES.md
 - Gemfile
 - Gemfile.lock
 - README.md
@@ -40,6 +38,7 @@ files:
 - lib/bettertabs/javascripts/jquery.bettertabs.coffee
 - lib/bettertabs/javascripts/jquery.bettertabs.js
 - lib/bettertabs/javascripts/jquery.bettertabs.min.js
+- lib/bettertabs/stylesheets/README.md
 - lib/bettertabs/version.rb
 - test/README_for_TEST.txt
 - test/ruby_1_9/rails_3_0/.rspec
@@ -78,7 +77,7 @@ files:
 - test/ruby_1_9/rails_3_0/public/favicon.ico
 - test/ruby_1_9/rails_3_0/public/images/rails.png
 - test/ruby_1_9/rails_3_0/public/javascripts/jquery-1.5.2.min.js
-- test/ruby_1_9/rails_3_0/public/javascripts/jquery.bettertabs.min.js
+- test/ruby_1_9/rails_3_0/public/javascripts/jquery.bettertabs.js
 - test/ruby_1_9/rails_3_0/public/javascripts/rails.js
 - test/ruby_1_9/rails_3_0/public/robots.txt
 - test/ruby_1_9/rails_3_0/public/stylesheets/bettertabs.css
@@ -86,8 +85,7 @@ files:
 - test/ruby_1_9/rails_3_0/script/rails
 - test/ruby_1_9/rails_3_0/spec/requests/bettertabs_spec.rb
 - test/ruby_1_9/rails_3_0/spec/spec_helper.rb
-has_rdoc: true
-homepage: ""
+homepage: https://github.com/agoragames/bettertabs
 licenses: []
 
 post_install_message: 
@@ -100,23 +98,19 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: bettertabs
-rubygems_version: 1.3.7
+rubygems_version: 1.7.2
 signing_key: 
 specification_version: 3
-summary: The better (simple, accessible, usable, flexible and fast) way to split content in tabs.
+summary: The better (simple, accessible, usable, flexible and fast) way to split content in tabs for Rails.
 test_files: []
 

data/test/ruby_1_9/rails_3_0/public/javascripts/jquery.bettertabs.min.js

@@ -1,4 +0,0 @@
-/**
- * Bettertabs jQuery plugin v1.0
- */
-(function(){var e,b,d,c,a,f;e=jQuery;a="data-tab-type";c="data-show-content-id";f=function(g){return g.attr(a)};d=function(g){return g.attr(c)};b=function(g){var h;if((typeof history!="undefined"&&history!==null)&&(history.replaceState!=null)){h=g.attr("href");return history.replaceState(null,document.title,h)}};e.fn.bettertabs=function(){return this.each(function(){var k,h,j,g,i;k=e(this);h=k.find("ul.tabs > li");i=k.find("ul.tabs > li > a");g=k.children(".content");j=h.add(g);return i.click(function(o){var q,r,n,m,p,l;m=e(this);if(f(m)!=="link"){o.preventDefault();p=m.parent();if(!p.is(".active")&&!m.is(".ajax-loading")){l=g.filter("#"+(d(m)));r=h.filter(".active");n=g.filter(".active");q=function(){j.removeClass("active").addClass("hidden");p.removeClass("hidden").addClass("active");l.removeClass("hidden").addClass("active");n.trigger("bettertabs-after-deactivate");l.trigger("bettertabs-after-activate");return b(m)};n.trigger("bettertabs-before-deactivate");l.trigger("bettertabs-before-activate");if(f(m)==="ajax"&&!(m.data("content-loaded-already")!=null)){m.addClass("ajax-loading");l.trigger("bettertabs-before-ajax-loading");return l.load(m.attr("href"),function(){m.removeClass("ajax-loading");m.data("content-loaded-already",true);l.trigger("bettertabs-after-ajax-loading");return q()})}else{return q()}}}})})}}).call(this);