betterlint 1.6.0 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71ba27a1b021ee2c1543aba5603245ae2631a64525c7c7e5338457b1296c66a6
-  data.tar.gz: e3c21186976d7d503c890cd4e0c8fed99d5c6f6ae20071a17fa697e9c4928ea7
+  metadata.gz: 65b957bbe3e091232127a01b3803411610b8968c9a2cecd0be839196c4edd66a
+  data.tar.gz: 66f79246845f20ab4cbb43104de461f14988831d5377ce4d2279e6c739353256
 SHA512:
-  metadata.gz: '048543b98c55befe6f306446a132f6f561598bf19ab9ffc4f74c6eb90b7ea5aa1d78d56594c34a2c8c6da7d79462329b8dadc8868af620fe53084189e7f6d604'
-  data.tar.gz: 35388c596e5edc116860dd60796313b9d6569326e77929b5e05b0f48f6f13067534684ec9d37904e140ba4b2dea93f8e243e10ead8196ee1eaba34e6b600d898
+  metadata.gz: 7c4e37ddc5f6285ea890fa8a06ff8a46564801fe182ab215e6a43af7977f69166be914f52f379d11a1166d8ab3b0dd1b155a60f9d708ac387016f59c1aa82935
+  data.tar.gz: 746e680bf2720c96e826fe1d9299169e7334cacafb367b820008cee18cdd1b3626e7cb37a6b2fd356134d549187e37b8e50db969c0510f19720557491a4c2a95

data/config/default.yml

@@ -86,7 +86,7 @@ Layout/CaseIndentation:
   IndentOneStep: true
 
 Layout/ClosingParenthesisIndentation:
-  Enabled: false
+  Enabled: true
 
 Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent

data/lib/rubocop/cop/betterment/fetch_boolean.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Betterment
+      class FetchBoolean < Base
+        MSG = <<~MSG
+          A boolean fetched from query params or ENV will never be false when
+          explicitly specified on the request or env var. Please use a model
+          with a boolean attribute, or cast the value.
+        MSG
+
+        # @!method fetch_boolean?(node)
+        def_node_matcher :fetch_boolean?, <<-PATTERN
+          (send _ :fetch _ (boolean))
+        PATTERN
+
+        # @!method fetch_env_boolean?(node)
+        def_node_matcher :fetch_env_boolean?, <<-PATTERN
+          (send (const nil? :ENV) :fetch _ (boolean))
+        PATTERN
+
+        # @!method boolean_cast?(node)
+        def_node_search :boolean_cast?, <<-PATTERN
+          (send
+            (send
+              (const
+                (const
+                  (const nil? :ActiveModel) :Type) :Boolean) :new) :cast
+            ...)
+        PATTERN
+
+        # @!method action_controller?(node)
+        def_node_search :action_controller?, <<~PATTERN
+          {
+            (const {nil? cbase} :ApplicationController)
+            (const (const {nil? cbase} :ActionController) :Base)
+          }
+        PATTERN
+
+        def on_send(node)
+          return unless fetch_env_boolean?(node) ||
+            (fetch_boolean?(node) && inherit_action_controller_base?(node))
+
+          return if node.each_ancestor(:send).any? { |ancestor| boolean_cast?(ancestor) }
+
+          add_offense(node)
+        end
+
+        private
+
+        def inherit_action_controller_base?(node)
+          class_node = node.each_ancestor(:class).first
+          return false unless class_node
+
+          action_controller?(class_node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/betterment/unscoped_find.rb

@@ -21,6 +21,7 @@ module RuboCop
         MSG
         METHOD_PATTERN = /^find_by_(.+?)(!)?$/
         FINDS = %i(find find_by find_by! where).freeze
+        GRAPHQL_PATTERN = /\bGraphQL\b/i
 
         def_node_matcher :custom_scope_find?, <<-PATTERN
           (send (send (const ... _) ...) {#{FINDS.map(&:inspect).join(' ')}} ...)
@@ -30,6 +31,10 @@ module RuboCop
           (send (const ... _) {#{FINDS.map(&:inspect).join(' ')}} ...)
         PATTERN
 
+        def_node_search :find_graphql_namespace_nodes, <<~PATTERN, name: GRAPHQL_PATTERN
+          (const _ %name)
+        PATTERN
+
         def initialize(config = nil, options = nil)
           super(config, options)
           config = @config.for_cop(self)
@@ -44,16 +49,26 @@ module RuboCop
           _, _, *arg_nodes = *node # rubocop:disable InternalAffairs/NodeDestructuring
           return unless
             (
-                find?(node) ||
-                custom_scope_find?(node) ||
-                static_method_name(node.method_name)
+              find?(node) ||
+              custom_scope_find?(node) ||
+              static_method_name(node.method_name)
             ) && !@unauthenticated_models.include?(Utils::Parser.get_root_token(node))
 
-          add_offense(node) if find_param_arg(arg_nodes)
+          add_offense(node) if find_param_arg(arg_nodes) || graphql_file? || graphql_namespace?(node)
         end
 
         private
 
+        def graphql_file?
+          processed_source.path&.match?(GRAPHQL_PATTERN)
+        end
+
+        def graphql_namespace?(node)
+          node
+            .each_ancestor(:class, :module)
+            .any? { |ancestor| find_graphql_namespace_nodes(ancestor).any? }
+        end
+
         def find_param_arg(arg_nodes)
           return unless arg_nodes
 

data/lib/rubocop/cop/betterment.rb

@@ -19,3 +19,4 @@ require 'rubocop/cop/betterment/allowlist_blocklist'
 require 'rubocop/cop/betterment/server_error_assertion'
 require 'rubocop/cop/betterment/hardcoded_id'
 require 'rubocop/cop/betterment/vague_serialize'
+require 'rubocop/cop/betterment/fetch_boolean'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.8.0
 platform: ruby
 authors:
 - Development
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-28 00:00:00.000000000 Z
+date: 2024-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -95,6 +95,7 @@ files:
 - lib/rubocop/cop/betterment/allowlist_blocklist.rb
 - lib/rubocop/cop/betterment/authorization_in_controller.rb
 - lib/rubocop/cop/betterment/dynamic_params.rb
+- lib/rubocop/cop/betterment/fetch_boolean.rb
 - lib/rubocop/cop/betterment/hardcoded_id.rb
 - lib/rubocop/cop/betterment/implicit_redirect_type.rb
 - lib/rubocop/cop/betterment/memoization_with_arguments.rb
@@ -129,7 +130,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.20
+rubygems_version: 3.5.6
 signing_key:
 specification_version: 4
 summary: Betterment rubocop configuration