betterlint 1.5.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 583f9b1d4c78270257202f26d509a0f262e41da066da447d88b868f1631f73fe
-  data.tar.gz: 246b11e285e7631a944b358f41603c438bf8677539189a6fa5de7817c464995a
+  metadata.gz: ec284b88f4606e1f10bb1a7e0c26794135b2f605077ac2ef472c9fff8ae1d80f
+  data.tar.gz: 25e9df31ca75903e469dadb172847f992b2bf4005679f76cc15343850697c5c2
 SHA512:
-  metadata.gz: ad19a059466a165bfe7bd9ec1a6dc8db2e86f9ec2c9f0e32bde0f09a5ce7703d60a60e9c79981cb0c073dac33789b99d636185bbbd5ffaab3065f9d21d161b17
-  data.tar.gz: '092f3ca327562d77edc0def71aa2ee62d86d3e0175c341e3fa4f38c9af380b888203e4642655b6e66aa5bc0483f35a1152ac5d38b65efcfc19406e20b6823b8c'
+  metadata.gz: 56be31837c8216b387b4ad5baa0fb4362152354bb5b5c71ccd95f2cf49d58da5c3499f6765a3509b8773b585bd6a0df22d4092dbeefb2152011ec095520a2293
+  data.tar.gz: c0b3a8a0fde1eae38420afe105cba2a5f9b3ac9d5704695c45337a6ba78ddcd04b8642ba701d610ea2434fb3814459fc810e9e877839c06bb69194bbfabaa564

data/config/default.yml

@@ -86,7 +86,7 @@ Layout/CaseIndentation:
   IndentOneStep: true
 
 Layout/ClosingParenthesisIndentation:
-  Enabled: false
+  Enabled: true
 
 Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
@@ -292,7 +292,7 @@ Style/Documentation:
   Enabled: false
 
 Style/FrozenStringLiteralComment:
-  Enabled: false
+  Enabled: true
 
 Style/GuardClause:
   Enabled: false

data/lib/rubocop/cop/betterment/active_job_performable.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
       class ActiveJobPerformable < Cop
-        MSG = <<~DOC.freeze
+        MSG = <<~DOC
           Classes that are "performable" should be ActiveJobs
 
           class MyJob < ApplicationJob

data/lib/rubocop/cop/betterment/allowlist_blocklist.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 # rubocop:disable Betterment/AllowlistBlocklist
 module RuboCop
   module Cop
     module Betterment
       class AllowlistBlocklist < Cop
-        MSG = <<-DOC.freeze
+        MSG = <<-DOC
           Avoid usages of whitelist & blacklist, in favor of more inclusive and descriptive language.
           For consistency, favor 'allowlist' and 'blocklist' where possible, but other terms (such as
           denylist, ignorelist, warnlist, safelist, etc) may be appropriate, depending on the use case.

data/lib/rubocop/cop/betterment/authorization_in_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
@@ -5,7 +7,7 @@ module RuboCop
         attr_accessor :unsafe_parameters, :unsafe_regex
 
         # MSG_UNSAFE_CREATE = 'Model created/updated using unsafe parameters'.freeze
-        MSG_UNSAFE_CREATE = <<~MSG.freeze
+        MSG_UNSAFE_CREATE = <<~MSG
           Model created/updated using unsafe parameters.
           Please query for the associated record in a way that enforces authorization (e.g. "trust-root chaining"),
           and then pass the resulting object into your model instead of the unsafe parameter.

data/lib/rubocop/cop/betterment/dynamic_params.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
       class DynamicParams < Cop
-        MSG_DYNAMIC_PARAMS = <<~MSG.freeze
+        MSG_DYNAMIC_PARAMS = <<~MSG
           Parameter names accessed dynamically, cannot determine safeness. Please inline the keys explicitly when calling `permit` or when accessing `params` like a hash.
 
           See here for more information on this error:

data/lib/rubocop/cop/betterment/hardcoded_id.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
@@ -5,7 +7,7 @@ module RuboCop
         include RangeHelp
         extend AutoCorrector
 
-        MSG = 'Hardcoded IDs cause flaky tests. Use a sequence instead.'.freeze
+        MSG = 'Hardcoded IDs cause flaky tests. Use a sequence instead.'
 
         # @!method key(node)
         def_node_matcher :key, '/^id$|_id$/'

data/lib/rubocop/cop/betterment/implicit_redirect_type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
@@ -13,10 +15,10 @@ module RuboCop
       #   get '/', redirect('/dashboard', status: 301)
       #   get(status: 302) { |params, request| '/dashboard' }
       class ImplicitRedirectType < Cop
-        ROUTES_FILE_NAME = 'routes.rb'.freeze
+        ROUTES_FILE_NAME = 'routes.rb'
         MSG =
           'Rails will create a permanent (301) redirect, which is dangerous. ' \
-          'Please specify your desired status, e.g. redirect(..., status: 302)'.freeze
+          'Please specify your desired status, e.g. redirect(..., status: 302)'
 
         # redirect('/')
         def_node_matcher :arg_form_without_options?, <<-PATTERN

data/lib/rubocop/cop/betterment/memoization_with_arguments.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
       class MemoizationWithArguments < Cop
         MSG = 'Memoized method `%<method>s` accepts arguments, ' \
               'which may cause it to return a stale result. ' \
-              'Remove memoization or refactor to remove arguments.'.freeze
+              'Remove memoization or refactor to remove arguments.'
 
         def self.node_pattern
           memo_assign = '(or_asgn $(ivasgn _) _)'

data/lib/rubocop/cop/betterment/non_standard_actions.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
       class NonStandardActions < Cop
-        MSG_GENERAL = 'Use a new controller instead of custom actions.'.freeze
+        MSG_GENERAL = 'Use a new controller instead of custom actions.'
         MSG_RESOURCE_ONLY = "Resource route refers to a non-standard action in it's 'only:' param. #{MSG_GENERAL}".freeze
         MSG_ROUTE_TO = "Route goes to a non-standard controller action. #{MSG_GENERAL}".freeze
 

data/lib/rubocop/cop/betterment/site_prism_loaded.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
       class SitePrismLoaded < Cop
-        MSG = 'Use `be_loaded` instead of `be_displayed`'.freeze
+        MSG = 'Use `be_loaded` instead of `be_displayed`'
 
         def_node_matcher :be_displayed_call?, <<-PATTERN
           (send (send nil? :expect _) _ (send nil? :be_displayed))

data/lib/rubocop/cop/betterment/spec_helper_required_outside_spec_dir.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
@@ -13,7 +15,7 @@ module RuboCop
       #   spec/models/my_class_spec.rb
       #   require 'rails_helper'
       class SpecHelperRequiredOutsideSpecDir < Cop
-        MSG = 'Spec helper required outside of a spec/ directory.'.freeze
+        MSG = 'Spec helper required outside of a spec/ directory.'
 
         def_node_matcher :requires_spec_helper?, <<-PATTERN
           (send nil? :require

data/lib/rubocop/cop/betterment/timeout.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
       class Timeout < Cop
-        MSG = 'Using Timeout.timeout without a custom exception can prevent rescue blocks from executing'.freeze
+        MSG = 'Using Timeout.timeout without a custom exception can prevent rescue blocks from executing'
 
         def_node_matcher :timeout_call?, <<-PATTERN
           (send (const nil? :Timeout) :timeout _)

data/lib/rubocop/cop/betterment/unsafe_job.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
       class UnsafeJob < Cop
         attr_accessor :sensitive_params, :class_regex
 
-        MSG = <<~MSG.freeze
+        MSG = <<~MSG
           This job takes a parameter that will end up serialized in plaintext. Do not pass sensitive data as bare arguments into jobs.
 
           See here for more information on this error:

data/lib/rubocop/cop/betterment/unscoped_find.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
       class UnscopedFind < Cop
         attr_accessor :unauthenticated_models
 
-        MSG = <<~MSG.freeze
+        MSG = <<~MSG
           Records are being retrieved directly using user input.
           Please query for the associated record in a way that enforces authorization (e.g. "trust-root chaining").
 
@@ -19,6 +21,7 @@ module RuboCop
         MSG
         METHOD_PATTERN = /^find_by_(.+?)(!)?$/
         FINDS = %i(find find_by find_by! where).freeze
+        GRAPHQL_PATTERN = /\bGraphQL\b/i
 
         def_node_matcher :custom_scope_find?, <<-PATTERN
           (send (send (const ... _) ...) {#{FINDS.map(&:inspect).join(' ')}} ...)
@@ -28,6 +31,10 @@ module RuboCop
           (send (const ... _) {#{FINDS.map(&:inspect).join(' ')}} ...)
         PATTERN
 
+        def_node_search :find_graphql_namespace_nodes, <<~PATTERN, name: GRAPHQL_PATTERN
+          (const _ %name)
+        PATTERN
+
         def initialize(config = nil, options = nil)
           super(config, options)
           config = @config.for_cop(self)
@@ -42,16 +49,26 @@ module RuboCop
           _, _, *arg_nodes = *node # rubocop:disable InternalAffairs/NodeDestructuring
           return unless
             (
-                find?(node) ||
-                custom_scope_find?(node) ||
-                static_method_name(node.method_name)
+              find?(node) ||
+              custom_scope_find?(node) ||
+              static_method_name(node.method_name)
             ) && !@unauthenticated_models.include?(Utils::Parser.get_root_token(node))
 
-          add_offense(node) if find_param_arg(arg_nodes)
+          add_offense(node) if find_param_arg(arg_nodes) || graphql_file? || graphql_namespace?(node)
         end
 
         private
 
+        def graphql_file?
+          processed_source.path&.match?(GRAPHQL_PATTERN)
+        end
+
+        def graphql_namespace?(node)
+          node
+            .each_ancestor(:class, :module)
+            .any? { |ancestor| find_graphql_namespace_nodes(ancestor).any? }
+        end
+
         def find_param_arg(arg_nodes)
           return unless arg_nodes
 

data/lib/rubocop/cop/betterment/utils/hardcoded_attribute.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment

data/lib/rubocop/cop/betterment/utils/method_return_table.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment

data/lib/rubocop/cop/betterment/utils/parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment

data/lib/rubocop/cop/betterment/vague_serialize.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Betterment
       class VagueSerialize < Base
         MSG = 'Active Record models with serialized columns should specify which ' \
-              'deserializer to use instead of falling back to the default.'.freeze
+              'deserializer to use instead of falling back to the default.'
 
         # @!method serialize?(node)
         def_node_matcher :serialize?, <<-PATTERN

data/lib/rubocop/cop/betterment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubocop'
 require 'rubocop/cop/betterment/utils/parser'
 require 'rubocop/cop/betterment/utils/method_return_table'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Development
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-29 00:00:00.000000000 Z
+date: 2023-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -129,7 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.19
+rubygems_version: 3.4.22
 signing_key:
 specification_version: 4
 summary: Betterment rubocop configuration