betterlint 1.4.7 → 1.4.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b226c8191c6a626e5cdd67d238bcc87f1a30e9dedc295df097e859ef0bae32b
-  data.tar.gz: 68756cf570f941a1d8fa354ee74585da526eb610e3daf3efdb2205b80347ecb4
+  metadata.gz: d607b36a006c41af535225cf9ea3c32771dae29a2cc6bee9092f50d8fc6cab0c
+  data.tar.gz: 9cea34ee8efe8657ba6387b08001a95301e61af4a0e0be69a653de02e7d41cbb
 SHA512:
-  metadata.gz: b25f6810a797815f54b308f9a895504a2c00d8642f13b45377ceac2dc9dd4da48438da338fc52317f90b80d1737c26ef68bda6e84ed237bd80866fc9883f8253
-  data.tar.gz: f28f19632b3fc5fec8335b6f364fecbffe384be5c2c2b56ab0251c5bcb64f391d039dbd6b15c7f3978c1b63ceb9e9102676904493b2e705520a3694c660e1391
+  metadata.gz: efb8a0837eef49c7a41152194b21fa6e004923a4705812365234375bfc05140bda6bdf25742c4e1e8d6ad002b2940885b8a9c46dfbfa56864bf4bfbe3a18b583
+  data.tar.gz: e4d1fdb860e7f9806f1f0e0593999ac998a34345a159de8c2e1030b3464f42473e9ef8d9d3911720898fba489d42690d29ff47b777921bff7ebc80afabdab14e

data/config/default.yml

@@ -8,17 +8,17 @@ require:
   - rubocop-rspec
 
 AllCops:
-  Exclude:
-    - 'bin/**/*'
-    - 'db/**/*'
-    - 'vendor/**/*'
-    - 'frontend/**/*'
-    - 'build/**/*'
-    - 'node_modules/**/*'
-    - 'tmp/**/*'
-    - 'Gemfile'
-  DisplayStyleGuide: true
   DisplayCopNames: true
+  DisplayStyleGuide: true
+  Exclude:
+    - Gemfile
+    - bin/**/*
+    - build/**/*
+    - db/**/*
+    - frontend/**/*
+    - node_modules/**/*
+    - tmp/**/*
+    - vendor/**/*
   NewCops: enable
   SuggestExtensions:
     rubocop-capybara: false
@@ -26,60 +26,60 @@ AllCops:
 Betterment:
   StyleGuideBaseURL: https://github.com/Betterment/betterlint
 
-Betterment/ServerErrorAssertion:
-  Description: 'Detects assertions on 5XX HTTP statuses.'
-  Include:
-    - 'spec/requests/**/*_spec.rb'
-
 Betterment/AuthorizationInController:
-  Description: 'Detects unsafe handling of id-like parameters in controllers.'
-  StyleGuide: '#bettermentauthorizationincontroller'
+  Description: Detects unsafe handling of id-like parameters in controllers.
   Enabled: false
-
-Betterment/UnsafeJob:
-  Enabled: false
-  StyleGuide: '#bettermentunsafejob'
-  sensitive_params:
-    - password
-    - social_security_number
-    - ssn
-
-Betterment/UnscopedFind:
-  StyleGuide: '#bettermentunscopedfind'
+  StyleGuide: '#bettermentauthorizationincontroller'
 
 Betterment/DynamicParams:
   StyleGuide: '#bettermentdynamicparams'
 
-Betterment/SitePrismLoaded:
-  Include:
-    - 'spec/features/**/*_spec.rb'
-    - 'spec/system/**/*_spec.rb'
+Betterment/HardcodedID:
+  AutoCorrect: false
+  Description: Detects hardcoded IDs in specs
+  SafeAutoCorrect: false
+  StyleGuide: '#bettermenthardcodedid'
 
 Betterment/NonStandardActions:
-  Description: 'Detects non-standard controller actions.'
-  StyleGuide: '#bettermentnonstandardactions'
   AdditionalAllowedActions: []
+  Description: Detects non-standard controller actions.
+  Include:
+    - config/routes.rb
   StandardActions:
+    - create
+    - destroy
+    - edit
     - index
-    - show
     - new
-    - edit
-    - create
+    - show
     - update
-    - destroy
+  StyleGuide: '#bettermentnonstandardactions'
+
+Betterment/ServerErrorAssertion:
+  Description: Detects assertions on 5XX HTTP statuses.
   Include:
-    - 'config/routes.rb'
+    - spec/requests/**/*_spec.rb
 
-Betterment/HardcodedID:
-  Description: 'Detects hardcoded IDs in specs'
-  StyleGuide: '#bettermenthardcodedid'
-  AutoCorrect: false
-  SafeAutoCorrect: false
+Betterment/SitePrismLoaded:
+  Include:
+    - spec/features/**/*_spec.rb
+    - spec/system/**/*_spec.rb
+
+Betterment/UnsafeJob:
+  Enabled: false
+  StyleGuide: '#bettermentunsafejob'
+  sensitive_params:
+    - password
+    - social_security_number
+    - ssn
+
+Betterment/UnscopedFind:
+  StyleGuide: '#bettermentunscopedfind'
 
 FactoryBot/ConsistentParenthesesStyle:
   Enabled: false
 
-Layout/ParameterAlignment:
+FactoryBot/SyntaxMethods:
   Enabled: false
 
 Layout/CaseIndentation:
@@ -100,95 +100,83 @@ Layout/MultilineMethodCallIndentation:
 Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
 
+Layout/ParameterAlignment:
+  Enabled: false
+
 # Disabling because of a bug in rubocop: https://github.com/rubocop-hq/rubocop/issues/6918
 Layout/RescueEnsureAlignment:
   Enabled: false
 
 Lint/AmbiguousBlockAssociation:
   Exclude:
-    - 'spec/**/*'
+    - spec/**/*
 
 Lint/AmbiguousOperator:
   Exclude:
-    - 'spec/**/*'
+    - spec/**/*
 
 Lint/AmbiguousRegexpLiteral:
   Exclude:
-    - 'spec/**/*'
+    - spec/**/*
 
 Lint/BooleanSymbol:
   Exclude:
-    - 'spec/**/*'
+    - spec/**/*
+
+Lint/FloatComparison:
+  Enabled: true
 
 Metrics/AbcSize:
   Exclude:
-    - 'spec/**/*'
-    - 'webvalve/**/*'
+    - spec/**/*
+    - webvalve/**/*
 
 Metrics/BlockLength:
   Enabled: false
 
 Metrics/ClassLength:
-  Max: 250
   Exclude:
-    - 'webvalve/**/*'
+    - webvalve/**/*
+  Max: 250
 
 Metrics/CyclomaticComplexity:
-  Max: 10
   Exclude:
-    - 'spec/**/*'
-    - 'webvalve/**/*'
+    - spec/**/*
+    - webvalve/**/*
+  Max: 10
 
 Metrics/MethodLength:
   Enabled: false
 
 Metrics/ModuleLength:
-  Max: 250
   Exclude:
-    - 'webvalve/**/*'
+    - webvalve/**/*
+  Max: 250
 
 Metrics/ParameterLists:
-  Max: 5
   CountKeywordArgs: false
+  Max: 5
 
 Metrics/PerceivedComplexity:
   Exclude:
-    - 'spec/**/*'
-    - 'webvalve/**/*'
+    - spec/**/*
+    - webvalve/**/*
 
 Naming/HeredocDelimiterNaming:
   Enabled: false
 
 Naming/PredicateName:
-  NamePrefix:
-    - is_
   ForbiddenPrefixes:
     - is_
+  NamePrefix:
+    - is_
 
 Naming/VariableNumber:
-  EnforcedStyle: 'snake_case'
+  EnforcedStyle: snake_case
 
 Performance/RedundantMatch:
   Enabled: false
 
-Rails:
-  Enabled: true
-
-Rails/ApplicationRecord:
-  Enabled: false
-
-Rails/Delegate:
-  Enabled: false
-
-Rails/FindEach:
-  Enabled: false
-
-Rails/HttpPositionalArguments:
-  Enabled: true
-
-Rails/OutputSafety:
-  Enabled: true
-  
 RSpec/BeEq:
   Enabled: false
 
@@ -202,7 +190,7 @@ RSpec/DescribeClass:
   Enabled: false
 
 RSpec/DescribedClass:
-  EnforcedStyle: 'described_class'
+  EnforcedStyle: described_class
 
 RSpec/EmptyLineAfterExampleGroup:
   Enabled: false
@@ -223,17 +211,17 @@ RSpec/ExampleWording:
   Enabled: false
 
 RSpec/ExpectChange:
-  EnforcedStyle: 'block'
+  EnforcedStyle: block
 
-FactoryBot/SyntaxMethods:
+RSpec/SpecFilePathSuffix:
   Enabled: false
 
-RSpec/FilePath:
+RSpec/SpecFilePathFormat:
   Enabled: false
 
 RSpec/HookArgument:
   Enabled: false
-  
+
 RSpec/IndexedLet:
   Enabled: false
 
@@ -273,6 +261,24 @@ RSpec/ScatteredLet:
 RSpec/ScatteredSetup:
   Enabled: false
 
+Rails:
+  Enabled: true
+
+Rails/ApplicationRecord:
+  Enabled: false
+
+Rails/Delegate:
+  Enabled: false
+
+Rails/FindEach:
+  Enabled: false
+
+Rails/HttpPositionalArguments:
+  Enabled: true
+
+Rails/OutputSafety:
+  Enabled: true
+
 Style/AccessModifierDeclarations:
   Enabled: false
 
@@ -299,20 +305,24 @@ Style/Lambda:
 
 Style/LambdaCall:
   Exclude:
-    - 'app/views/**/*.jbuilder'
+    - app/views/**/*.jbuilder
 
 Style/MissingElse:
   Enabled: true
   EnforcedStyle: case
 
+Style/NumberedParameters:
+  Enabled: true
+  EnforcedStyle: disallow
+
 Style/PercentLiteralDelimiters:
   PreferredDelimiters:
-    default: '()'
-    '%i': '()'
-    '%I': '()'
+    '%I': ()
+    '%W': ()
+    '%i': ()
     '%r': '{}'
-    '%w': '()'
-    '%W': '()'
+    '%w': ()
+    default: ()
 
 Style/SafeNavigation:
   Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.4.7
+  version: 1.4.9
 platform: ruby
 authors:
 - Development
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-31 00:00:00.000000000 Z
+date: 2023-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.22'
+        version: '2.24'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.22'
+        version: '2.24'
 description: Betterment rubocop configuration
 email:
 - development@betterment.com
@@ -129,7 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: Betterment rubocop configuration