betterlint 1.4.0 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 412124b5950ac692bc3b555414eb9b46ff7632b0535baf7efd5cb16095c79e2f
-  data.tar.gz: e75bb5528c7e82a76144e763796f2373f431ce027659a4321195526c11a0bd94
+  metadata.gz: 1e93a2bacb559d6455d9e1d7acf0ee3d34e378817b70ff2694d9c7dc5fd051c7
+  data.tar.gz: 8613c5d928bfa812f75e6092ddb201d7030cee8e9c27ded059487941628a6540
 SHA512:
-  metadata.gz: 2e441d742d6c67abead8a74d052f579c0290d57aa5c77ae46b117273cb1bcae8c5fe06a02cad97c0582a67e2afe0b83a1a775b35e6d8564a486419a75a3afc10
-  data.tar.gz: a756fb81d8747b7358f6f650c61b23092518e49d6166aefe5f7123810805a2df7d83878776b2f9a17db29a9ffee838c37ecca1783ce6563b01cdd0354e57db8d
+  metadata.gz: 3dc6e12bc99a8405a25f0902636087ef2f034641f161465c3b337f08ade4a916d3a92b6ec8a4e259afea53aebefe4068214dd2b3faf5bbf0473a4b3617289154
+  data.tar.gz: c8e15b4f85363fb9ade768e1e012b717a58e168040500639b053fd831a48133174ae67c33cd25229ea8eff885ac90b5228c0c4113be01e411f3f8f92fed35fb6

data/lib/rubocop/cop/betterment/hardcoded_id.rb

@@ -91,7 +91,7 @@ module RuboCop
         end
 
         def with_comma(attribute)
-          range = attribute.location.expression
+          range = attribute.source_range
           range = range_with_surrounding_space(range: range)
           range_with_surrounding_comma(range, :left)
         end

data/lib/rubocop/cop/betterment/site_prism_loaded.rb

@@ -11,12 +11,12 @@ module RuboCop
         def on_send(node)
           return unless be_displayed_call?(node)
 
-          add_offense(node, location: node.children[2].loc.expression)
+          add_offense(node, location: node.children[2].source_range)
         end
 
         def autocorrect(node)
           lambda do |corrector|
-            corrector.replace(node.children[2].loc.expression, 'be_loaded')
+            corrector.replace(node.children[2].source_range, 'be_loaded')
           end
         end
       end

data/lib/rubocop/cop/betterment/utils/hardcoded_attribute.rb

@@ -41,7 +41,7 @@ module RuboCop
         private
 
         def create_range(node, match)
-          range = node.loc.expression
+          range = node.source_range
           begin_pos = range.begin_pos + match.begin(0)
           end_pos = range.begin_pos + match.end(0)
           range.with(begin_pos: begin_pos, end_pos: end_pos)

data/lib/rubocop/cop/betterment/vague_serialize.rb

@@ -0,0 +1,21 @@
+module RuboCop
+  module Cop
+    module Betterment
+      class VagueSerialize < Base
+        MSG = 'Active Record models with serialized columns should specify which ' \
+              'deserializer to use instead of falling back to the default.'.freeze
+
+        # @!method serialize?(node)
+        def_node_matcher :serialize?, <<-PATTERN
+          (send nil? :serialize ...)
+        PATTERN
+
+        def on_send(node)
+          return unless serialize? node
+
+          add_offense(node) if node.arguments.length < 2 || !node.arguments[1].const_type?
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/betterment.rb

@@ -16,3 +16,4 @@ require 'rubocop/cop/betterment/active_job_performable'
 require 'rubocop/cop/betterment/allowlist_blocklist'
 require 'rubocop/cop/betterment/server_error_assertion'
 require 'rubocop/cop/betterment/hardcoded_id'
+require 'rubocop/cop/betterment/vague_serialize'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.2
 platform: ruby
 authors:
 - Development
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-28 00:00:00.000000000 Z
+date: 2023-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.7'
 description: Betterment rubocop configuration
 email:
 - development@betterment.com
@@ -108,6 +108,7 @@ files:
 - lib/rubocop/cop/betterment/utils/hardcoded_attribute.rb
 - lib/rubocop/cop/betterment/utils/method_return_table.rb
 - lib/rubocop/cop/betterment/utils/parser.rb
+- lib/rubocop/cop/betterment/vague_serialize.rb
 homepage:
 licenses:
 - MIT
@@ -128,7 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: Betterment rubocop configuration