betterlint 1.30.0 → 1.31.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fd581451b52d71fae89c2aa596958a8bd87bbddfa13f7e8b9019dbbe34cf3c6d
-  data.tar.gz: '0198a7a5d5e9db377f8964db8a7cd3e05c0f227e3f7a047d2914d930103aec81'
+  metadata.gz: df6ab37fcacbca2232240ecc261718b03ce8cae9d9ec6860d01b1fe5aafa15de
+  data.tar.gz: 3c1aace8b60b77b649f621b5923f3defddb33d18922aff23211225cea7461af5
 SHA512:
-  metadata.gz: c9c17ae11bc30e88ea612dd5a5b77dd8c7a89d9b2c0614a2c88dc53f5fc7099055286b1289c58015d7c8fad069df93f455a34000bf6820f32cb62a4241bc8025
-  data.tar.gz: ab5077e13a6044c53fc65654a57f282c14922a5288c1d2115c491cd35c063662f06e07572c7b26de750b4e73334ea26e8754ac1e3e8820c8821f312200960cec
+  metadata.gz: 0405efeb7e9268e65ab0440399f375e482338b7008a9ffa4690cbdc0640d8f0d1e5ea5382ddf2f203f54beb517f76387386f104b0f2a20519615e9c34f3bd6fd
+  data.tar.gz: 668fba99358e61376714517009c13e3e335e74c5576541941293c56018a851dca599edb0333160d99c27a31b192ec730149dac7cdf53045dbbac2cc24f643fba

data/README.md

@@ -470,3 +470,24 @@ end
 ```
 
 This cop is disabled by default, because it reports many offenses in applications with older specs. To use it, enable it in your `.rubocop.yml`. By default it examines all files in `spec/`, except for the `features`, `requests`, `routing`, `system`, and `views` directories, where integration style tests that don't test one class and method are common. Examples in shared example groups are also ignored.
+
+### Betterment/NoSend
+
+This cop flags calls to `send`, `public_send`, and `__send__`. Dynamic dispatch hides the call from Sorbet and code search, and `send` also reaches private methods. Call the method directly instead.
+
+#### BAD:
+
+```ruby
+record.public_send(:name)
+record.send(attribute_name)
+job.send(:plaid_item)
+```
+
+#### GOOD:
+
+```ruby
+record.name
+record.attributes.fetch(attribute_name)
+```
+
+This cop ignores files in `spec/`, and calls to `send` with no arguments, which are usually a different method named `send`.

data/config/default.yml

@@ -70,6 +70,13 @@ Betterment/NoDownMigrations:
   Include:
     - db/migrate/**/*.rb
 
+Betterment/NoSend:
+  Description: Detects dynamic method calls through send, public_send and __send__.
+  StyleGuide: '#bettermentnosend'
+  Enabled: true
+  Exclude:
+    - spec/**/*
+
 Betterment/NonNamespacedClass:
   Description: Detects classes that are not namespaced under a module or constant
   StyleGuide: '#bettermentnonamespacedclass'

data/lib/betterlint/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Betterlint
-  VERSION = '1.30.0'
+  VERSION = '1.31.0'
 end

data/lib/rubocop/cop/betterment/no_send.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Betterment
+      class NoSend < Base
+        MSG = <<~TEXT
+          Call the method directly instead of using `%<method>s`; dynamic dispatch is invisible to Sorbet and code search.
+
+          See here for more information on this cop:
+          https://github.com/Betterment/betterlint/blob/main/README.md#bettermentnosend
+        TEXT
+
+        RESTRICT_ON_SEND = %i(send public_send __send__).freeze
+
+        def on_send(node)
+          return unless node.arguments?
+
+          add_offense(node.loc.selector, message: format(MSG, method: node.method_name))
+        end
+        alias on_csend on_send
+      end
+    end
+  end
+end

data/lib/rubocop/cop/betterment.rb

@@ -13,6 +13,7 @@ require 'rubocop/cop/betterment/implicit_redirect_type'
 require 'rubocop/cop/betterment/internals_protection'
 require 'rubocop/cop/betterment/memoization_with_arguments'
 require 'rubocop/cop/betterment/no_down_migrations'
+require 'rubocop/cop/betterment/no_send'
 require 'rubocop/cop/betterment/non_namespaced_class'
 require 'rubocop/cop/betterment/non_standard_actions'
 require 'rubocop/cop/betterment/non_standard_controller'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.30.0
+  version: 1.31.0
 platform: ruby
 authors:
 - Development
@@ -180,6 +180,7 @@ files:
 - lib/rubocop/cop/betterment/internals_protection.rb
 - lib/rubocop/cop/betterment/memoization_with_arguments.rb
 - lib/rubocop/cop/betterment/no_down_migrations.rb
+- lib/rubocop/cop/betterment/no_send.rb
 - lib/rubocop/cop/betterment/non_namespaced_class.rb
 - lib/rubocop/cop/betterment/non_standard_actions.rb
 - lib/rubocop/cop/betterment/non_standard_controller.rb
@@ -204,10 +205,10 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/Betterment/betterlint
-  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.30.0
-  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.30.0/CHANGELOG.md
+  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.31.0
+  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.31.0/CHANGELOG.md
   bug_tracker_uri: https://github.com/Betterment/betterlint/issues
-  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.30.0
+  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.31.0
   rubygems_mfa_required: 'true'
   default_lint_roller_plugin: Betterlint::Plugin
 rdoc_options: []
@@ -224,7 +225,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.21
+rubygems_version: 4.0.24
 specification_version: 4
 summary: Betterment rubocop configuration
 test_files: []