betterlint 1.3.1 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ce3c58a36213288dc8a00fada7143d6f6494e1625e4ea1863f4bc3a460a0e0f3
-  data.tar.gz: 2a06ea46d279cbdcc5c78c8850db4023ac862f8d5b0dc8de7109428ef06a445c
+  metadata.gz: d33fd3ef06ee7f731fa4e879cc87429f7d7e833e0687a761439628ccb4424922
+  data.tar.gz: 690aa6d3a567b3718a5ae7bb6d354d3cd1162cd15ff9d069dba24cbaba9f4318
 SHA512:
-  metadata.gz: 55323d12ee9b064b77f66067df837ffb68a3b9dd055b6a5bef7ecf16c86a0d6f798ea5ff36b2ec2b1348cad507a4494b4a91560850bac736f98b35488f4a9a87
-  data.tar.gz: a92da3b7813d65df914fa9cca948338328b987dbab1fa1e559dd9b7a2932a2b7c81ff5e40628df1b2a952b1febfc0488cf76d275acbe8a6fab56990cb127a087
+  metadata.gz: 3a5a1cffd033ed6b46008c0e72b3a2d81d003d99138cb22b85fcbac76b60972ab55db3a8d61e50f7735c5f14c5958038e2748dfbd41d335e097a9f2eb63a24a2
+  data.tar.gz: 57b13761e63538931f32e4c55aceececca5a7c579b4318cb39881c7c090765361b00848bb884d9360c4bca5928be4221eb5d21982ebbe272c7209e422da63c1c

data/config/default.yml

@@ -217,6 +217,9 @@ RSpec/ExampleWording:
 RSpec/ExpectChange:
   EnforcedStyle: 'block'
 
+RSpec/FactoryBot/SyntaxMethods:
+  Enabled: false
+
 RSpec/FilePath:
   Enabled: false
 

data/lib/rubocop/cop/betterment/hardcoded_id.rb

@@ -91,7 +91,7 @@ module RuboCop
         end
 
         def with_comma(attribute)
-          range = attribute.location.expression
+          range = attribute.source_range
           range = range_with_surrounding_space(range: range)
           range_with_surrounding_comma(range, :left)
         end

data/lib/rubocop/cop/betterment/implicit_redirect_type.rb

@@ -62,7 +62,7 @@ module RuboCop
         private
 
         def routes_file?
-          Pathname.new(processed_source.buffer.name).basename.to_s == ROUTES_FILE_NAME
+          Pathname.new(processed_source.file_path).basename.to_s == ROUTES_FILE_NAME
         end
       end
     end

data/lib/rubocop/cop/betterment/non_standard_actions.rb

@@ -17,7 +17,7 @@ module RuboCop
         PATTERN
 
         def not_to_or_action?(sym)
-          !%i(to action).include?(sym)
+          !%i(to action).include?(sym) # rubocop:disable Style/InverseMethods
         end
 
         # @!method route_to(node)

data/lib/rubocop/cop/betterment/site_prism_loaded.rb

@@ -11,12 +11,12 @@ module RuboCop
         def on_send(node)
           return unless be_displayed_call?(node)
 
-          add_offense(node, location: node.children[2].loc.expression)
+          add_offense(node, location: node.children[2].source_range)
         end
 
         def autocorrect(node)
           lambda do |corrector|
-            corrector.replace(node.children[2].loc.expression, 'be_loaded')
+            corrector.replace(node.children[2].source_range, 'be_loaded')
           end
         end
       end

data/lib/rubocop/cop/betterment/spec_helper_required_outside_spec_dir.rb

@@ -27,7 +27,7 @@ module RuboCop
         private
 
         def spec_directory?
-          Pathname.new(processed_source.buffer.name)
+          Pathname.new(processed_source.file_path)
             .relative_path_from(Pathname.pwd)
             .to_s
             .start_with?("spec#{File::SEPARATOR}")

data/lib/rubocop/cop/betterment/unscoped_find.rb

@@ -45,7 +45,7 @@ module RuboCop
                 find?(node) ||
                 custom_scope_find?(node) ||
                 static_method_name(node.method_name)
-            ) && !@unauthenticated_models.include?(Utils::Parser.get_root_token(node))
+            ) && !@unauthenticated_models.include?(Utils::Parser.get_root_token(node)) # rubocop:disable Style/InverseMethods
 
           add_offense(node) if find_param_arg(arg_nodes)
         end

data/lib/rubocop/cop/betterment/utils/hardcoded_attribute.rb

@@ -41,7 +41,7 @@ module RuboCop
         private
 
         def create_range(node, match)
-          range = node.loc.expression
+          range = node.source_range
           begin_pos = range.begin_pos + match.begin(0)
           end_pos = range.begin_pos + match.end(0)
           range.with(begin_pos: begin_pos, end_pos: end_pos)

data/lib/rubocop/cop/betterment/vague_serialize.rb

@@ -0,0 +1,21 @@
+module RuboCop
+  module Cop
+    module Betterment
+      class VagueSerialize < Base
+        MSG = 'Active Record models with serialized columns should specify which ' \
+              'deserializer to use instead of falling back to the default.'.freeze
+
+        # @!method serialize?(node)
+        def_node_matcher :serialize?, <<-PATTERN
+          (send nil? :serialize ...)
+        PATTERN
+
+        def on_send(node)
+          return unless serialize? node
+
+          add_offense(node) if node.arguments.length < 2 || !node.arguments[1].const_type?
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/betterment.rb

@@ -16,3 +16,4 @@ require 'rubocop/cop/betterment/active_job_performable'
 require 'rubocop/cop/betterment/allowlist_blocklist'
 require 'rubocop/cop/betterment/server_error_assertion'
 require 'rubocop/cop/betterment/hardcoded_id'
+require 'rubocop/cop/betterment/vague_serialize'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.4.1
 platform: ruby
 authors:
 - Development
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-11 00:00:00.000000000 Z
+date: 2023-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -108,6 +108,7 @@ files:
 - lib/rubocop/cop/betterment/utils/hardcoded_attribute.rb
 - lib/rubocop/cop/betterment/utils/method_return_table.rb
 - lib/rubocop/cop/betterment/utils/parser.rb
+- lib/rubocop/cop/betterment/vague_serialize.rb
 homepage:
 licenses:
 - MIT
@@ -128,7 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: Betterment rubocop configuration