betterlint 1.26.0 → 1.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 521829c1a24b2013526ec739c7767473854130c2e57f7c29b184011f059264a4
-  data.tar.gz: a7cb5622266cc225688096b99811eae23fec5a1af226e410f205986c3d7414ac
+  metadata.gz: 070e58e2493975205fb3f5f52f1c6082109835db4388e67d7876bfd471861e59
+  data.tar.gz: 73a4c6ddd11054bd6b2c3add1e3963f62b6849241b2eb4be2a41a1bec41cc2f7
 SHA512:
-  metadata.gz: cc3c3e063757b97e37257303a939e2d6d13bd8534646c5b0047f2fd58a229979bf2687702025a6d24971dac784b987c2393d67df79bc58875842500d67f55cb0
-  data.tar.gz: 0e1171c10b8c6b26f71cc13ddd77694487fce3749e40d84931ad82d90d0f57bf9eaea48bd16504c64695cdc95686932625de0dd4c56853c6bb2bf2807539a6ce
+  metadata.gz: c212dd812b46431b40bea0876f5aeefe5d4f657ef59bb0355342a4e22d19e167cbe950ca7edd237ad581e17cc2400f7c08cabc84ce677b16731f56957ba517d6
+  data.tar.gz: 486bdb3b54a34ee2363cf482e113a928840bda36ca94a9407e2b269748fa534a24d75e407df839d5b86561dedb50c9a1648558b507ae49acf6152b77866cfb8a

data/STYLEGUIDE.md

@@ -110,6 +110,39 @@ expect(response).to have_http_status :internal_server_error
 expect(response).to have_http_status 500
 ```
 
+## Betterment/NonNamespacedClass
+
+This cop prevents defining classes at the top level without a namespace. All classes should be defined within a module namespace to avoid polluting the global namespace and to better organize code.
+
+### BAD:
+
+```ruby
+class MyClass
+  def my_method
+  end
+end
+```
+
+### GOOD:
+
+```ruby
+module MyNamespace
+  class MyClass
+    def my_method
+    end
+  end
+end
+```
+
+or using the `::` syntax:
+
+```ruby
+class MyNamespace::MyClass
+  def my_method
+  end
+end
+```
+
 ## Betterment/SimpleDelegator
 
 This cop requires you to use Rail's `delegate` class method instead of `SimpleDelegator` in order to explicitly specify

data/config/default.yml

@@ -62,6 +62,12 @@ Betterment/InternalsProtection:
   StyleGuide: '#bettermentinternalsprotection'
   Enabled: false
 
+Betterment/NonNamespacedClass:
+  Description: Detects classes that are not namespaced under a module or constant
+  StyleGuide: '#bettermentnonamespacedclass'
+  Enabled: false
+  AllowedClasses: []
+
 Betterment/NonStandardActions:
   AdditionalAllowedActions: []
   Description: Detects non-standard controller actions.

data/lib/betterlint/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Betterlint
-  VERSION = '1.26.0'
+  VERSION = '1.28.0'
 end

data/lib/rubocop/cop/betterment/non_namespaced_class.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Betterment
+      class NonNamespacedClass < Base
+        attr_accessor :allowed_classes
+
+        MSG = <<~TEXT
+          Do not add new classes that are not namespaced underneath another constant.
+          Classes should be defined within a module namespace (e.g., `module MyNamespace; class Foo; end; end`)
+          or use the `::` syntax (e.g., `class MyNamespace::Foo`).
+
+          See here for more information on this cop:
+          https://github.com/Betterment/betterlint/blob/main/README.md#bettermentnonamespacedclass
+        TEXT
+
+        def initialize(config = nil, options = nil)
+          super
+          @allowed_classes = cop_config.fetch("AllowedClasses", []).map(&:to_sym)
+        end
+
+        def on_class(node)
+          class_name_node = node.children[0]
+
+          # Skip if the class name is nil (anonymous class)
+          return unless class_name_node
+
+          class_name = class_name_node.short_name
+
+          if class_name_node.const_type? &&
+              !namespaced?(class_name_node) &&
+              !inside_namespace?(node) &&
+              !allowed_classes.include?(class_name)
+
+            add_offense(node)
+          end
+        end
+
+        private
+
+        def namespaced?(node)
+          node.children.first&.const_type?
+        end
+
+        def inside_namespace?(node)
+          node.each_ancestor(:module, :class).any?
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/betterment.rb

@@ -12,6 +12,7 @@ require 'rubocop/cop/betterment/hardcoded_id'
 require 'rubocop/cop/betterment/implicit_redirect_type'
 require 'rubocop/cop/betterment/internals_protection'
 require 'rubocop/cop/betterment/memoization_with_arguments'
+require 'rubocop/cop/betterment/non_namespaced_class'
 require 'rubocop/cop/betterment/non_standard_actions'
 require 'rubocop/cop/betterment/non_standard_controller'
 require 'rubocop/cop/betterment/not_using_rswag'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.26.0
+  version: 1.28.0
 platform: ruby
 authors:
 - Development
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-12-17 00:00:00.000000000 Z
+date: 2026-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lint_roller
@@ -180,6 +180,7 @@ files:
 - lib/rubocop/cop/betterment/implicit_redirect_type.rb
 - lib/rubocop/cop/betterment/internals_protection.rb
 - lib/rubocop/cop/betterment/memoization_with_arguments.rb
+- lib/rubocop/cop/betterment/non_namespaced_class.rb
 - lib/rubocop/cop/betterment/non_standard_actions.rb
 - lib/rubocop/cop/betterment/non_standard_controller.rb
 - lib/rubocop/cop/betterment/not_using_rswag.rb
@@ -202,10 +203,10 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/Betterment/betterlint
-  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.26.0
-  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.26.0/CHANGELOG.md
+  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.28.0
+  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.28.0/CHANGELOG.md
   bug_tracker_uri: https://github.com/Betterment/betterlint/issues
-  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.26.0
+  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.28.0
   rubygems_mfa_required: 'true'
   default_lint_roller_plugin: Betterlint::Plugin
 post_install_message: