betterlint 1.25.0 → 1.27.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 04c560ef56ed92b4393449c238d64d433b16caa1db01dbcb81c647c04f9931d6
-  data.tar.gz: bac5e05a6ec457e6c047eba8c1d709549167ceae3b408fa084c5aa83c9594676
+  metadata.gz: 6bd1ad5be3babcc02d2b5c8f481e9106bf90d575849e9f309d44b137298b1ab0
+  data.tar.gz: d999b55f53b8528b169110f2257b1b0cb0127629b50ecdfcc5a59250cb9f79c3
 SHA512:
-  metadata.gz: 57bf6d2446f5ec19e463e3bad15bb22934b08104a7614f08b1f67291bd8243ef7c1fdbccd7d8259f8b7b69c10f995248561c2e2cecf032c2bac01df2fd074aba
-  data.tar.gz: f2cee92d7b16ba483562f7bb1ebf822ff186e106cbf1df9f3f026f013f801a2f4f9fb01737e50b3e8bbfe83f4ee26af1b44614e35a48cf65028e7d3f6afb1dd2
+  metadata.gz: af695c343d0618c7d0ac9bc937a67e99fdc5732e6d507bf8efb6a11d1d4981c437dd3118881bd09e504a3427de8e44a852cc7790502767022671de9c2fa88bfa
+  data.tar.gz: 56309c5e67dbdd2c4c6a83eb51cf466b2195f5f3deb6ad9b16409e4595b032c2c7aa3140b731a00b325ee5bbcfe14a694ec96b2c3c0d99c53c124059fb680c18

data/README.md

@@ -15,9 +15,8 @@ gem 'betterlint'
 .rubocop.yml:
 
 ```yml
-inherit_gem:
-  betterlint:
-    - config/default.yml
+plugins:
+  - betterlint
 ```
 
 ## Dependencies

data/STYLEGUIDE.md

@@ -110,6 +110,39 @@ expect(response).to have_http_status :internal_server_error
 expect(response).to have_http_status 500
 ```
 
+## Betterment/NonNamespacedClass
+
+This cop prevents defining classes at the top level without a namespace. All classes should be defined within a module namespace to avoid polluting the global namespace and to better organize code.
+
+### BAD:
+
+```ruby
+class MyClass
+  def my_method
+  end
+end
+```
+
+### GOOD:
+
+```ruby
+module MyNamespace
+  class MyClass
+    def my_method
+    end
+  end
+end
+```
+
+or using the `::` syntax:
+
+```ruby
+class MyNamespace::MyClass
+  def my_method
+  end
+end
+```
+
 ## Betterment/SimpleDelegator
 
 This cop requires you to use Rail's `delegate` class method instead of `SimpleDelegator` in order to explicitly specify

data/config/default.yml

@@ -2,11 +2,16 @@
 
 require:
   - rubocop/cop/betterment.rb
+
+plugins:
+  - rubocop-capybara
+  - rubocop-factory_bot
   - rubocop-graphql
   - rubocop-performance
   - rubocop-rails
   - rubocop-rake
   - rubocop-rspec
+  - rubocop-rspec_rails
 
 AllCops:
   DisplayCopNames: true
@@ -42,10 +47,9 @@ Betterment/DynamicParams:
 
 Betterment/EnvironmentConfiguration:
   StyleGuide: '#bettermentenvironmentconfiguration'
-  Exclude:
-    - config/**/*.rb
-    - spec/**/*.rb
-    - test/**/*.rb
+  Include:
+    - app/**/*.rb
+    - lib/**/*.rb
 
 Betterment/HardcodedID:
   AutoCorrect: false
@@ -58,6 +62,11 @@ Betterment/InternalsProtection:
   StyleGuide: '#bettermentinternalsprotection'
   Enabled: false
 
+Betterment/NonNamespacedClass:
+  Description: Detects classes that are not namespaced under a module or constant
+  StyleGuide: '#bettermentnonamespacedclass'
+  Enabled: false
+
 Betterment/NonStandardActions:
   AdditionalAllowedActions: []
   Description: Detects non-standard controller actions.
@@ -254,7 +263,7 @@ Metrics/PerceivedComplexity:
 Naming/HeredocDelimiterNaming:
   Enabled: false
 
-Naming/PredicateName:
+Naming/PredicatePrefix:
   ForbiddenPrefixes:
     - is_
   NamePrefix:
@@ -269,9 +278,6 @@ Performance/RedundantMatch:
 RSpec/BeEq:
   Enabled: false
 
-RSpec/Capybara/FeatureMethods:
-  Enabled: false
-
 RSpec/ContextWording:
   Enabled: false
 
@@ -303,7 +309,7 @@ RSpec/ExpectChange:
   EnforcedStyle: block
 
 RSpec/SpecFilePathSuffix:
-  Enabled: false
+  Enabled: true
 
 RSpec/SpecFilePathFormat:
   Enabled: false

data/lib/betterlint/version.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+module Betterlint
+  VERSION = '1.27.0'
+end

data/lib/betterlint.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require 'lint_roller'
+require_relative 'betterlint/version'
+
+module Betterlint
+  class Plugin < LintRoller::Plugin
+    def about
+      LintRoller::About.new(
+        name: 'betterlint',
+        version: VERSION,
+        homepage: 'https://github.com/Betterment/betterlint',
+        description: 'Shared rubocop configuration for Betterment Rails apps/engines.',
+      )
+    end
+
+    def supported?(context)
+      context.engine == :rubocop
+    end
+
+    def rules(_context)
+      LintRoller::Rules.new(
+        type: :path,
+        config_format: :rubocop,
+        value: File.expand_path('../config/default.yml', __dir__),
+      )
+    end
+  end
+end

data/lib/rubocop/cop/betterment/authorization_in_controller.rb

@@ -118,7 +118,7 @@ module RuboCop
             #   params[:user_id]
             # end
             if ret.send_type? && ret.method?(:[])
-              internal_params = ret.arguments.select { |x| x.sym_type? || x.str_type? }.map(&:value)
+              internal_params = ret.arguments.select { |x| x.type?(:sym, :str) }.map(&:value)
             else
               internal_returns = get_method_returns(Utils::Parser.get_root_token(ret))
               internal_params = internal_returns.flat_map { |x| Utils::Parser.get_extracted_parameters(x, param_aliases: @param_wrappers) }

data/lib/rubocop/cop/betterment/non_namespaced_class.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Betterment
+      class NonNamespacedClass < Base
+        MSG = <<~TEXT.gsub(/\s+/, " ").strip
+          Do not add new classes that are not namespaced underneath another constant.
+          Classes should be defined within a module namespace (e.g., `module MyNamespace; class Foo; end; end`)
+          or use the `::` syntax (e.g., `class MyNamespace::Foo`).
+        TEXT
+
+        def on_class(node)
+          class_name_node = node.children[0]
+
+          # Skip if the class name is nil (anonymous class)
+          return unless class_name_node
+
+          if class_name_node.const_type? && !namespaced?(class_name_node) && !inside_namespace?(node)
+            add_offense(node)
+          end
+        end
+
+        private
+
+        def namespaced?(node)
+          node.children.first&.const_type?
+        end
+
+        def inside_namespace?(node)
+          node.each_ancestor(:module, :class).any?
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/betterment/non_standard_actions.rb

@@ -52,6 +52,10 @@ module RuboCop
           route = route_to(node)
           if route
             (path, param, value) = route
+
+            # Newer Rubocop versions return param as an array
+            param = param.first if param.is_a?(Array)
+
             action = case param
             when :to then value.first.split('#').last
             when :action then value.first

data/lib/rubocop/cop/betterment/utils/parser.rb

@@ -67,16 +67,16 @@ module RuboCop
             end
           end
 
-          def self.params_from_arguments(arguments) # rubocop:disable Metrics/PerceivedComplexity
+          def self.params_from_arguments(arguments)
             parameter_names = []
 
             arguments.each do |arg|
               if arg.hash_type?
                 arg.children.each do |pair|
                   value = pair.value
-                  parameter_names << value.value if value.sym_type? || value.str_type?
+                  parameter_names << value.value if value.type?(:sym, :str)
                 end
-              elsif arg.sym_type? || arg.str_type?
+              elsif arg.type?(:sym, :str)
                 parameter_names << arg.value
               end
             end
@@ -92,7 +92,7 @@ module RuboCop
 
             if node.method?(:[]) && aliases.include?(get_root_token(node))
               return node.arguments.select { |x|
-                x.sym_type? || x.str_type?
+                x.type?(:sym, :str)
               }.map(&:value)
             end
 

data/lib/rubocop/cop/betterment.rb

@@ -12,6 +12,7 @@ require 'rubocop/cop/betterment/hardcoded_id'
 require 'rubocop/cop/betterment/implicit_redirect_type'
 require 'rubocop/cop/betterment/internals_protection'
 require 'rubocop/cop/betterment/memoization_with_arguments'
+require 'rubocop/cop/betterment/non_namespaced_class'
 require 'rubocop/cop/betterment/non_standard_actions'
 require 'rubocop/cop/betterment/non_standard_controller'
 require 'rubocop/cop/betterment/not_using_rswag'

metadata

@@ -1,28 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.25.0
+  version: 1.27.0
 platform: ruby
 authors:
 - Development
+autorequire:
 bindir: bin
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2026-01-27 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: lint_roller
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.71'
+        version: '1.82'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.82'
+- !ruby/object:Gem::Dependency
+  name: rubocop-capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.22'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.22'
+- !ruby/object:Gem::Dependency
+  name: rubocop-factory_bot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.28'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.71'
+        version: '2.28'
 - !ruby/object:Gem::Dependency
   name: rubocop-graphql
   requirement: !ruby/object:Gem::Requirement
@@ -30,6 +73,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.5.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -37,62 +83,79 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.5.6
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.23'
+        version: '1.26'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.23'
+        version: '1.26'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.29'
+        version: '2.34'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.29'
+        version: '2.34'
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.29'
+        version: '3.8'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.8'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec_rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.32'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.29'
+        version: '2.32'
 description: Betterment rubocop configuration
 email:
 - development@betterment.com
@@ -103,6 +166,8 @@ files:
 - README.md
 - STYLEGUIDE.md
 - config/default.yml
+- lib/betterlint.rb
+- lib/betterlint/version.rb
 - lib/rubocop/cop/betterment.rb
 - lib/rubocop/cop/betterment/active_job_performable.rb
 - lib/rubocop/cop/betterment/allowlist_blocklist.rb
@@ -115,6 +180,7 @@ files:
 - lib/rubocop/cop/betterment/implicit_redirect_type.rb
 - lib/rubocop/cop/betterment/internals_protection.rb
 - lib/rubocop/cop/betterment/memoization_with_arguments.rb
+- lib/rubocop/cop/betterment/non_namespaced_class.rb
 - lib/rubocop/cop/betterment/non_standard_actions.rb
 - lib/rubocop/cop/betterment/non_standard_controller.rb
 - lib/rubocop/cop/betterment/not_using_rswag.rb
@@ -137,11 +203,13 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/Betterment/betterlint
-  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.25.0
-  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.25.0/CHANGELOG.md
+  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.27.0
+  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.27.0/CHANGELOG.md
   bug_tracker_uri: https://github.com/Betterment/betterlint/issues
-  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.25.0
+  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.27.0
   rubygems_mfa_required: 'true'
+  default_lint_roller_plugin: Betterlint::Plugin
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -156,7 +224,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.8
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: Betterment rubocop configuration
 test_files: []