betterlint 1.23.0 → 1.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e78f83970d4e6b36b46992475351b250c46011a6038cb48eab065ab96dc602b7
-  data.tar.gz: 8a8638f233932cab03d50d11d34c90a1abc043823be86c75252f2a79ff2773bb
+  metadata.gz: dedcf1bca77813b532e0523d2c85776697e0a0602faaa7a6939f77d0c1af5d9c
+  data.tar.gz: 68097f9df8adb9f37db3ecafa2fbec26d1445418bc080f8d879a845557b25f4a
 SHA512:
-  metadata.gz: 6a95aa48d9f871dd4c1b09f3361d62808d058afe8739a8d5ea85c2ed28aedb43e16c2cc6c54e9b8bbff27d31dd03215abd0c0701df90abaa8f7e77d0caf984cf
-  data.tar.gz: dd86cb3a940ced9cde0eb1902aa435bfe66f7bb7c94b2cd08d3f340f1c6f86537ec4eee890dcaeb4f15c62f2524029cc576c6b5a03df5c57f26f5de401b8b0b6
+  metadata.gz: '07922a227dc628c4c3fd9389dee5ffbacb56db56cc4e15160db8849a69a21e8102e1b46c9f80bbe1062073e6886832b4ef1978ed4506aa7912edfc9a6948d9e8'
+  data.tar.gz: 38d4bfc4ea265f2242cbb45b67f9d872dfb4ea7c168b3f729ce121a7f848f2c9b1c7ca2b3df89a2b65969eb9b5994f3f012ab575b3899b9b8e1c2d060a7c76fd

data/README.md

@@ -142,13 +142,18 @@ If there isn't a better place to assign your environment variable, Rails provide
 for [custom configuration](https://guides.rubyonrails.org/configuring.html#custom-configuration):
 
 ```ruby
-config.x.whatever = ENV.fetch('WHATEVER')
+config.x.some_namespace.whatever = ENV.fetch('WHATEVER')
 ```
 
 Here's how you'd reference this configuration parameter at runtime:
 
 ```ruby
-Rails.configuration.x.whatever
+Rails.configuration.x.some_namespace.whatever
+```
+
+Or to raise an error when the value is not present
+```ruby
+Rails.configuration.x.some_namespace.whatever! # will raise "KeyError: :whatever is blank" when value is not set or set to nil
 ```
 
 ### Betterment/InternalsProtection
@@ -302,6 +307,39 @@ This cop requires you to explicitly provide an HTTP status code when rendering a
 create, update, and destroy actions. When autocorrecting, this will automatically add
 `status: :unprocessable_entity` or `status: :ok` depending on what you're rendering.
 
+### Betterment/SimpleDelegator
+
+This cop requires you to use Rails's `delegate` class method instead of `SimpleDelegator` in order to explicitly specify
+the set of delegated methods.
+
+#### BAD:
+
+```ruby
+class GearPresenter < SimpleDelegator
+  def ratio_string
+    ratio.to_s
+  end
+end
+```
+
+#### GOOD:
+
+```ruby
+class GearPresenter
+  attr_reader :gear
+  
+  delegate :ratio, to: :gear
+  
+  def initialize(gear)
+    @gear = gear
+  end
+  
+  def ratio_string
+    ratio.to_s
+  end
+end
+```
+
 ### Betterment/UseGlobalStrictLoading/ByDefaultForModels
 
 This cop identifies models where `self.strict_loading_by_default` is assigned to explicitly, and prefers that it be removed in favor of using the global strict loading settings.

data/STYLEGUIDE.md

@@ -109,3 +109,36 @@ expect(response).to have_http_status 422
 expect(response).to have_http_status :internal_server_error
 expect(response).to have_http_status 500
 ```
+
+## Betterment/SimpleDelegator
+
+This cop requires you to use Rail's `delegate` class method instead of `SimpleDelegator` in order to explicitly specify
+the set of delegating methods.
+
+### BAD:
+
+```ruby
+class GearPresenter < SimpleDelegator
+  def ratio_string
+    ratio.to_s
+  end
+end
+```
+
+### GOOD:
+
+```ruby
+class GearDelegator
+  attr_reader :gear
+
+  delegate :ratio, to: :gear
+
+  def initialize(gear)
+    @gear = gear
+  end
+
+  def ratio_string
+    ratio.to_s
+  end
+end
+```

data/config/default.yml

@@ -95,6 +95,10 @@ Betterment/ServerErrorAssertion:
   Include:
     - spec/requests/**/*_spec.rb
 
+Betterment/SimpleDelegator:
+  StyleGuide: '#bettermentsimpledelegator'
+  AutoCorrect: false
+
 Betterment/SitePrismLoaded:
   Include:
     - spec/features/**/*_spec.rb

data/lib/rubocop/cop/betterment/simple_delegator.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Betterment
+      class SimpleDelegator < Base
+        MSG = <<~MSG
+          In order to specify a set of explicitly available methods,
+          use the `delegate` class method instead of `SimpleDelegator`.
+
+          See here for more information on this error:
+          https://github.com/Betterment/betterlint/#bettermentsimpledelegator
+        MSG
+
+        # @!method class_with_simple_delegator?(node)
+        def_node_matcher :class_with_simple_delegator?, <<~PATTERN
+          (class _ (const nil? :SimpleDelegator) _)
+        PATTERN
+
+        def on_class(node)
+          add_offense(node) if class_with_simple_delegator?(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/betterment.rb

@@ -18,6 +18,7 @@ require 'rubocop/cop/betterment/not_using_rswag'
 require 'rubocop/cop/betterment/redirect_status'
 require 'rubocop/cop/betterment/render_status'
 require 'rubocop/cop/betterment/server_error_assertion'
+require 'rubocop/cop/betterment/simple_delegator'
 require 'rubocop/cop/betterment/site_prism_loaded'
 require 'rubocop/cop/betterment/spec_helper_required_outside_spec_dir'
 require 'rubocop/cop/betterment/timeout'

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.23.0
+  version: 1.24.0
 platform: ruby
 authors:
 - Development
 bindir: bin
 cert_chain: []
-date: 2025-07-10 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -121,6 +121,7 @@ files:
 - lib/rubocop/cop/betterment/redirect_status.rb
 - lib/rubocop/cop/betterment/render_status.rb
 - lib/rubocop/cop/betterment/server_error_assertion.rb
+- lib/rubocop/cop/betterment/simple_delegator.rb
 - lib/rubocop/cop/betterment/site_prism_loaded.rb
 - lib/rubocop/cop/betterment/spec_helper_required_outside_spec_dir.rb
 - lib/rubocop/cop/betterment/timeout.rb
@@ -137,10 +138,10 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/Betterment/betterlint
-  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.23.0
-  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.23.0/CHANGELOG.md
+  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.24.0
+  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.24.0/CHANGELOG.md
   bug_tracker_uri: https://github.com/Betterment/betterlint/issues
-  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.23.0
+  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.24.0
   rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
@@ -156,7 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.6
+rubygems_version: 3.6.8
 specification_version: 4
 summary: Betterment rubocop configuration
 test_files: []