betterlint 1.21.0 → 1.22.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25f8e840f59447c480bca9bb7c6ec070d1a6ef4cc5d784448bbaae92bc81e0ee
-  data.tar.gz: 1aeef2d6f6c42e0967605a5dca2f69a43b58d7a4b705338956b392979c8fefe0
+  metadata.gz: abed62a3254c489777ae4372142ff0bf2a4c8201003619e5c10f0754a07f9eb8
+  data.tar.gz: 618bb3269cb0c584e94bd3fef3f6776b5e325e9bf63d5cfdc8737c3c3d5f33a2
 SHA512:
-  metadata.gz: 4ed29d409e9038101e030a72bb736be26fa2687e8e2028be8b0fa25cddf49a768582c8fb04c546ebad0dcc4585a12705b9e0a94fa87fd81c7f381fd25f199fea
-  data.tar.gz: 622fab9cfcf2b8aeb6bc6e3ccc0c13cb62ed473d282a498798a814e1227dbfb3893f71e089359de11af7a6c8ba92b2ae4ea25f3abd0cda162b20abe8d9fdb8c6
+  metadata.gz: 641573afe2d923b6c4a063c6ed7051792484750e8542171f9f39c499886101ef6cb1aee01790de96f2c5c16de514e063a3ede731b37b68c7afce23a13b8cd9cb
+  data.tar.gz: bf51c01eb160f348615a8a0ee57c3f5954e22b18547b41b93f4c54a2c6dcf6bd3b544c761c56a162e6514c49e85b285c379a0270faf234f5739ae9b905dbf1d5

data/README.md

@@ -318,3 +318,15 @@ This allows us two benefits:
 This cop identifies associations where `:strict_loading` is set explicitly, and prefers that it be removed in favor of using the global strict loading settings.
 
 This is related to the [Betterment/UseGlobalStrictLoading/ByDefaultForModels](#bettermentuseglobalstrictloadingbydefaultformodels) cop, but allows for more granular enablement and disablement of associations within a model. The intention is similar, in that we are using this cop to help "burn down" code to strict load, but it allows us to focus on the per-association level. Some models may have quite a lot of usage, so enabling it for a model might cause thousands of failures in the specs. In those cases we will disable all the associations, and then work through them one at a time until all code that uses the model strict loads.
+
+### Betterment/VagueSerialize
+
+This cop identifies calls to `serialize` that do not specify a coder either by using the positional argument or
+the `coder` keyword argument.
+
+**NOTE:** Using a positional argument is deprecated for Rails 7.1+. That means that...
+
+- If you are on Rails 7.2
+- And you've opted into 7.1 defaults (namely, `config.active_record.default_column_serializer = nil`)
+
+...you can safely disable this cop, since failing to pass a deserializer will raise an exception.

data/lib/rubocop/cop/betterment/vague_serialize.rb

@@ -12,10 +12,16 @@ module RuboCop
           (send nil? :serialize ...)
         PATTERN
 
-        def on_send(node)
-          return unless serialize? node
+        # @!method kwargs_with_coder?(node)
+        def_node_matcher :kwargs_with_coder?, '(hash <(pair (sym :coder) const) ...>)'
+
+        # @!method valid_serialize?(node)
+        def_node_matcher :valid_serialize?, <<-PATTERN
+          (send nil? :serialize _ { const !#kwargs_with_coder?? | #kwargs_with_coder? })
+        PATTERN
 
-          add_offense(node) if node.arguments.length < 2 || !node.arguments[1].const_type?
+        def on_send(node)
+          add_offense(node) if serialize?(node) && !valid_serialize?(node)
         end
         alias on_csend on_send
       end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.21.0
+  version: 1.22.0
 platform: ruby
 authors:
 - Development
 bindir: bin
 cert_chain: []
-date: 2025-06-05 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -137,10 +137,10 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/Betterment/betterlint
-  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.21.0
-  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.21.0/CHANGELOG.md
+  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.22.0
+  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.22.0/CHANGELOG.md
   bug_tracker_uri: https://github.com/Betterment/betterlint/issues
-  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.21.0
+  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.22.0
   rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
@@ -156,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.6
+rubygems_version: 3.6.8
 specification_version: 4
 summary: Betterment rubocop configuration
 test_files: []