betterlint 1.13.0 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c4835d2317f75072a423ec551933a1eaccccf5e9e625f98973a0c7750d9a8a8
-  data.tar.gz: c40e7571c5cab59a0fbe006b8cd8dc8117bc16010ec9a0a7c33798e62c550f4a
+  metadata.gz: eba1c8a88e6cefd6fc8db168dfe4b9f41f30989c4716fdc0338e99614a40315d
+  data.tar.gz: 9b176cbf47cf1f1d65547624b44531dcb0328832a1dfc62c12b3f33c0222f1e3
 SHA512:
-  metadata.gz: e1fd9a6bfdcbc7fa683bee7200f6ff8d097b655f18757023f011ddffd9205d33b93649d721825f209e106f98bc2a1e1e32632e8ee98ab3bf4e26e62db875410b
-  data.tar.gz: 781b01893ca3ad33f4b64842fc48d27577cc0d16401d29f135d0f596a570ece65f6e37dc7aeb06f45ccd50fea846d9266a8eeb1ed199d99daff62f3a30fd1f42
+  metadata.gz: 00b1ed1bdec96493c6c9332228a2cff4a1134926c27d72ea0c13439f454af5668258a1722ef53520ffa2786472c59b1c09e12ee5abdce8e7fdc1d1d91ecb09df
+  data.tar.gz: 7d159d6ee74e8a6f5b30f3e922e9d13ae1d5a26c779c12df0750daad6e82b68d2caecda1a8e473c7b983af45d96aca3635239906d03592e3e790fbf09952dec5

data/README.md

@@ -101,6 +101,15 @@ Betterment/UnscopedFind:
     - ZipCode
 ```
 
+### Betterment/DirectDelayedEnqueue
+
+This cop flags code that uses `Object#delay` or `Delayed::Job.enqueue`. Please use `ActiveJob` instead.
+
+```ruby
+user.delay.save!
+Delayed::Job.enqueue(MyJob.new)
+```
+
 ### Betterment/DynamicParams
 
 This cop flags code that accesses parameters whose names may be dynamically generated, such as a list of parameters in an a global variable or a return value from a method. In some cases, dynamically accessing parameter names can obscure what the client is expected to send and may make it difficult to reason about the code, both manually and programmatically. For example:

data/config/default.yml

@@ -32,6 +32,9 @@ Betterment/AuthorizationInController:
   Enabled: false
   StyleGuide: '#bettermentauthorizationincontroller'
 
+Betterment/DirectDelayedEnqueue:
+  StyleGuide: '#bettermentdirectdelayedenqueue'
+
 Betterment/DynamicParams:
   StyleGuide: '#bettermentdynamicparams'
 
@@ -98,15 +101,43 @@ FactoryBot/ConsistentParenthesesStyle:
 FactoryBot/SyntaxMethods:
   Enabled: false
 
+Layout/ArgumentAlignment:
+  EnforcedStyle: with_fixed_indentation
+
+Layout/ArrayAlignment:
+  EnforcedStyle: with_fixed_indentation
+
 Layout/CaseIndentation:
-  IndentOneStep: true
+  EnforcedStyle: end
+  IndentOneStep: false
 
 Layout/ClosingParenthesisIndentation:
   Enabled: true
 
+Layout/EndAlignment:
+  EnforcedStyleAlignWith: variable
+
+Layout/FirstArgumentIndentation:
+  EnforcedStyle: consistent
+
 Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
+Layout/FirstHashElementIndentation:
+  EnforcedStyle: consistent
+
+Layout/FirstParameterIndentation:
+  Enabled: false
+
+Layout/LineContinuationLeadingSpace:
+  Enabled: false
+
+Layout/LineContinuationSpacing:
+  Enabled: true
+
+Layout/LineEndStringConcatenationIndentation:
+  Enabled: false
+
 Layout/LineLength:
   Max: 140
 
@@ -117,11 +148,11 @@ Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
 
 Layout/ParameterAlignment:
-  Enabled: false
+  Enabled: true
+  EnforcedStyle: with_fixed_indentation
 
-# Disabling because of a bug in rubocop: https://github.com/rubocop-hq/rubocop/issues/6918
 Layout/RescueEnsureAlignment:
-  Enabled: false
+  Enabled: true
 
 Lint/AmbiguousBlockAssociation:
   Exclude:

data/lib/rubocop/cop/betterment/direct_delayed_enqueue.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Betterment
+      class DirectDelayedEnqueue < Base
+        DELAY_MESSAGE = 'Please use Active Job instead of using `Object#delay`'
+        ENQUEUE_MESSAGE = 'Please use Active Job instead of using `Delayed::Job.enqueue`'
+
+        # @!method enqueue?(node)
+        def_node_matcher :enqueue?, <<-PATTERN
+          (send (const (const nil? :Delayed) :Job) :enqueue ...)
+        PATTERN
+
+        def on_send(node)
+          add_offense(node, message: DELAY_MESSAGE) if node.method?(:delay)
+          add_offense(node, message: ENQUEUE_MESSAGE) if enqueue?(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/betterment/non_standard_actions.rb

@@ -53,10 +53,10 @@ module RuboCop
           if route
             (path, param, value) = route
             action = case param
-                       when :to then value.first.split('#').last
-                       when :action then value.first
-                       else path
-                     end
+            when :to then value.first.split('#').last
+            when :action then value.first
+            else path
+            end
             add_offense(node, message: MSG_ROUTE_TO) unless allowed_action?(action)
             true
           end

data/lib/rubocop/cop/betterment/render_status.rb

@@ -26,10 +26,10 @@ module RuboCop
 
         def infer_status(responder)
           case extract_template(responder).to_s
-            when 'new', 'edit'
-              :unprocessable_entity
-            else
-              :ok
+          when 'new', 'edit'
+            :unprocessable_entity
+          else
+            :ok
           end
         end
 

data/lib/rubocop/cop/betterment/utils/parser.rb

@@ -39,25 +39,25 @@ module RuboCop
             return [node] if node.literal? || node.variable?
 
             case node.type
-              when :begin
-                get_return_values(node.children.last)
-              when :block
-                get_return_values(node.body)
-              when :if
-                if_rets = get_return_values(node.if_branch)
-                else_rets = get_return_values(node.else_branch)
-                if_rets + else_rets
-              when :case
-                cases = []
-                node.each_when do |block|
-                  cases += get_return_values(block.body)
-                end
+            when :begin
+              get_return_values(node.children.last)
+            when :block
+              get_return_values(node.body)
+            when :if
+              if_rets = get_return_values(node.if_branch)
+              else_rets = get_return_values(node.else_branch)
+              if_rets + else_rets
+            when :case
+              cases = []
+              node.each_when do |block|
+                cases += get_return_values(block.body)
+              end
 
-                cases + get_return_values(node.else_branch)
-              when :send
-                [node]
-              else
-                []
+              cases + get_return_values(node.else_branch)
+            when :send
+              [node]
+            else
+              []
             end
           end
 

data/lib/rubocop/cop/betterment.rb

@@ -5,6 +5,7 @@ require 'rubocop/cop/betterment/utils/parser'
 require 'rubocop/cop/betterment/utils/method_return_table'
 require 'rubocop/cop/betterment/utils/hardcoded_attribute'
 require 'rubocop/cop/betterment/authorization_in_controller'
+require 'rubocop/cop/betterment/direct_delayed_enqueue'
 require 'rubocop/cop/betterment/dynamic_params'
 require 'rubocop/cop/betterment/unscoped_find'
 require 'rubocop/cop/betterment/unsafe_job'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.13.0
+  version: 1.14.0
 platform: ruby
 authors:
 - Development
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-10 00:00:00.000000000 Z
+date: 2024-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -108,6 +108,7 @@ files:
 - lib/rubocop/cop/betterment/active_job_performable.rb
 - lib/rubocop/cop/betterment/allowlist_blocklist.rb
 - lib/rubocop/cop/betterment/authorization_in_controller.rb
+- lib/rubocop/cop/betterment/direct_delayed_enqueue.rb
 - lib/rubocop/cop/betterment/dynamic_params.rb
 - lib/rubocop/cop/betterment/fetch_boolean.rb
 - lib/rubocop/cop/betterment/hardcoded_id.rb
@@ -132,10 +133,10 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/Betterment/betterlint
-  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.13.0
-  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.13.0/CHANGELOG.md
+  source_code_uri: https://github.com/Betterment/betterlint/tree/v1.14.0
+  changelog_uri: https://github.com/Betterment/betterlint/blob/v1.14.0/CHANGELOG.md
   bug_tracker_uri: https://github.com/Betterment/betterlint/issues
-  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.13.0
+  documentation_uri: https://www.rubydoc.info/gems/betterlint/1.14.0
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
@@ -152,7 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.14
+rubygems_version: 3.5.18
 signing_key:
 specification_version: 4
 summary: Betterment rubocop configuration