betterlint 1.10.0 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8ae56cca2ec6c902c0eb366462cdc80fafb3895c3ea56454bdc247f528694cfa
-  data.tar.gz: d70a646105175ee4c68a1098c7bc31dc8d06249484245f180ad2e2164aa720c3
+  metadata.gz: 7eb5c7ed26f89c821f0319b2c474bed54ea591ba5e3b131f980b03e877693855
+  data.tar.gz: fe1fe8ca996cca9fd3b6380c2360695a875d48c37ec1017064d92769349ca8a3
 SHA512:
-  metadata.gz: cbde32295337b547e4b8a9fe128ebd0406573745a8e8a8acafb8c3bd8f10f6e052442c6ff36e1c915d559fc3a924f8ed7aa40914d78b3560e00c373f1019deaa
-  data.tar.gz: 709a0ea18f486e1489da86947951cf73d9d22341178a46c242d282d686eeafbce4986fbef7143305e20698e047478532dc0ce2556d781ad4b6b6fd093721ee05
+  metadata.gz: 31d148d653926781736d4725d66ddaec2e4c76502f51e5a43d61fb918744da04a8268b9afd8680506583b2621b91a0412adbf1f839873318c585a0e124b3a74a
+  data.tar.gz: a04c4263391347e8ffef907f86538a9732ce894e06283ba378d1e0adefb867f67776e5d5eb8e1c612ff0bb73252724ff1c8d4011e42bc29af964ae85a918b9fc

data/config/default.yml

@@ -2,6 +2,7 @@
 
 require:
   - rubocop/cop/betterment.rb
+  - rubocop-graphql
   - rubocop-performance
   - rubocop-rails
   - rubocop-rake

data/lib/rubocop/cop/betterment/redirect_status.rb

@@ -17,11 +17,7 @@ module RuboCop
         MSG
 
         def on_def(node)
-          each_offense(node, :redirect_to) do |responder|
-            add_offense(responder) do |corrector|
-              corrector.insert_after(responder, ", status: :see_other")
-            end
-          end
+          each_offense(node, :redirect_to) { :see_other }
         end
       end
     end

data/lib/rubocop/cop/betterment/render_status.rb

@@ -18,9 +18,7 @@ module RuboCop
 
         def on_def(node)
           each_offense(node, :render) do |responder|
-            add_offense(responder) do |corrector|
-              corrector.insert_after(responder, ", status: #{infer_status(responder).inspect}")
-            end
+            infer_status(responder)
           end
         end
 

data/lib/rubocop/cop/betterment/utils/response_status.rb

@@ -11,15 +11,28 @@ module RuboCop
 
           private
 
-          def each_offense(node, responder_name, &block)
-            if UNSAFE_ACTIONS.include?(node.method_name)
-              on_missing_status(node, responder_name, &block)
+          def each_offense(node, responder_name)
+            return unless UNSAFE_ACTIONS.include?(node.method_name)
+
+            on_missing_status(node, responder_name) do |responder|
+              add_offense(responder) do |corrector|
+                status = yield(responder)
+
+                if responder.arguments?
+                  corrector.insert_after(responder.last_argument, ", status: #{status.inspect}")
+                else
+                  corrector.replace(responder, "#{responder_name} status: #{status.inspect}")
+                end
+              end
             end
           end
 
           # @!method on_missing_status(node)
           def_node_search :on_missing_status, <<~PATTERN
-            (send nil? %1 ... !(hash <(pair (sym :status) _) ...>))
+            {
+              (send nil? %1)
+              (send nil? %1 ... !(hash <(pair (sym :status) _) ...>))
+            }
           PATTERN
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.11.0
 platform: ruby
 authors:
 - Development
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-04-09 00:00:00.000000000 Z
+date: 2024-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.62.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-graphql
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement