better_seo 1.0.0.1 → 1.0.0.2

data/lib/better_seo/dsl/twitter_cards.rb

@@ -37,10 +37,8 @@ module BetterSeo
         return get(:image) if value.nil?
 
         if value.is_a?(Hash)
-          set(:image, value)
-        else
-          set(:image, value)
         end
+        set(:image, value)
       end
 
       def image_alt(value = nil)
@@ -74,10 +72,10 @@ module BetterSeo
         else
           # Set for all platforms
           set(:app_name, {
-            iphone: value,
-            ipad: value,
-            googleplay: value
-          })
+                iphone: value,
+                ipad: value,
+                googleplay: value
+              })
         end
       end
 

data/lib/better_seo/generators/amp_generator.rb

@@ -32,22 +32,16 @@ module BetterSeo
       def to_meta_tags
         tags = []
 
-        if @canonical_url
-          tags << %(<link rel="canonical" href="#{escape_html(@canonical_url)}">)
-        end
+        tags << %(<link rel="canonical" href="#{escape_html(@canonical_url)}">) if @canonical_url
 
-        if @title
-          tags << %(<meta property="og:title" content="#{escape_html(@title)}">)
-        end
+        tags << %(<meta property="og:title" content="#{escape_html(@title)}">) if @title
 
         if @description
           tags << %(<meta name="description" content="#{escape_html(@description)}">)
           tags << %(<meta property="og:description" content="#{escape_html(@description)}">)
         end
 
-        if @image
-          tags << %(<meta property="og:image" content="#{escape_html(@image)}">)
-        end
+        tags << %(<meta property="og:image" content="#{escape_html(@image)}">) if @image
 
         tags.join("\n")
       end
@@ -72,11 +66,11 @@ module BetterSeo
         return "" if text.nil?
 
         text.to_s
-          .gsub("&", "&amp;")
-          .gsub("<", "&lt;")
-          .gsub(">", "&gt;")
-          .gsub('"', "&quot;")
-          .gsub("'", "&#39;")
+            .gsub("&", "&amp;")
+            .gsub("<", "&lt;")
+            .gsub(">", "&gt;")
+            .gsub('"', "&quot;")
+            .gsub("'", "&#39;")
       end
     end
   end

data/lib/better_seo/generators/breadcrumbs_generator.rb

@@ -46,10 +46,13 @@ module BetterSeo
         html << %(  <ol class="#{escape_html(list_class)}">)
 
         @items.each_with_index do |item, index|
+          active_class = item[:url].nil? ? " active" : ""
+          aria_current = item[:url].nil? ? ' aria-current="page"' : ""
+
           if schema
-            html << %(    <li class="breadcrumb-item#{item[:url].nil? ? " active" : ""}" itemprop="itemListElement" itemscope itemtype="https://schema.org/ListItem"#{item[:url].nil? ? ' aria-current="page"' : ""}>)
+            html << %(    <li class="breadcrumb-item#{active_class}" itemprop="itemListElement" itemscope itemtype="https://schema.org/ListItem"#{aria_current}>)
           else
-            html << %(    <li class="breadcrumb-item#{item[:url].nil? ? " active" : ""}"#{item[:url].nil? ? ' aria-current="page"' : ""}>)
+            html << %(    <li class="breadcrumb-item#{active_class}"#{aria_current}>)
           end
 
           if item[:url]
@@ -61,13 +64,11 @@ module BetterSeo
             else
               html << %(      <a href="#{escape_html(item[:url])}">#{escape_html(item[:name])}</a>)
             end
+          elsif schema
+            html << %(      <span itemprop="name">#{escape_html(item[:name])}</span>)
+            html << %(      <meta itemprop="position" content="#{index + 1}" />)
           else
-            if schema
-              html << %(      <span itemprop="name">#{escape_html(item[:name])}</span>)
-              html << %(      <meta itemprop="position" content="#{index + 1}" />)
-            else
-              html << %(      #{escape_html(item[:name])})
-            end
+            html << %(      #{escape_html(item[:name])})
           end
 
           html << %(    </li>)
@@ -115,11 +116,11 @@ module BetterSeo
         return "" if text.nil?
 
         text.to_s
-          .gsub("&", "&amp;")
-          .gsub("<", "&lt;")
-          .gsub(">", "&gt;")
-          .gsub('"', "&quot;")
-          .gsub("'", "&#39;")
+            .gsub("&", "&amp;")
+            .gsub("<", "&lt;")
+            .gsub(">", "&gt;")
+            .gsub('"', "&quot;")
+            .gsub("'", "&#39;")
       end
     end
   end

data/lib/better_seo/generators/canonical_url_manager.rb

@@ -42,14 +42,10 @@ module BetterSeo
           uri = URI.parse(@url)
 
           # Check if it's a relative URL
-          unless uri.absolute?
-            raise ValidationError, "Canonical URL must be absolute: #{@url}"
-          end
+          raise ValidationError, "Canonical URL must be absolute: #{@url}" unless uri.absolute?
 
           # Check if it's HTTP or HTTPS
-          unless uri.is_a?(URI::HTTP) || uri.is_a?(URI::HTTPS)
-            raise ValidationError, "Invalid URL format: #{@url}"
-          end
+          raise ValidationError, "Invalid URL format: #{@url}" unless uri.is_a?(URI::HTTP) || uri.is_a?(URI::HTTPS)
         rescue URI::InvalidURIError
           raise ValidationError, "Invalid URL format: #{@url}"
         end
@@ -81,9 +77,7 @@ module BetterSeo
         normalized = uri.to_s
 
         # Remove trailing slash (except for root URL)
-        if normalized.end_with?("/") && normalized.count("/") > 3
-          normalized = normalized[0...-1]
-        end
+        normalized = normalized[0...-1] if normalized.end_with?("/") && normalized.count("/") > 3
 
         # Lowercase if configured
         normalized = normalized.downcase if @lowercase
@@ -95,11 +89,11 @@ module BetterSeo
         return "" if text.nil?
 
         text.to_s
-          .gsub("&", "&")
-          .gsub("<", "&lt;")
-          .gsub(">", "&gt;")
-          .gsub('"', "&quot;")
-          .gsub("'", "&#39;")
+            .gsub("&", "&amp;")
+            .gsub("<", "&lt;")
+            .gsub(">", "&gt;")
+            .gsub('"', "&quot;")
+            .gsub("'", "&#39;")
       end
     end
   end

data/lib/better_seo/generators/meta_tags_generator.rb

@@ -47,7 +47,7 @@ module BetterSeo
 
       def keywords_tag
         keywords = @config[:keywords]
-        return nil unless keywords && keywords.any?
+        return nil unless keywords&.any?
 
         keywords_str = Array(keywords).join(", ")
         %(<meta name="keywords" content="#{escape(keywords_str)}">)
@@ -79,7 +79,8 @@ module BetterSeo
 
         # Additional directives
         robots.each do |key, value|
-          next if [:index, :follow].include?(key)
+          next if %i[index follow].include?(key)
+
           directives << key.to_s if value
         end
 
@@ -90,10 +91,10 @@ module BetterSeo
 
       def escape(text)
         text.to_s
-          .gsub("&", "&amp;")
-          .gsub('"', "&quot;")
-          .gsub("<", "&lt;")
-          .gsub(">", "&gt;")
+            .gsub("&", "&amp;")
+            .gsub('"', "&quot;")
+            .gsub("<", "&lt;")
+            .gsub(">", "&gt;")
       end
     end
   end

data/lib/better_seo/generators/open_graph_generator.rb

@@ -52,7 +52,7 @@ module BetterSeo
 
       def locale_alternate_tags
         alternates = @config[:locale_alternate]
-        return [] unless alternates && alternates.any?
+        return [] unless alternates&.any?
 
         Array(alternates).map do |locale|
           meta_tag("og:locale:alternate", locale)
@@ -100,10 +100,10 @@ module BetterSeo
 
       def escape(text)
         text.to_s
-          .gsub("&", "&")
-          .gsub('"', """)
-          .gsub("<", "&lt;")
-          .gsub(">", "&gt;")
+            .gsub("&", "&amp;")
+            .gsub('"', "&quot;")
+            .gsub("<", "&lt;")
+            .gsub(">", "&gt;")
       end
     end
   end

data/lib/better_seo/generators/robots_txt_generator.rb

@@ -58,23 +58,17 @@ module BetterSeo
           lines << "User-agent: #{rule[:user_agent]}"
 
           # Allow directives
-          if rule[:allow]
-            rule[:allow].each do |path|
-              lines << "Allow: #{path}"
-            end
+          rule[:allow]&.each do |path|
+            lines << "Allow: #{path}"
           end
 
           # Disallow directives
-          if rule[:disallow]
-            rule[:disallow].each do |path|
-              lines << "Disallow: #{path}"
-            end
+          rule[:disallow]&.each do |path|
+            lines << "Disallow: #{path}"
           end
 
           # Crawl delay
-          if rule[:crawl_delay]
-            lines << "Crawl-delay: #{rule[:crawl_delay]}"
-          end
+          lines << "Crawl-delay: #{rule[:crawl_delay]}" if rule[:crawl_delay]
 
           # Add blank line between user agent sections (except last)
           lines << "" if index < @rules.size - 1

data/lib/better_seo/generators/twitter_cards_generator.rb

@@ -92,10 +92,10 @@ module BetterSeo
 
       def escape(text)
         text.to_s
-          .gsub("&", "&")
-          .gsub('"', """)
-          .gsub("<", "&lt;")
-          .gsub(">", "&gt;")
+            .gsub("&", "&amp;")
+            .gsub('"', "&quot;")
+            .gsub("<", "&lt;")
+            .gsub(">", "&gt;")
       end
     end
   end

data/lib/better_seo/image/optimizer.rb

@@ -24,6 +24,7 @@ module BetterSeo
         unless SUPPORTED_FORMATS.include?(ext)
           raise ImageError, "Unsupported format: #{ext}. Supported: #{SUPPORTED_FORMATS.join(", ")}"
         end
+
         true
       end
 
@@ -136,6 +137,7 @@ module BetterSeo
 
       def validate_source!(source)
         raise ImageError, "Source file not found: #{source}" unless File.exist?(source)
+
         validate_format!(source)
       end
     end

data/lib/better_seo/rails/helpers/controller_helpers.rb

@@ -62,9 +62,11 @@ module BetterSeo
         def set_page_description(description, max_length: nil)
           final_description = description
 
+          # rubocop:disable Style/IfUnlessModifier
           if max_length && description.length > max_length
-            final_description = description[0...max_length - 3] + "..."
+            final_description = "#{description[0...(max_length - 3)]}..."
           end
+          # rubocop:enable Style/IfUnlessModifier
 
           merge_seo_data(:meta, { description: final_description })
         end

data/lib/better_seo/rails/helpers/seo_helper.rb

@@ -41,7 +41,7 @@ module BetterSeo
         end
 
         # Generate all SEO tags (meta + og + twitter) from configuration or block
-        def seo_tags(config = nil, &block)
+        def seo_tags(config = nil)
           if block_given?
             context = SeoTagsContext.new
             yield(context)
@@ -55,9 +55,7 @@ module BetterSeo
 
           tags = []
 
-          if merged_config[:meta]
-            tags << seo_meta_tags(merged_config[:meta])
-          end
+          tags << seo_meta_tags(merged_config[:meta]) if merged_config[:meta]
 
           if merged_config[:og] && BetterSeo.configuration.open_graph_enabled?
             tags << seo_open_graph_tags(merged_config[:og])
@@ -81,9 +79,7 @@ module BetterSeo
           meta = {}
 
           # Start with controller data
-          if controller_data[:meta]
-            meta = controller_data[:meta].dup
-          end
+          meta = controller_data[:meta].dup if controller_data[:meta]
 
           # Use default title if not set
           meta[:title] ||= config.meta_tags.default_title

data/lib/better_seo/rails/helpers/structured_data_helper.rb

@@ -27,7 +27,7 @@ module BetterSeo
           raw(sd_object.to_script_tag)
         end
 
-        def structured_data_tags(objects = nil, &block)
+        def structured_data_tags(objects = nil)
           array = block_given? ? yield : objects
           return "" if array.nil? || array.empty?
 
@@ -109,7 +109,7 @@ module BetterSeo
 
         private
 
-        def create_structured_data(type, properties, &block)
+        def create_structured_data(type, properties)
           klass = TYPE_MAPPING[type]
           raise ArgumentError, "Unknown structured data type: #{type}" unless klass
 

data/lib/better_seo/sitemap/generator.rb

@@ -6,7 +6,7 @@ module BetterSeo
   module Sitemap
     class Generator
       class << self
-        def generate(&block)
+        def generate
           builder = Builder.new
           yield(builder) if block_given?
           builder.to_xml

data/lib/better_seo/sitemap/sitemap_index.rb

@@ -62,11 +62,11 @@ module BetterSeo
 
       def escape_xml(text)
         text.to_s
-          .gsub("&", "&")
-          .gsub("<", "&lt;")
-          .gsub(">", "&gt;")
-          .gsub('"', "&quot;")
-          .gsub("'", "&apos;")
+            .gsub("&", "&amp;")
+            .gsub("<", "&lt;")
+            .gsub(">", "&gt;")
+            .gsub('"', "&quot;")
+            .gsub("'", "&apos;")
       end
     end
   end

data/lib/better_seo/sitemap/url_entry.rb

@@ -28,13 +28,13 @@ module BetterSeo
         unless VALID_CHANGEFREQ.include?(value)
           raise ValidationError, "Invalid changefreq: #{value}. Must be one of: #{VALID_CHANGEFREQ.join(", ")}"
         end
+
         @changefreq = value
       end
 
       def priority=(value)
-        unless value.between?(0.0, 1.0)
-          raise ValidationError, "Priority must be between 0.0 and 1.0"
-        end
+        raise ValidationError, "Priority must be between 0.0 and 1.0" unless value.between?(0.0, 1.0)
+
         @priority = value
       end
 
@@ -119,9 +119,7 @@ module BetterSeo
 
         begin
           uri = URI.parse(@loc)
-          unless uri.is_a?(URI::HTTP) || uri.is_a?(URI::HTTPS)
-            raise ValidationError, "Invalid URL format: #{@loc}"
-          end
+          raise ValidationError, "Invalid URL format: #{@loc}" unless uri.is_a?(URI::HTTP) || uri.is_a?(URI::HTTPS)
         rescue URI::InvalidURIError
           raise ValidationError, "Invalid URL format: #{@loc}"
         end
@@ -146,11 +144,11 @@ module BetterSeo
 
       def escape_xml(text)
         text.to_s
-          .gsub("&", "&")
-          .gsub("<", "&lt;")
-          .gsub(">", "&gt;")
-          .gsub('"', "&quot;")
-          .gsub("'", "&apos;")
+            .gsub("&", "&amp;")
+            .gsub("<", "&lt;")
+            .gsub(">", "&gt;")
+            .gsub('"', "&quot;")
+            .gsub("'", "&apos;")
       end
     end
   end

data/lib/better_seo/structured_data/base.rb

@@ -35,7 +35,7 @@ module BetterSeo
         hash
       end
 
-      def to_json(*args)
+      def to_json(*_args)
         JSON.pretty_generate(to_h)
       end
 
@@ -53,6 +53,7 @@ module BetterSeo
 
       def validate!
         raise ValidationError, "@type is required for structured data" unless valid?
+
         true
       end
 

data/lib/better_seo/structured_data/event.rb

@@ -82,9 +82,7 @@ module BetterSeo
         location_hash["name"] = name if name
         location_hash["url"] = url if url
 
-        if address
-          location_hash["address"] = build_address(address)
-        end
+        location_hash["address"] = build_address(address) if address
 
         other_properties.each do |key, value|
           location_hash[key.to_s] = value

data/lib/better_seo/structured_data/generator.rb

@@ -10,61 +10,61 @@ module BetterSeo
           structured_data_array.map(&:to_script_tag).join("\n\n")
         end
 
-        def organization(**properties, &block)
+        def organization(**properties)
           org = Organization.new(**properties)
           yield(org) if block_given?
           org
         end
 
-        def article(**properties, &block)
+        def article(**properties)
           article = Article.new(**properties)
           yield(article) if block_given?
           article
         end
 
-        def person(**properties, &block)
+        def person(**properties)
           person = Person.new(**properties)
           yield(person) if block_given?
           person
         end
 
-        def product(**properties, &block)
+        def product(**properties)
           product = Product.new(**properties)
           yield(product) if block_given?
           product
         end
 
-        def breadcrumb_list(**properties, &block)
+        def breadcrumb_list(**properties)
           breadcrumb = BreadcrumbList.new(**properties)
           yield(breadcrumb) if block_given?
           breadcrumb
         end
 
-        def local_business(**properties, &block)
+        def local_business(**properties)
           business = LocalBusiness.new(**properties)
           yield(business) if block_given?
           business
         end
 
-        def event(**properties, &block)
+        def event(**properties)
           event = Event.new(**properties)
           yield(event) if block_given?
           event
         end
 
-        def faq_page(**properties, &block)
+        def faq_page(**properties)
           faq = FAQPage.new(**properties)
           yield(faq) if block_given?
           faq
         end
 
-        def how_to(**properties, &block)
+        def how_to(**properties)
           how_to = HowTo.new(**properties)
           yield(how_to) if block_given?
           how_to
         end
 
-        def recipe(**properties, &block)
+        def recipe(**properties)
           recipe = Recipe.new(**properties)
           yield(recipe) if block_given?
           recipe

data/lib/better_seo/structured_data/recipe.rb

@@ -79,7 +79,8 @@ module BetterSeo
       end
 
       # Nutrition information
-      def nutrition(calories: nil, fat_content: nil, carbohydrate_content: nil, protein_content: nil, sugar_content: nil, **other)
+      def nutrition(calories: nil, fat_content: nil, carbohydrate_content: nil, protein_content: nil,
+                    sugar_content: nil, **other)
         nutrition_hash = {
           "@type" => "NutritionInformation"
         }
@@ -114,9 +115,7 @@ module BetterSeo
       def to_h
         hash = super
 
-        if @ingredients.any?
-          hash["recipeIngredient"] = @ingredients
-        end
+        hash["recipeIngredient"] = @ingredients if @ingredients.any?
 
         if @instructions.any?
           hash["recipeInstructions"] = @instructions.map.with_index(1) do |instruction, index|

data/lib/better_seo/validators/seo_recommendations.rb

@@ -22,7 +22,7 @@ module BetterSeo
         recommendations = []
         length = title_result[:length]
 
-        if length == 0
+        if length.zero?
           recommendations << {
             category: "Title",
             priority: :high,
@@ -56,7 +56,7 @@ module BetterSeo
         recommendations = []
         length = desc_result[:length]
 
-        if length == 0
+        if length.zero?
           recommendations << {
             category: "Meta Description",
             priority: :high,
@@ -90,7 +90,7 @@ module BetterSeo
         recommendations = []
         h1_count = headings_result[:h1_count]
 
-        if h1_count == 0
+        if h1_count.zero?
           recommendations << {
             category: "Headings",
             priority: :high,
@@ -106,7 +106,7 @@ module BetterSeo
           }
         end
 
-        if headings_result[:total_headings] == 0
+        if headings_result[:total_headings].zero?
           recommendations << {
             category: "Headings",
             priority: :medium,
@@ -123,13 +123,13 @@ module BetterSeo
 
         recommendations = []
 
-        if images_result[:images_without_alt] > 0
+        if images_result[:images_without_alt].positive?
           count = images_result[:images_without_alt]
           recommendations << {
             category: "Images",
             priority: :medium,
             action: "Add alt text to images",
-            details: "#{count} image#{count > 1 ? 's' : ''} missing alt text. Alt text improves accessibility and SEO."
+            details: "#{count} image#{"s" if count > 1} missing alt text. Alt text improves accessibility and SEO."
           }
         end
 
@@ -145,7 +145,7 @@ module BetterSeo
         # Group by priority
         grouped = recommendations.group_by { |r| r[:priority] }
 
-        [:high, :medium, :low].each do |priority|
+        %i[high medium low].each do |priority|
           next unless grouped[priority]
 
           output << "## #{priority.to_s.capitalize} Priority\n"