better_record 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f55b373249d94d0c3897696ebcd255ee63195ad676e6fce7e00d60d6bd042c1c
-  data.tar.gz: eec66e18958e1cdd9961220c5bd1992553ecb2b8a6eb4e96f1a7cb295bef574d
+  metadata.gz: b34680cbdfc9ffc808911351efc1e7694a8ba71d7b3cfb8420cfed2af6cbc2ef
+  data.tar.gz: f0940956cf68e9043664be86359be4c0fe60a0c01165ab0e8c430547a2ee1957
 SHA512:
-  metadata.gz: 1d6cec87644e2201c977029d872a801f7eec6619eccdd705af3b534ddb193c248939923722568fc13af14b23add0f41332d01026bc25c056a7245fe1f1cfbc27
-  data.tar.gz: ccdbbb3bea4fd5343e6a8fa1e138f0b3731ea1505299b65421042d01720381213ee9090ab2ba92f4396c1fdd998e26579dc93ebeb3e6159da30b4ee1e2a3824a
+  metadata.gz: 826c96881eeb3caaa6cc37bf72adfc9dbba9a78a30854a63954295c57717e41bf96e7013de9f5c5d6700d4f61c6fd50a22eeb117d3752e60d9bdace03dce4d41
+  data.tar.gz: a1a368f27c284f95b99639cd839d17fde9b2e6d9331f4101262658b08b29a77c7d42cab718fd4671ae86f5ac5d3d37e24acd113ed7846912b65f9cedda4af0ba

data/lib/better_record.rb

@@ -17,7 +17,7 @@ module BetterRecord
   self.app_domain_name = (ENV.fetch('APP_DOMAIN_NAME') { 'non_existant_domain.com' }).to_s
 end
 
-Dir.glob("#{File.expand_path(__dir__)}/better_record/*").each do |d|
+Dir.glob("#{File.expand_path(__dir__)}/better_record/*.rb").each do |d|
   require d unless (d =~ /fake/)
 end
 

data/lib/better_record/rspec/extensions.rb

@@ -0,0 +1,10 @@
+module BetterRecord
+  module Rspec
+    module Extensions
+    end
+  end
+end
+
+Dir.glob("#{File.expand_path(__dir__)}/extensions/*").each do |d|
+  require d
+end

data/lib/better_record/rspec/extensions/boolean_column.rb

@@ -0,0 +1,54 @@
+module BetterRecord
+  module Rspec
+    module Extensions
+      def boolean_column(factory_name, column_name, default_val = false)
+        describe column_name.to_s do
+          let(:record) { build(factory_name) }
+
+          it "cannot be nil in the database" do
+            stubbed = record.dup
+            allow(stubbed).to receive(:set_booleans)
+
+            stubbed.__send__"#{column_name}=", nil
+            expect(stubbed.valid?).to be false
+            expect(stubbed.errors[column_name]).to include("must be true or false")
+            expect { stubbed.save(validate: false) }.to raise_error(ActiveRecord::NotNullViolation)
+          end
+
+          it "defaults to '#{default_val}'" do
+            empty_record = record.class.new
+            expect(empty_record.__send__ column_name).to be default_val
+          end
+
+          it "will parse to boolean on save" do
+            record.__send__"#{column_name}=", nil
+            record.save
+            expect(record.__send__ column_name).to be false
+
+            record.__send__"#{column_name}=", 0
+            record.save
+            expect(record.__send__ column_name).to be false
+
+            record.__send__"#{column_name}=", 'false'
+            record.save
+            expect(record.__send__ column_name).to be false
+
+            record.__send__"#{column_name}=", 1
+            record.save
+            expect(record.__send__ column_name).to be true
+
+            record.__send__"#{column_name}=", 'asdf'
+            record.save
+            expect(record.__send__ column_name).to be true
+
+            record.__send__"#{column_name}=", 'true'
+            record.save
+            expect(record.__send__ column_name).to be true
+
+            record.destroy
+          end
+        end
+      end
+    end
+  end
+end

data/lib/better_record/rspec/extensions/has_valid_factory.rb

@@ -0,0 +1,22 @@
+module BetterRecord
+  module Rspec
+    module Extensions
+      def has_valid_factory(factory_name, count = 10)
+        it "has a valid factory" do
+          records = []
+          count = (count.to_i == 0) ? 1 : count.to_i
+          count.times do
+            test_factory = build(factory_name)
+            unless test_factory.valid?
+              puts test_factory.errors.full_messages
+            end
+            expect(test_factory.valid?).to be true
+            expect(test_factory.save).to be true
+            records << test_factory
+          end
+          records.each {|f| f.destroy}
+        end
+      end
+    end
+  end
+end

data/lib/better_record/rspec/extensions/optional_column.rb

@@ -0,0 +1,19 @@
+module BetterRecord
+  module Rspec
+    module Extensions
+      def optional_column(factory_name, column_name, &blk)
+        describe column_name.to_s do
+          let(:record) { build(factory_name) }
+
+          it "is optional" do
+            record.__send__"#{column_name}=", nil
+            expect(record.valid?).to be true
+            expect(record.errors[column_name]).to be_empty
+          end
+
+          instance_eval(&blk) if block_given?
+        end
+      end
+    end
+  end
+end

data/lib/better_record/rspec/extensions/required_column.rb

@@ -0,0 +1,37 @@
+module BetterRecord
+  module Rspec
+    module Extensions
+      def required_column(factory_name, column_name, unique = false, &blk)
+        describe column_name.to_s do
+          let(:record) { build(factory_name) }
+
+          it "is required" do
+            record.__send__"#{column_name}=", nil
+            expect(record.valid?).to be false
+            expect(record.errors[column_name]).to include("can't be blank")
+            expect { record.save(validate: false) }.to raise_error(ActiveRecord::NotNullViolation)
+          end
+
+          if unique
+            it "must be unique" do
+              expect(record.valid?).to be true
+              expect(record.save).to be true
+
+              dupped = record.dup
+              expect(dupped.valid?).to be false
+              expect(dupped.errors[column_name]).to include("has already been taken")
+              expect(dupped.save).to be false
+
+              record.destroy
+              expect(dupped.valid?).to be true
+              expect(dupped.save).to be true
+              dupped.destroy
+            end
+          end
+
+          instance_eval(&blk) if block_given?
+        end
+      end
+    end
+  end
+end

data/lib/better_record/version.rb

@@ -1,3 +1,3 @@
 module BetterRecord
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/lib/generators/better_record/eject_rspec_extensions/USAGE

@@ -0,0 +1,12 @@
+Description:
+    Eject BetterRecord::Rspec::Extensions into local spec dir
+
+Example:
+    rails generate better_record:eject_rspec_extensions
+
+    This will create:
+        spec/extensions.rb
+        spec/extensions/boolean_column.rb
+        spec/extensions/has_valid_factory.rb
+        spec/extensions/optional_column.rb
+        spec/extensions/required_column.rb

data/lib/generators/better_record/eject_rspec_extensions/eject_rspec_extensions_generator.rb

@@ -0,0 +1,8 @@
+class BetterRecord::EjectRspecExtensionsGenerator < Rails::Generators::Base
+  source_root File.expand_path('templates', __dir__)
+
+  def copy_templates
+    template "#{BetterRecord::Engine.root}/lib/better_record/rspec/extensions.rb", 'spec/extensions.rb'
+    directory "#{BetterRecord::Engine.root}/lib/better_record/rspec/extensions", 'spec/extensions'
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: better_record
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Sampson Crowley
@@ -196,7 +196,14 @@ files:
 - lib/better_record/railtie.rb
 - lib/better_record/reflection.rb
 - lib/better_record/relation.rb
+- lib/better_record/rspec/extensions.rb
+- lib/better_record/rspec/extensions/boolean_column.rb
+- lib/better_record/rspec/extensions/has_valid_factory.rb
+- lib/better_record/rspec/extensions/optional_column.rb
+- lib/better_record/rspec/extensions/required_column.rb
 - lib/better_record/version.rb
+- lib/generators/better_record/eject_rspec_extensions/USAGE
+- lib/generators/better_record/eject_rspec_extensions/eject_rspec_extensions_generator.rb
 - lib/generators/better_record/setup/USAGE
 - lib/generators/better_record/setup/setup_generator.rb
 - lib/generators/better_record/setup/templates/gitattributes