better_receive 0.4.1 → 0.5.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 2374b6397328e21d63f479e68e74a2dfdc843960
+  data.tar.gz: c4e755a254de947b2fe8bed0bcca4e390177a513
+SHA512:
+  metadata.gz: 9c755925be275f776cb9e7bfc86372785b96fb96a348583b2d03252d4e4b4771f13ab7189652a6e498f7de6cbdc7937d87406c129a71b324fc4b8a00289412b8
+  data.tar.gz: 2692f614cf4c2803c7f24e91fa9fc92ec545c5e54432aadc9a943934155ac54900bcb0c16ee9cb25c0c82121811ff00d853bd4d786c281288fd1e84abc211085

data/.gitignore

@@ -3,6 +3,7 @@
 .bundle
 .config
 .yardoc
+.ruby-version
 Gemfile.lock
 InstalledFiles
 _yardoc

data/README.md

@@ -20,6 +20,8 @@ foo.better_receive(:bar)
 foo.better_stub(bar: 1, baz: 2)
 # or
 Foo.any_instance.better_receive(:bar).with(:wibble)
+# or
+foo.better_not_receive(:bar_baz)
 
 ```
 

data/lib/better_receive.rb

@@ -8,6 +8,10 @@ module BetterReceive
     Mock.new(self).assert_with(*args, &block)
   end
 
+  def better_not_receive(*args, &block)
+    Mock.new(self).assert_negative_with(*args, &block)
+  end
+
   def better_stub(*args, &block)
     Stub.new(self).assert_with(*args, &block)
   end

data/lib/better_receive/base.rb

@@ -27,6 +27,11 @@ module BetterReceive
       any_instance_add_expectation selector, &block
     end
 
+    def any_instance_better_not_expect(selector, options, &block)
+      any_instance_should_respond_to selector
+      any_instance_add_negative_expectation selector, &block
+    end
+
     def any_instance_should_respond_to(selector)
       klass = subject.instance_variable_get(:@klass)
       unless klass.method_defined?(selector)
@@ -43,5 +48,14 @@ module BetterReceive
       subject.message_chains.add(selector, expectation_chain(selector, &block))
     end
 
+    def any_instance_add_negative_expectation(selector, &block)
+      RSpec::Mocks::space.add(subject)
+
+      subject.instance_variable_set(:@expectation_set, true)
+      subject.send(:observe!, selector)
+
+      subject.message_chains.add(selector, negative_expectation_chain(selector, &block))
+    end
+
   end
 end

data/lib/better_receive/mock.rb

@@ -2,6 +2,7 @@ module BetterReceive
   class Mock < Base
 
     def assert_with(selector, options={}, &block)
+      selector = selector.to_sym
       if subject_is_any_instance?
         any_instance_better_expect(selector, options, &block)
       else
@@ -10,6 +11,16 @@ module BetterReceive
       end
     end
 
+    def assert_negative_with(selector, options={}, &block)
+      selector = selector.to_sym
+      if subject_is_any_instance?
+        any_instance_better_not_expect(selector, options, &block)
+      else
+        subject.should respond_to selector
+        negative_mock_subject_method(selector, options, &block)
+      end
+    end
+
 
     private
 
@@ -18,6 +29,11 @@ module BetterReceive
       subject_mock_proxy.add_message_expectation(location, selector, options, &block)
     end
 
+    def negative_mock_subject_method(selector, options, &block)
+      location = options[:expected_from] || caller(1)[2]
+      subject_mock_proxy.add_negative_message_expectation(location, selector, &block)
+    end
+
     def expectation_chain(*args)
       if defined?(RSpec::Mocks::AnyInstance::PositiveExpectationChain)
         RSpec::Mocks::AnyInstance::PositiveExpectationChain.new(*args)
@@ -26,5 +42,13 @@ module BetterReceive
       end
     end
 
+    def negative_expectation_chain(*args)
+      if defined?(RSpec::Mocks::AnyInstance::NegativeExpectationChain)
+        RSpec::Mocks::AnyInstance::NegativeExpectationChain.new(*args)
+      else
+        RSpec::Mocks::AnyInstance::NegativeExpectationChain.new(*args)
+      end
+    end
+
   end
 end

data/lib/better_receive/stub.rb

@@ -15,6 +15,7 @@ module BetterReceive
     private
 
     def better_stub_method(selector, options, &block)
+      selector = selector.to_sym
       if subject_is_any_instance?
         any_instance_better_expect(selector, options, &block)
       else

data/lib/better_receive/version.rb

@@ -1,3 +1,3 @@
 module BetterReceive
-  BETTER_VERSION = "0.4.1"
+  BETTER_VERSION = "0.5.0"
 end

data/spec/lib/better_receive/mock_spec.rb

@@ -60,6 +60,15 @@ describe BetterReceive::Mock do
 
           br_mock.assert_with(:bar, passed: true, &block_param)
         end
+
+        it "converts the selector to a symbol if necessary" do
+          foo.should_receive(:send).with(:__mock_proxy).and_return(mock_proxy)
+          mock_proxy.should_receive(:add_message_expectation) do |*args, &block|
+            args[1].should == :bar
+          end
+
+          br_mock.assert_with('bar', passed: true, &block_param)
+        end
       end
 
       context "on .any_instance" do
@@ -99,4 +108,106 @@ describe BetterReceive::Mock do
       end
     end
   end
+
+  describe "#assert_negative_with" do
+    let(:foo) { Foo.new }
+    let(:br_mock) { BetterReceive::Mock.new(foo) }
+
+    it "raises an error if the method is not defined" do
+      expect {
+        br_mock.assert_negative_with :bar_baz
+      }.to raise_error(RSpec::Expectations::ExpectationNotMetError) { |error|
+        error.message.should =~ /to respond to :bar_baz/
+      }
+    end
+
+    context "when mocking" do
+      let(:mock_proxy) { double(RSpec::Mocks::Proxy) }
+
+      it "creates a mock proxy and adds an expectation to it" do
+        foo.should_receive(:send).with(:__mock_proxy).and_return(mock_proxy)
+        mock_proxy.should_receive(:add_negative_message_expectation)
+
+        br_mock.assert_negative_with :bar
+      end
+
+      it "returns an rspec message expectation(responds to additional matchers ('with', 'once'...))" do
+        foo.better_not_receive(:bar).should be_a RSpec::Mocks::NegativeMessageExpectation
+
+        expect {
+          foo.bar
+        }.to raise_error(RSpec::Mocks::MockExpectationError) { |error|
+          error.message.should include "received: 1 time"
+        }
+
+        br_mock.assert_negative_with(:bar).with('wibble')
+        expect {
+          foo.bar('wibble')
+        }.to raise_error(RSpec::Mocks::MockExpectationError) { |error|
+          error.message.should include "received: 1 time"
+        }
+
+      end
+
+      context "and passing arguments" do
+        let(:block_param) { Proc.new {} }
+        let(:options) { {passed: true} }
+
+        it "passes all arguments through to the mock_proxy" do
+          foo.should_receive(:send).with(:__mock_proxy).and_return(mock_proxy)
+          mock_proxy.should_receive(:add_negative_message_expectation) do |*args, &block|
+            args[1].should == :bar
+            block.should == block_param
+          end
+
+          br_mock.assert_negative_with(:bar, &block_param)
+        end
+
+        it "converts the selector to a symbol" do
+          foo.should_receive(:send).with(:__mock_proxy).and_return(mock_proxy)
+          mock_proxy.should_receive(:add_negative_message_expectation) do |*args, &block|
+            args[1].should == :bar
+          end
+
+          br_mock.assert_negative_with("bar", &block_param)
+        end
+      end
+
+      context "on .any_instance" do
+        let(:br_mock) { BetterReceive::Mock.new(Foo.any_instance) }
+
+        context "when the method is defined" do
+          context "and the method is called" do
+            it 'raises when called' do
+              expect {
+                br_mock.assert_negative_with(:bar)
+                foo.bar
+              }.to raise_error(RSpec::Mocks::MockExpectationError) { |error|
+                error.message.should include "received: 1 time"
+              }
+            end
+          end
+
+          context 'and the method is not called' do
+            it 'does not raise an error' do
+              expect {
+                br_mock.assert_negative_with(:bar)
+                RSpec::Mocks::space.verify_all
+              }.to_not raise_error
+            end
+          end
+        end
+
+        context 'when the method is not defined' do
+          it 'raises an error' do
+            expect {
+              br_mock.assert_negative_with(:baz)
+            }.to raise_error { |error|
+              error.message.should == "Expected instances of Foo to respond to :baz"
+            }
+          end
+        end
+      end
+    end
+  end
 end

data/spec/lib/better_receive/stub_spec.rb

@@ -51,14 +51,23 @@ describe BetterReceive::Stub do
         it "passes all arguments through to the mock_proxy" do
           foo.should_receive(:send).with(:__mock_proxy).and_return(mock_proxy)
           mock_proxy.should_receive(:add_stub) do |*args, &block|
-          args[1].should == :bar
-          args[2].should == options
-          block.should == block_param
+            args[1].should == :bar
+            args[2].should == options
+            block.should == block_param
           end
 
           br_stub.assert_with(:bar, passed: true, &block_param)
         end
 
+        it "converts the selector to a string" do
+          foo.should_receive(:send).with(:__mock_proxy).and_return(mock_proxy)
+          mock_proxy.should_receive(:add_stub) do |*args, &block|
+            args[1].should == :bar
+          end
+
+          br_stub.assert_with("bar", passed: true, &block_param)
+        end
+
         it "returns the value passed in the block" do
           br_stub.assert_with(:bar) { :baz }
 

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: better_receive
 version: !ruby/object:Gem::Version
-  version: 0.4.1
-  prerelease: 
+  version: 0.5.0
 platform: ruby
 authors:
 - Steve Ellis
@@ -10,12 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-07 00:00:00.000000000 Z
+date: 2013-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -23,7 +21,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -31,33 +28,29 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Assert that an object responds to a method before asserting that the
@@ -87,27 +80,26 @@ files:
 - spec/spec_helper.rb
 homepage: http://github.com/se3000/better_receive
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A more assertive mock.
 test_files:
 - spec/lib/better_receive/mock_spec.rb