better_errors 1.0.0 → 2.9.1

data/spec/better_errors/middleware_spec.rb

@@ -1,112 +0,0 @@
-require "spec_helper"
-
-module BetterErrors
-  describe Middleware do
-    let(:app) { Middleware.new(->env { ":)" }) }
-    let(:exception) { RuntimeError.new("oh no :(") }
-
-    it "passes non-error responses through" do
-      app.call({}).should == ":)"
-    end
-
-    it "calls the internal methods" do
-      app.should_receive :internal_call
-      app.call("PATH_INFO" => "/__better_errors/1/preform_awesomness")
-    end
-
-    it "calls the internal methods on any subfolder path" do
-      app.should_receive :internal_call
-      app.call("PATH_INFO" => "/any_sub/folder/path/__better_errors/1/preform_awesomness")
-    end
-
-    it "shows the error page" do
-      app.should_receive :show_error_page
-      app.call("PATH_INFO" => "/__better_errors/")
-    end
-
-    it "shows the error page on any subfolder path" do
-      app.should_receive :show_error_page
-      app.call("PATH_INFO" => "/any_sub/folder/path/__better_errors/")
-    end
-
-    it "doesn't show the error page to a non-local address" do
-      app.should_not_receive :better_errors_call
-      app.call("REMOTE_ADDR" => "1.2.3.4")
-    end
-
-    it "shows to a whitelisted IP" do
-      BetterErrors::Middleware.allow_ip! '77.55.33.11'
-      app.should_receive :better_errors_call
-      app.call("REMOTE_ADDR" => "77.55.33.11")
-    end
-
-    it "doesn't blow up when given a blank REMOTE_ADDR" do
-      expect { app.call("REMOTE_ADDR" => " ") }.to_not raise_error
-    end
-
-    it "doesn't blow up when given an IP address with a zone index" do
-      expect { app.call("REMOTE_ADDR" => "0:0:0:0:0:0:0:1%0" ) }.to_not raise_error
-    end
-
-    context "when requesting the /__better_errors manually" do
-      let(:app) { Middleware.new(->env { ":)" }) }
-
-      it "shows that no errors have been recorded" do
-        status, headers, body = app.call("PATH_INFO" => "/__better_errors")
-        body.join.should match /No errors have been recorded yet./
-      end
-
-      it "shows that no errors have been recorded on any subfolder path" do
-        status, headers, body = app.call("PATH_INFO" => "/any_sub/folder/path/__better_errors")
-        body.join.should match /No errors have been recorded yet./
-      end
-    end
-
-    context "when handling an error" do
-      let(:app) { Middleware.new(->env { raise exception }) }
-
-      it "returns status 500" do
-        status, headers, body = app.call({})
-
-        status.should == 500
-      end
-
-      it "returns ExceptionWrapper's status_code" do
-        ad_ew = double("ActionDispatch::ExceptionWrapper")
-        ad_ew.stub('new').with({}, exception ){ double("ExceptionWrapper", status_code: 404) }
-        stub_const('ActionDispatch::ExceptionWrapper', ad_ew)
-
-        status, headers, body = app.call({})
-
-        status.should == 404
-      end
-
-      it "returns UTF-8 error pages" do
-        status, headers, body = app.call({})
-
-        headers["Content-Type"].should match /charset=utf-8/
-      end
-
-      it "returns text pages by default" do
-        status, headers, body = app.call({})
-
-        headers["Content-Type"].should match /text\/plain/
-      end
-
-      it "returns HTML pages by default" do
-        # Chrome's 'Accept' header looks similar this.
-        status, headers, body = app.call("HTTP_ACCEPT" => "text/html,application/xhtml+xml;q=0.9,*/*")
-
-        headers["Content-Type"].should match /text\/html/
-      end
-
-      it "logs the exception" do
-        logger = Object.new
-        logger.should_receive :fatal
-        BetterErrors.stub(:logger).and_return(logger)
-
-        app.call({})
-      end
-    end
-  end
-end

data/spec/better_errors/repl/basic_spec.rb

@@ -1,18 +0,0 @@
-require "spec_helper"
-require "better_errors/repl/basic"
-require "better_errors/repl/shared_examples"
-
-module BetterErrors
-  module REPL
-    describe Basic do
-      let(:fresh_binding) {
-        local_a = 123
-        binding
-      }
-      
-      let(:repl) { Basic.new fresh_binding }
-
-      it_behaves_like "a REPL provider"
-    end
-  end
-end

data/spec/better_errors/repl/pry_spec.rb

@@ -1,36 +0,0 @@
-require "spec_helper"
-require "pry"
-require "better_errors/repl/pry"
-require "better_errors/repl/shared_examples"
-
-module BetterErrors
-  module REPL
-    describe Pry do
-      let(:fresh_binding) {
-        local_a = 123
-        binding
-      }
-
-      let(:repl) { Pry.new fresh_binding }
-
-      it "does line continuation" do
-        output, prompt, filled = repl.send_input ""
-        output.should == "=> nil\n"
-        prompt.should == ">>"
-        filled.should == ""
-
-        output, prompt, filled = repl.send_input "def f(x)"
-        output.should == ""
-        prompt.should == ".."
-        filled.should == "  "
-
-        output, prompt, filled = repl.send_input "end"
-        output.should == "=> nil\n"
-        prompt.should == ">>"
-        filled.should == ""
-      end
-
-      it_behaves_like "a REPL provider"
-    end
-  end
-end

data/spec/better_errors/repl/shared_examples.rb

@@ -1,18 +0,0 @@
-shared_examples_for "a REPL provider" do
-  it "evaluates ruby code in a given context" do
-    repl.send_input("local_a = 456")
-    fresh_binding.eval("local_a").should == 456
-  end
-  
-  it "returns a tuple of output and the new prompt" do
-    output, prompt = repl.send_input("1 + 2")
-    output.should == "=> 3\n"
-    prompt.should == ">>"
-  end
-  
-  it "doesn't barf if the code throws an exception" do
-    output, prompt = repl.send_input("raise Exception")
-    output.should include "Exception: Exception"
-    prompt.should == ">>"
-  end
-end

data/spec/better_errors/stack_frame_spec.rb

@@ -1,161 +0,0 @@
-require "spec_helper"
-
-module BetterErrors
-  describe StackFrame do
-    context "#application?" do
-      it "is true for application filenames" do
-        BetterErrors.stub(:application_root).and_return("/abc/xyz")
-        frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index")
-        
-        frame.application?.should be_true
-      end
-      
-      it "is false for everything else" do
-        BetterErrors.stub(:application_root).and_return("/abc/xyz")
-        frame = StackFrame.new("/abc/nope", 123, "foo")
-        
-        frame.application?.should be_false
-      end
-      
-      it "doesn't care if no application_root is set" do
-        frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index")
-        
-        frame.application?.should be_false
-      end
-    end
-    
-    context "#gem?" do
-      it "is true for gem filenames" do
-        Gem.stub(:path).and_return(["/abc/xyz"])
-        frame = StackFrame.new("/abc/xyz/gems/whatever-1.2.3/lib/whatever.rb", 123, "foo")
-        
-        frame.gem?.should be_true
-      end
-      
-      it "is false for everything else" do
-        Gem.stub(:path).and_return(["/abc/xyz"])
-        frame = StackFrame.new("/abc/nope", 123, "foo")
-        
-        frame.gem?.should be_false
-      end
-    end
-    
-    context "#application_path" do
-      it "chops off the application root" do
-        BetterErrors.stub(:application_root).and_return("/abc/xyz")
-        frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index")
-        
-        frame.application_path.should == "app/controllers/crap_controller.rb"
-      end
-    end
-    
-    context "#gem_path" do
-      it "chops of the gem path and stick (gem) there" do
-        Gem.stub(:path).and_return(["/abc/xyz"])
-        frame = StackFrame.new("/abc/xyz/gems/whatever-1.2.3/lib/whatever.rb", 123, "foo")
-        
-        frame.gem_path.should == "whatever (1.2.3) lib/whatever.rb"
-      end
-      
-      it "prioritizes gem path over application path" do
-        BetterErrors.stub(:application_root).and_return("/abc/xyz")
-        Gem.stub(:path).and_return(["/abc/xyz/vendor"])
-        frame = StackFrame.new("/abc/xyz/vendor/gems/whatever-1.2.3/lib/whatever.rb", 123, "foo")
-        
-        frame.gem_path.should == "whatever (1.2.3) lib/whatever.rb"
-      end
-    end
-    
-    context "#pretty_path" do
-      it "returns #application_path for application paths" do
-        BetterErrors.stub(:application_root).and_return("/abc/xyz")
-        frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index")
-        frame.pretty_path.should == frame.application_path
-      end
-      
-      it "returns #gem_path for gem paths" do
-        Gem.stub(:path).and_return(["/abc/xyz"])
-        frame = StackFrame.new("/abc/xyz/gems/whatever-1.2.3/lib/whatever.rb", 123, "foo")
-        
-        frame.pretty_path.should == frame.gem_path
-      end
-    end
-
-    it "special cases SyntaxErrors" do
-      begin
-        eval(%{ raise SyntaxError, "you wrote bad ruby!" }, nil, "my_file.rb", 123)
-      rescue SyntaxError => syntax_error
-      end
-      frames = StackFrame.from_exception(syntax_error)
-      frames.first.filename.should == "my_file.rb"
-      frames.first.line.should == 123
-    end
-    
-    it "doesn't blow up if no method name is given" do
-      error = StandardError.allocate
-      
-      error.stub(:backtrace).and_return(["foo.rb:123"])
-      frames = StackFrame.from_exception(error)
-      frames.first.filename.should == "foo.rb"
-      frames.first.line.should == 123
-      
-      error.stub(:backtrace).and_return(["foo.rb:123: this is an error message"])
-      frames = StackFrame.from_exception(error)
-      frames.first.filename.should == "foo.rb"
-      frames.first.line.should == 123
-    end
-    
-    it "ignores a backtrace line if its format doesn't make any sense at all" do
-      error = StandardError.allocate
-      error.stub(:backtrace).and_return(["foo.rb:123:in `foo'", "C:in `find'", "bar.rb:123:in `bar'"])
-      frames = StackFrame.from_exception(error)
-      frames.count.should == 2
-    end
-    
-    it "doesn't blow up if a filename contains a colon" do
-      error = StandardError.allocate
-      error.stub(:backtrace).and_return(["crap:filename.rb:123"])
-      frames = StackFrame.from_exception(error)
-      frames.first.filename.should == "crap:filename.rb"
-    end
-
-    it "doesn't blow up with a BasicObject as frame binding" do
-      obj = BasicObject.new
-      def obj.my_binding
-        ::Kernel.binding
-      end
-      frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index", obj.my_binding)
-      if RUBY_VERSION >= "2.0.0"
-        frame.class_name.should == 'BasicObject'
-      else
-        frame.class_name.should be_nil
-      end
-    end
-
-    it "sets method names properly" do
-      obj = "string"
-      def obj.my_method
-        begin
-          raise "foo"
-        rescue => err
-          err
-        end
-      end
-
-      frame = StackFrame.from_exception(obj.my_method).first
-      if RUBY_VERSION >= "2.0.0"
-        frame.method_name.should == "#my_method"
-        frame.class_name.should == "String"
-      else
-        frame.method_name.should == "my_method"
-        frame.class_name.should be_nil
-      end
-    end
-
-    if RUBY_ENGINE == "java"
-      it "doesn't blow up on a native Java exception" do
-        expect { StackFrame.from_exception(java.lang.Exception.new) }.to_not raise_error
-      end
-    end
-  end
-end

data/spec/better_errors/support/my_source.rb

@@ -1,20 +0,0 @@
-one
-two
-three
-four
-five
-six
-seven
-eight
-nine
-ten
-eleven
-twelve
-thirteen
-fourteen
-fifteen
-sixteen
-seventeen
-eighteen
-nineteen
-twenty

data/spec/better_errors_spec.rb

@@ -1,73 +0,0 @@
-require "spec_helper"
-
-describe BetterErrors do
-  context ".editor" do
-    it "defaults to textmate" do
-      subject.editor["foo.rb", 123].should == "txmt://open?url=file://foo.rb&line=123"
-    end
-
-    it "url escapes the filename" do
-      subject.editor["&.rb", 0].should == "txmt://open?url=file://%26.rb&line=0"
-    end
-
-    [:emacs, :emacsclient].each do |editor|
-      it "uses emacs:// scheme when set to #{editor.inspect}" do
-        subject.editor = editor
-        subject.editor[].should start_with "emacs://"
-      end
-    end
-
-    [:macvim, :mvim].each do |editor|
-      it "uses mvim:// scheme when set to #{editor.inspect}" do
-        subject.editor = editor
-        subject.editor[].should start_with "mvim://"
-      end
-    end
-
-    [:sublime, :subl, :st].each do |editor|
-      it "uses subl:// scheme when set to #{editor.inspect}" do
-        subject.editor = editor
-        subject.editor[].should start_with "subl://"
-      end
-    end
-
-    [:textmate, :txmt, :tm].each do |editor|
-      it "uses txmt:// scheme when set to #{editor.inspect}" do
-        subject.editor = editor
-        subject.editor[].should start_with "txmt://"
-      end
-    end
-
-    ["emacsclient", "/usr/local/bin/emacsclient"].each do |editor|
-      it "uses emacs:// scheme when EDITOR=#{editor}" do
-        ENV["EDITOR"] = editor
-        subject.editor = subject.default_editor
-        subject.editor[].should start_with "emacs://"
-      end
-    end
-
-    ["mvim -f", "/usr/local/bin/mvim -f"].each do |editor|
-      it "uses mvim:// scheme when EDITOR=#{editor}" do
-        ENV["EDITOR"] = editor
-        subject.editor = subject.default_editor
-        subject.editor[].should start_with "mvim://"
-      end
-    end
-
-    ["subl -w", "/Applications/Sublime Text 2.app/Contents/SharedSupport/bin/subl"].each do |editor|
-      it "uses mvim:// scheme when EDITOR=#{editor}" do
-        ENV["EDITOR"] = editor
-        subject.editor = subject.default_editor
-        subject.editor[].should start_with "subl://"
-      end
-    end
-
-    ["mate -w", "/usr/bin/mate -w"].each do |editor|
-      it "uses txmt:// scheme when EDITOR=#{editor}" do
-        ENV["EDITOR"] = editor
-        subject.editor = subject.default_editor
-        subject.editor[].should start_with "txmt://"
-      end
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,7 +0,0 @@
-require "simplecov"
-SimpleCov.start
-
-$: << File.expand_path("../../lib", __FILE__)
-ENV["EDITOR"] = nil
-require "better_errors"
-require "ostruct"