better_errors 1.0.0.rc1 → 1.0.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NjYyNmFjYTQ1MjJmN2M4ZTIyODQ0MGY2YzNjOTE5ODU5ODU2NzQyZQ==
-  data.tar.gz: !binary |-
-    OWRjYzA4NTI5YzI1YWViZDAyMjlhN2RmOWQ4NDA3MWYwMTlkMzUyNA==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    MTBhZDMwMTI5MzFiZTYwNzNlNzk2YWI2NTE2OTYzODc2ODZjZjFkYjQ4MGIw
-    MGI5ZGM5NzVkMzQzZmUzYzBjOTJlYmYzMWZjMDZlMjZjYmQzNjQ2NDM5OTY5
-    NTdlNDMwMjFhNTlhY2VhYWU1YzVlMTA2ZGZmYmI0OGYwYzYxNmQ=
-  data.tar.gz: !binary |-
-    ZTZmNjc4ZTRmZjlhZTZhOTJhMjc1MDM0NDAwMDMyYjdkNzY4MDdkOTNlN2Nk
-    YjBhMjhlNjE3YTZhZmFkODU1OTk1MGFkMjk4MWRhMzljNzc4ZTczMzdhMTBk
-    MTRjNWJhMGU4NDllYWFiMDFiOWNiMmNhZTQ4OGU2MzE3MGQyMzQ=
+SHA1:
+  metadata.gz: b488ee0f5ae9ab59d99cdf4600dcd8068142f7af
+  data.tar.gz: 16eb29a92fc99d51ac5bec8bfda47551ee70eb5e
+SHA512:
+  metadata.gz: 011da282c504e61de751a0ac51084fe71bca604ade85fc6fd432d7fd2cf87d2f13396766d78b1f80d54481b605bc490acf7d5a44d358d2721ce87b3058617078
+  data.tar.gz: ed553954f0e7471ec4ad323d96e5db470e0c94db4545ecaf97f84c828ac2d4c8a257cfe8f54aa48e1f0f1b8ee3394e33c6649a046572c21f35efb4f6912d14e3

data/.travis.yml

@@ -1,4 +1,6 @@
 language: ruby
 rvm:
   - 2.0.0
+  - 1.9.3
+  - 1.9.2
   - jruby-1.7.4

data/Gemfile

@@ -5,7 +5,7 @@ gemspec
 gem "rake"
 gem "rspec", "2.14.1"
 gem "binding_of_caller", platforms: :ruby
-gem "pry"
+gem "pry", "0.9.12"
 gem "simplecov"
 gem "yard"
 gem "kramdown"

data/README.md

@@ -21,14 +21,6 @@ group :development do
 end
 ```
 
-If you would like to use Better Errors' **advanced features** (REPL, local/instance variable inspection, pretty stack frame names), you need to add the [`binding_of_caller`](https://github.com/banister/binding_of_caller) gem by [@banisterfiend](http://twitter.com/banisterfiend) to your Gemfile:
-
-```ruby
-gem "binding_of_caller"
-```
-
-This is an optional dependency however, and Better Errors will work without it.
-
 ## Security
 
 **NOTE:** It is *critical* you put better\_errors in the **development** section. **Do NOT run better_errors in production, or on Internet facing hosts.**

data/better_errors.gemspec

@@ -16,6 +16,7 @@ Gem::Specification.new do |s|
   s.files         = `git ls-files`.split($/)
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ["lib"]
+  s.extensions    = ["ext/mkrf_conf.rb"]
 
   s.required_ruby_version = ">= 1.9.2"
   

data/ext/mkrf_conf.rb

@@ -0,0 +1,11 @@
+require 'rubygems/dependency_installer'
+
+gem = Gem::DependencyInstaller.new
+
+if ["rbx", "ruby"].include?(RUBY_ENGINE)
+  # This MUST match the version specified in lib/better_errors.rb, or else
+  # weird shit will happen.
+  if Gem::Dependency.new("binding_of_caller", "0.7.2").matching_specs.empty?
+    gem.install "binding_of_caller", "0.7.2"
+  end
+end

data/lib/better_errors.rb

@@ -134,10 +134,11 @@ module BetterErrors
   BetterErrors.editor = default_editor
 end
 
-begin
+if Gem::Dependency.new("binding_of_caller", "0.7.2").matching_specs.any?
+  gem "binding_of_caller", "0.7.2"
   require "binding_of_caller"
   BetterErrors.binding_of_caller_available = true
-rescue LoadError => e
+else
   BetterErrors.binding_of_caller_available = false
 end
 

data/lib/better_errors/repl/pry.rb

@@ -39,7 +39,7 @@ module BetterErrors
         @input = Input.new
         @output = Output.new
         @pry = ::Pry.new input: @input, output: @output
-        @pry.hooks.clear_all
+        @pry.hooks.clear_all if defined?(@pry.hooks.clear_all)
         @fiber.resume
       end
     

data/lib/better_errors/templates/main.erb

@@ -252,6 +252,12 @@
         text-shadow: 0 0 4px rgba(0, 0, 0, 0.4), 0 1px 0 rgba(0, 0, 0, 0.4);
     }
 
+    nav.tabs a.disabled {
+        text-decoration: line-through;
+        text-shadow: none;
+        cursor: default;
+    }
+
     /* ---------------------------------------------------------------------
      * Sidebar
      * --------------------------------------------------------------------- */
@@ -953,24 +959,40 @@
       document.querySelector(".frames li")
     ).onclick();
 
+    // This is the second query performed for frames; maybe the 'allFrames' list
+    // currently used and this list can be better used to avoid the repetition:
+    var applicationFramesCount = document.querySelectorAll(
+        "ul.frames li[data-context=application]"
+    ).length;
+
+    var applicationFramesButtonIsInstalled = false;
     var applicationFramesButton = document.getElementById("application_frames");
     var allFramesButton = document.getElementById("all_frames");
     
-    applicationFramesButton.onclick = function() {
-        allFramesButton.className = "";
-        applicationFramesButton.className = "selected";
-        for(var i = 0; i < allFrames.length; i++) {
-            if(allFrames[i].attributes["data-context"].value == "application") {
-                allFrames[i].style.display = "block";
-            } else {
-                allFrames[i].style.display = "none";
+    // The application frames button only needs to be bound if
+    // there are actually any application frames to look at.
+    var installApplicationFramesButton = function() {
+        applicationFramesButton.onclick = function() {
+            allFramesButton.className = "";
+            applicationFramesButton.className = "selected";
+            for(var i = 0; i < allFrames.length; i++) {
+                if(allFrames[i].attributes["data-context"].value == "application") {
+                    allFrames[i].style.display = "block";
+                } else {
+                    allFrames[i].style.display = "none";
+                }
             }
-        }
-        return false;
-    };
+            return false;
+        };
+        
+        applicationFramesButtonIsInstalled = true;
+    }
     
     allFramesButton.onclick = function() {
-        applicationFramesButton.className = "";
+        if(applicationFramesButtonIsInstalled) {
+            applicationFramesButton.className = "";
+        }
+
         allFramesButton.className = "selected";
         for(var i = 0; i < allFrames.length; i++) {
             allFrames[i].style.display = "block";
@@ -978,7 +1000,16 @@
         return false;
     };
     
-    applicationFramesButton.onclick();
+    // If there are no application frames, select the 'All Frames'
+    // tab by default.
+    if(applicationFramesCount > 0) {
+        installApplicationFramesButton();
+        applicationFramesButton.onclick();
+    } else {
+        applicationFramesButton.className = "disabled";
+        applicationFramesButton.title = "No application frames available";
+        allFramesButton.onclick();
+    }
 })();
 </script>
 </html>

data/lib/better_errors/version.rb

@@ -1,3 +1,3 @@
 module BetterErrors
-  VERSION = "1.0.0.rc1"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,41 +1,41 @@
 --- !ruby/object:Gem::Specification
 name: better_errors
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc1
+  version: 1.0.0
 platform: ruby
 authors:
 - Charlie Somerville
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-29 00:00:00.000000000 Z
+date: 2013-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.6.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.6.6
 - !ruby/object:Gem::Dependency
   name: coderay
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.0
 description: Provides a better error page for Rails and other Rack apps. Includes
@@ -44,7 +44,8 @@ description: Provides a better error page for Rails and other Rack apps. Include
 email:
 - charlie@charliesomerville.com
 executables: []
-extensions: []
+extensions:
+- ext/mkrf_conf.rb
 extra_rdoc_files: []
 files:
 - .gitignore
@@ -55,6 +56,7 @@ files:
 - README.md
 - Rakefile
 - better_errors.gemspec
+- ext/mkrf_conf.rb
 - lib/better_errors.rb
 - lib/better_errors/code_formatter.rb
 - lib/better_errors/code_formatter/html.rb
@@ -91,17 +93,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>'
+  - - '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Better error page for Rails and other Rack apps