better_errors-creditkudos 2.1.1

data/spec/better_errors/raised_exception_spec.rb

@@ -0,0 +1,72 @@
+require "spec_helper"
+
+module BetterErrors
+  describe RaisedException do
+    let(:exception) { RuntimeError.new("whoops") }
+    subject { RaisedException.new(exception) }
+
+    its(:exception) { should == exception }
+    its(:message)   { should == "whoops" }
+    its(:type)      { should == RuntimeError }
+
+    context "when the exception wraps another exception" do
+      let(:original_exception) { RuntimeError.new("something went wrong!") }
+      let(:exception) { double(:original_exception => original_exception) }
+
+      its(:exception) { should == original_exception }
+      its(:message)   { should == "something went wrong!" }
+    end
+
+    context "when the exception is a syntax error" do
+      let(:exception) { SyntaxError.new("foo.rb:123: you made a typo!") }
+
+      its(:message) { should == "you made a typo!" }
+      its(:type)    { should == SyntaxError }
+
+      it "has the right filename and line number in the backtrace" do
+        subject.backtrace.first.filename.should == "foo.rb"
+        subject.backtrace.first.line.should == 123
+      end
+    end
+
+    context "when the exception is a HAML syntax error" do
+      before do
+        stub_const("Haml::SyntaxError", Class.new(SyntaxError))
+      end
+
+      let(:exception) {
+        Haml::SyntaxError.new("you made a typo!").tap do |ex|
+          ex.set_backtrace(["foo.rb:123", "haml/internals/blah.rb:123456"])
+        end
+      }
+
+      its(:message) { should == "you made a typo!" }
+      its(:type)    { should == Haml::SyntaxError }
+
+      it "has the right filename and line number in the backtrace" do
+        subject.backtrace.first.filename.should == "foo.rb"
+        subject.backtrace.first.line.should == 123
+      end
+    end
+
+    context "when the exception is a Coffeelint syntax error" do
+      before do
+        stub_const("Sprockets::Coffeelint::Error", Class.new(SyntaxError))
+      end
+
+      let(:exception) {
+        Sprockets::Coffeelint::Error.new("[stdin]:11:88: error: unexpected=").tap do |ex|
+          ex.set_backtrace(["app/assets/javascripts/files/index.coffee:11", "sprockets/coffeelint.rb:3"])
+        end
+      }
+
+      its(:message) { should == "[stdin]:11:88: error: unexpected=" }
+      its(:type)    { should == Sprockets::Coffeelint::Error }
+
+      it "has the right filename and line number in the backtrace" do
+        subject.backtrace.first.filename.should == "app/assets/javascripts/files/index.coffee"
+        subject.backtrace.first.line.should == 11
+      end
+    end
+  end
+end

data/spec/better_errors/repl/basic_spec.rb

@@ -0,0 +1,18 @@
+require "spec_helper"
+require "better_errors/repl/basic"
+require "better_errors/repl/shared_examples"
+
+module BetterErrors
+  module REPL
+    describe Basic do
+      let(:fresh_binding) {
+        local_a = 123
+        binding
+      }
+
+      let(:repl) { Basic.new fresh_binding }
+
+      it_behaves_like "a REPL provider"
+    end
+  end
+end

data/spec/better_errors/repl/pry_spec.rb

@@ -0,0 +1,40 @@
+require "spec_helper"
+require "pry"
+require "better_errors/repl/pry"
+require "better_errors/repl/shared_examples"
+
+module BetterErrors
+  module REPL
+    describe Pry do
+      let(:fresh_binding) {
+        local_a = 123
+        binding
+      }
+
+      let(:repl) { Pry.new fresh_binding }
+
+      it "does line continuation" do
+        output, prompt, filled = repl.send_input ""
+        output.should == "=> nil\n"
+        prompt.should == ">>"
+        filled.should == ""
+
+        output, prompt, filled = repl.send_input "def f(x)"
+        output.should == ""
+        prompt.should == ".."
+        filled.should == "  "
+
+        output, prompt, filled = repl.send_input "end"
+        if RUBY_VERSION >= "2.1.0"
+          output.should == "=> :f\n"
+        else
+          output.should == "=> nil\n"
+        end
+        prompt.should == ">>"
+        filled.should == ""
+      end
+
+      it_behaves_like "a REPL provider"
+    end
+  end
+end

data/spec/better_errors/repl/shared_examples.rb

@@ -0,0 +1,18 @@
+shared_examples_for "a REPL provider" do
+  it "evaluates ruby code in a given context" do
+    repl.send_input("local_a = 456")
+    fresh_binding.eval("local_a").should == 456
+  end
+
+  it "returns a tuple of output and the new prompt" do
+    output, prompt = repl.send_input("1 + 2")
+    output.should == "=> 3\n"
+    prompt.should == ">>"
+  end
+
+  it "doesn't barf if the code throws an exception" do
+    output, prompt = repl.send_input("raise Exception")
+    output.should include "Exception: Exception"
+    prompt.should == ">>"
+  end
+end

data/spec/better_errors/stack_frame_spec.rb

@@ -0,0 +1,157 @@
+require "spec_helper"
+
+module BetterErrors
+  describe StackFrame do
+    context "#application?" do
+      it "is true for application filenames" do
+        BetterErrors.stub(:application_root).and_return("/abc/xyz")
+        frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index")
+
+        frame.should be_application
+      end
+
+      it "is false for everything else" do
+        BetterErrors.stub(:application_root).and_return("/abc/xyz")
+        frame = StackFrame.new("/abc/nope", 123, "foo")
+
+        frame.should_not be_application
+      end
+
+      it "doesn't care if no application_root is set" do
+        frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index")
+
+        frame.should_not be_application
+      end
+    end
+
+    context "#gem?" do
+      it "is true for gem filenames" do
+        Gem.stub(:path).and_return(["/abc/xyz"])
+        frame = StackFrame.new("/abc/xyz/gems/whatever-1.2.3/lib/whatever.rb", 123, "foo")
+
+        frame.should be_gem
+      end
+
+      it "is false for everything else" do
+        Gem.stub(:path).and_return(["/abc/xyz"])
+        frame = StackFrame.new("/abc/nope", 123, "foo")
+
+        frame.should_not be_gem
+      end
+    end
+
+    context "#application_path" do
+      it "chops off the application root" do
+        BetterErrors.stub(:application_root).and_return("/abc/xyz")
+        frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index")
+
+        frame.application_path.should == "app/controllers/crap_controller.rb"
+      end
+    end
+
+    context "#gem_path" do
+      it "chops of the gem path and stick (gem) there" do
+        Gem.stub(:path).and_return(["/abc/xyz"])
+        frame = StackFrame.new("/abc/xyz/gems/whatever-1.2.3/lib/whatever.rb", 123, "foo")
+
+        frame.gem_path.should == "whatever (1.2.3) lib/whatever.rb"
+      end
+
+      it "prioritizes gem path over application path" do
+        BetterErrors.stub(:application_root).and_return("/abc/xyz")
+        Gem.stub(:path).and_return(["/abc/xyz/vendor"])
+        frame = StackFrame.new("/abc/xyz/vendor/gems/whatever-1.2.3/lib/whatever.rb", 123, "foo")
+
+        frame.gem_path.should == "whatever (1.2.3) lib/whatever.rb"
+      end
+    end
+
+    context "#pretty_path" do
+      it "returns #application_path for application paths" do
+        BetterErrors.stub(:application_root).and_return("/abc/xyz")
+        frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index")
+        frame.pretty_path.should == frame.application_path
+      end
+
+      it "returns #gem_path for gem paths" do
+        Gem.stub(:path).and_return(["/abc/xyz"])
+        frame = StackFrame.new("/abc/xyz/gems/whatever-1.2.3/lib/whatever.rb", 123, "foo")
+
+        frame.pretty_path.should == frame.gem_path
+      end
+    end
+
+    it "special cases SyntaxErrors" do
+      begin
+        eval(%{ raise SyntaxError, "you wrote bad ruby!" }, nil, "my_file.rb", 123)
+      rescue SyntaxError => syntax_error
+      end
+      frames = StackFrame.from_exception(syntax_error)
+      frames.first.filename.should == "my_file.rb"
+      frames.first.line.should == 123
+    end
+
+    it "doesn't blow up if no method name is given" do
+      error = StandardError.allocate
+
+      error.stub(:backtrace).and_return(["foo.rb:123"])
+      frames = StackFrame.from_exception(error)
+      frames.first.filename.should == "foo.rb"
+      frames.first.line.should == 123
+
+      error.stub(:backtrace).and_return(["foo.rb:123: this is an error message"])
+      frames = StackFrame.from_exception(error)
+      frames.first.filename.should == "foo.rb"
+      frames.first.line.should == 123
+    end
+
+    it "ignores a backtrace line if its format doesn't make any sense at all" do
+      error = StandardError.allocate
+      error.stub(:backtrace).and_return(["foo.rb:123:in `foo'", "C:in `find'", "bar.rb:123:in `bar'"])
+      frames = StackFrame.from_exception(error)
+      frames.count.should == 2
+    end
+
+    it "doesn't blow up if a filename contains a colon" do
+      error = StandardError.allocate
+      error.stub(:backtrace).and_return(["crap:filename.rb:123"])
+      frames = StackFrame.from_exception(error)
+      frames.first.filename.should == "crap:filename.rb"
+    end
+
+    it "doesn't blow up with a BasicObject as frame binding" do
+      obj = BasicObject.new
+      def obj.my_binding
+        ::Kernel.binding
+      end
+      frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index", obj.my_binding)
+      frame.class_name.should == 'BasicObject'
+    end
+
+    it "sets method names properly" do
+      obj = "string"
+      def obj.my_method
+        begin
+          raise "foo"
+        rescue => err
+          err
+        end
+      end
+
+      frame = StackFrame.from_exception(obj.my_method).first
+      if BetterErrors.binding_of_caller_available?
+        frame.method_name.should == "#my_method"
+        frame.class_name.should == "String"
+      else
+        frame.method_name.should == "my_method"
+        frame.class_name.should == nil
+      end
+    end
+
+    if RUBY_ENGINE == "java"
+      it "doesn't blow up on a native Java exception" do
+        expect { StackFrame.from_exception(java.lang.Exception.new) }.to_not raise_error
+      end
+    end
+  end
+end

data/spec/better_errors/support/my_source.rb

@@ -0,0 +1,20 @@
+one
+two
+three
+four
+five
+six
+seven
+eight
+nine
+ten
+eleven
+twelve
+thirteen
+fourteen
+fifteen
+sixteen
+seventeen
+eighteen
+nineteen
+twenty

data/spec/better_errors_spec.rb

@@ -0,0 +1,73 @@
+require "spec_helper"
+
+describe BetterErrors do
+  context ".editor" do
+    it "defaults to textmate" do
+      subject.editor["foo.rb", 123].should == "txmt://open?url=file://foo.rb&line=123"
+    end
+
+    it "url escapes the filename" do
+      subject.editor["&.rb", 0].should == "txmt://open?url=file://%26.rb&line=0"
+    end
+
+    [:emacs, :emacsclient].each do |editor|
+      it "uses emacs:// scheme when set to #{editor.inspect}" do
+        subject.editor = editor
+        subject.editor[].should start_with "emacs://"
+      end
+    end
+
+    [:macvim, :mvim].each do |editor|
+      it "uses mvim:// scheme when set to #{editor.inspect}" do
+        subject.editor = editor
+        subject.editor[].should start_with "mvim://"
+      end
+    end
+
+    [:sublime, :subl, :st].each do |editor|
+      it "uses subl:// scheme when set to #{editor.inspect}" do
+        subject.editor = editor
+        subject.editor[].should start_with "subl://"
+      end
+    end
+
+    [:textmate, :txmt, :tm].each do |editor|
+      it "uses txmt:// scheme when set to #{editor.inspect}" do
+        subject.editor = editor
+        subject.editor[].should start_with "txmt://"
+      end
+    end
+
+    ["emacsclient", "/usr/local/bin/emacsclient"].each do |editor|
+      it "uses emacs:// scheme when EDITOR=#{editor}" do
+        ENV["EDITOR"] = editor
+        subject.editor = subject.default_editor
+        subject.editor[].should start_with "emacs://"
+      end
+    end
+
+    ["mvim -f", "/usr/local/bin/mvim -f"].each do |editor|
+      it "uses mvim:// scheme when EDITOR=#{editor}" do
+        ENV["EDITOR"] = editor
+        subject.editor = subject.default_editor
+        subject.editor[].should start_with "mvim://"
+      end
+    end
+
+    ["subl -w", "/Applications/Sublime Text 2.app/Contents/SharedSupport/bin/subl"].each do |editor|
+      it "uses subl:// scheme when EDITOR=#{editor}" do
+        ENV["EDITOR"] = editor
+        subject.editor = subject.default_editor
+        subject.editor[].should start_with "subl://"
+      end
+    end
+
+    ["mate -w", "/usr/bin/mate -w"].each do |editor|
+      it "uses txmt:// scheme when EDITOR=#{editor}" do
+        ENV["EDITOR"] = editor
+        subject.editor = subject.default_editor
+        subject.editor[].should start_with "txmt://"
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,5 @@
+$: << File.expand_path("../../lib", __FILE__)
+
+ENV["EDITOR"] = nil
+
+require "better_errors"

data/spec/without_binding_of_caller.rb

@@ -0,0 +1,9 @@
+module Kernel
+  alias_method :require_with_binding_of_caller, :require
+
+  def require(feature)
+    raise LoadError if feature == "binding_of_caller"
+
+    require_with_binding_of_caller(feature)
+  end
+end

metadata

@@ -0,0 +1,136 @@
+--- !ruby/object:Gem::Specification
+name: better_errors-creditkudos
+version: !ruby/object:Gem::Version
+  version: 2.1.1
+platform: ruby
+authors:
+- Charlie Somerville
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2017-01-20 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: erubis
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.6.6
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.6.6
+- !ruby/object:Gem::Dependency
+  name: coderay
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: rack
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.9.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.9.0
+description: Temporary fork of better_errors with some performance improvements.
+email:
+- charlie@charliesomerville.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".gitignore"
+- ".travis.yml"
+- ".yardopts"
+- CHANGELOG.md
+- Gemfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- better_errors-creditkudos.gemspec
+- lib/better_errors.rb
+- lib/better_errors/code_formatter.rb
+- lib/better_errors/code_formatter/html.rb
+- lib/better_errors/code_formatter/text.rb
+- lib/better_errors/error_page.rb
+- lib/better_errors/exception_extension.rb
+- lib/better_errors/middleware.rb
+- lib/better_errors/rails.rb
+- lib/better_errors/raised_exception.rb
+- lib/better_errors/repl.rb
+- lib/better_errors/repl/basic.rb
+- lib/better_errors/repl/pry.rb
+- lib/better_errors/stack_frame.rb
+- lib/better_errors/templates/main.erb
+- lib/better_errors/templates/text.erb
+- lib/better_errors/templates/variable_info.erb
+- lib/better_errors/version.rb
+- spec/better_errors/code_formatter_spec.rb
+- spec/better_errors/error_page_spec.rb
+- spec/better_errors/middleware_spec.rb
+- spec/better_errors/raised_exception_spec.rb
+- spec/better_errors/repl/basic_spec.rb
+- spec/better_errors/repl/pry_spec.rb
+- spec/better_errors/repl/shared_examples.rb
+- spec/better_errors/stack_frame_spec.rb
+- spec/better_errors/support/my_source.rb
+- spec/better_errors_spec.rb
+- spec/spec_helper.rb
+- spec/without_binding_of_caller.rb
+homepage: https://github.com/creditkudos/better_errors
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: 2.0.0
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.5.2
+signing_key: 
+specification_version: 4
+summary: Temporary fork of better_errors with some performance improvements.
+test_files:
+- spec/better_errors/code_formatter_spec.rb
+- spec/better_errors/error_page_spec.rb
+- spec/better_errors/middleware_spec.rb
+- spec/better_errors/raised_exception_spec.rb
+- spec/better_errors/repl/basic_spec.rb
+- spec/better_errors/repl/pry_spec.rb
+- spec/better_errors/repl/shared_examples.rb
+- spec/better_errors/stack_frame_spec.rb
+- spec/better_errors/support/my_source.rb
+- spec/better_errors_spec.rb
+- spec/spec_helper.rb
+- spec/without_binding_of_caller.rb