better-faraday 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 505a74e2ae063f298dd6b7885d06f6e8d4851e1b566d4f5560be0b1d1e7890d5
-  data.tar.gz: abe6ef33c08df902f55f8d6235ff587707e84e497ec65a2059b2f4bb06c20097
+  metadata.gz: 63e3069002b8c492c1974502babbe1ab1b0815a499fcb1fb6384860953957051
+  data.tar.gz: 79af46da23df8de021919a3e1fab6990b927524634cb705b3e88a06eeb115170
 SHA512:
-  metadata.gz: 692fd039d299eeb2067441d8dd816634924b826314ddcc3caaf0cb3d0231b82b90e47c9077b337fcaaa721231ece2e865432f9b4f1dbb80c97ebb81940f02338
-  data.tar.gz: ca8287fcd46f4e32a2ea5d9ec217b05d0f0fea61167895a90d7c61d0643dc7704b07ced2894a0e89230a08ad29b957f23cf4428840a164e5c3ce36d98e3e5da0
+  metadata.gz: ef42fd021a83dc99654aef97736ac6364942774748865be68ca3b379fcb097213043274f0ab6ab16b0912918b5b9b68438ab69fc0326b7404b7d2d112c13780d
+  data.tar.gz: 1dba086f05f40addb2577ea44905cb7e7114abb6b2176b13884324df8dc4c3c8cee5a7d0d334cad6da6c1467cd6a58a91532b109071532df1edba4ed3c5cbce8

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    better-faraday (3.1.0)
+    better-faraday (3.1.1)
       faraday (>= 1.0, < 3.0)
 
 GEM
@@ -86,7 +86,7 @@ DEPENDENCIES
 
 CHECKSUMS
   addressable (2.9.0) sha256=7fdf6ac3660f7f4e867a0838be3f6cf722ace541dd97767fa42bc6cfa980c7af
-  better-faraday (3.1.0)
+  better-faraday (3.1.1)
   bigdecimal (4.1.3) sha256=61ebe1e5e559bdc3cc6f2c0ee7f427321fc838f59611c294356eb04d6e21cf66
   bundler (4.0.22) sha256=d8d5ec84c8555e0af71db63ed7aee4d1a8fb839ec46d84212d61979242a5d75a
   byebug (13.0.0) sha256=d2263efe751941ca520fa29744b71972d39cbc41839496706f5d9b22e92ae05d

data/better-faraday.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name                  = "better-faraday"
-  s.version               = "3.1.0"
+  s.version               = "3.1.1"
   s.author                = "Yaroslav Konoplov"
   s.email                 = "eahome00@gmail.com"
   s.summary               = "Extends Faraday with useful features"

data/lib/better-faraday.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require_relative "better_faraday"

data/spec/binary_body_spec.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require "securerandom"
+
+RSpec.describe "BetterFaraday Binary Data Handling" do
+  # Generate 3000 bytes of random binary data (invalid UTF-8)
+  let(:binary_payload) { SecureRandom.random_bytes(3000) }
+  let(:expected_omission) { "... (truncated)" }
+
+  let(:env) do
+    Faraday::Env.from(
+      method: :post,
+      url: URI("https://api.example.com/upload"),
+      status: 200,
+      reason_phrase: "OK",
+      request_headers: { "Content-Type" => "application/octet-stream" },
+      request_body: binary_payload,
+      response_headers: { "Content-Type" => "image/png" },
+      body: binary_payload
+    )
+  end
+
+  let(:response) { Faraday::Response.new(env) }
+
+  before do
+    response.env.instance_variable_set(:@bf_request_headers, { "Content-Type" => "application/octet-stream" })
+    response.env.instance_variable_set(:@bf_request_body, binary_payload)
+  end
+
+  it "safely inspects binary data without encoding crashes and truncates it" do
+    inspection = nil
+
+    # Ensure no Encoding::UndefinedConversionError or similar exceptions are raised
+    expect { inspection = response.inspect }.not_to raise_error
+
+    # Verify that the byte count accurately reflects the binary size
+    expect(inspection).to include("-- Request Body (3000 bytes) --")
+    expect(inspection).to include("-- Response Body (3000 bytes) --")
+
+    # Verify that the output is safely truncated to avoid console memory bloat
+    expect(inspection).to include(expected_omission)
+
+    # The raw binary string should not be fully present in the output
+    expect(inspection).not_to include(binary_payload)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: better-faraday
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Yaroslav Konoplov
@@ -142,10 +142,12 @@ files:
 - README.md
 - Rakefile
 - better-faraday.gemspec
+- lib/better-faraday.rb
 - lib/better_faraday.rb
 - spec/adapters_spec.rb
 - spec/array_masking_spec.rb
 - spec/assert_status_spec.rb
+- spec/binary_body_spec.rb
 - spec/custom_sensitive_signs_spec.rb
 - spec/http_error_spec.rb
 - spec/inspect_truncation_spec.rb
@@ -185,6 +187,7 @@ test_files:
 - spec/adapters_spec.rb
 - spec/array_masking_spec.rb
 - spec/assert_status_spec.rb
+- spec/binary_body_spec.rb
 - spec/custom_sensitive_signs_spec.rb
 - spec/http_error_spec.rb
 - spec/inspect_truncation_spec.rb