betsy 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 343e99ec22018a9e3a9213d0347a41c7e2467ae065663d0949f911569e9e18ee
-  data.tar.gz: d30007fc1dd8c093db8e3281b438e21431cdce28ec2da31298d331c69c3811af
+  metadata.gz: be84657637faf15358471454761e8f48181ce8907741f64120ce17837d777119
+  data.tar.gz: f7b0948911a4271e09423591f7bd55e6be04612c5502c32bc2cb9d2713bd279f
 SHA512:
-  metadata.gz: 63eefeee0bba2edab434f1b702ab82d1fd694611c73d72c21ab8235cf24504a9649fc82297ce81daafde98cbfc130a6ce518d907d37add81f83475e6cff7e708
-  data.tar.gz: 0f27a68eb7ed1682c10c2440f5e2f5be421f3491e1fd5137ba44918884a7cc4a0e21bf41f8ea96876803ee02cf435f835e32ec438174e57ce1bff5af7ac9c603
+  metadata.gz: e34859ed8deb1e858c2284c2a0691d4a5ddaa09e6efa2b1a867f58956cb73456161285356603500ecd287d15455667e82422f77ec01c2aa2138296a61327510e
+  data.tar.gz: 75120021566c48ece0adf0ca7abf44b61efb9903d77a950fcac75383eb9ad2a985a8a496a2f50665f18fdecbefc9611ce3efb81a497bf8114015ac04438863cc

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 ## [Unreleased]
 
+## [0.3.0] - 2026-05-14
+
+### Breaking changes
+
+- The account model (default `EtsyAccount`) must now implement a `token_expired?` instance method. If you ran the install generator in v0.2.x, you need to add this method manually. See the [migration guide](#migrating-from-v02x-to-v03x) in the README.
+
+### Changed
+
+- Token expiration checking now delegates to `token_expired?` on the account model instead of using inline logic in the gem
+- Replaced Faraday with Ruby's stdlib `Net::HTTP`, removing the only external runtime dependency
+- Declared `activesupport` as an explicit runtime dependency (was previously undeclared)
+
+### Fixed
+
+- Fixed `TypeError` crash in `check_token_expiration` when `expires_in` or `last_token_refresh` is nil
+- Failed token refresh responses no longer save nil credentials back to the account
+
 ## [0.2.0] - 2021-05-04
 
 - Initial release

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    betsy (0.2.0)
-      faraday (>= 0.10)
+    betsy (0.3.0)
+      activesupport (>= 5.0)
 
 GEM
   remote: https://rubygems.org/
@@ -83,8 +83,6 @@ GEM
     diff-lcs (1.4.4)
     docile (1.4.0)
     erubi (1.10.0)
-    faraday (0.17.6)
-      multipart-post (>= 1.2, < 3)
     globalid (0.5.2)
       activesupport (>= 5.0)
     hashdiff (1.0.1)
@@ -100,9 +98,8 @@ GEM
     method_source (1.0.0)
     mini_mime (1.1.0)
     minitest (5.14.4)
-    multipart-post (2.3.0)
     nio4r (2.5.8)
-    nokogiri (1.12.2-x86_64-linux)
+    nokogiri (1.19.3-x86_64-linux-gnu)
       racc (~> 1.4)
     parallel (1.20.1)
     parser (3.0.2.0)

data/README.md

@@ -66,6 +66,32 @@ Betsy::UserAddress.get_user_addresses(etsy_account: EtsyAccount.first)
 
 By default, Betsy handles the refreshing of authentication tokens for you.
 
+## Migrating from v0.2.x to v0.3.x
+
+### Account model requires `token_expired?`
+
+In v0.3.0, the token expiration check was moved out of the gem and into your account model. You need to add a `token_expired?` method to your `EtsyAccount` model (or whatever model you configured via `Betsy.account_model`):
+
+```ruby
+class EtsyAccount < ApplicationRecord
+  def token_expired?
+    last_token_refresh.nil? || expires_in.nil? || last_token_refresh + expires_in <= DateTime.now
+  end
+end
+```
+
+This gives you full control over the expiration logic. For example, you could add a buffer to refresh tokens early:
+
+```ruby
+def token_expired?
+  last_token_refresh.nil? || expires_in.nil? || last_token_refresh + expires_in - 5.minutes <= DateTime.now
+end
+```
+
+### Faraday removed
+
+Betsy no longer depends on Faraday. It uses Ruby's built-in `Net::HTTP` instead. If your app was relying on Betsy to pull in Faraday, you'll need to add it to your own Gemfile.
+
 ## License
 
 The gem is available as open-source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/betsy.gemspec

@@ -37,7 +37,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency("webmock", "~> 3.13.0")
   spec.add_development_dependency("coveralls")
 
-  spec.add_dependency("faraday", ">= 0.10")
+  spec.add_dependency("activesupport", ">= 5.0")
 
   # For more information and examples about making a new gem, checkout our
   # guide at: https://bundler.io/guides/creating_gem.html

data/lib/betsy/model.rb

@@ -9,28 +9,52 @@ module Betsy
         end
       end
 
+      REQUEST_CLASSES = {
+        get: Net::HTTP::Get,
+        post: Net::HTTP::Post,
+        put: Net::HTTP::Put,
+        patch: Net::HTTP::Patch,
+        delete: Net::HTTP::Delete
+      }.freeze
+
       def make_request(request_type, endpoint, options = {})
         check_token_expiration(options[:etsy_account]) if options[:etsy_account]
         headers = access_credentials(options[:etsy_account])
         options.delete(:etsy_account)
 
+        uri = URI("#{BASE_ETSY_API_URL}#{endpoint}")
+
         if [:post, :put, :patch].include?(request_type)
           headers = headers.reverse_merge(content_type: "application/json")
-          options = options.to_json
+          request = REQUEST_CLASSES[request_type].new(uri)
+          request.body = options.to_json
+        else
+          uri.query = URI.encode_www_form(options) if options.any?
+          request = REQUEST_CLASSES[request_type].new(uri)
+        end
+
+        headers.each { |key, value| request[key.to_s] = value }
+
+        response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: uri.scheme == "https") do |http|
+          http.request(request)
         end
 
-        response = Faraday.send(request_type, "#{BASE_ETSY_API_URL}#{endpoint}", options, headers)
         handle_response(response)
       end
 
       def check_token_expiration(etsy_account)
-        if etsy_account.last_token_refresh + etsy_account.expires_in <= DateTime.now
+        if etsy_account.token_expired?
           options = {
             grant_type: "refresh_token",
             refresh_token: etsy_account.refresh_token,
             client_id: Betsy.api_key
           }
-          response = JSON.parse(Faraday.post("https://api.etsy.com/v3/public/oauth/token", options).body)
+          response = JSON.parse(Net::HTTP.post_form(URI("https://api.etsy.com/v3/public/oauth/token"), options).body)
+
+          if response["access_token"].nil?
+            raise "Etsy token refresh failed: #{response}"
+          end
+
           etsy_account.access_token = response["access_token"]
           etsy_account.expires_in = response["expires_in"]
           etsy_account.refresh_token = response["refresh_token"]
@@ -46,12 +70,12 @@ module Betsy
       end
 
       def handle_response(response)
-        if response.status == 200
+        if response.code.to_i == 200
           return nil if response.body.empty?
           response = JSON.parse(response.body)
           build_objects(response)
         else
-          Betsy::Error.new(JSON.parse(response.body).merge!("status" => response.status))
+          Betsy::Error.new(JSON.parse(response.body).merge!("status" => response.code.to_i))
         end
       end
 

data/lib/betsy/review.rb

@@ -18,5 +18,9 @@ module Betsy
     def self.get_reviews_by_shop(shop_id, options = {})
       make_request(:get, "/v3/application/shops/#{shop_id}/reviews", options)
     end
+
+    def self.get_reviews_by_listing(listing_id, options = {})
+      make_request(:get, "/v3/application/listings/#{listing_id}/reviews", options)
+    end
   end
 end

data/lib/betsy/shop_listing.rb

@@ -52,6 +52,9 @@ module Betsy
     attribute :language
     attribute :price
     attribute :taxonomy_id
+    attribute :production_partners
+    attribute :skus
+    attribute :views
 
     # listing properties
     attribute :property_id

data/lib/betsy/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Betsy
-  VERSION = "0.2.1"
+  VERSION = "0.3.0"
 end

data/lib/betsy.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
 require "active_support"
-require "faraday"
+require "net/http"
+require "uri"
+require "json"
 
 require_relative "betsy/version"
 require_relative "betsy/model"
@@ -95,7 +97,7 @@ module Betsy
         code: params[:code],
         code_verifier: etsy_account.code_verifier
       }
-      response = JSON.parse(Faraday.post("https://api.etsy.com/v3/public/oauth/token", options).body)
+      response = JSON.parse(Net::HTTP.post_form(URI("https://api.etsy.com/v3/public/oauth/token"), options).body)
       etsy_account.access_token = response["access_token"]
       etsy_account.refresh_token = response["refresh_token"]
       etsy_account.expires_in = response["expires_in"]

data/lib/generators/betsy/templates/etsy_account.rb.tt

@@ -1,2 +1,5 @@
 class <%= Betsy.account_model %> < ApplicationRecord
+  def token_expired?
+    last_token_refresh.nil? || expires_in.nil? || last_token_refresh + expires_in <= DateTime.now
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: betsy
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Jace Bayless
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-05-02 00:00:00.000000000 Z
+date: 2026-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -109,19 +109,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: faraday
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '5.0'
 description: This gem allows users to simply interact with the Etsy V3 API.
 email:
 - jacebayless@gmail.com
@@ -184,7 +184,7 @@ metadata:
   homepage_uri: https://github.com/JaceBayless/betsy
   source_code_uri: https://github.com/JaceBayless/betsy
   changelog_uri: https://github.com/JaceBayless/betsy/blob/main/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -199,8 +199,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
-signing_key: 
+rubygems_version: 3.4.20
+signing_key:
 specification_version: 4
 summary: A gem for the Etsy API V3
 test_files: []