betfair_api_ng_rails 1.1.0 → 2.1.0

data/spec/lib/betfair_api_ng_rails/api/request_method_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe BetfairApiNgRails::Api::RequestMethod do
+  let(:method_name) { 'someMethod' }
+  let(:logger)   { double(:logger) }
+  let(:endpoint) { BetfairApiNgRails.config.endpoint }
+
+  subject(:method) { described_class.new(method_name, endpoint) }
+
+  before do
+    BetfairApiNgRails.log = logger
+    allow(logger).to receive(:write)
+  end
+
+  context 'has attributes' do
+    its(:name) { is_expected.to eq(method_name) }
+  end
+
+  context 'when method is exists in allowed' do
+    before do
+      stub_const('BetfairApiNgRails::Api::Constants::ALLOWED_RESOURCES', {betting: [method_name]})
+      stub_const('BetfairApiNgRails::Api::Constants::JSON_METHOD', {betting: 'json_method'})
+    end
+
+    its(:type) { is_expected.to eq(:betting) }
+    its(:allowed?) { is_expected.to be_truthy }
+    its(:api_url) { is_expected.to_not eq :no_api_url }
+    its(:json_method) { is_expected.to eq('json_method') }
+  end
+
+  context 'when method is not exists in allowed' do
+    before do
+      stub_const('BetfairApiNgRails::Api::Constants::ALLOWED_RESOURCES', {betting: ['someMethod1']})
+    end
+
+    its(:allowed?) { is_expected.to be_falsey }
+  end
+end

data/spec/{betfair_api_ng_rails → lib/betfair_api_ng_rails}/api/request_methods_spec.rb

@@ -1,80 +1,95 @@
 require 'spec_helper'
 require 'betfair_api_ng_rails/api/constants'
 
-module TestModule
-  extend BetfairApiNgRails::Api::RequestMethods
-end
-
 describe BetfairApiNgRails::Api::RequestMethods do
+  let(:logger)   { double(:logger) }
+  before do
+    BetfairApiNgRails.config.locale = :en
+    BetfairApiNgRails.log = logger
+    allow(logger).to receive(:write)
+  end
 
-  before { BetfairApiNgRails.config.locale = :en }
-  
   BetfairApiNgRails::Api::Constants::SIMPLE_LISTING_FILTERED.each do |method|
-
     describe "##{method}" do
-    
       it "calls run_request with proper params" do
-        expect(TestModule).to receive(:run_request).with(method.underscore.to_sym, {filter: :filter}, {locale: :en})
+        expect(TestModule).to receive(:run_request).with(method.underscore.to_sym, {filter: :filter, locale: :en})
         TestModule.send method.underscore.to_sym, filter: :filter
       end
-
     end
-
   end
 
   describe "#list_market_catalogue" do
-
     it "calls run_request with proper params" do
-      expect(TestModule).to receive(:run_request).with(:list_market_catalogue, {filter: :filter, market_projection: [], sort: "", max_results: '1'}, {locale: :en})
+      expect(TestModule).to receive(:run_request).with(:list_market_catalogue, {filter: :filter, market_projection: [], sort: "", max_results: '1', locale: :en})
       TestModule.list_market_catalogue filter: :filter
     end
-
   end
 
   describe "#list_market_book" do
-    
     it "calls run_request with proper params" do
-      expect(TestModule).to receive(:run_request).with(:list_market_book, {market_ids: ['1'], price_projection: :priceProjection, order_projection: '', match_projection: ''}, {currency_code: 'USD', locale: :en})
+      expect(TestModule).to receive(:run_request).with(:list_market_book, {market_ids: ['1'], price_projection: :priceProjection, order_projection: '', match_projection: '', currency_code: 'USD', locale: :en})
       TestModule.list_market_book market_ids: ['1'], price_projection: :priceProjection
     end
-
   end
 
   describe "#place_orders" do
-    
     it "calls run_request with proper params" do
-      expect(TestModule).to receive(:run_request).with(:place_orders, {market_id: "", instructions: [], customer_ref: ""})
+      expect(TestModule).to receive(:run_request).with(:place_orders, {market_id: "", instructions: [], customer_ref: ""}, "")
       TestModule.place_orders
     end
+  end
 
+  describe '#get_account_details' do
+    it 'calls run request with proper params' do
+      expect(TestModule).to receive(:run_request).with(:get_account_details, {}, "")
+      TestModule.get_account_details
+    end
+  end
+
+  describe '#get_account_funds' do
+    it 'calls run request with proper params' do
+      expect(TestModule).to receive(:run_request).with(:get_account_funds, {}, "")
+      TestModule.get_account_funds
+    end
+  end
+
+  describe '#get_account_statement' do
+    context 'when valid params passed' do
+      let(:params) { {locale: :en} }
+
+      it 'runs success' do
+        expect(TestModule).to receive(:run_request).with(:get_account_statement, params, nil)
+        TestModule.get_account_statement params
+      end
+    end
+
+    context 'when invalid params passed' do
+      let(:params) { [1, 2] }
+
+      it 'raises exception' do
+        expect{
+          TestModule.get_account_statement params
+        }.to raise_error
+      end
+    end
   end
 
   describe "private method" do
-    
     describe "#build_request_type" do
-      
       it "returns proper api method name" do
         expect(TestModule.send(:build_request_type, 'some_value')).to eq 'someValue'
       end
-
     end
 
     describe "#run_request" do
-      
       let(:params) { {key1: 'value'} }
-      let(:data) { {key2: 'value'} }
       let(:connection) { double(:connection) }
 
-      before(:each) { BetfairApiNgRails.connection = connection }
-
-      after(:each) { TestModule.send(:run_request, 'some_method', params, data) }
+      after(:each) { TestModule.send(:run_request, 'some_method', params) }
 
       it "calls request method with proper params" do
-        expect(connection).to receive(:request).with('someMethod', params.merge(data))
+        expect_any_instance_of(BetfairApiNgRails::Api::Connection).to receive(:request).with('someMethod', params)
       end
-
     end
-
   end
-
-end
+end

data/spec/lib/betfair_api_ng_rails/api/session_manager_spec.rb

@@ -0,0 +1,77 @@
+require 'spec_helper'
+
+describe BetfairApiNgRails::Api::SessionManager do
+  subject(:session_manager) { described_class.new(endpoint) }
+
+  let(:endpoint) { BetfairApiNgRails.config.endpoint }
+  let(:username) { 'user001' }
+  let(:asm) { double(:account_session_manager) }
+  let(:account) { BetfairApiNgRails::Account.new(username, 'password', '3cnt4ngt8oh3co', 'crt', 'key') }
+
+  before do
+    allow(BetfairApiNgRails).to receive(:account_session_manager).and_return asm
+  end
+
+  describe '.get_ssoid' do
+    before do
+      allow(BetfairApiNgRails).to receive_message_chain(:account_session_manager, :get).and_return ssoid
+    end
+
+    context 'when ASM has ssoid for passed account' do
+      let(:ssoid) { '2mf348f3fm3f3' }
+
+      it 'returns this one' do
+        expect(session_manager.get_ssoid(account)).to eq ssoid
+      end
+    end
+
+    context 'when ASM has not ssoid' do
+      let(:ssoid) { nil }
+
+      it 'requests new ssoid and returns it' do
+        expect_any_instance_of(BetfairApiNgRails::Api::SessionManager::SsoidRequester).to receive(:session_token).and_return ssoid
+        expect(asm).to receive(:store)
+        expect(session_manager.get_ssoid(account)).to eq ssoid
+      end
+    end
+  end
+
+  describe '.expire_ssoid' do
+    it 'expires ssoid for passed account' do
+      expect(asm).to receive(:expire).with username
+      session_manager.expire_ssoid account
+    end
+  end
+
+end
+
+describe BetfairApiNgRails::Api::SessionManager::SsoidRequester do
+  subject(:requester) { described_class.new(account, endpoint) }
+
+  let(:endpoint) { BetfairApiNgRails.config.endpoint }
+  let(:username) { 'user001' }
+  let(:account) { BetfairApiNgRails::Account.new(username, 'password', '3cnt4ngt8oh3co', 'crt', 'key') }
+
+  let(:http_requester) { double(:http_requester, do_request: login_response) }
+  let(:login_response) do
+    double(:login_response, session_token: session_token)
+  end
+  let(:session_token) { 'some_session_token_str' }
+
+  before do
+    allow(BetfairApiNgRails::Api::Http::Factory).to receive(:session_requester)
+      .with(instance_of(String), account)
+      .and_return http_requester
+  end
+
+  describe '#get' do
+    it 'returns fetched ssoid' do
+      expect(requester.get).to eq session_token
+    end
+
+    it 'stores fetched ssoid in registry' do
+      requester.get
+      expect(BetfairApiNgRails.account_session_manager.sessions.count).to eq 1
+    end
+  end
+end

data/spec/lib/betfair_api_ng_rails/integration/get_account_statement_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+require 'pry-nav'
+
+describe 'getAccountStatement request method' do
+  let(:method_name) { "get_account_statement" }
+  let(:result_class) { BetfairApiNgRails::AccountStatementReport }
+  let(:account) { BetfairApiNgRails::Account.new('user001', 'password', '42f2f434f3g43') }
+  let(:result_hash) do
+    <<-'JSON'
+    {"result":
+      {
+        "accountStatement":[
+          {
+            "refId":"0",
+            "itemDate":"2015-01-02T20:32:51.000Z",
+            "amount":-100.0,
+            "balance":318.58,
+            "itemClassData":{"unknownStatementItem":"{\"avgPrice\":1.68,\"betSize\":100.0,\"betType\":\"B\",\"betCategoryType\":\"E\",\"commissionRate\":null,\"eventId\":116857220,\"eventTypeId\":7524,\"fullMarketName\":\"Games 08 January / Florida @ Vancouver/ Moneyline\",\"grossBetAmount\":0.0,\"marketName\":\"Ставки вкл. ОТ\",\"marketType\":\"O\",\"placedDate\":\"2015-01-08T22:09:26.000Z\",\"selectionId\":2109691,\"selectionName\":\"Ванкувер\",\"startDate\":\"0001-01-01T00:00:00.000Z\",\"transactionType\":\"ACCOUNT_DEBIT\",\"transactionId\":0,\"winLose\":\"RESULT_LOST\"}"},
+            "legacyData": {"avgPrice":1.68,"betSize":100.0,"betType":"B","betCategoryType":"E","eventId":116857220,"eventTypeId":7524,"fullMarketName":"Games 08 January / Florida @ Vancouver/ Moneyline","grossBetAmount":0.0,"marketName":"Ставки вкл. ОТ","marketType":"O","placedDate":"2015-01-08T22:09:26.000Z","selectionId":2109691,"selectionName":"Ванкувер","startDate":"0001-01-01T00:00:00.000Z","transactionType":"ACCOUNT_DEBIT","transactionId":0,"winLose":"RESULT_LOST"},
+            "itemClass":"UNKNOWN"
+          }
+        ],
+        "moreAvailable":false
+      },
+      "id":1}
+    JSON
+  end
+  let(:parameters)   do
+    { }
+  end
+  let(:logger)       { double(:logger) }
+
+  before(:each) do
+    BetfairApiNgRails.config.formatter = nil
+    BetfairApiNgRails.log = logger
+    allow(logger).to receive(:write)
+    allow(BetfairApiNgRails).to receive_message_chain(:account_manager, :get).and_return account
+  end
+
+  context 'when no error occured' do
+    it_behaves_like 'request method' do
+      it { is_expected.to_not be_nil }
+      its(:more_available) { is_expected.to be_nil }
+      its(:account_statement) { is_expected.to_not be_empty }
+    end
+  end
+
+  context 'when api error occured' do
+    it_behaves_like 'request method' do
+      let(:result_hash) { "{\"error\":{\"code\":-32700,\"message\":\"DSC-3000\"}}" }
+
+      it "raise APINGException" do
+        expect{ subject }.to raise_error
+      end
+    end
+  end
+end

data/spec/{betfair_api_ng_rails → lib/betfair_api_ng_rails}/integration/list_competitions_spec.rb

@@ -1,18 +1,16 @@
 require 'spec_helper'
 
-module TestModule
-  extend BetfairApiNgRails::Api::RequestMethods
-end
-
 describe "listCompetitions request method" do
-
   it_behaves_like 'simple list filtering request', 'listCompetitions' do
-
     let(:method_name)  { "list_competitions" }
     let(:result_class) { BetfairApiNgRails::CompetitionResult }
-    let(:result_hash)  { "{\"result\": [{\"marketCount\": 1, \"competition\": { \"id\": 1, \"name\": \"World Cup 2014\" }, \"competitionRegion\": \"BR\"}]}" }
-
+    let(:result_hash)  do
+      <<-JSON
+      {"result":
+        [{"marketCount": 1, "competition": { "id": 1, "name": "World Cup 2014" }, "competitionRegion": "BR"}
+      ]}
+      JSON
+    end
   end
-
 end
 

data/spec/{betfair_api_ng_rails → lib/betfair_api_ng_rails}/integration/list_countries_spec.rb

@@ -1,18 +1,16 @@
 require 'spec_helper'
 
-module TestModule
-  extend BetfairApiNgRails::Api::RequestMethods
-end
-
 describe "listCountries request method" do
-
   it_behaves_like 'simple list filtering request', 'listCountries' do
-
     let(:method_name)  { "list_countries" }
     let(:result_class) { BetfairApiNgRails::CountryCodeResult }
-    let(:result_hash)  { "{\"result\": [{\"marketCount\": 1, \"event\": \"UA\"}]}" }
-
+    let(:result_hash)  do
+      <<-JSON
+      {"result":
+        [{"marketCount": 1, "event": "UA"}
+      ]}
+      JSON
+    end
   end
-
 end
 

data/spec/{betfair_api_ng_rails → lib/betfair_api_ng_rails}/integration/list_event_types_spec.rb

@@ -1,18 +1,16 @@
 require 'spec_helper'
 
-module TestModule
-  extend BetfairApiNgRails::Api::RequestMethods
-end
-
 describe "listEventTypes request method" do
-
   it_behaves_like 'simple list filtering request', 'listEventTypes' do
-
     let(:method_name)  { "list_event_types" }
     let(:result_class) { BetfairApiNgRails::EventTypeResult }
-    let(:result_hash)  { "{\"result\": [{\"marketCount\": 1, \"eventType\": { \"id\": 1, \"name\": \"Soccer\" }}]}" }
-
+    let(:result_hash)  do
+      <<-JSON
+      {"result":
+        [{"marketCount": 1, "eventType": { "id": 1, "name": "Soccer" }}
+      ]}
+      JSON
+    end
   end
-
 end
 

data/spec/{betfair_api_ng_rails → lib/betfair_api_ng_rails}/integration/list_events_spec.rb

@@ -1,18 +1,16 @@
 require 'spec_helper'
 
-module TestModule
-  extend BetfairApiNgRails::Api::RequestMethods
-end
-
 describe "listEvents request method" do
-
   it_behaves_like 'simple list filtering request', 'listEvents' do
-
     let(:method_name)  { "list_events" }
     let(:result_class) { BetfairApiNgRails::EventResult }
-    let(:result_hash)  { "{\"result\": [{\"marketCount\": 1, \"event\": { \"id\": 1, \"name\": \"Chelsea - PSG\" }}]}" }
-
+    let(:result_hash)  do
+      <<-JSON
+      {"result":
+        [{"marketCount": 1, "event": { "id": 1, "name": "Chelsea - PSG" }}
+      ]}
+      JSON
+    end
   end
-
 end
 

data/spec/{betfair_api_ng_rails → lib/betfair_api_ng_rails}/integration/list_market_book_spec.rb

@@ -1,19 +1,17 @@
 require 'spec_helper'
 
-module TestModule
-  extend BetfairApiNgRails::Api::RequestMethods
-end
-
 describe "listMarketBook request method" do
-
   it_behaves_like 'simple list filtering request', 'listMarketBook' do
-
     let(:parameters)   { {market_ids: [1]} }
     let(:method_name)  { "list_market_book" }
     let(:result_class) { BetfairApiNgRails::MarketBook }
-    let(:result_hash)  { "{\"result\": [{\"marketId\": 1, \"isMarketDataDelayed\": \"true\"}]}" }
-
+    let(:result_hash)  do
+      <<-JSON
+      {"result":
+        [{"marketId": 1, "isMarketDataDelayed": "true"}
+      ]}
+      JSON
+    end
   end
-
 end
 

data/spec/{betfair_api_ng_rails → lib/betfair_api_ng_rails}/integration/list_market_catalogue_spec.rb

@@ -1,36 +1,27 @@
 require 'spec_helper'
 
-module TestModule
-  extend BetfairApiNgRails::Api::RequestMethods
-end
-
 describe "listMarketCatalogue request method" do
-
   it_behaves_like 'simple list filtering request', 'listMarketCatalogue' do
-
     let(:method_name)  { "list_market_catalogue" }
     let(:result_class) { BetfairApiNgRails::MarketCatalogue }
-    let(:result_hash)  { "{\"result\": [{\"marketId\": 1, \"marketName\": \"Madrid\", \"marketStartTime\": \"23-04-2014\", \"description\": \"Madrid\", \"totalMatched\": \"1\", \"competition\": {\"id\": 1, \"name\": \"name\"}}]}" }
+    let(:result_hash)  do
+      <<-JSON
+      {"result":
+        [{"marketId": 1, "marketName": "Madrid", "marketStartTime": "23-04-2014", "description": "Madrid", "totalMatched": "1", "competition": {"id": 1, "name": "name"}}
+      ]}
+      JSON
+    end
 
     describe 'checking attribute' do
-      
       context 'competition' do
-        
         it_behaves_like 'request method' do
-
           subject { TestModule.send(method_name, parameters).first }
 
           its(:competition)       { is_expected.not_to be_nil }
-
           its('competition.name') { is_expected.to eq 'name' }
-
         end
-        
       end
-
     end
-
   end
-
 end