bestchange 1.1 → 1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8081c2cc7f9b963ede0ad28cc64923c9a550f0b9cbd4f388bf17600ccfc6ade
-  data.tar.gz: f4813b0a6675c55e9c17c57a2ddbbe71f13706241eb21a43afcfb250cf305487
+  metadata.gz: 1d6a02d56b4b2a21310cec76c34b7b35565953193839cd881e601a8793713da9
+  data.tar.gz: 79f74ffaad6279e4786bf0feb0c6adf0cf2cde65ae219a4831290460aa0b968f
 SHA512:
-  metadata.gz: 573465318a1d906fe83c98659ebbb4167d473bfeb3cafe4e07869133add1363077958026c3771c2f24afea9957db5b113dc6687055b63a771ce70e360d4fbf73
-  data.tar.gz: 477626b6f7183c6da3390c6e204755c42f26274f5b0bada6ae0fb671c511d3259ecf8e23376134cf231a84a4894dab3db8c5cdd21c8a5071dcefa7aac5d6f3db
+  metadata.gz: 9390b359cafddf3c1f1cda493f47a0e6a3723575dc049b4e1f037795677d2f474d93163195e8e0c9ea56ec78c88d5b976c5bc315640aef2261440879cb7e6f54
+  data.tar.gz: 0f0b6ba210438209fddbece962396ecc7336c48b509d834e974fc0ff1ec0049260258294e5655d1514f1bae42746f5e357aeec223cbf3b8f1f3e3966d545229e

data/.rubocop.yml

@@ -3,4 +3,4 @@ AllCops:
 Style/Documentation:
   Enabled: false
 Metrics/MethodLength:
-  Max: 15
+  Max: 20

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change log
 
+## [1.3]
+Add on_extract callback support to ZipExtractor initializer
+
+## [1.2]
+Add base connection, request constants
+
 ## [1.1]
 Fix tempfile location
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bestchange-api (1.1)
+    bestchange (1.3)
       rubyzip (= 2.3.2)
 
 GEM
@@ -48,7 +48,7 @@ PLATFORMS
   arm64-darwin-22
 
 DEPENDENCIES
-  bestchange-api!
+  bestchange!
   minitest (= 5.17.0)
   minitest-reporters
   pry (= 0.14.2)

data/README.md

@@ -1,14 +1,14 @@
 
-# bestchange-api
+# bestchange
 
-bestchange-api is a simple library for getting data from Bestchange aggregator
+bestchange is a simple library for getting data from Bestchange aggregator
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'bestchange-api'
+gem 'bestchange'
 ```
 
 And then execute:
@@ -17,7 +17,7 @@ And then execute:
 
 Or install it yourself as:
 
-    $ gem install bestchange-api
+    $ gem install bestchange
 
 ## Usage
 [Bestchange api description](https://github.com/karpinovsky/bestchange-api/blob/master/API_DOC.txt)
@@ -83,4 +83,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the bestchange-api project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/karpinovsky/bestchange-api/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the bestchange project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/karpinovsky/bestchange-api/blob/master/CODE_OF_CONDUCT.md).

data/bestchange.gemspec

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require_relative 'lib/bestchange/version'
+
+Gem::Specification.new do |spec|
+  spec.name = 'bestchange'
+  spec.summary = 'Bestchange client'
+  spec.description = 'A simple library for getting data from Bestchange aggregator'
+
+  spec.version = Bestchange::VERSION
+  spec.required_ruby_version = Gem::Requirement.new('>= 3.1.3')
+
+  spec.authors = ['Kirill Karpinovsky']
+  spec.email = 'karpinovsky@gmail.com'
+
+  spec.homepage = 'https://github.com/karpinovsky/bestchange'
+
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['source_code_uri'] = spec.homepage
+  spec.metadata['bug_tracker_uri'] = "#{spec.homepage}/issues"
+  spec.metadata['changelog_uri'] = "#{spec.homepage}/blob/master/CHANGELOG.md"
+
+  spec.extra_rdoc_files = Dir['README.md', 'CHANGELOG.md', 'LICENSE.txt']
+
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
+    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  end
+
+  spec.require_paths = ['lib']
+
+  spec.add_dependency 'rubyzip', '2.3.2'
+
+  spec.add_development_dependency 'minitest', '5.17.0'
+  spec.add_development_dependency 'minitest-reporters'
+  spec.add_development_dependency 'pry', '0.14.2'
+  spec.add_development_dependency 'rubocop', '1.47.0'
+
+  spec.license = 'MIT'
+end

data/lib/bestchange/api.rb

@@ -9,25 +9,17 @@ require 'zip'
 module Bestchange
   class Api
     BASE_URI = 'http://api.bestchange.ru/info.zip'
+    BASE_CONNECTION = Net::HTTP.new(URI(BASE_URI).host, URI(BASE_URI).port)
+    BASE_REQUEST = Net::HTTP::Get.new(URI(BASE_URI))
 
-    def initialize(conn = default_conn)
+    def initialize(conn = BASE_CONNECTION)
       @conn = conn
     end
 
     attr_reader :conn
 
-    def request(request = default_request)
+    def request(request = BASE_REQUEST)
       conn.request(request)
     end
-
-    private
-
-    def default_conn
-      Net::HTTP.new(URI(BASE_URI).host, URI(BASE_URI).port)
-    end
-
-    def default_request
-      Net::HTTP::Get.new(URI(BASE_URI))
-    end
   end
 end

data/lib/bestchange/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bestchange
-  VERSION = '1.1'
+  VERSION = '1.3'
 end

data/lib/bestchange/zip_extractor.rb

@@ -4,8 +4,9 @@ require 'zip'
 
 module Bestchange
   class ZipExtractor
-    def initialize(zip_file)
+    def initialize(zip_file, on_extract: nil)
       @zip_file = zip_file
+      @on_extract = on_extract
     end
 
     def call(filename)
@@ -14,6 +15,7 @@ module Bestchange
       Zip::File.open(@zip_file) do |zip_file|
         entry = zip_file.find_entry(filename)
 
+        @on_extract&.call(entry)
         entry.extract(tempfile) { true }
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bestchange
 version: !ruby/object:Gem::Version
-  version: '1.1'
+  version: '1.3'
 platform: ruby
 authors:
 - Kirill Karpinovsky
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-04-25 00:00:00.000000000 Z
+date: 2023-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -98,6 +98,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- bestchange.gemspec
 - bin/console
 - bin/setup
 - lib/bestchange.rb