bestchange-api 0.6 → 1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8da60c9f91d2fac5ff9899af64181c5715b668baa92dd5789dfcf508a92a286
-  data.tar.gz: c8259d19fd314094146ad62d60507ca4eb3279af5d481105fb6e57aac929dd57
+  metadata.gz: fefd2ae756cf40bfa5313e56c56bc473c0677dfc13873c5dea2a527ce901f551
+  data.tar.gz: 1c031422cbff5f5f610c750b9dd1fdbcbfa0fbf6c578aa7d15efabb1282f1d1b
 SHA512:
-  metadata.gz: 3fc1081e2b6e436b0fc1659dae92a3c48396d51ee562310d6a0433979a576e173c7025fa19aed0b3941a020e889a26f4beef94b13c68af6cad27ef43bcee3b50
-  data.tar.gz: 5c891ca4e54319a4a542472daea41fcf00d349f5c4e130854e9650259029c04f31a1ca375ccb9d2fab1156dd1c114235e166db240fca0eae8726bfc58601dcdb
+  metadata.gz: 2626dd57b231e3e8450b29805bbb58de6994842546c9b2b2dde3e6a3aef0e064a5f0d2c7eff5a98840afc3122b38afdf2ea6439195409292543b3e386ea8c13c
+  data.tar.gz: b0bcf4bff9cce0413c69fdca33e90f0fd7c9a7949dc91633e561f5d6b2d18ad6ff958c5cc2463ca86b8109781a56249f00cf7a1d14dcda334053a30e44dc2649

data/.rubocop.yml

@@ -1,3 +1,5 @@
+AllCops:
+  TargetRubyVersion: 3.1.3
 Style/Documentation:
   Enabled: false
 Metrics/MethodLength:

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Change log
 
+## [0.7]
+Minor improvements
+
 ## [0.6]
 Pass zip entry via before_extract block
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bestchange-api (0.5)
+    bestchange-api (0.7)
       rubyzip (= 2.3.2)
 
 GEM

data/README.md

@@ -1,4 +1,3 @@
-
 # bestchange-api
 
 bestchange-api is a simple library for getting data from Bestchange aggregator

data/lib/bestchange/api.rb

@@ -7,46 +7,31 @@ require 'timeout'
 require 'zip'
 
 module Bestchange
-  module Api
-    extend self
+  class Api
+    BASE_URI = 'http://api.bestchange.ru/info.zip'
 
-    def get_files(filenames, &before_extract)
-      Timeout.timeout(Bestchange.configuration.timeout) do
-        fetch_files(filenames, &before_extract)
-      end
+    def initialize(conn = default_conn)
+      @conn = conn
     end
 
-    private
-
-    def fetch_files(filenames, &before_extract)
-      response = make_request
+    attr_reader :conn
 
-      archive = Tempfile.new(ARCHIVE_DATA_FILENAME, encoding: ARCHIVE_DATA_ENCODING)
-      archive.write(response)
+    def request(request = default_request)
+      response = conn.request(request)
 
-      extract_files('info.zip', filenames, &before_extract)
-    ensure
-      archive.close if defined?(archive)
-    end
+      return response unless block_given?
 
-    def make_request
-      Net::HTTP.get(URI(BASE_URI))
+      yield response
     end
 
-    def extract_files(archive, filenames, &before_extract)
-      Zip::File.open(archive) do |zip_file|
-        filenames.map do |filename|
-          entry = zip_file.find_entry(filename)
-
-          pathname = Pathname.new(Bestchange.configuration.dir).join(filename)
-
-          before_extract&.call(entry, pathname)
+    private
 
-          zip_file.extract(entry, pathname)
+    def default_conn
+      Net::HTTP.new(URI(BASE_URI).host, URI(BASE_URI).port)
+    end
 
-          pathname.open
-        end
-      end
+    def default_request
+      Net::HTTP::Get.new(URI(BASE_URI))
     end
   end
 end

data/lib/bestchange/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bestchange
-  VERSION = '0.6'
+  VERSION = '1.0'
 end

data/lib/bestchange/zip_builder.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module Bestchange
+  class ZipBuilder
+    ARCHIVE_DATA_ENCODING = 'ASCII-8BIT'
+
+    def initialize(response_body)
+      @response_body = response_body
+    end
+
+    def call
+      zip_file = Tempfile.new('', encoding: ARCHIVE_DATA_ENCODING)
+      zip_file.write(@response_body)
+      zip_file.rewind
+      zip_file
+    end
+  end
+end

data/lib/bestchange/zip_extractor.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+require 'zip'
+
+module Bestchange
+  class ZipExtractor
+    def initialize(zip_file)
+      @zip_file = zip_file
+    end
+
+    def call(filename)
+      Zip::File.open(@zip_file) do |zip_file|
+        entry = zip_file.find_entry(filename)
+
+        tempfile = Tempfile.new(filename)
+
+        entry.extract(tempfile) { true }
+
+        tempfile.rewind
+        tempfile
+      end
+    end
+  end
+end

data/lib/bestchange.rb

@@ -1,24 +1,8 @@
 # frozen_string_literal: true
 
 require_relative 'bestchange/api'
-require_relative 'bestchange/configuration'
+require_relative 'bestchange/zip_builder'
+require_relative 'bestchange/zip_extractor'
 
 module Bestchange
-  ARCHIVE_DATA_FILENAME = 'info.zip'
-  ARCHIVE_DATA_ENCODING = 'ASCII-8BIT'
-
-  BASE_URI = "http://api.bestchange.ru/#{ARCHIVE_DATA_FILENAME}".freeze
-
-  DIRECTORY = Dir.pwd
-  TIMEOUT = 40
-
-  def self.configuration
-    @configuration ||= Configuration.new
-  end
-
-  def self.configure
-    return configuration unless block_given?
-
-    yield(configuration)
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bestchange-api
 version: !ruby/object:Gem::Version
-  version: '0.6'
+  version: '1.0'
 platform: ruby
 authors:
 - Kirill Karpinovsky
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-17 00:00:00.000000000 Z
+date: 2023-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -89,8 +89,9 @@ files:
 - bin/setup
 - lib/bestchange.rb
 - lib/bestchange/api.rb
-- lib/bestchange/configuration.rb
 - lib/bestchange/version.rb
+- lib/bestchange/zip_builder.rb
+- lib/bestchange/zip_extractor.rb
 homepage: https://github.com/karpinovsky/bestchange-api
 licenses:
 - MIT

data/lib/bestchange/configuration.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-module Bestchange
-  class Configuration
-    def dir
-      @dir || Bestchange::DIRECTORY
-    end
-
-    def timeout
-      @timeout || Bestchange::TIMEOUT
-    end
-
-    attr_writer :dir, :timeout
-  end
-end