bestchange-api 0.5 → 0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3e48dd22229d0446f26b047fd38fee4a9824be55e2981b7bcfeadb49ca4f044
-  data.tar.gz: a098a7884b4b9668974acabc2f73df5837ad54b671c40dec14dc147e23e6d1aa
+  metadata.gz: a4519573ffcd91610bf68a30544ebd17c00506ab8c052b5412b74ff348f07d8a
+  data.tar.gz: c6e1e36c2ed0d7c35a374e00576c8c5de2f433e86edb986a0ceaf5e17a04e167
 SHA512:
-  metadata.gz: 3d574c842366cc7429dc2f197e34767996d265eed053eae2a9f64f00bc5bbd1743bfde48da456e7501473b85acd467378c2223b766db9e11d509805d9994f075
-  data.tar.gz: bd27f374b87e3e18b74e41d952e33e5eb740748d9ae7344dd1895538e477dfd6c5c9cd4f931c8c827d6dd284aa85928c9a96c29426505e91784d50e0e268487d
+  metadata.gz: 8677e25eb2333d11e437e0b06eb64bcc122994b12fba0b81693e10dee37a6f31ce71d47a3f124929dafd865d72280db7e37df2c3109c7f0c4d2231c7b7d89c84
+  data.tar.gz: 5459ab729ad2777e2981b8ba1b55fd37a88a8720d85ddbf18167dcb2587c095b0c5ba6e85f1a2583cad53446545ad569e77fcbc53491f71134cc53d867285e02

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change log
 
+## [0.7]
+Small improvements
+
+## [0.6]
+Pass zip entry via before_extract block
+
 ## [0.5]
 Add before_extract block
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bestchange-api (0.4)
+    bestchange-api (0.7)
       rubyzip (= 2.3.2)
 
 GEM

data/README.md

@@ -19,6 +19,7 @@ Or install it yourself as:
     $ gem install bestchange-api
 
 ## Usage
+[Bestchange api description](https://github.com/karpinovsky/bestchange-api/blob/master/API_DOC.txt)
 
 Add your own configuration or use the default one
 
@@ -35,8 +36,15 @@ Fetch data
 ```ruby
 Bestchange::Api.get_files(['bm_rates.dat']) # => [File] 
 ```
+### &before_extract
+You can also pass a block that will be called before `Zip::Entry#extract`. It might be helpful if you need to remove existed files or change files destination for example
+```ruby
+before_extract = ->(_zip_entry, pathname) do
+  pathname.delete if pathname.exist?
+end
 
-**NOTE**:  API documentation is described here [API_DOC.txt](https://github.com/karpinovsky/bestchange-api/blob/master/API_DOC.txt)
+Bestchange::Api.get_files(['bm_rates.dat'], &before_extract)
+```
 
 ## License
 

data/lib/bestchange/api.rb

@@ -20,11 +20,8 @@ module Bestchange
 
     def fetch_files(filenames, &before_extract)
       response = make_request
-
-      archive = Tempfile.new(ARCHIVE_DATA_FILENAME, encoding: ARCHIVE_DATA_ENCODING)
-      archive.write(response)
-
-      extract_files('info.zip', filenames, &before_extract)
+      archive = make_archive(response)
+      extract_files(archive, filenames, &before_extract)
     ensure
       archive.close if defined?(archive)
     end
@@ -33,6 +30,12 @@ module Bestchange
       Net::HTTP.get(URI(BASE_URI))
     end
 
+    def make_archive(response)
+      archive = Tempfile.new(ARCHIVE_DATA_FILENAME, encoding: ARCHIVE_DATA_ENCODING)
+      archive.write(response)
+      archive
+    end
+
     def extract_files(archive, filenames, &before_extract)
       Zip::File.open(archive) do |zip_file|
         filenames.map do |filename|
@@ -40,7 +43,7 @@ module Bestchange
 
           pathname = Pathname.new(Bestchange.configuration.dir).join(filename)
 
-          before_extract&.call(filename, pathname)
+          before_extract&.call(entry, pathname)
 
           zip_file.extract(entry, pathname)
 

data/lib/bestchange/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bestchange
-  VERSION = '0.5'
+  VERSION = '0.7'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bestchange-api
 version: !ruby/object:Gem::Version
-  version: '0.5'
+  version: '0.7'
 platform: ruby
 authors:
 - Kirill Karpinovsky
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-11 00:00:00.000000000 Z
+date: 2023-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip