bestchange-api 0.3 → 0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 04f8a40e380db40689c09a837ee11046dc2db89aa57b4cb35e7f7f2a1491a1c3
-  data.tar.gz: 71e0dfc4d65b38a3ce17c5a680a559e43b2370683eb31b1cb865feef921fe81a
+  metadata.gz: 99363eb68e71e5ca12cf33f1fb63560b320274402f1d5c0c0e7417f573929263
+  data.tar.gz: 5a1aa1d8806d507cf324256815252f11e83a53fbbc679e7c8aefa0fc5705398e
 SHA512:
-  metadata.gz: 431c8546f41f151ae5c087ca373759e4f535921a951171b023c6a52e553d94a7a71ceea0ce28162971f758e90c1c48077fe57f16d780d7a0df6d6558577d6b72
-  data.tar.gz: f2804fcd70e28c4ff26bc19a70651fc84d47d31d938b0e40fe1a4cc8bd45c3b15a381d531b93241c2dec1974578f8996621e2b4c349007d9839cb094f2b82fc4
+  metadata.gz: 1370a2573f45154957c215a8994d03445650dca1fefab070059148369f22c57d1fd33c58d78d6b3cc06d2cb55cfabb0269ce06a81055e3fd9ce375ac61f568cc
+  data.tar.gz: de6f4885b1d02238392a11d49f90cf24821195e3767d476faf93689d409a894f5f3098e7b1ac1fdd8723e1f0968c560882bf9509a6f332218d205d4a021ec9d0

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Change log
 
+## [0.4]
+Do not delete already existed files
+
 ## [0.3]
 Fix configuration access
 

data/README.md

@@ -23,6 +23,8 @@ Or install it yourself as:
 Add your own configuration or use the default one
 
 ```ruby
+require 'bestchange'
+
 Bestchange.configure do |config|
   config.dir = "path/to/your/custom/folder" # default is Dir.pwd
   config.timeout = 20 # Timeout for getting & parsing data, default is 40

data/lib/bestchange/api.rb

@@ -7,36 +7,44 @@ require 'timeout'
 require 'zip'
 
 module Bestchange
-  class Api
-    def self.get_files(filenames)
-      pathnames = filenames.map do |filename|
-        Pathname.new(Bestchange.configuration.dir).join(filename)
-      end
-
-      Timeout.timeout(Bestchange.configuration.timeout) { fetch_data(pathnames) }
+  module Api
+    extend self
 
-      pathnames.map do |pathname|
-        File.open(pathname)
+    def get_files(filenames)
+      Timeout.timeout(Bestchange.configuration.timeout) do
+        fetch_files(filenames)
       end
     end
 
-    def self.fetch_data(pathnames)
-      response = Net::HTTP.get(URI(BASE_URI))
+    private
 
-      temp_file = Tempfile.new(ARCHIVE_DATA_FILENAME, encoding: ARCHIVE_DATA_ENCODING)
-      temp_file.write(response)
+    def fetch_files(filenames)
+      response = make_request
 
-      Zip::File.open(temp_file) do |zip_file|
-        pathnames.each do |pathname|
-          entry = zip_file.find_entry(pathname.basename)
+      archive = Tempfile.new(ARCHIVE_DATA_FILENAME, encoding: ARCHIVE_DATA_ENCODING)
+      archive.write(response)
 
-          pathname.delete if pathname.exist?
+      extract_files(archive, filenames)
+    ensure
+      archive.close if defined?(archive)
+    end
+
+    def make_request
+      Net::HTTP.get(URI(BASE_URI))
+    end
+
+    def extract_files(archive, filenames)
+      Zip::File.open(archive) do |zip_file|
+        filenames.map do |filename|
+          entry = zip_file.find_entry(filename)
+
+          pathname = Pathname.new(Bestchange.configuration.dir).join(filename)
 
           zip_file.extract(entry, pathname)
+
+          pathname.open
         end
       end
-
-      temp_file.close
     end
   end
 end

data/lib/bestchange/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bestchange
-  VERSION = '0.3'
+  VERSION = '0.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bestchange-api
 version: !ruby/object:Gem::Version
-  version: '0.3'
+  version: '0.4'
 platform: ruby
 authors:
 - Kirill Karpinovsky
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-05 00:00:00.000000000 Z
+date: 2023-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip