bestchange-api 0.2 → 0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d4fa52ab370765f06a8ea106d4547fca3cc36edcd379827fa1b7abe57e0f0384
-  data.tar.gz: d282e1a33a6e49ebe0179d4042304639e3f277c4999d0c8843cae500cbcad0bd
+  metadata.gz: 99363eb68e71e5ca12cf33f1fb63560b320274402f1d5c0c0e7417f573929263
+  data.tar.gz: 5a1aa1d8806d507cf324256815252f11e83a53fbbc679e7c8aefa0fc5705398e
 SHA512:
-  metadata.gz: dd099097f90da89ce098e417252e7eca73f3432c623b1fc89e1674f4f6e44a4bfc24da5557417b12fa6b055ab1a18ef087b9c692c50b3ab3d97ed3dc8912aede
-  data.tar.gz: e7f9176098122689fb80453d0c9215580215daf7773bc4024846ada491727883af9fe1dc142a8886fd80448d14a377c23c906a6090452c01e3e897b25e8b35e5
+  metadata.gz: 1370a2573f45154957c215a8994d03445650dca1fefab070059148369f22c57d1fd33c58d78d6b3cc06d2cb55cfabb0269ce06a81055e3fd9ce375ac61f568cc
+  data.tar.gz: de6f4885b1d02238392a11d49f90cf24821195e3767d476faf93689d409a894f5f3098e7b1ac1fdd8723e1f0968c560882bf9509a6f332218d205d4a021ec9d0

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change log
 
+## [0.4]
+Do not delete already existed files
+
+## [0.3]
+Fix configuration access
+
 ## [0.2]
 Fix missing dependencies. Move requirements to Api class
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bestchange-api (0.1)
+    bestchange-api (0.3)
       rubyzip (= 2.3.2)
 
 GEM

data/README.md

@@ -23,6 +23,8 @@ Or install it yourself as:
 Add your own configuration or use the default one
 
 ```ruby
+require 'bestchange'
+
 Bestchange.configure do |config|
   config.dir = "path/to/your/custom/folder" # default is Dir.pwd
   config.timeout = 20 # Timeout for getting & parsing data, default is 40

data/lib/bestchange/api.rb

@@ -7,36 +7,44 @@ require 'timeout'
 require 'zip'
 
 module Bestchange
-  class Api
-    def self.get_files(filenames)
-      pathnames = filenames.map do |filename|
-        Pathname.new(Bestchange.configuration.dir).join(filename)
-      end
-
-      Timeout.timeout(Bestchange.configuration.timeout) { fetch_data(pathnames) }
+  module Api
+    extend self
 
-      pathnames.map do |pathname|
-        File.open(pathname)
+    def get_files(filenames)
+      Timeout.timeout(Bestchange.configuration.timeout) do
+        fetch_files(filenames)
       end
     end
 
-    def self.fetch_data(pathnames)
-      response = Net::HTTP.get(URI(BASE_URI))
+    private
 
-      temp_file = Tempfile.new(ARCHIVE_DATA_FILENAME, encoding: ARCHIVE_DATA_ENCODING)
-      temp_file.write(response)
+    def fetch_files(filenames)
+      response = make_request
 
-      Zip::File.open(temp_file) do |zip_file|
-        pathnames.each do |pathname|
-          entry = zip_file.find_entry(pathname.basename)
+      archive = Tempfile.new(ARCHIVE_DATA_FILENAME, encoding: ARCHIVE_DATA_ENCODING)
+      archive.write(response)
 
-          pathname.delete if pathname.exist?
+      extract_files(archive, filenames)
+    ensure
+      archive.close if defined?(archive)
+    end
+
+    def make_request
+      Net::HTTP.get(URI(BASE_URI))
+    end
+
+    def extract_files(archive, filenames)
+      Zip::File.open(archive) do |zip_file|
+        filenames.map do |filename|
+          entry = zip_file.find_entry(filename)
+
+          pathname = Pathname.new(Bestchange.configuration.dir).join(filename)
 
           zip_file.extract(entry, pathname)
+
+          pathname.open
         end
       end
-
-      temp_file.close
     end
   end
 end

data/lib/bestchange/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bestchange
-  VERSION = '0.2'
+  VERSION = '0.4'
 end

data/lib/bestchange.rb

@@ -12,15 +12,13 @@ module Bestchange
   DIRECTORY = Dir.pwd
   TIMEOUT = 40
 
-  class << self
-    def configuration
-      @configuration ||= Configuration.new
-    end
+  def self.configuration
+    @configuration ||= Configuration.new
+  end
 
-    def configure
-      return configuration unless block_given?
+  def self.configure
+    return configuration unless block_given?
 
-      yield(configuration)
-    end
+    yield(configuration)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bestchange-api
 version: !ruby/object:Gem::Version
-  version: '0.2'
+  version: '0.4'
 platform: ruby
 authors:
 - Kirill Karpinovsky
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-04 00:00:00.000000000 Z
+date: 2023-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip