best_practice_project 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b261b120ec527cc114e33b9a9a527ad2694a083e
-  data.tar.gz: 3ffa272f8f77bd9d6ea8946fc6bb7163e8da3d3f
+  metadata.gz: 4ac02c1babdd1ad02b8a984339c36617283294e9
+  data.tar.gz: d6917c5650e11826ec7f6d2a84ef3f5aa72466dd
 SHA512:
-  metadata.gz: ea011471d688c598eef9b99becefc850f53bd1d6ea4cc60a251d840fff2121222ecd4b658252205293368009d60bdc808ca660cad6b6bc26aa5e9936536ce13f
-  data.tar.gz: 34f122ab457aca0f064469dd2bbce82c0469845d81cb4f38fae53c5c9ad2b638393b4fcee45f1ace2044318ad6763e5aa4754d9e10ae03a48283f25b5c45d616
+  metadata.gz: 0e1b622177296a2381f530a29af7662c9f01932549baabb56ad83d2e28da108d61d9a48caf82644703f5a0c1f2a6cf9602749435e58cc6267ab63bee59f59836
+  data.tar.gz: bce5d11f08347122560701a17497d9169341ec743cf9bde4d68147f8afdfe461b4bf283bdbe2f1ad78681f1b6662917fef636cd808c5578ff44a452009a710e9

data/.rubocop.yml

@@ -0,0 +1,54 @@
+AllCops:
+  Exclude:
+    - db/schema.rb
+    - spec/dummy/db/schema.rb
+
+# https://github.com/AtomLinter/linter-rubocop/issues/2
+Style/FileName:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 160
+
+Metrics/MethodLength:
+  Max: 50
+
+Metrics/AbcSize:
+  Max: 25
+
+Metrics/ClassLength:
+  Max: 250
+
+Style/AccessModifierIndentation:
+  EnforcedStyle: outdent
+
+Style/ClassAndModuleChildren:
+  EnforcedStyle: compact
+
+Style/Documentation:
+  Enabled: false
+
+Style/EmptyLines:
+  Enabled: false
+
+StringLiterals:
+  EnforcedStyle: double_quotes
+
+StringLiteralsInInterpolation:
+  Enabled: false
+
+Style/NilComparison:
+  Enabled: false
+
+Style/SignalException:
+  EnforcedStyle: only_raise
+
+Style/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+Style/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+
+Style/TrivialAccessors:
+  ExactNameMatch: true
+  Enabled: true

data/README.md

@@ -32,6 +32,7 @@ end
 
 Add this to your Rakefile:
 ```ruby
+require "best_practice_project"
 BestPracticeProject.load_tasks
 ```
 

data/VERSION

@@ -1 +1 @@
-0.0.4
+0.0.5

data/best_practice_project.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: best_practice_project 0.0.4 ruby lib
+# stub: best_practice_project 0.0.5 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "best_practice_project"
-  s.version = "0.0.4"
+  s.version = "0.0.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["kaspernj"]
-  s.date = "2015-11-25"
+  s.date = "2015-12-03"
   s.description = "A bundle of various linters and code inspection tools"
   s.email = "k@spernj.org"
   s.extra_rdoc_files = [
@@ -21,6 +21,7 @@ Gem::Specification.new do |s|
   s.files = [
     ".document",
     ".rspec",
+    ".rubocop.yml",
     "Gemfile",
     "Gemfile.lock",
     "LICENSE.txt",
@@ -38,7 +39,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/kaspernj/best_practice_project"
   s.licenses = ["MIT"]
-  s.rubygems_version = "2.4.0"
+  s.rubygems_version = "2.2.2"
   s.summary = "A bundle of various linters and code inspection tools"
 
   if s.respond_to? :specification_version then

data/lib/best_practice_project/config/rubocop.yml

@@ -3,6 +3,10 @@ AllCops:
     - db/schema.rb
     - spec/dummy/db/schema.rb
 
+# https://github.com/AtomLinter/linter-rubocop/issues/2
+Style/FileName:
+  Enabled: false
+
 Metrics/LineLength:
   Max: 160
 

data/lib/best_practice_project/rubocop_handler.rb

@@ -4,11 +4,15 @@ class BestPracticeProject::RubocopHandler
     @actual_config_path = File.realpath("#{File.dirname(__FILE__)}/config/rubocop.yml")
 
     if rails?
-      @config_path = Rails.root.join("config", "rubocop.yml").to_s
-      @todo_path = Rails.root.join("config", "rubocop_todo.yml").to_s
+      @config_path = Rails.root.join("config", "best_project_practice_rubocop.yml").to_s
+      @todo_path = Rails.root.join("config", "best_project_practice_rubocop_todo.yml").to_s
+      @default_path = Rails.root.join(".rubocop.yml")
+      @default_todo_path = Rails.root.join(".rubocop_todo.yml")
     else
-      @config_path = "config/rubocop.yml"
-      @todo_path = "config/rubocop_todo.yml"
+      @config_path = "config/best_project_practice_rubocop.yml"
+      @todo_path = "config/best_project_practice_rubocop_todo.yml"
+      @default_path = ".rubocop.yml"
+      @default_todo_path = ".rubocop_todo.yml"
     end
   end
 
@@ -16,6 +20,10 @@ class BestPracticeProject::RubocopHandler
     @bpp.rails?
   end
 
+  def remove_best_practice_path
+    self.inherit_from_to = nil
+  end
+
   def update_best_practice_path
     self.inherit_from_to = @actual_config_path
   end
@@ -24,6 +32,19 @@ class BestPracticeProject::RubocopHandler
     self.inherit_from_to = "$$$best_practice_project_config_path$$$"
   end
 
+  # Make default ".rubocop.yml" and ".rubocop_todo" to support Sublime Text plugins and likewise
+  def update_default_configs
+    remove_best_practice_path
+    File.symlink(@todo_path, @default_todo_path)
+    # FileUtils.cp(@todo_path, @default_todo_path)
+
+    # Make default ".rubocop.yml" and ".rubocop_todo" to support Sublime Text plugins and likewise
+    generated_config = {"inherit_from" => [@actual_config_path, ".rubocop_todo.yml"]}
+    File.open(@default_path, "w") do |fp|
+      fp.write(YAML.dump(generated_config))
+    end
+  end
+
   def command
     command = "bundle exec rubocop --display-cop-names"
     command << " --rails" if rails?
@@ -43,13 +64,13 @@ class BestPracticeProject::RubocopHandler
     puts "Generated Rubocop todo config in #{@todo_path}"
 
     generated_config = {}
-    generated_config["inherit_from"] = "rubocop_todo.yml"
+    generated_config["inherit_from"] = "best_project_practice_rubocop_todo.yml"
 
     File.open(@config_path, "w") do |fp|
       fp.write(YAML.dump(generated_config))
     end
 
-    reset_best_practice_path
+    update_default_configs
 
     puts "Generated Rubocop config in  #{@config_path}"
   end
@@ -87,7 +108,7 @@ class BestPracticeProject::RubocopHandler
     begin
       system(command)
     ensure
-      reset_best_practice_path
+      remove_best_practice_path
     end
   end
 
@@ -96,17 +117,21 @@ private
   def inherit_from_to=(new_inherit_from)
     todo_config = File.read(@todo_path)
 
-    replace_with = "inherit_from: \"#{new_inherit_from}\""
+    if new_inherit_from
+      replace_with = "inherit_from: \"#{new_inherit_from}\""
+    else
+      replace_with = ""
+    end
 
     if todo_config.include?("inherit_from:")
       replace_what = /^inherit_from: (.+)$/
     elsif todo_config.start_with?("---\n")
       replace_what = /\A---\n/
       replace_with.prepend("---\n")
-      replace_with << "\n\n"
+      replace_with << "\n\n" if replace_with.length > 0
     else
       replace_what = /\A/
-      replace_with << "\n\n"
+      replace_with << "\n\n" if replace_with.length > 0
     end
 
     todo_config.gsub!(replace_what, replace_with)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: best_practice_project
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - kaspernj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-25 00:00:00.000000000 Z
+date: 2015-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: psych
@@ -104,6 +104,7 @@ extra_rdoc_files:
 files:
 - ".document"
 - ".rspec"
+- ".rubocop.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -138,7 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A bundle of various linters and code inspection tools