best_in_placeish 0.2.2

data/spec/helpers/best_in_place_spec.rb

@@ -0,0 +1,239 @@
+# encoding: utf-8
+require "spec_helper"
+
+describe BestInPlace::BestInPlaceHelpers do
+  describe "#best_in_place" do
+    before do
+      @user = User.new :name => "Lucia",
+        :last_name => "Napoli",
+        :email => "lucianapoli@gmail.com",
+        :address => "Via Roma 99",
+        :zip => "25123",
+        :country => "2",
+        :receive_email => false,
+        :description => "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus a lectus et lacus ultrices auctor. Morbi aliquet convallis tincidunt. Praesent enim libero, iaculis at commodo nec, fermentum a dolor. Quisque eget eros id felis lacinia faucibus feugiat et ante. Aenean justo nisi, aliquam vel egestas vel, porta in ligula. Etiam molestie, lacus eget tincidunt accumsan, elit justo rhoncus urna, nec pretium neque mi et lorem. Aliquam posuere, dolor quis pulvinar luctus, felis dolor tincidunt leo, eget pretium orci purus ac nibh. Ut enim sem, suscipit ac elementum vitae, sodales vel sem."
+    end
+
+    it "should generate a proper span" do
+      nk = Nokogiri::HTML.parse(helper.best_in_place @user, :name)
+      span = nk.css("span")
+      span.should_not be_empty
+    end
+
+    describe "general properties" do
+      before do
+        nk = Nokogiri::HTML.parse(helper.best_in_place @user, :name)
+        @span = nk.css("span")
+      end
+
+      context "when it's an ActiveRecord model" do
+        it "should have a proper id" do
+          @span.attribute("id").value.should == "best_in_place_user_#{@user.id}_name"
+        end
+      end
+
+      context "when it's not an AR model" do
+        it "shold generate an html id without any id" do
+          nk = Nokogiri::HTML.parse(helper.best_in_place [1,2,3], :first, :path => @user)
+          span = nk.css("span")
+          span.attribute("id").value.should == "best_in_place_array_first"
+        end
+      end
+
+      it "should have the best_in_place class" do
+        @span.attribute("class").value.should == "best_in_place"
+      end
+
+      it "should have the correct data-attribute" do
+        @span.attribute("data-attribute").value.should == "name"
+      end
+
+      it "should have the correct data-object" do
+        @span.attribute("data-object").value.should == "user"
+      end
+
+      it "should have no activator by default" do
+        @span.attribute("data-activator").should be_nil
+      end
+
+      it "should have no inner_class by default" do
+        @span.attribute("data-inner-class").should be_nil
+      end
+
+      describe "url generation" do
+        it "should have the correct default url" do
+          @user.save!
+          nk = Nokogiri::HTML.parse(helper.best_in_place @user, :name)
+          span = nk.css("span")
+          span.attribute("data-url").value.should == "/users/#{@user.id}"
+        end
+
+        it "should use the custom url specified in string format" do
+          out = helper.best_in_place @user, :name, :path => "/custom/path"
+          nk = Nokogiri::HTML.parse(out)
+          span = nk.css("span")
+          span.attribute("data-url").value.should == "/custom/path"
+        end
+
+        it "should use the path given in a named_path format" do
+          out = helper.best_in_place @user, :name, :path => helper.users_path
+          nk = Nokogiri::HTML.parse(out)
+          span = nk.css("span")
+          span.attribute("data-url").value.should == "/users"
+        end
+
+        it "should use the given path in a hash format" do
+          out = helper.best_in_place @user, :name, :path => {:controller => :users, :action => :edit, :id => 23}
+          nk = Nokogiri::HTML.parse(out)
+          span = nk.css("span")
+          span.attribute("data-url").value.should == "/users/23/edit"
+        end
+      end
+
+      describe "nil option" do
+        it "should have no nil data by default" do
+          @span.attribute("data-nil").should be_nil
+        end
+
+        it "should show '' if the object responds with nil for the passed attribute" do
+          @user.stub!(:name).and_return(nil)
+          nk = Nokogiri::HTML.parse(helper.best_in_place @user, :name)
+          span = nk.css("span")
+          span.text.should == ""
+        end
+
+        it "should show '' if the object responds with an empty string for the passed attribute" do
+          @user.stub!(:name).and_return("")
+          nk = Nokogiri::HTML.parse(helper.best_in_place @user, :name)
+          span = nk.css("span")
+          span.text.should == ""
+        end
+      end
+
+      it "should have the given inner_class" do
+        out = helper.best_in_place @user, :name, :inner_class => "awesome"
+        nk = Nokogiri::HTML.parse(out)
+        span = nk.css("span")
+        span.attribute("data-inner-class").value.should == "awesome"
+      end
+
+      it "should have the given activator" do
+        out = helper.best_in_place @user, :name, :activator => "awesome"
+        nk = Nokogiri::HTML.parse(out)
+        span = nk.css("span")
+        span.attribute("data-activator").value.should == "awesome"
+      end
+    end
+
+
+    context "with a text field attribute" do
+      before do
+        nk = Nokogiri::HTML.parse(helper.best_in_place @user, :name)
+        @span = nk.css("span")
+      end
+
+      it "should render the name as text" do
+        @span.text.should == "Lucia"
+      end
+
+      it "should have an input data-type" do
+        @span.attribute("data-type").value.should == "input"
+      end
+
+      it "should have no data-collection" do
+        @span.attribute("data-collection").should be_nil
+      end
+    end
+
+    context "with a boolean attribute" do
+      before do
+        nk = Nokogiri::HTML.parse(helper.best_in_place @user, :receive_email, :type => :checkbox)
+        @span = nk.css("span")
+      end
+
+      it "should have a checkbox data-type" do
+        @span.attribute("data-type").value.should == "checkbox"
+      end
+
+      it "should have the default data-collection" do
+        data = ["No", "Yes"]
+        @span.attribute("data-collection").value.should == data.to_json
+      end
+
+      it "should render the current option as No" do
+        @span.text.should == "No"
+      end
+
+      describe "custom collection" do
+        before do
+          nk = Nokogiri::HTML.parse(helper.best_in_place @user, :receive_email, :type => :checkbox, :collection => ["Nain", "Da"])
+          @span = nk.css("span")
+        end
+
+        it "should show the message with the custom values" do
+          @span.text.should == "Nain"
+        end
+
+        it "should render the proper data-collection" do
+          @span.attribute("data-collection").value.should == ["Nain", "Da"].to_json
+        end
+      end
+
+    end
+
+    context "with a select attribute" do
+      before do
+        @countries = COUNTRIES.to_a
+        nk = Nokogiri::HTML.parse(helper.best_in_place @user, :country, :type => :select, :collection => @countries)
+        @span = nk.css("span")
+      end
+
+      it "should have a select data-type" do
+        @span.attribute("data-type").value.should == "select"
+      end
+
+      it "should have a proper data collection" do
+        @span.attribute("data-collection").value.should == @countries.to_json
+      end
+
+      it "should show the current country" do
+        @span.text.should == "Italy"
+      end
+    end
+  end
+
+  describe "#best_in_place_if" do
+    context "when the parameters are valid" do
+      before(:each) do
+        @output = "Some Value"
+        @field = :somefield
+        @object = mock("object", @field => @output)
+        @options = mock("options")
+      end
+      context "when the condition is true" do
+        before {@condition = true}
+        context "when the options parameter is left off" do
+          it "should call best_in_place with the rest of the parameters and empty options" do
+            helper.should_receive(:best_in_place).with(@object, @field, {})
+            helper.best_in_place_if @condition, @object, @field
+          end
+        end
+        context "when the options parameter is included" do
+          it "should call best_in_place with the rest of the parameters" do
+            helper.should_receive(:best_in_place).with(@object, @field, @options)
+            helper.best_in_place_if @condition, @object, @field, @options
+          end
+        end
+      end
+      context "when the condition is false" do
+        before {@condition = false}
+        it "should return the value of the field when the options value is left off" do
+          helper.best_in_place_if(@condition, @object, @field).should eq @output
+        end
+        it "should return the value of the field when the options value is included" do
+          helper.best_in_place_if(@condition, @object, @field, @options).should eq @output
+        end
+      end
+    end
+  end
+end

data/spec/integration/double_init_spec.rb

@@ -0,0 +1,32 @@
+# encoding: utf-8
+require "spec_helper"
+
+describe "Double initialization bug", :js => true do
+  before do
+    @user = User.new :name => "Lucia",
+      :last_name => "Napoli",
+      :email => "lucianapoli@gmail.com",
+      :address => "Via Roma 99",
+      :zip => "25123",
+      :country => "2",
+      :receive_email => false,
+      :description => "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus a lectus et lacus ultrices auctor. Morbi aliquet convallis tincidunt. Praesent enim libero, iaculis at commodo nec, fermentum a dolor. Quisque eget eros id felis lacinia faucibus feugiat et ante. Aenean justo nisi, aliquam vel egestas vel, porta in ligula. Etiam molestie, lacus eget tincidunt accumsan, elit justo rhoncus urna, nec pretium neque mi et lorem. Aliquam posuere, dolor quis pulvinar luctus, felis dolor tincidunt leo, eget pretium orci purus ac nibh. Ut enim sem, suscipit ac elementum vitae, sodales vel sem."
+  end
+
+  it "should be able to change a boolean value" do
+    @user.save!
+    visit double_init_user_path(@user)
+
+    within("#receive_email") do
+      page.should have_content("No thanks")
+    end
+
+    bip_bool @user, :receive_email
+
+    visit double_init_user_path(@user)
+    within("#receive_email") do
+      page.should have_content("Yes of course")
+    end
+
+  end
+end

data/spec/integration/js_spec.rb

@@ -0,0 +1,165 @@
+# encoding: utf-8
+require "spec_helper"
+
+describe "JS behaviour", :js => true do
+  before do
+    @user = User.new :name => "Lucia",
+      :last_name => "Napoli",
+      :email => "lucianapoli@gmail.com",
+      :address => "Via Roma 99",
+      :zip => "25123",
+      :country => "2",
+      :receive_email => false,
+      :description => "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus a lectus et lacus ultrices auctor. Morbi aliquet convallis tincidunt. Praesent enim libero, iaculis at commodo nec, fermentum a dolor. Quisque eget eros id felis lacinia faucibus feugiat et ante. Aenean justo nisi, aliquam vel egestas vel, porta in ligula. Etiam molestie, lacus eget tincidunt accumsan, elit justo rhoncus urna, nec pretium neque mi et lorem. Aliquam posuere, dolor quis pulvinar luctus, felis dolor tincidunt leo, eget pretium orci purus ac nibh. Ut enim sem, suscipit ac elementum vitae, sodales vel sem."
+  end
+
+  describe "nil option" do
+    it "should render the default '-' string when the field is empty" do
+      @user.name = ""
+      @user.save :validate => false
+      visit user_path(@user)
+
+      within("#name") do
+        page.should have_content("-")
+      end
+    end
+
+    it "should render the passed nil value if the field is empty" do
+      @user.last_name = ""
+      @user.save :validate => false
+      visit user_path(@user)
+
+      within("#last_name") do
+        page.should have_content("Nothing to show")
+      end
+    end
+  end
+
+  it "should be able to use bip_text to update a text field" do
+    @user.save!
+    visit user_path(@user)
+    within("#email") do
+      page.should have_content("lucianapoli@gmail.com")
+    end
+
+    bip_text @user, :email, "new@email.com"
+
+    visit user_path(@user)
+    within("#email") do
+      page.should have_content("new@email.com")
+    end
+  end
+
+  it "should be able to update a field two consecutive times" do
+    @user.save!
+    visit user_path(@user)
+
+    bip_text @user, :email, "new@email.com"
+
+    within("#email") do
+      page.should have_content("new@email.com")
+    end
+
+    bip_text @user, :email, "new_two@email.com"
+
+    within("#email") do
+      page.should have_content("new_two@email.com")
+    end
+
+    visit user_path(@user)
+    within("#email") do
+      page.should have_content("new_two@email.com")
+    end
+  end
+
+  it "should be able to update a field after an error" do
+    @user.save!
+    visit user_path(@user)
+
+    bip_text @user, :email, "wrong format"
+    page.should have_content("Email has wrong email format")
+
+    bip_text @user, :email, "another@email.com"
+    within("#email") do
+      page.should have_content("another@email.com")
+    end
+
+    visit user_path(@user)
+    within("#email") do
+      page.should have_content("another@email.com")
+    end
+  end
+
+  it "should be able to use bil_select to change a select field" do
+    @user.save!
+    visit user_path(@user)
+    within("#country") do
+      page.should have_content("Italy")
+    end
+
+    bip_select @user, :country, "France"
+
+    visit user_path(@user)
+    within("#country") do
+      page.should have_content("France")
+    end
+  end
+
+  it "should be able to use bip_bool to change a boolean value" do
+    @user.save!
+    visit user_path(@user)
+
+    within("#receive_email") do
+      page.should have_content("No thanks")
+    end
+
+    bip_bool @user, :receive_email
+
+    visit user_path(@user)
+    within("#receive_email") do
+      page.should have_content("Yes of course")
+    end
+  end
+
+  it "should show validation errors" do
+    @user.save!
+    visit user_path(@user)
+
+    bip_text @user, :address, ""
+    page.should have_content("Address can't be blank")
+    within("#address") do
+      page.should have_content("Via Roma 99")
+    end
+  end
+
+  it "should show validation errors using respond_with in the controller" do
+    @user.save!
+    visit user_path(@user)
+
+    bip_text @user, :last_name, "a"
+    page.should have_content("last_name has invalid length")
+  end
+
+  it "should be able to update a field after an error using respond_with in the controller" do
+    @user.save!
+    visit user_path(@user)
+
+    bip_text @user, :last_name, "a"
+
+    within("#last_name") do
+      page.should have_content("Napoli")
+    end
+
+    bip_text @user, :last_name, "Another"
+
+    within("#last_name") do
+      page.should have_content("Another")
+    end
+
+    visit user_path(@user)
+    within("#last_name") do
+      page.should have_content("Another")
+    end
+  end
+end
+

data/spec/integration/text_area_spec.rb

@@ -0,0 +1,30 @@
+# encoding: utf-8
+require "spec_helper"
+
+describe "JS behaviour", :js => true do
+  before do
+    @user = User.new :name => "Lucia",
+      :last_name => "Napoli",
+      :email => "lucianapoli@gmail.com",
+      :address => "Via Roma 99",
+      :zip => "25123",
+      :country => "2",
+      :receive_email => false,
+      :description => "User description"
+  end
+
+  it "should be able to use bip_text to update a text area" do
+    @user.save!
+    visit user_path(@user)
+    within("#description") do
+      page.should have_content("User description")
+    end
+
+    bip_area @user, :description, "A new description"
+
+    visit user_path(@user)
+    within("#description") do
+      page.should have_content("A new description")
+    end
+  end
+end