best_in_place 3.0.3 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 84ce49122f38b9152cae6c9ce661307dd0f3d528
-  data.tar.gz: ad3e88ba32e9c656706661ef05e807f9fdfc7fb3
+  metadata.gz: 69cca3a71a33da7518f1fb792624d505c10e9018
+  data.tar.gz: 9782236c6e4508607b856b0690ef29abaef84780
 SHA512:
-  metadata.gz: 1502b356495066e3c08541b068e8af62bd58bcc0c32d0ff84b5fdb570ffdd663fb9fa864ea2f78c77326ff0d359cf42b9819402a5052bf1245a5f47c19e11993
-  data.tar.gz: db75bf52797e26f7bb11253b4cadaaaede87ec84d46dfe736bfead6960469c76bc10fa5fb7284f211241f48da035f63d792a1197a8d2d79cb84ab458eb31d3a5
+  metadata.gz: 9d5d31fa17f831062346c9b21e9eac994cf948fe551d2c5699dc43c69ae508421374a4281cf58e3ef1860504a6e80736ff2cbf7665e05e3961359d2757a79d3c
+  data.tar.gz: 5b4d5c558752d542e434060724909c356defa96932105e17d8b63d440562f1858a286714f131e68e97789d1f947b4b669b258bbbce65b6424ac2eb1e1704edf2

data/Appraisals

@@ -1,10 +1,12 @@
 appraise "rails-3.2" do
   gem 'rails', github: "rails/rails", branch: '3-2-stable'
   gem 'strong_parameters'
+  gem 'test-unit'
 end
 
 appraise "rails-4.0" do
   gem "rails", github: "rails/rails", branch: '4-0-stable'
+  gem 'test-unit'
 end
 
 appraise "rails-4.1" do
@@ -18,4 +20,4 @@ end
 appraise "rails-edge" do
   gem "rails", github: "rails/rails"
   gem 'arel', github: 'rails/arel'
-end
+end

data/CHANGELOG.md

@@ -1,4 +1,6 @@
 #Changelog
+- unreleased
+  - add option[:skip_blur] to play nice with wysiwhtml5
 
 - v.3.0.3 :
   - Pass all callback arguments on $.ajax
@@ -15,14 +17,14 @@
   - Support all supported version of actionpack/rails
   - Dropped dependency on jquery gem
   - Namespaced all data attributes to avoid conflict.
-  - Jquery-ui datepicker was extracted to best_in_place.jquery-ui.js 
+  - Jquery-ui datepicker was extracted to best_in_place.jquery-ui.js
   - Added BestInPlaceEditor.defaults
   - Deprecated opts[:sanitize] in favor of option[:raw]
-  - You have to require jquery.purr  before best_in_place.purr 
-  - You have to require jquery-ui.datepicker  before best_in_place.jquery-ui 
+  - You have to require jquery.purr  before best_in_place.purr
+  - You have to require jquery-ui.datepicker  before best_in_place.jquery-ui
   - Added opts[:value] to set custom original-value
   - You can override the default container
-  
+
 - v.2x : glitch in the Matrix
 
 - v.1.1.0 Changed $ by jQuery for compatibility (thanks @tschmitz), new

data/README.md

@@ -11,8 +11,6 @@ Javascript file to the application it allows all the fields with the proper defi
 
 The editor works by PUTting the updated value to the server and GETting the updated record afterwards to display the updated value.
 
-[**SEE DEMO**](http://bipapp.heroku.com/)
-
 ---
 
 ##Installation
@@ -87,7 +85,7 @@ Options:
 - **:cancel_button**: (Inputs and textareas only) If set to a string, then a Cancel button will be shown with the string as its label.
 - **:cancel_button_class**: (Inputs and textareas only) Specifies any extra classes to set on the Cancel button.
 - **:sanitize**: True by default. If set to false the input/textarea will accept html tags.
-- **:html_attrs**: Hash of html arguments such as maxlength, default-value, etc. that will be set on the rendered input **not** the best_in_place span.  
+- **:html_attrs**: Hash of html arguments such as maxlength, default-value, etc. that will be set on the rendered input **not** the best_in_place span.
 - **:inner_class**: Class that is set to the rendered input.
 - **:display_as**: A **model** method which will be called in order to display this field. Cannot be used when using `display_with`.
 - **:display_with**: A **helper** method or proc will be called in order to display this field. Cannot be used with `display_as`.
@@ -97,9 +95,10 @@ Options:
 - **:value**: Customize the starting value of the inline input (defaults to to the field's value)
 - **:id**: The HTML id of the best_in_place span. If not specified one is automatically generated.
 - **:param**: If you wish to specific the object explicitly use this option.
-- **:confirm**: If set to true displays a confirmation message when abandoning changes (pressing the escape key);
+- **:confirm**: If set to true displays a confirmation message when abandoning changes (pressing the escape key).
+- **:skip_blur**: If set to true, blurring the input will not cause changes to be abandoned in textareas.
 
-HTML Options:  
+HTML Options:
 
 If you provide an option that is not explicitly a best_in_place option it will be passed through when creating the best_in_place span.
 
@@ -141,7 +140,7 @@ Examples (code in the views):
 
     <%= best_in_place @user, :name, :as => :input %>
 
-    <%= best_in_place @user, :name, :as => :input, :nil => "Click me to add content!" %>
+    <%= best_in_place @user, :name, :as => :input, :place_holder => "Click me to add content!" %>
 
 ### Textarea
 
@@ -161,10 +160,15 @@ The value will always be converted to a string for display.
 
 ### Checkbox
 
-    <%= best_in_place @user, :receive_emails, :as => :checkbox, :collection => ["No, thanks", "Yes, of course!"] %>
+    <%= best_in_place @user, :receive_emails, as: :checkbox, collection: ["No, thanks", "Yes, of course!"] %>
+    <%= best_in_place @user, :receive_emails, as: :checkbox, collection: {false: "Nope", true: "Yep"} %>
 
-The first value is always the negative boolean value and the second the positive. Structure: `["false value", "true value"]`.
+If you use array as a collection, the first value is always the negative boolean value and the second the positive. Structure: `["false value", "true value"]`.
 If not defined, it will default to *Yes* and *No* options.
+Default true and false values are stored in locales
+ 
+    t(:'best_in_place.yes', default: 'Yes')
+    t(:'best_in_place.no', default: 'No')
 
 ### Date
 
@@ -243,8 +247,8 @@ then bind to that class.
     <%= best_in_place @user, :name, :classes => 'highlight_on_success' %>
     <%= best_in_place @user, :mail, :classes => 'bounce_on_success' %>
 
-    $('.highlight_on_success').bind("ajax:success", function(){$(this).closest('tr').effect('highlight'));});
-    $('.bounce_on_success').bind("ajax:success", function(){$(this).closest('tr').effect('bounce'));});
+    $('.highlight_on_success').bind("ajax:success", function(){$(this).closest('tr').effect('highlight');});
+    $('.bounce_on_success').bind("ajax:success", function(){$(this).closest('tr').effect('bounce');});
 
 ### Providing data to the callback
 
@@ -328,6 +332,15 @@ And finally we need a controller:
 
 And this is how it is done!
 
+## Configuration
+
+You can configure some global options for best_in_place. Currently these options are available:
+
+    BestInPlace.configure do |config|
+      config.container = :div
+      config.skip_blur = true
+    end
+    
 
 ## Notification
 

data/gemfiles/rails_3.2.gemfile

@@ -18,6 +18,7 @@ gem "appraisal"
 gem "launchy"
 gem "rails", :github => "rails/rails", :branch => "3-2-stable"
 gem "strong_parameters"
+gem "test-unit"
 
 platforms :mri_21 do
   gem "byebug"

data/gemfiles/rails_4.0.gemfile

@@ -17,6 +17,7 @@ gem "sqlite3"
 gem "appraisal"
 gem "launchy"
 gem "rails", :github => "rails/rails", :branch => "4-0-stable"
+gem "test-unit"
 
 platforms :mri_21 do
   gem "byebug"

data/lib/assets/javascripts/best_in_place.js

@@ -120,11 +120,11 @@ BestInPlaceEditor.prototype = {
                 this.previousCollectionValue = value;
 
                 // search for the text for the span
-                editor.element.html(this.arrayToObject(this.values)[value]);
+                $.each(this.values, function(index, arr){ if (String(arr[0]) === String(value)) editor.element.html(arr[1]); });
                 break;
 
             case "checkbox":
-                editor.element.html(this.arrayToObject(this.values)[value]);
+                $.each(this.values, function(index, arr){ if (String(arr[0]) === String(value)) editor.element.html(arr[1]); });
                 break;
 
             default:
@@ -140,6 +140,7 @@ BestInPlaceEditor.prototype = {
         }
 
         editor.element.data('bipValue', value);
+        editor.element.attr('data-bip-value', value);
 
         editor.element.trigger(jQuery.Event("best_in_place:update"));
 
@@ -173,6 +174,7 @@ BestInPlaceEditor.prototype = {
             self.okButtonClass = self.okButtonClass || $parent.data("bipOkButtonClass");
             self.cancelButton = self.cancelButton || $parent.data("bipCancelButton");
             self.cancelButtonClass = self.cancelButtonClass || $parent.data("bipCancelButtonClass");
+            self.skipBlur = self.skipBlur || $parent.data("bipSkipBlur");
         });
 
         // Load own attributes (overrides all others)
@@ -186,18 +188,19 @@ BestInPlaceEditor.prototype = {
         self.okButtonClass = self.element.data("bipOkButtonClass") || self.okButtonClass || BestInPlaceEditor.defaults.okButtonClass;
         self.cancelButton = self.element.data("bipCancelButton") || self.cancelButton;
         self.cancelButtonClass = self.element.data("bipCancelButtonClass") || self.cancelButtonClass || BestInPlaceEditor.defaults.cancelButtonClass;
-        
+        self.skipBlur = self.element.data("bipSkipBlur") || self.skipBlur || BestInPlaceEditor.defaults.skipBlur;
+
         // Fix for default values of 0
         if (self.element.data("bipPlaceholder") == null) {
           self.placeHolder = BestInPlaceEditor.defaults.locales[''].placeHolder;
         } else {
           self.placeHolder = self.element.data("bipPlaceholder");
         }
-        
+
         self.inner_class = self.element.data("bipInnerClass");
         self.html_attrs = self.element.data("bipHtmlAttrs");
         self.original_content = self.element.data("bipOriginalContent") || self.original_content;
-        
+
         // if set the input won't be satinized
         self.display_raw = self.element.data("bip-raw");
 
@@ -220,6 +223,7 @@ BestInPlaceEditor.prototype = {
         'use strict';
         // TODO add placeholder for select and checkbox
         if (this.element.html() === "") {
+            this.element.addClass('bip-placeholder');
             this.element.html(this.placeHolder);
         }
     },
@@ -236,19 +240,6 @@ BestInPlaceEditor.prototype = {
         alert(BestInPlaceEditor.defaults.locales[''].uninitializedForm);
     },
 
-    arrayToObject: function(list, values) {
-        if (list == null) return {};
-        var result = {};
-        for (var i = 0, length = list.length; i < length; i++) {
-            if (values) {
-                result[list[i]] = values[i];
-            } else {
-                result[list[i][0]] = list[i][1];
-            }
-        }
-        return result;
-    },
-
     // Trim and Strips HTML from text
     sanitizeValue: function (s) {
         'use strict';
@@ -299,6 +290,7 @@ BestInPlaceEditor.prototype = {
                 this.element.html(response.display_as);
             }
         }
+        this.element.toggleClass('bip-placeholder', this.isPlaceHolder());
 
         this.element.trigger(jQuery.Event("best_in_place:success"), [data, status, xhr]);
         this.element.trigger(jQuery.Event("ajax:success"), [data, status, xhr]);
@@ -469,15 +461,17 @@ BestInPlaceEditor.forms = {
                     .attr('class', this.inner_class !== null ? this.inner_class : ''),
                 currentCollectionValue = this.collectionValue,
                 key, value,
-                a = this.arrayToObject(this.values);
-            for (key in a) {
-                value = a[key];
+                a = this.values;
+
+            $.each(a, function(index, arr){
+                key = arr[0];
+                value = arr[1];
                 var option_elt = jQuery(document.createElement('option'))
                     .val(key)
                     .html(value);
                 if (String(key) === String(currentCollectionValue)) option_elt.attr('selected', 'selected');
                 select_elt.append(option_elt);
-            };
+            });
             output.append(select_elt);
 
             this.element.html(output);
@@ -493,9 +487,9 @@ BestInPlaceEditor.forms = {
               var e = document.createEvent("MouseEvents");
               e.initMouseEvent("mousedown", true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
               this.element.find("select")[0].dispatchEvent(e);
-            } 
+            }
             catch(e) {
-              // browser doesn't support this, e.g. IE8 
+              // browser doesn't support this, e.g. IE8
             }
         },
 
@@ -569,7 +563,9 @@ BestInPlaceEditor.forms = {
                 this.element.find("input[type='button']").bind('click', {editor: this}, BestInPlaceEditor.forms.textarea.cancelButtonHandler);
             }
 
-            this.element.find("textarea").bind('blur', {editor: this}, BestInPlaceEditor.forms.textarea.blurHandler);
+            if (!this.skipBlur) {
+                this.element.find("textarea").bind('blur', {editor: this}, BestInPlaceEditor.forms.textarea.blurHandler);
+            }
             this.element.find("textarea").bind('keyup', {editor: this}, BestInPlaceEditor.forms.textarea.keyupHandler);
             this.blurTimer = null;
             this.userClicked = false;
@@ -631,7 +627,8 @@ BestInPlaceEditor.defaults = {
     ajaxMethod: "put",  //TODO Change to patch when support to 3.2 is dropped
     ajaxDataType: 'text',
     okButtonClass: '',
-    cancelButtonClass: ''
+    cancelButtonClass: '',
+    skipBlur: false
 };
 
 // Default locale

data/lib/best_in_place.rb

@@ -14,10 +14,11 @@ module BestInPlace
   end
 
   class Configuration
-    attr_accessor :container
+    attr_accessor :container, :skip_blur
 
     def initialize
       @container = :span
+      @skip_blur = false
     end
   end
 

data/lib/best_in_place/helper.rb

@@ -1,7 +1,7 @@
 module BestInPlace
   module Helper
     def best_in_place(object, field, opts = {})
-      
+
       best_in_place_assert_arguments(opts)
       type = opts[:as] || :input
       field = field.to_s
@@ -20,11 +20,8 @@ module BestInPlace
       if opts[:collection] or type == :checkbox
         collection = opts[:collection]
         value = value.to_s
-        collection = if collection.blank?
-          best_in_place_default_collection
-        else
-          best_in_place_collection_builder(type, collection)
-        end
+        collection = best_in_place_default_collection if collection.blank?
+        collection = best_in_place_collection_builder(type, collection)
         display_value = collection.flat_map{|a| a[0].to_s == value ? a[1] : nil }.compact[0]
         collection = collection.to_json
         options[:data]['bip-collection'] = html_escape(collection)
@@ -49,6 +46,8 @@ module BestInPlace
       options[:data]['bip-cancel-button-class'] = opts[:cancel_button_class].presence
       options[:data]['bip-original-content'] = html_escape(opts[:value] || value).presence
 
+      options[:data]['bip-skip-blur'] = opts.has_key?(:skip_blur) ? opts[:skip_blur].presence : BestInPlace.skip_blur
+
       options[:data]['bip-url'] = url_for(opts[:url] || object)
 
       options[:data]['bip-confirm'] = opts[:confirm].presence
@@ -133,68 +132,47 @@ module BestInPlace
       end
     end
 
-    def best_in_place_deprecated_options(args)
-      if deprecated_option = args.delete(:path)
-        args[:url] = deprecated_option
-        ActiveSupport::Deprecation.warn('[Best_in_place] :path is deprecated in favor of :url ')
-      end
-
-      if deprecated_option = args.delete(:object_name)
-        args[:param] = deprecated_option
-        ActiveSupport::Deprecation.warn('[Best_in_place] :object_name is deprecated in favor of :param ')
-      end
-
-      if deprecated_option = args.delete(:type)
-        args[:as] = deprecated_option
-        ActiveSupport::Deprecation.warn('[Best_in_place] :type is deprecated in favor of :as ')
-      end
-
-      if deprecated_option = args.delete(:classes)
-        args[:class] = deprecated_option
-        ActiveSupport::Deprecation.warn('[Best_in_place] :classes is deprecated in favor of :class ')
+    def best_in_place_deprecated_options(opts)
+      deprecations = [
+          {from: :path, to: :url},
+          {from: :object_name, to: :param},
+          {from: :type, to: :as},
+          {from: :classes, to: :class},
+          {from: :nil, to: :place_holder},
+          {from: :use_confirm, to: :confirm},
+          {from: :sanitize, to: :raw}
+      ]
+
+      deprecations.each do |deprecation|
+        if deprecated_option = opts.delete(deprecation[:from])
+          opts[deprecation[:from]] = deprecated_option
+          ActiveSupport::Deprecation.warn("[Best_in_place] :#{deprecation[:from]} is deprecated in favor of :#{deprecation[:to]} ")
+        end
       end
+    end
 
-      if deprecated_option = args.delete(:nil)
-        args[:place_holder] = deprecated_option
-        ActiveSupport::Deprecation.warn('[Best_in_place] :nil is deprecated in favor of :place_holder ')
-      end
+    def best_in_place_collection_builder(type, collection)
+      return Array(collection) if collection.is_a?(Hash)
 
-      if deprecated_option = args.delete(:use_confirm)
-        args[:confirm] = deprecated_option
-        ActiveSupport::Deprecation.warn('[Best_in_place] :use_confirm is deprecated in favor of :confirm ')
+      if type == :checkbox
+        best_in_place_collection_checkbox(collection)
+      else # :select
+        best_in_place_collection_select(collection)
       end
+    end
 
-      if deprecated_option = args.delete(:sanitize)
-        args[:raw] = !deprecated_option
-        ActiveSupport::Deprecation.warn('[Best_in_place] :sanitize is deprecated in favor of :raw ')
+    def best_in_place_collection_checkbox(collection)
+      if collection.length == 2
+        [['false', collection[0]], ['true', collection[1]]]
+      else
+        fail ArgumentError, '[Best_in_place] :collection array should have 2 values'
       end
     end
 
-    def best_in_place_collection_builder(type, collection)
-      collection = case collection
-        when Array
-          if type == :checkbox
-            if collection.length == 2
-              {'false' => collection[0], 'true' => collection[1]}.stringify_keys
-            else
-              fail ArgumentError, '[Best_in_place] :collection array should have 2 values'
-            end
-          else # :select
-            case collection[0]
-              when Array
-                collection
-              else
-                if collection[0].length == 2
-                  collection.to_a
-                else
-                  collection.each_with_index.map{|a,i| [i+1,a]}
-                end
-            end
-          end
-        else
-          collection.to_a
-      end
-      collection
+    def best_in_place_collection_select(collection)
+      return Array(collection) if collection[0].is_a?(Array) || collection[0].length == 2
+
+      collection.each_with_index.map { |a, i| [i+1, a] }
     end
 
     def best_in_place_default_collection

data/lib/best_in_place/version.rb

@@ -1,3 +1,3 @@
 module BestInPlace
-  VERSION = '3.0.3'
+  VERSION = '3.1.0'
 end

data/spec/helper_spec.rb

@@ -31,6 +31,12 @@ describe BestInPlace::Helper, type: :helper do
       expect(span).not_to be_empty
     end
 
+    it "should show deprecation warning" do
+      expect(ActiveSupport::Deprecation).to receive(:warn).with("[Best_in_place] :path is deprecated in favor of :url ")
+
+      helper.best_in_place @user, :name, path: "http://example.com"
+    end
+
     it "should not allow both display_as and display_with option" do
       expect { helper.best_in_place(@user, :money, :display_with => :number_to_currency, :display_as => :custom) }.to raise_error(ArgumentError)
     end
@@ -141,7 +147,7 @@ describe BestInPlace::Helper, type: :helper do
           span = nk.css("span")
           expect(span.text).to eq("")
         end
-        
+
       end
 
       it "should have the given inner_class" do
@@ -320,7 +326,7 @@ describe BestInPlace::Helper, type: :helper do
       end
 
       it "should have the default data-bip-collection" do
-        expect(@span.attribute("data-bip-collection").value).to eq("{\"true\":\"Yes\",\"false\":\"No\"}")
+        expect(@span.attribute("data-bip-collection").value).to eq("[[\"true\",\"Yes\"],[\"false\",\"No\"]]")
       end
 
       it "should render the current option as No" do
@@ -355,8 +361,8 @@ describe BestInPlace::Helper, type: :helper do
           expect(@span.text).to eq("Net")
         end
 
-        it "should render the proper data-bip-collection" do
-          expect(@span.attribute("data-bip-collection").value).to eq({false: @good_collection[0], true: @good_collection[1]}.to_json)
+        it 'should render the proper data-bip-collection' do
+          expect(@span.attribute('data-bip-collection').value).to eq([['false', @good_collection[0]], ['true', @good_collection[1]]].to_json)
         end
 
         it "should raise an argument error on bad collection" do
@@ -480,24 +486,24 @@ describe BestInPlace::Helper, type: :helper do
         end
 
       end
-      
+
       describe "with html parameters" do
         before do
           @attrs = {tabindex: 1, width: "300px", height: "24px"}
           nk = Nokogiri::HTML.parse(helper.best_in_place @user, :name, @attrs)
           @span = nk.css("span")
         end
-        
+
         it 'should pass through html attributes to the best_in_place span' do
           expect(@attrs.select {|key, value| @span.attribute(key.to_s) }).to eq(@attrs)
         end
-        
+
         it 'should have the proper values set' do
           expect(@attrs.map {|key, value| @span.attribute(key.to_s).value }).to eq(@attrs.map {|key, value| value.to_s })
         end
-        
+
       end
-      
+
     end
 
     context 'custom container' do
@@ -521,6 +527,30 @@ describe BestInPlace::Helper, type: :helper do
         BestInPlace.container = @old_container
       end
     end
+
+    context '.configure' do
+      describe 'skip_blur' do
+        before(:each) do
+          @old_skip_blur = BestInPlace.skip_blur
+          @user.save
+          BestInPlace.skip_blur  = true
+        end
+
+        after(:each) do
+          BestInPlace.skip_blur = @old_skip_blur
+        end
+
+        it 'should override blur globally' do
+          nk = Nokogiri::HTML.parse(helper.best_in_place(@user, :name))
+          expect(nk.css("span").attribute("data-bip-skip-blur").value).to eq("true")
+        end
+
+        it 'should use helper params' do
+          nk = Nokogiri::HTML.parse(helper.best_in_place(@user, :name, skip_blur: false))
+          expect(nk.css("span").attribute("data-bip-skip-blur")).to be_nil
+        end
+      end
+    end
   end
 
   describe "#best_in_place_if" do

data/spec/integration/js_spec.rb

@@ -111,6 +111,17 @@ describe "JS behaviour", :js => true do
     end
   end
 
+  it 'should update the DOM when a field value changes' do
+    @user.save!
+    visit user_path(@user)
+
+    expect(find('#receive_email')).to have_content('No thanks')
+
+    bip_bool @user, :receive_email
+
+    expect(page).to have_selector('#receive_email span[data-bip-value=true]')
+  end
+
   it "should be able to update last but one item in list" do
     @user.save!
     @user2 = User.create :name => "Test",
@@ -193,7 +204,7 @@ describe "JS behaviour", :js => true do
 
     expect(find('#country')).to have_content('Italy')
 
-    bip_select @user, :country, "France"
+    bip_select @user, :country, 'France'
 
     expect(find('#country')).to have_content('France')
 
@@ -264,6 +275,22 @@ describe "JS behaviour", :js => true do
     expect(find('#birth_date')).to have_content(today.beginning_of_month.strftime('%d-%m-%Y'))
   end
 
+  it "should be able to use bip_bool to change the default boolean values" do
+    @user.save!
+    visit user_path(@user)
+
+
+    expect(find('#receive_email_default')).to have_content('No')
+
+    bip_bool @user, :receive_email_default
+
+    expect(find('#receive_email_default')).to have_content('Yes')
+
+    visit user_path(@user)
+
+    expect(find('#receive_email_default')).to have_content('Yes')
+  end
+
   it "should be able to use bip_bool to change a boolean value" do
     @user.save!
     visit user_path(@user)

data/spec/internal/app/models/user.rb

@@ -17,6 +17,7 @@ class User < ActiveRecord::Base
 
   alias_attribute :money_custom, :money
   alias_attribute :money_value, :money
+  alias_attribute :receive_email_default, :receive_email
   alias_attribute :receive_email_image, :receive_email
   alias_attribute :description_simple, :description
 

data/spec/internal/app/views/users/show.html.erb

@@ -52,10 +52,16 @@
         <%= best_in_place @user, :country, as: :select, :collection => @countries, :inner_class => :some_class %>
       </td>
     </tr>
+    <tr>
+      <td>Receive newsletter? (default display)</td>
+      <td id="receive_email_default">
+        <%= best_in_place @user, :receive_email_default, as: :checkbox %>
+      </td>
+    </tr>
     <tr>
       <td>Receive newsletter?</td>
       <td id="receive_email">
-        <%= best_in_place @user, :receive_email, as: :checkbox, collection: {'false' => "No thanks", 'true' => "Yes of course"} %>
+        <%= best_in_place @user, :receive_email, as: :checkbox, collection: ['No thanks', 'Yes of course'] %>
       </td>
     </tr>
     <tr>
@@ -137,7 +143,7 @@
         <%= best_in_place @user, :zero_field, place_holder: 0 %>
       </td>
     </tr>
-    
+
   </table>
   <br/>
   <hr/>

data/spec/internal/config/initializers/countries.rb

@@ -1,4 +1,4 @@
-COUNTRIES_HASH = { 1 => 'Spain', 2 => 'Italy', 3 => 'Germany', 4 => 'France' }
+COUNTRIES_HASH = { 1 => 'Spain', 3 => 'Germany', 2 => 'Italy', 4 => 'France' }
 COUNTRIES_HASH_STRING_KEYS = { es: 'Spain', it: 'Italy', de: 'Germany', fr: 'France' }
 COUNTRIES_ARRAY = %w(Spain Italy Germany France)
 COUNTRIES_ARRAY_OF_ARRAYS = [[1, 'Spain'], [3, 'Germany'], [2, 'Italy'], [4, 'France']]

data/vendor/assets/javascripts/jquery.purr.js

@@ -53,7 +53,7 @@
       // Set up the close button
       var close = document.createElement('a');
       jQuery(close).attr({
-          class: 'close',
+          'class': 'close',
           href: '#close'
           }).appendTo(notice).click(function() {
               removeNotice();

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: best_in_place
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.1.0
 platform: ruby
 authors:
 - Bernat Farrero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-26 00:00:00.000000000 Z
+date: 2015-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -158,7 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: It makes any field in place editable by clicking on it, it works for inputs,