best_in_place 3.0.1 → 3.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a7128e2317c366f2b4b3c07523f9a7007c9d441f
-  data.tar.gz: cd010b383a647c68f71c91ec0bc6351da8777be3
+  metadata.gz: e5e84415483a33f06ae8ad58a61c1659b185568e
+  data.tar.gz: eb2b9be33ed3f859f29222028b4143ec05b8c582
 SHA512:
-  metadata.gz: acb6ef8c4bf474ac43408fb12c0c37cee42c4fbb4dde9419ab3abb415ba32f29d45de261129036712fc46fcd09d48b0957a7986c90ea5e80e5edfcc273c85521
-  data.tar.gz: f64607487b57f5531b5d789df4cc168d07344e0282c0660492f16e477344d3a3efe191c6083ba17060c855973ecdfca492363a0fd4d71e0ea6322579781dfbe2
+  metadata.gz: 5403e603dd30cd6d28be3e39ba6bec7a2c407918a7b8759da50712fcdce2fd9af5b59e69eacde956d21086c6ccbbee7980aa1fe2d1d0dbeaeb2c1f8c68269e92
+  data.tar.gz: ea7dc137ed0816109d9debb3b7782349d6fcf7a587c66725eab2e6ddc3a5ac1006dba2170e2c8ca7a6e8a58b990c86dcb530d104d6f85c79b043f8f2b818971f

data/.gitignore

@@ -11,3 +11,4 @@ spec/internal/tmp/**/*
 
 .rvmrc
 coverage
+tmp

data/.travis.yml

@@ -1,7 +1,10 @@
 language: ruby
+sudo: false
+cache: bundler
 rvm:
+  - 2.1
   - 1.9.3
-  - 2.1.2
+  - 2.2
   - rbx-2
 
 env: "RAILS_ENV=test DISPLAY=:99.0"
@@ -9,6 +12,7 @@ gemfile:
   - gemfiles/rails_3.2.gemfile
   - gemfiles/rails_4.0.gemfile
   - gemfiles/rails_4.1.gemfile
+  - gemfiles/rails_4.2.gemfile
   - gemfiles/rails_edge.gemfile
 
 matrix:

data/Appraisals

@@ -1,14 +1,18 @@
 appraise "rails-3.2" do
-  gem 'rails', '3.2.19'
+  gem 'rails', github: "rails/rails", branch: '3-2-stable'
   gem 'strong_parameters'
 end
 
 appraise "rails-4.0" do
-  gem "rails", "~> 4.0.0"
+  gem "rails", github: "rails/rails", branch: '4-0-stable'
 end
 
 appraise "rails-4.1" do
-  gem "rails", "~> 4.1.0"
+  gem "rails", github: "rails/rails", branch: '4-1-stable'
+end
+
+appraise "rails-4.2" do
+  gem "rails", github: "rails/rails", branch: '4-2-stable'
 end
 
 appraise "rails-edge" do

data/README.md

@@ -77,8 +77,7 @@ Params:
 Options:
 
 - **:type** It can be only [:input, :textarea, :select, :checkbox, :date (>= 1.0.4)] or if undefined it defaults to :input.
-- **:collection**: If you are using the :select type then you must specify the collection of values it takes as a hash where keys represent the display text and values are the option's value when selected. If you are
-  using the :checkbox type you can specify the two values it can take, or otherwise they will default to Yes and No.
+- **:collection**: If you are using the :select type then you must specify the collection of values it takes as a hash where values represent the display text and keys are the option's value when selected. If you are using the :checkbox type you can specify the two values it can take, or otherwise they will default to Yes and No.
 - **:url**: URL to which the updating action will be sent. If not defined it defaults to the :object path.
 - **:place_holder**: The nil param defines the content displayed in case no value is defined for that field. It can be something like "click me to edit".
   If not defined it will show *"-"*.
@@ -88,18 +87,30 @@ Options:
 - **:cancel_button**: (Inputs and textareas only) If set to a string, then a Cancel button will be shown with the string as its label.
 - **:cancel_button_class**: (Inputs and textareas only) Specifies any extra classes to set on the Cancel button.
 - **:sanitize**: True by default. If set to false the input/textarea will accept html tags.
-- **:html_attrs**: Hash of html arguments, such as maxlength, default-value etc.
+- **:html_attrs**: Hash of html arguments such as maxlength, default-value, etc. that will be set on the rendered input **not** the best_in_place span.  
 - **:inner_class**: Class that is set to the rendered input.
-- **:display_as**: A model method which will be called in order to display
-  this field.
+- **:display_as**: A **model** method which will be called in order to display this field. Cannot be used when using `display_with`.
+- **:display_with**: A **helper** method or proc will be called in order to display this field. Cannot be used with `display_as`.
+- **:helper_options**: A hash of parameters to be sent to the helper method specified by `display_with`.
 - **:as**: Used for overriding the default params key used for the object (the data-object attribute). Useful for e.g. STI scenarios where best_in_place should post to a common controller for different models.
 - **:data**: Hash of custom data attributes to be added to span. Can be used to provide data to the ajax:success callback.
 - **:class**: Additional classes to apply to the best_in_place span.  Accepts either a string or Array of strings
 - **:value**: Customize the starting value of the inline input (defaults to to the field's value)
+- **:id**: The HTML id of the best_in_place span. If not specified one is automatically generated.
+- **:param**: If you wish to specific the object explicitly use this option.
+- **:confirm**: If set to true displays a confirmation message when abandoning changes (pressing the escape key);
+
+HTML Options:  
+
+If you provide an option that is not explicitly a best_in_place option it will be passed through when creating the best_in_place span.
+
+So, for instance, if you want to add an HTML tab index to the best_in_place span just add it to your method call:
+
+    <%= best_in_place @user, :name, tabindex: "1" %>
 
 ###best_in_place_if
 **best_in_place_if condition, object, field, OPTIONS**
-see also **best_in_place_unless
+see also **best_in_place_unless**
 
 It allows us to use best_in_place only if the first new parameter, a
 condition, is satisfied. Specifically:
@@ -123,7 +134,7 @@ It is a very useful feature to use with, for example, [Ryan Bates](https://githu
 
 ---
 
-##Examples
+## Examples
 
 Examples (code in the views):
 
@@ -142,9 +153,12 @@ Examples (code in the views):
 ### Select
 
     <%= best_in_place @user, :country, :type => :select, :collection => {"1" => "Spain", "2" => "Italy", "3" => "Germany", "4" => "France"} %>
+    <%= best_in_place @user, :country, :type => :select, :collection => { es: 'Spain', it: 'Italy', de: 'Germany', fr: 'France' } %>
+    <%= best_in_place @user, :country, :type => :select, :collection => %w(Spain Italy Germany France) %>
+    <%= best_in_place @user, :country, :type => :select, :collection => [[1, 'Spain'], [3, 'Germany'], [2, 'Italy'], [4, 'France']] %>
 
 Of course it can take an instance or global variable for the collection, just remember the structure is a hash.
-The key will always be converted to a string for display. *
+The value will always be converted to a string for display.
 
 ### Checkbox
 
@@ -269,7 +283,7 @@ In the view, we'd do:
           th= flavour
       - sizes.each do |size|
         tr
-          %th= size
+          th= size
           - flavours.each do |flavour|
             - v = @ice_cream.get_stock(flavour: flavour, size: size)
             td= best_in_place v, :to_i, type: :input, url: set_stock_ice_cream_path(flavour: flavour, size: size)
@@ -353,8 +367,11 @@ Fork the project on [github](https://github.com/bernat/best_in_place 'bernat / b
 
 ### Run the specs
 
+    $ appraisal
     $ appraisal rspec
 
+You many need to install appraisal: `gem install appraisal`
+
 ---
 
 ##Test Helpers

data/config.ru

@@ -3,5 +3,28 @@ require 'bundler'
 
 Bundler.require :default, :development
 
-Combustion.initialize! :active_record
+Combustion.initialize! :active_record do
+  if ENV['RACK_ENV'] == 'development'
+    config.assets.debug = true
+  end
+end
+
+if ENV['RACK_ENV'] == 'development'
+  User.create! :name => "Lucia",
+               :last_name => "Napoli",
+               :email => "lucianapoli@gmail.com",
+               :height => "h51",
+               :address => "Via Roma 99",
+               :zip => "25123",
+               :country => "2",
+               :receive_email => false,
+               :birth_date => Time.now.utc,
+               :money => 100,
+               :money_proc => 100,
+               :favorite_color => 'Red',
+               :favorite_books => "The City of Gold and Lead",
+               :description => "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus a lectus et lacus ultrices auctor. Morbi aliquet convallis tincidunt. Praesent enim libero, iaculis at commodo nec, fermentum a dolor. Quisque eget eros id felis lacinia faucibus feugiat et ante. Aenean justo nisi, aliquam vel egestas vel, porta in ligula. Etiam molestie, lacus eget tincidunt accumsan, elit justo rhoncus urna, nec pretium neque mi et lorem. Aliquam posuere, dolor quis pulvinar luctus, felis dolor tincidunt leo, eget pretium orci purus ac nibh. Ut enim sem, suscipit ac elementum vitae, sodales vel sem.",
+               :favorite_movie => "The Hitchhiker's Guide to the Galaxy"
+end
 run Combustion::Application
+

data/gemfiles/rails_3.2.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 source "https://rails-assets.org"
 
+gem "activerecord"
 gem "rails-assets-jquery", "1.11.1"
 gem "rails-assets-jquery-ui", "1.10.4"
 gem "rdiscount"
@@ -15,7 +16,7 @@ gem "poltergeist"
 gem "sqlite3"
 gem "appraisal"
 gem "launchy"
-gem "rails", "3.2.19"
+gem "rails", :github => "rails/rails", :branch => "3-2-stable"
 gem "strong_parameters"
 
 platforms :mri_21 do

data/gemfiles/rails_4.0.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 source "https://rails-assets.org"
 
+gem "activerecord"
 gem "rails-assets-jquery", "1.11.1"
 gem "rails-assets-jquery-ui", "1.10.4"
 gem "rdiscount"
@@ -15,7 +16,7 @@ gem "poltergeist"
 gem "sqlite3"
 gem "appraisal"
 gem "launchy"
-gem "rails", "~> 4.0.0"
+gem "rails", :github => "rails/rails", :branch => "4-0-stable"
 
 platforms :mri_21 do
   gem "byebug"

data/gemfiles/rails_4.1.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 source "https://rails-assets.org"
 
+gem "activerecord"
 gem "rails-assets-jquery", "1.11.1"
 gem "rails-assets-jquery-ui", "1.10.4"
 gem "rdiscount"
@@ -15,7 +16,7 @@ gem "poltergeist"
 gem "sqlite3"
 gem "appraisal"
 gem "launchy"
-gem "rails", "~> 4.1.0"
+gem "rails", :github => "rails/rails", :branch => "4-1-stable"
 
 platforms :mri_21 do
   gem "byebug"

data/gemfiles/rails_4.2.gemfile

@@ -0,0 +1,25 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+source "https://rails-assets.org"
+
+gem "activerecord"
+gem "rails-assets-jquery", "1.11.1"
+gem "rails-assets-jquery-ui", "1.10.4"
+gem "rdiscount"
+gem "rspec-rails"
+gem "nokogiri"
+gem "combustion"
+gem "sprockets-rails"
+gem "capybara"
+gem "poltergeist"
+gem "sqlite3"
+gem "appraisal"
+gem "launchy"
+gem "rails", :github => "rails/rails", :branch => "4-2-stable"
+
+platforms :mri_21 do
+  gem "byebug"
+end
+
+gemspec :path => "../"

data/gemfiles/rails_edge.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 source "https://rails-assets.org"
 
+gem "activerecord"
 gem "rails-assets-jquery", "1.11.1"
 gem "rails-assets-jquery-ui", "1.10.4"
 gem "rdiscount"

data/lib/assets/javascripts/best_in_place.jquery-ui.js

@@ -18,6 +18,7 @@ BestInPlaceEditor.forms.date = {
                 .attr('type', 'text')
                 .attr('name', this.attributeName)
                 .attr('value', this.sanitizeValue(this.display_value));
+                
         if (this.inner_class !== null) {
             input_elt.addClass(this.inner_class);
         }

data/lib/assets/javascripts/best_in_place.js

@@ -120,12 +120,11 @@ BestInPlaceEditor.prototype = {
                 this.previousCollectionValue = value;
 
                 // search for the text for the span
-                jQuery.each(this.values, function (i, v) {
-                        if (String(value) === String(i)) {
-                            editor.element.html(v);
-                        }
-                    }
-                );
+                var key, val, _i, _len, _ref, a;
+                for (_i = 0, a = this.values, _len = a.length; _i < _len; _i++) {
+                    _ref = a[_i], key = _ref[0], val = _ref[1];
+                    if (String(value) === String(key)) editor.element.html(val);
+                };
                 break;
 
             case "checkbox":
@@ -191,17 +190,23 @@ BestInPlaceEditor.prototype = {
         self.okButtonClass = self.element.data("bipOkButtonClass") || self.okButtonClass || BestInPlaceEditor.defaults.okButtonClass;
         self.cancelButton = self.element.data("bipCancelButton") || self.cancelButton;
         self.cancelButtonClass = self.element.data("bipCancelButtonClass") || self.cancelButtonClass || BestInPlaceEditor.defaults.cancelButtonClass;
-        self.placeHolder = self.element.data("bipPlaceholder") || BestInPlaceEditor.defaults.locales[''].placeHolder;
+        
+        // Fix for default values of 0
+        if (self.element.data("bipPlaceholder") == null) {
+          self.placeHolder = BestInPlaceEditor.defaults.locales[''].placeHolder;
+        } else {
+          self.placeHolder = self.element.data("bipPlaceholder");
+        }
+        
         self.inner_class = self.element.data("bipInnerClass");
         self.html_attrs = self.element.data("bipHtmlAttrs");
         self.original_content = self.element.data("bipOriginalContent") || self.original_content;
-
+        
         // if set the input won't be satinized
         self.display_raw = self.element.data("bip-raw");
 
         self.useConfirm = self.element.data("bip-confirm");
 
-
         if (self.formType === "select" || self.formType === "checkbox") {
             self.values = self.collection;
             self.collectionValue = self.element.data("bipValue") || self.collectionValue;
@@ -453,17 +458,18 @@ BestInPlaceEditor.forms = {
                 selected = '',
                 select_elt = jQuery(document.createElement('select'))
                     .attr('class', this.inner_class !== null ? this.inner_class : ''),
-                currentCollectionValue = this.collectionValue;
-
-            jQuery.each(this.values, function (key, value) {
+                currentCollectionValue = this.collectionValue,
+                a, key, value, _i, _len, _ref;
+            for (_i = 0, a = this.values, _len = a.length; _i < _len; _i++) {
+                _ref = a[_i], key = _ref[0], value = _ref[1];
                 var option_elt = jQuery(document.createElement('option'))
                     .val(key)
                     .html(value);
-                if (key === String(currentCollectionValue)) {
+                if (String(key) === String(currentCollectionValue)) {
                     option_elt.attr('selected', 'selected');
-                }
+                };
                 select_elt.append(option_elt);
-            });
+            };
             output.append(select_elt);
 
             this.element.html(output);
@@ -472,6 +478,17 @@ BestInPlaceEditor.forms = {
             this.element.find("select").bind('blur', {editor: this}, BestInPlaceEditor.forms.select.blurHandler);
             this.element.find("select").bind('keyup', {editor: this}, BestInPlaceEditor.forms.select.keyupHandler);
             this.element.find("select")[0].focus();
+
+            // automatically click on the select so you
+            // don't have to click twice
+            try {
+              var e = document.createEvent("MouseEvents");
+              e.initMouseEvent("mousedown", true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
+              this.element.find("select")[0].dispatchEvent(e);
+            } 
+            catch(e) {
+              // browser doesn't support this, e.g. IE8 
+            }
         },
 
         getValue: function () {

data/lib/best_in_place/helper.rb

@@ -1,6 +1,7 @@
 module BestInPlace
   module Helper
     def best_in_place(object, field, opts = {})
+      
       best_in_place_assert_arguments(opts)
       type = opts[:as] || :input
       field = field.to_s
@@ -19,26 +20,21 @@ module BestInPlace
       if opts[:collection] or type == :checkbox
         collection = opts[:collection]
         value = value.to_s
-        case type
-          when :checkbox
-            if collection.blank?
-              collection = best_in_place_default_collection
-            else
-              collection = best_in_place_collection_builder(type, collection)
-            end
-            display_value = collection[value]
-            collection = collection.to_json
-          else # :select
-            collection = best_in_place_collection_builder(type, collection)
-            display_value = collection[value]
-            collection = collection.to_json
+        collection = if collection.blank?
+          best_in_place_default_collection
+        else
+          best_in_place_collection_builder(type, collection)
         end
+        display_value = collection.flat_map{|a| a[0].to_s == value ? a[1] : nil }.compact[0]
+        collection = collection.to_json
         options[:data]['bip-collection'] = html_escape(collection)
       end
 
       options[:class] = ['best_in_place'] + Array(opts[:class] || opts[:classes])
       options[:id] = opts[:id] || BestInPlace::Utils.build_best_in_place_id(real_object, field)
 
+      pass_through_html_options(opts, options)
+
       options[:data]['bip-activator'] = opts[:activator].presence
 
       options[:data]['bip-html-attrs'] = opts[:html_attrs].to_json unless opts[:html_attrs].blank?
@@ -82,6 +78,16 @@ module BestInPlace
 
     private
 
+    def pass_through_html_options(opts, options)
+      known_keys = [:id, :type, :nil, :classes, :collection, :data,
+                    :activator, :cancel_button, :cancel_button_class, :html_attrs, :inner_class, :nil,
+                    :object_name, :ok_button, :ok_button_class, :display_as, :display_with, :path, :value,
+                    :use_confirm, :confirm, :sanitize, :raw, :helper_options, :url, :place_holder, :class,
+                    :as, :param, :container]
+      uknown_keys = opts.keys - known_keys
+      uknown_keys.each { |key| options[key] = opts[key] }
+    end
+
     def best_in_place_build_value_for(object, field, opts)
       klass = object.class
       if opts[:display_as]
@@ -102,8 +108,6 @@ module BestInPlace
           if field_value.blank?
             ''
           else
-
-
             BestInPlace::ViewHelpers.send(opts[:display_with], field_value)
           end
         end
@@ -118,12 +122,6 @@ module BestInPlace
     end
 
     def best_in_place_assert_arguments(args)
-      args.assert_valid_keys(:id, :type, :nil, :classes, :collection, :data,
-                             :activator, :cancel_button, :cancel_button_class, :html_attrs, :inner_class, :nil,
-                             :object_name, :ok_button, :ok_button_class, :display_as, :display_with, :path, :value,
-                             :use_confirm, :confirm, :sanitize, :raw, :helper_options, :url, :place_holder, :class,
-                             :as, :param, :container)
-
       best_in_place_deprecated_options(args)
 
       if args[:display_as] && args[:display_with]
@@ -177,17 +175,26 @@ module BestInPlace
         when Array
           if type == :checkbox
             if collection.length == 2
-              {'false' => collection[0], 'true' => collection[1]}
+              {'false' => collection[0], 'true' => collection[1]}.stringify_keys
             else
               fail ArgumentError, '[Best_in_place] :collection array should have 2 values'
             end
           else # :select
-            Hash[(1...collection.size+1).zip collection]
+            case collection[0]
+              when Array
+                collection
+              else
+                if collection[0].length == 2
+                  collection.to_a
+                else
+                  collection.each_with_index.map{|a,i| [i+1,a]}
+                end
+            end
           end
         else
-          collection
+          collection.to_a
       end
-      collection.stringify_keys
+      collection
     end
 
     def best_in_place_default_collection

data/lib/best_in_place/version.rb

@@ -1,3 +1,3 @@
 module BestInPlace
-  VERSION = '3.0.1'
+  VERSION = '3.0.2'
 end

data/spec/helper_spec.rb

@@ -123,12 +123,12 @@ describe BestInPlace::Helper, type: :helper do
         end
       end
 
-      describe "nil option" do
-        it "should have no nil data by default" do
+      describe "placeholder option" do
+        it "should have no placeholder data by default" do
           expect(@span.attribute("data-bip-placeholder")).to be_nil
         end
 
-        it "should show '' if the object responds with nil for the passed attribute" do
+        it "should show '' if the object responds with placeholder for the passed attribute" do
           expect(@user).to receive(:name).twice.and_return("")
           nk = Nokogiri::HTML.parse(helper.best_in_place @user, :name)
           span = nk.css("span")
@@ -141,6 +141,7 @@ describe BestInPlace::Helper, type: :helper do
           span = nk.css("span")
           expect(span.text).to eq("")
         end
+        
       end
 
       it "should have the given inner_class" do
@@ -338,7 +339,7 @@ describe BestInPlace::Helper, type: :helper do
         end
 
         it "should render the proper data-bip-collection" do
-          expect(@span.attribute("data-bip-collection").value).to eq(@collection.to_json)
+          expect(@span.attribute("data-bip-collection").value).to eq(@collection.to_a.to_json)
         end
       end
 
@@ -370,6 +371,7 @@ describe BestInPlace::Helper, type: :helper do
         @countries_hash = COUNTRIES_HASH
         @countries_hash_string_keys = COUNTRIES_HASH_STRING_KEYS
         @countries_array = COUNTRIES_ARRAY
+        @countries_array_of_arrays = COUNTRIES_ARRAY_OF_ARRAYS
         @apostrophe_countries_hash = COUNTRIES_APOSTROPHE_HASH
         @apostrophe_countries_array = COUNTRIES_APOSTROPHE_ARRAY
       end
@@ -385,7 +387,7 @@ describe BestInPlace::Helper, type: :helper do
         end
 
         it 'should have a proper data collection' do
-          expect(@span.attribute('data-bip-collection').value).to eq(@countries_hash.to_json)
+          expect(@span.attribute('data-bip-collection').value).to eq(@countries_hash.to_a.to_json)
         end
 
         it 'should show the current country' do
@@ -405,7 +407,7 @@ describe BestInPlace::Helper, type: :helper do
           end
 
           it 'should have a proper data collection' do
-            expect(@span.attribute('data-bip-collection').value).to eq(@countries_hash_string_keys.to_json)
+            expect(@span.attribute('data-bip-collection').value).to eq(@countries_hash_string_keys.to_a.to_json)
           end
 
           it 'should show the current country' do
@@ -424,7 +426,7 @@ describe BestInPlace::Helper, type: :helper do
           end
 
           it 'should have a proper data collection' do
-            expect(@span.attribute('data-bip-collection').value).to eq(@apostrophe_countries_hash.to_json)
+            expect(@span.attribute('data-bip-collection').value).to eq(@apostrophe_countries_hash.to_a.to_json)
           end
         end
       end
@@ -436,7 +438,7 @@ describe BestInPlace::Helper, type: :helper do
         end
 
         it 'should have a proper data collection' do
-          expect(@span.attribute('data-bip-collection').value).to eq(@countries_hash.to_json)
+          expect(@span.attribute('data-bip-collection').value).to eq(@countries_array.each_with_index.map{|a,i| [i+1,a]}.to_json)
         end
 
         it 'should show the current country' do
@@ -454,10 +456,48 @@ describe BestInPlace::Helper, type: :helper do
           end
 
           it 'should have a proper data collection' do
-            expect(@span.attribute('data-bip-collection').value).to eq(@apostrophe_countries_hash.to_json)
+            expect(@span.attribute('data-bip-collection').value).to eq(@apostrophe_countries_array.each_with_index.map{|a,i| [i+1,a]}.to_json)
           end
         end
       end
+
+      describe 'with an array parameter' do
+        before do
+          nk = Nokogiri::HTML.parse(helper.best_in_place @user, :country, as: :select, collection: @countries_array_of_arrays)
+          @span = nk.css('span')
+        end
+
+        it 'should have a proper data collection' do
+          expect(@span.attribute('data-bip-collection').value).to eq(@countries_array_of_arrays.to_json)
+        end
+
+        it 'should show the current country' do
+          expect(@span.text).to eq('Italy')
+        end
+
+        it 'should include the proper data-bip-value' do
+          expect(@span.attribute('data-bip-value').value).to eq('2')
+        end
+
+      end
+      
+      describe "with html parameters" do
+        before do
+          @attrs = {tabindex: 1, width: "300px", height: "24px"}
+          nk = Nokogiri::HTML.parse(helper.best_in_place @user, :name, @attrs)
+          @span = nk.css("span")
+        end
+        
+        it 'should pass through html attributes to the best_in_place span' do
+          expect(@attrs.select {|key, value| @span.attribute(key.to_s) }).to eq(@attrs)
+        end
+        
+        it 'should have the proper values set' do
+          expect(@attrs.map {|key, value| @span.attribute(key.to_s).value }).to eq(@attrs.map {|key, value| value.to_s })
+        end
+        
+      end
+      
     end
 
     context 'custom container' do

data/spec/integration/placeholder_spec.rb

@@ -0,0 +1,26 @@
+# encoding: utf-8
+
+describe "Placeholder behavior", :js => true do
+  before do
+    @user = User.new name: "Zero",
+      last_name: "My Hero",
+      address: "0 Nowhere lane",
+      email: "zero@zero.com",
+      height: "0",
+      zip: "00000",
+      description: ""                    
+  end
+
+  it "should set a place_holder value" do
+    @user.save!
+    visit user_path(@user)
+    expect(find('#favorite_locale')).to have_content("N/A")
+  end
+
+  it "should allow the use of 0 for a placeholder" do
+    @user.save!
+    visit user_path(@user)
+    expect(find('#zero_field')).to have_content("0")
+  end
+
+end

data/spec/internal/app/views/users/show.html.erb

@@ -102,7 +102,7 @@
     <tr>
       <td>Money</td>
       <td id="money">
-        <%= best_in_place @user, :money, :display_with => :number_to_currency %>
+        <%= best_in_place @user, :money, :display_with => :number_to_currency%>
       </td>
     </tr>
     <tr>
@@ -131,6 +131,13 @@
         <%= best_in_place @user, :favorite_movie, opts %>
       </td>
     </tr>
+    <tr>
+      <td>Zero Field</td>
+      <td id="zero_field">
+        <%= best_in_place @user, :zero_field, place_holder: 0 %>
+      </td>
+    </tr>
+    
   </table>
   <br/>
   <hr/>

data/spec/internal/config/initializers/countries.rb

@@ -1,5 +1,6 @@
 COUNTRIES_HASH = { 1 => 'Spain', 2 => 'Italy', 3 => 'Germany', 4 => 'France' }
 COUNTRIES_HASH_STRING_KEYS = { es: 'Spain', it: 'Italy', de: 'Germany', fr: 'France' }
 COUNTRIES_ARRAY = %w(Spain Italy Germany France)
+COUNTRIES_ARRAY_OF_ARRAYS = [[1, 'Spain'], [3, 'Germany'], [2, 'Italy'], [4, 'France']]
 COUNTRIES_APOSTROPHE_HASH = {1 => "Joe's Country", 2 => "Bob's Country"}
 COUNTRIES_APOSTROPHE_ARRAY = ["Joe's Country", "Bob's Country"]

data/spec/internal/db/schema.rb

@@ -22,5 +22,6 @@ ActiveRecord::Schema.define do
     t.string   "height"
     t.string   "favorite_movie"
     t.string   "favorite_locale"
+    t.integer  "zero_field"
   end
 end

data/spec/support/retry_on_timeout.rb

@@ -2,6 +2,6 @@ def retry_on_timeout(n = 3, &block)
   block.call
 rescue => e
   fail if n.zero?
-  puts "Catched error: #{e.message}. #{n-1} more attempts."
+  puts "Caught error: #{e.message}. #{n-1} more attempts."
   retry_on_timeout(n - 1, &block)
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: best_in_place
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.0.2
 platform: ruby
 authors:
 - Bernat Farrero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-11 00:00:00.000000000 Z
+date: 2014-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -61,6 +61,7 @@ files:
 - gemfiles/rails_3.2.gemfile
 - gemfiles/rails_4.0.gemfile
 - gemfiles/rails_4.1.gemfile
+- gemfiles/rails_4.2.gemfile
 - gemfiles/rails_edge.gemfile
 - lib/assets/javascripts/best_in_place.jquery-ui.js
 - lib/assets/javascripts/best_in_place.js
@@ -78,6 +79,7 @@ files:
 - spec/integration/double_init_spec.rb
 - spec/integration/js_spec.rb
 - spec/integration/live_spec.rb
+- spec/integration/placeholder_spec.rb
 - spec/integration/text_area_spec.rb
 - spec/internal/app/assets/images/info.png
 - spec/internal/app/assets/images/no.png