besepa 0.8.6 → 0.8.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a69fb821a543b03151aa6b529d545838b8bea1ad
-  data.tar.gz: 775acc212a6c94171d2cd84731d320a5df8c9484
+  metadata.gz: b0dfd1d5b9656509abbc89b489589aec737a23a8
+  data.tar.gz: 95352c75920428600705bd74aad2c6ce822932ec
 SHA512:
-  metadata.gz: bb03cc4a74b6fcfb4027457c96d0111e7adadcffffe308256dd5dcfdecbe54f811451a143bcdf220683ddebc2c7ad6dad23a33c35a09a40cfae6d1f937cb5f92
-  data.tar.gz: ff0320336c6c294d9f9be247dbe2db5da1f7ac72308bbe4985942ee50946c81d946bcfb9e47d690a9d70692ee46c9256a74ffcd79cfa44a5c5770cb9827a472f
+  metadata.gz: ad025815d2dbc5d503f1b297a23497d52359b2696cc621a3a62439a3bba597af529e24470f0866cb9afe5b2349c76f75eb81b6721fcddcb1a2c636d0aede648e
+  data.tar.gz: c39b99a2cac7aa30881e7c5b7276bd02e6ce0b8bf7677f8fd44469f9983c2fc72667c894df4027d4e6ab79e2e779801d64b7e8e623b49b9988156f79667cdccb

data/besepa-ruby.gemspec

@@ -26,4 +26,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.1'
   spec.add_development_dependency 'webmock', '~> 1.20'
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "byebug"
 end

data/lib/besepa/api_calls/create.rb

@@ -1,26 +1,18 @@
 module Besepa
-    
   module ApiCalls
-    
     module Create
-
       module ClassMethods
-        
         def create(params, filters={})
           payload = {}
           payload[klass_name] = params
           response = post "/#{api_path(filters)}", payload
           self.new(response['response'])
         end
-        
       end
 
       def self.included(base)
         base.extend(ClassMethods)
       end
-    
     end
-    
   end
-  
 end

data/lib/besepa/business_account.rb

@@ -4,14 +4,14 @@ module Besepa
     include Besepa::ApiCalls::List
     include Besepa::ApiCalls::Create
     include Besepa::ApiCalls::Update
-
-    FIELDS = [:id, :iban, :bic, :bank_name, :status, :default,
-              :core_enabled, :core_suffix, :b2b_enabled, :b2b_suffix,
-              :created_at, :authorization, :line_amount, :retention_days,
-              :debit_cost, :rejection_cost, :core_future_risk,
-              :core_amount_at_risk, :b2b_future_risk, :b2b_amount_at_risk,
+            
+    FIELDS = [:id, :iban, :bic, :bank_name, :status, :default, 
+              :core_enabled, :core_suffix, :b2b_enabled, :b2b_suffix, :created_at, :authorization,
+              :limit_core, :limit_b2b, :retention_days, :debit_cost, :rejection_cost,
+              :core_future_risk, :core_current_risk, :b2b_future_risk, :b2b_current_risk,
               :financed]
 
+
     FIELDS.each do |f|
       attr_accessor f
     end

data/lib/besepa/errors/besepa_error.rb

@@ -1,28 +1,23 @@
 module Besepa
 
   module Errors
-    
     class BesepaError < StandardError
-      
       attr_reader :error
       attr_reader :description
       attr_reader :http_status
       attr_reader :messages
 
       def initialize(error=nil, description=nil, http_status=nil, messages=nil)
-        @messages = messages
+        @messages    = messages
         @http_status = http_status
         @description = description
-        @error = error
+        @error       = error
       end
 
       def to_s
         status_string = @http_status.nil? ? "" : "(Status #{@http_status}) "
         "#{status_string}#{@error} (#{@description})"
       end
-      
     end
-  
   end
-
-end
+end

data/lib/besepa/errors/invalid_resource_error.rb

@@ -1,11 +1,6 @@
 module Besepa
-
   module Errors
-    
     class InvalidResourceError < BesepaError
-      
     end
-  
   end
-
 end

data/lib/besepa/errors/resource_not_found_error.rb

@@ -1,11 +1,6 @@
 module Besepa
-
   module Errors
-    
     class ResourceNotFoundError < BesepaError
-      
     end
-  
   end
-
 end

data/lib/besepa/report.rb

@@ -0,0 +1,27 @@
+module Besepa
+
+  class Report < Besepa::Resource
+
+    include Besepa::ApiCalls::List
+    include Besepa::ApiCalls::Create
+    include Besepa::ApiCalls::Search
+
+    FIELDS = [:id, :until_at, :since_at, :kind, :created_at,
+              :document_file_name, :document_file_size, :status]
+
+    FIELDS.each do |f|
+      attr_accessor f
+    end
+
+    def self.klass_name
+      "report"
+    end
+
+
+    def download_url
+      response = get "/#{self.class.api_path}/#{CGI.escape(id)}/download"
+      response["response"]["url"]
+    end
+
+  end
+end

data/lib/besepa/utils/version.rb

@@ -1,6 +1,6 @@
 module Besepa
 
   module Utils
-    VERSION = '0.8.6'.freeze
+    VERSION = '0.8.7'.freeze
   end
 end

data/spec/besepa/bank_account_spec.rb

@@ -0,0 +1,134 @@
+require 'helper'
+
+describe Besepa::BankAccount do
+
+  describe '#all' do
+    before do
+      stub_get('/bank_accounts?page=1').
+        to_return(body:    fixture('bank_accounts.json'),
+                  headers: { content_type: 'application/json; charset=utf-8' })
+    end
+
+    it 'returns a list of bank_accounts' do
+      bank_accounts = Besepa::BankAccount.all(page: 1)
+      expect(bank_accounts).to respond_to(:each)
+      expect(bank_accounts.first).to be_an Besepa::BankAccount
+      expect(bank_accounts.size).to eq(1)
+      expect(bank_accounts.per_page).to eq(30)
+      expect(bank_accounts.current_page).to eq(1)
+      expect(bank_accounts.total).to eq(1)
+      expect(bank_accounts.pages).to eq(1)
+    end
+  end
+
+  describe '#find' do
+    before do
+      stub_get('/bank_accounts/ban12345').
+        to_return(body:    fixture('bank_account.json'),
+                  headers: { content_type: 'application/json; charset=utf-8' })
+    end
+
+    it 'returns a bank account' do
+      bank_account = Besepa::BankAccount.find('ban12345')
+      expect(bank_account).to be_an Besepa::BankAccount
+      expect(bank_account.iban).to eq("ES6012345678050000000001")
+    end
+  end
+
+  describe '#create' do
+    before do
+      stub_post('/bank_accounts').with(
+      body: { "bank_account": {
+        "bank_name":    "Test Bank",
+        "bic":          "TESTXXX",
+        "iban":         "ES6012345678050000000001",
+        "b2b_enabled":  "false",
+        "b2b_suffix":   "000",
+        "core_enabled": "true",
+        "core_suffix":  "000"
+      }}.to_json).to_return(
+        body:    fixture('bank_account.json'),
+        headers: {content_type: 'application/json; charset=utf-8'})
+    end
+
+    it 'returns a bank_account' do
+      bank_account = Besepa::BankAccount.create({
+        "bank_name":    "Test Bank",
+        "bic":          "TESTXXX",
+        "iban":         "ES6012345678050000000001",
+        "b2b_enabled":  "false",
+        "b2b_suffix":   "000",
+        "core_enabled": "true",
+        "core_suffix":  "000"
+      })
+      expect(bank_account).to be_an Besepa::BankAccount
+      expect(bank_account.iban).to eq("ES6012345678050000000001")
+    end
+  end
+
+  describe '.generate_signature_request' do
+    describe 'with creditor account' do
+      before do
+        stub_get('/bank_accounts/ban12345').to_return(
+          body:    fixture('bank_account.json'),
+          headers: {content_type: 'application/json; charset=utf-8'})
+
+
+        stub_put('/bank_accounts/ban12345/generate_signature_request').to_return(
+          body:    fixture('bank_account.json'),
+          headers: {content_type: 'application/json; charset=utf-8'})
+      end
+
+      it 'returns a bank_account' do
+        bank_account = Besepa::BankAccount.find('ban12345')
+        result = bank_account.generate_signature_request
+        expect(result).to be_an Besepa::BankAccount
+        expect(result.iban).to eq("ES6012345678050000000001")
+      end
+    end
+    describe 'with no creditor account' do
+      before do
+      stub_get('/bank_accounts/ban12345').to_return(
+        body:    fixture('bank_account.json'),
+        headers: {content_type: 'application/json; charset=utf-8'})
+
+      stub_put('/bank_accounts/ban12345/generate_signature_request').to_return(
+        status:  409,
+        body: { error: "missing_creditor",
+                error_description: "Status: no puede ser activada sin una cuenta de destino"
+        }.to_json,
+        headers: {content_type: 'application/json; charset=utf-8'}
+      )
+      end
+      it 'raises error' do
+        bank_account = Besepa::BankAccount.find('ban12345')
+        expect {
+          bank_account.generate_signature_request
+        }.to raise_error(Besepa::Errors::BesepaError,
+                         /no puede ser activada sin una cuenta de destino/)
+      end
+    end
+    describe 'when already signed' do
+      before do
+      stub_get('/bank_accounts/ban12345').to_return(
+        body:    fixture('bank_account.json'),
+        headers: {content_type: 'application/json; charset=utf-8'})
+
+      stub_put('/bank_accounts/ban12345/generate_signature_request').to_return(
+        status:  409,
+        body: { error: "already_signed",
+                error_description: "Status: el mandato ya ha sido firmado"
+        }.to_json,
+        headers: {content_type: 'application/json; charset=utf-8'}
+      )
+      end
+      it 'raises error' do
+        bank_account = Besepa::BankAccount.find('ban12345')
+        expect {
+          bank_account.generate_signature_request
+        }.to raise_error(Besepa::Errors::BesepaError,
+                         /ya ha sido firmado/)
+      end
+    end
+  end
+end

data/spec/besepa/customer_spec.rb

@@ -24,7 +24,7 @@ describe Besepa::Customer do
       stub_get('/customers/cus12345').to_return(body: fixture('customer.json'), headers: {content_type: 'application/json; charset=utf-8'})
     end
 
-    it 'returns a a customer' do
+    it 'returns a customer' do
       customer = Besepa::Customer.find('cus12345')
       expect(customer).to be_an Besepa::Customer
       expect(customer.name).to eq("Pancho Villa SLU")
@@ -54,7 +54,7 @@ describe Besepa::Customer do
       stub_put('/customers/cus12345').to_return(body: fixture('customer.json'), headers: {content_type: 'application/json; charset=utf-8'})
     end
 
-    it 'returns a a customer' do
+    it 'returns a customer' do
       customer = Besepa::Customer.find('cus12345')
       customer.name = customer.name.reverse
       customer = customer.save
@@ -69,7 +69,7 @@ describe Besepa::Customer do
       stub_delete('/customers/cus12345').to_return(body: fixture('customer_removed.json'), headers: {content_type: 'application/json; charset=utf-8'})
     end
 
-    it 'returns a a customer' do
+    it 'returns a customer' do
       customer = Besepa::Customer.find('cus12345')
       customer.name = customer.name.reverse
       customer = customer.destroy

data/spec/besepa/report_spec.rb

@@ -0,0 +1,63 @@
+require 'helper'
+
+describe Besepa::Report do
+
+ describe '#all' do
+    before do
+      stub_get('/reports?page=1').to_return(body: fixture('reports.json'), headers: {content_type: 'application/json; charset=utf-8'})
+    end
+
+    it 'returns a list of reports' do
+      reports = Besepa::Report.all(page: 1)
+      expect(reports).to respond_to(:each)
+      expect(reports.first).to be_an Besepa::Report
+      expect(reports.size).to eq(3)
+      expect(reports.per_page).to eq(30)
+      expect(reports.current_page).to eq(1)
+      expect(reports.total).to eq(3)
+      expect(reports.pages).to eq(1)
+    end
+  end
+
+  describe '#find' do
+    before do
+      stub_get('/reports/rep123456789').to_return(body: fixture('report.json'), headers: {content_type: 'application/json; charset=utf-8'})
+    end
+
+    it 'returns a report' do
+      report = Besepa::Report.find('rep123456789')
+      expect(report).to be_an Besepa::Report
+      expect(report.kind).to eq("FullExcelReports")
+      expect(report.status).to eq("GENERATED")
+    end
+  end
+
+  describe '#search' do
+    before do
+      stub_get('/reports/search?field=group_id&value=foo&page=1').to_return(body: fixture('reports.json'), headers: {content_type: 'application/json; charset=utf-8'})
+    end
+
+    it 'returs a list of reports' do
+      reports = Besepa::Report.search(field: 'group_id', value: 'foo', page: 1)
+      expect(reports).to respond_to(:each)
+      expect(reports.first).to be_an Besepa::Report
+      expect(reports.size).to eq(3)
+      expect(reports.per_page).to eq(30)
+      expect(reports.current_page).to eq(1)
+      expect(reports.total).to eq(3)
+      expect(reports.pages).to eq(1)
+    end
+  end
+
+  describe '#download_url' do
+    before do
+      stub_get("/reports/rep123456789").to_return(body: fixture('report.json'), headers: {content_type: 'application/json; charset=utf-8'})
+      stub_get("/reports/rep123456789/download").to_return(body: fixture('report_url.json'), headers: {content_type: 'application/json; charset=utf-8'})
+    end
+
+    it "returns download url" do
+      report = Besepa::Report.find('rep123456789')
+      expect(report.download_url).to eq("url_s3")
+    end
+  end
+end

data/spec/fixtures/bank_account.json

@@ -0,0 +1,15 @@
+{
+  "response": {
+    "id": "ban12345",
+    "iban": "ES6012345678050000000001",
+    "bic": "TESTXXX",
+    "bank_name": "Banco Test",
+    "status": "PENDING_MANDATE",
+    "default": true,
+    "created_at": "2016-08-26T10:52:28.000+02:00",
+    "b2b_enabled": true,
+    "b2b_suffix": "001",
+    "core_enabled": true,
+    "core_suffix": "000"
+  }
+}

data/spec/fixtures/bank_accounts.json

@@ -0,0 +1,26 @@
+{
+  "response": [
+    {
+      "id": "ban12345",
+      "iban": "ES6012345678050000000001",
+      "bic": "TESTXXX",
+      "bank_name": "Banco Test",
+      "status": "PENDING_MANDATE",
+      "default": true,
+      "created_at": "2016-08-26T10:52:28.000+02:00",
+      "b2b_enabled": true,
+      "b2b_suffix": "001",
+      "core_enabled": true,
+      "core_suffix": "000"
+    }
+  ],
+  "count": 1,
+  "pagination": {
+    "previous": null,
+    "next": null,
+    "current": 1,
+    "per_page": 30,
+    "count": 1,
+    "pages": 1
+  }
+}

data/spec/fixtures/report.json

@@ -0,0 +1,13 @@
+{
+  "response": {
+    "id": "rep123456789",
+    "kind": "FullExcelReports",
+    "status": "GENERATED",
+    "until_at": "2017-07-14",
+    "since_at": "2017-07-14",
+    "document_file_name": "README.md",
+    "document_file_size": 2345,
+    "created_at": "2017-08-08T13:31:59.000+02:00",
+    "updated_at": "2017-08-08T13:31:59.000+02:00"
+  }
+}

data/spec/fixtures/report_url.json

@@ -0,0 +1,5 @@
+{
+  "response": {
+    "url": "url_s3"
+  }
+}

data/spec/fixtures/reports.json

@@ -0,0 +1,46 @@
+{
+  "response": [
+    {
+      "id": "rep835c463c1d7783",
+      "until_at": "2017-07-14",
+      "since_at": "2017-07-14",
+      "kind": "FullExcelReports",
+      "status": "QUEUED",
+      "document_file_name": "README.md",
+      "document_file_size": 2345,
+      "created_at": "2017-08-08T13:31:59.000+02:00",
+      "updated_at": "2017-08-08T13:31:59.000+02:00"
+    },
+    {
+      "id": "rep4bd6790cd1706d",
+      "until_at": "2017-07-14",
+      "since_at": "2017-07-14",
+      "kind": "FullExcelReports",
+      "status": "QUEUED",
+      "document_file_name": "README.md",
+      "document_file_size": 2345,
+      "created_at": "2017-08-08T13:31:59.000+02:00",
+      "updated_at": "2017-08-08T13:31:59.000+02:00"
+    },
+    {
+      "id": "repecd4f6592d0054",
+      "until_at": "2017-07-14",
+      "since_at": "2017-07-14",
+      "kind": "FullExcelReports",
+      "status": "QUEUED",
+      "document_file_name": "README.md",
+      "document_file_size": 2345,
+      "created_at": "2017-08-08T13:31:59.000+02:00",
+      "updated_at": "2017-08-08T13:31:59.000+02:00"
+    }
+  ],
+  "count": 3,
+  "pagination": {
+    "previous": null,
+    "next": null,
+    "current": 1,
+    "per_page": 30,
+    "count": 3,
+    "pages": 1
+  }
+}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: besepa
 version: !ruby/object:Gem::Version
-  version: 0.8.6
+  version: 0.8.7
 platform: ruby
 authors:
 - besepa.com
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-14 00:00:00.000000000 Z
+date: 2018-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Ruby client for besepa.com
 email:
 - alberto@besepa.com
@@ -127,6 +141,7 @@ files:
 - lib/besepa/payment.rb
 - lib/besepa/product.rb
 - lib/besepa/remittance.rb
+- lib/besepa/report.rb
 - lib/besepa/resource.rb
 - lib/besepa/subscription.rb
 - lib/besepa/user.rb
@@ -135,9 +150,13 @@ files:
 - lib/besepa/utils/request.rb
 - lib/besepa/utils/version.rb
 - lib/besepa/webhook.rb
+- spec/besepa/bank_account_spec.rb
 - spec/besepa/customer_spec.rb
 - spec/besepa/group_spec.rb
+- spec/besepa/report_spec.rb
 - spec/besepa/subscription_spec.rb
+- spec/fixtures/bank_account.json
+- spec/fixtures/bank_accounts.json
 - spec/fixtures/collection.json
 - spec/fixtures/customer.json
 - spec/fixtures/customer_add_debit.json
@@ -145,6 +164,9 @@ files:
 - spec/fixtures/customer_debits.json
 - spec/fixtures/customer_removed.json
 - spec/fixtures/customers.json
+- spec/fixtures/report.json
+- spec/fixtures/report_url.json
+- spec/fixtures/reports.json
 - spec/fixtures/resource.json
 - spec/helper.rb
 homepage: http://www.besepa.com
@@ -167,14 +189,18 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Ruby client for besepa.com
 test_files:
+- spec/besepa/bank_account_spec.rb
 - spec/besepa/customer_spec.rb
 - spec/besepa/group_spec.rb
+- spec/besepa/report_spec.rb
 - spec/besepa/subscription_spec.rb
+- spec/fixtures/bank_account.json
+- spec/fixtures/bank_accounts.json
 - spec/fixtures/collection.json
 - spec/fixtures/customer.json
 - spec/fixtures/customer_add_debit.json
@@ -182,5 +208,8 @@ test_files:
 - spec/fixtures/customer_debits.json
 - spec/fixtures/customer_removed.json
 - spec/fixtures/customers.json
+- spec/fixtures/report.json
+- spec/fixtures/report_url.json
+- spec/fixtures/reports.json
 - spec/fixtures/resource.json
 - spec/helper.rb