berns 4.1.0 → 4.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb2de0ba05a5e234fa5cef7edf3a222411222d0743c0e69492c1e1d5e53541bb
-  data.tar.gz: f62f2273f787a46aa18784b668f1110adb80a1bbb8c33226c9c58e585d5acec7
+  metadata.gz: 9332f5ed53d3722052cc33ff3796a47555a50586e89512df69ac2f314dec592c
+  data.tar.gz: 381ebd539a72cb79925554928cb11503104beae42b3ec5f4566e973ac4647409
 SHA512:
-  metadata.gz: 7d8fb46aeb4dc948729b36bbb6a794625618c34742ee2b18024d1cde99bda330b21bd7fb890bd241010a9b60e956c81fe401c3036464a90d28fb4ebca11ba621
-  data.tar.gz: c7c430ae90da5be3b93f15d1ac6ab2bba300b89558cfb131af276b2af9d2e82b118fa0691000402bf7e982e13406defc275c786e2e512304041f660afe0b53cc
+  metadata.gz: 6001d1682311fffcddebb1d6cfefa7d9094386dae315d6d5b2d3a4a36a34ebdb97f9e5721c74b5f7dc4d8bfc1118fbf6c417f7bcc38f79c7158144729fe7909a
+  data.tar.gz: 7fce9c7ca12b3fec44c75902e3724ef6f4d6b11d77855e77864326bb4b1b3d8f53f47b45b99b59b70a37fe6f06199abf79cee317d2f28a0ff7931530f996cf87

data/README.org

@@ -215,20 +215,22 @@ area base br col embed hr img input link menuitem meta param source track wbr
 
 ** Performance
 
-Berns 3 is about three times faster than the pure Ruby implementation used in
-version 2. See the file [[file:benchmarks/performance.rb][benchmarks/performance.rb]] for the benchmark code.
+Berns 3 was a total rewrite from a pure Ruby implementation to one powered by a
+C extension. That rewrite is about three times faster than the pure Ruby
+implementation used in version 2. See the file [[file:benchmarks/performance.rb][benchmarks/performance.rb]] for the
+benchmark code.
 
 #+begin_example
 Warming up --------------------------------------
-             element    27.373k i/100ms
-               berns    94.118k i/100ms
+                ruby    27.521k i/100ms
+               c-ext    74.915k i/100ms
 Calculating -------------------------------------
-             element    314.078k (± 4.5%) i/s -      1.588M in   5.065539s
-               berns    935.528k (± 6.1%) i/s -      4.706M in   5.049718s
+                ruby    275.913k (± 1.0%) i/s -      1.404M in   5.087516s
+               c-ext    813.113k (± 1.0%) i/s -      4.120M in   5.067902s
 
 Comparison:
-               berns:   935527.9 i/s
-             element:   314078.4 i/s - 2.98x  (± 0.00) slower
+               c-ext:   813113.3 i/s
+                ruby:   275913.5 i/s - 2.95x  (± 0.00) slower
 #+end_example
 
 ** Trivia

data/ext/berns/berns.c

@@ -357,7 +357,20 @@ static char * hash_value_to_attribute(const char *attr, const size_t attrlen, VA
     free(combined);
   }
 
-  return destination;
+  /*
+   * Reallocate destination to final size. This is generally a reduction in the
+   * allocated memory since we chunk allocations in 256 byte multiples.
+   */
+  char *rightsizeddest = realloc(destination, occupied + 1);
+
+  if (rightsizeddest == NULL) {
+    free(destination);
+    rb_raise(rb_eNoMemError, "Berns could not allocate sufficient memory.");
+  }
+
+  rightsizeddest[occupied] = '\0';
+
+  return rightsizeddest;
 }
 
 /*
@@ -452,6 +465,9 @@ static VALUE external_to_attributes(RB_UNUSED_VAR(VALUE self), VALUE attributes)
   return rstring;
 }
 
+/*
+ * Create a void element i.e. one without children/content.
+ */
 static char * void_element(const char *tag, size_t tlen, VALUE attributes) {
   const char *empty = "";
   char *attrs = hash_value_to_attribute(empty, 0, attributes);
@@ -478,6 +494,8 @@ static char * void_element(const char *tag, size_t tlen, VALUE attributes) {
 
   ptr = stecpy(ptr, tag_close, end);
 
+  free(attrs);
+
   return dest;
 }
 

data/lib/berns/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Berns
-  VERSION = '4.1.0'
+  VERSION = '4.1.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: berns
 version: !ruby/object:Gem::Version
-  version: 4.1.0
+  version: 4.1.2
 platform: ruby
 authors:
 - Taylor Beck
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-06-14 00:00:00.000000000 Z
+date: 2022-10-24 00:00:00.000000000 Z
 dependencies: []
 description: A utility library for generating HTML strings.
 email: