berkshelf 7.0.8 → 8.0.0

data/spec/config/knife.rb

@@ -4,7 +4,7 @@ node_name                "berkshelf"
 client_key               File.expand_path("spec/config/berkshelf.pem")
 validation_client_name   "validator"
 validation_key           File.expand_path("spec/config/validator.pem")
-chef_server_url          "http://localhost:26310"
+chef_server_url          "http://127.0.0.1:26310"
 cache_type               "BasicFile"
-cache_options( path: "#{ENV['HOME']}/.chef/checksums" )
+cache_options( path: "#{ENV["HOME"]}/.chef/checksums" )
 cookbook_path []

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@ def windows?
   !!(RUBY_PLATFORM =~ /mswin|mingw|windows/)
 end
 
-BERKS_SPEC_DATA = File.expand_path("../data", __FILE__)
+BERKS_SPEC_DATA = File.expand_path("data", __dir__)
 
 require "rspec"
 require "cleanroom/rspec"

data/spec/support/chef_server.rb

@@ -10,11 +10,11 @@ module Berkshelf
         attr_reader :server
 
         def clear_request_log
-          @request_log = Array.new
+          @request_log = []
         end
 
         def request_log
-          @request_log ||= Array.new
+          @request_log ||= []
         end
 
         def server_url

data/spec/support/git.rb

@@ -5,7 +5,7 @@ module Berkshelf
       include Berkshelf::RSpec::PathHelpers
 
       def git_origin_for(repo, options = {})
-        "file://#{generate_fake_git_remote("git@github.com/RiotGames/#{repo}.git", options)}/.git"
+        "file://#{generate_fake_git_remote("git@github.com/chef/#{repo}.git", options)}/.git"
       end
 
       def generate_fake_git_remote(uri, options = {})
@@ -84,26 +84,26 @@ module Berkshelf
 
       private
 
-        # The path to store the local git clones.
-        #
-        # @return [Pathname]
+      # The path to store the local git clones.
+      #
+      # @return [Pathname]
       def clones
         ensure_and_return(tmp_path.join("clones"))
       end
 
-        # The path to store the git remotes.
-        #
-        # @return [Pathname]
+      # The path to store the git remotes.
+      #
+      # @return [Pathname]
       def remotes
         ensure_and_return(tmp_path.join("remotes"))
       end
 
-        # Generate a cookbook by the given name.
-        #
-        # @param [#to_s] name
-        #   the name of the cookbook to create
-        # @param [Hash] options
-        #   the list ooptions to pass to the generator
+      # Generate a cookbook by the given name.
+      #
+      # @param [#to_s] name
+      #   the name of the cookbook to create
+      # @param [Hash] options
+      #   the list ooptions to pass to the generator
       def generate_git_cookbook(name, options = {})
         options = {
           skip_vagrant: true,
@@ -114,12 +114,12 @@ module Berkshelf
         Berkshelf::Cli.new.invoke(:cookbook, [name.to_s], options)
       end
 
-        # Make sure the given path exists and return the path
-        #
-        # @param [#to_s] path
-        #   the path to create and return
-        #
-        # @return [Pathname]
+      # Make sure the given path exists and return the path
+      #
+      # @param [#to_s] path
+      #   the path to create and return
+      #
+      # @return [Pathname]
       def ensure_and_return(path)
         FileUtils.mkdir(path) unless File.exist?(path)
         Pathname.new(path).expand_path

data/spec/support/path_helpers.rb

@@ -50,10 +50,10 @@ module Berkshelf
 
       private
 
-        # This is the magical "reset" function that gives us a clean working
-        # directory on each run.
-        #
-        # @return [nil]
+      # This is the magical "reset" function that gives us a clean working
+      # directory on each run.
+      #
+      # @return [nil]
       def reload_configs
         Berkshelf.chef_config = chef_config
 

data/spec/tmp/berkshelf/cookbooks/fake-0.1.0/metadata.rb

@@ -0,0 +1,2 @@
+name     'fake'
+version  '0.1.0'

data/spec/tmp/berkshelf/cookbooks/fake-0.2.0/metadata.rb

@@ -0,0 +1,2 @@
+name     'fake'
+version  '0.2.0'

data/spec/tmp/berkshelf/cookbooks/fake-1.0.0/metadata.rb

@@ -0,0 +1,2 @@
+name     'fake'
+version  '1.0.0'

data/spec/unit/berkshelf/berksfile_spec.rb

@@ -200,10 +200,10 @@ describe Berkshelf::Berksfile do
 
   describe "#dependencies" do
     let(:groups) do
-      [
-        :nautilus,
-        :skarner,
-      ]
+      %i{
+        nautilus
+        skarner
+      }
     end
 
     it "returns all Berkshelf::Dependencys added to the instance of Berksfile" do
@@ -235,8 +235,8 @@ describe Berkshelf::Berksfile do
   describe "#groups" do
     before do
       allow(subject).to receive(:dependencies) { [dependency_one, dependency_two] }
-      allow(dependency_one).to receive(:groups) { [:nautilus, :skarner] }
-      allow(dependency_two).to receive(:groups) { [:nautilus, :riven] }
+      allow(dependency_one).to receive(:groups) { %i{nautilus skarner} }
+      allow(dependency_two).to receive(:groups) { %i{nautilus riven} }
     end
 
     it "returns a hash containing keys for every group a dependency is a member of" do
@@ -255,7 +255,7 @@ describe Berkshelf::Berksfile do
   describe "#add_dependency" do
     let(:name) { "cookbook_one" }
     let(:constraint) { "= 1.2.0" }
-    let(:options) { Hash.new }
+    let(:options) { {} }
 
     before(:each) do
       subject.add_dependency(name, constraint, options)

data/spec/unit/berkshelf/berkshelf/api_client/chef_server_connection_spec.rb

@@ -0,0 +1,65 @@
+require "spec_helper"
+
+describe Berkshelf::APIClient::ChefServerConnection do
+  let(:instance) do
+    described_class.new(
+      server_url: "https://chef.example.org/organizations/foobar",
+      timeout: 30,
+      open_timeout: 3,
+      ssl: {}
+    )
+  end
+
+  describe "#universe" do
+    before do
+      body_response = %q{{"ruby":{"1.2.3":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"},"2.0.0":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}},"elixir":{"1.0.0":{"endpoint_priority":0,"platforms":{"CentOS":"= 6.0.0"},"dependencies":{},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}}}}
+
+      stub_request(:get, "https://chef.example.org/organizations/foobar/universe")
+        .to_return(status: 200, body: body_response, headers: { "Content-Type" => "application/json; charset=utf-8" })
+    end
+
+    subject { instance.universe }
+
+    it "returns an array of APIClient::RemoteCookbook" do
+      expect(subject).to be_a(Array)
+
+      subject.each do |remote|
+        expect(remote).to be_a(Berkshelf::APIClient::RemoteCookbook)
+      end
+    end
+
+    it "contains a item for each dependency" do
+      expect(subject.size).to eq(3)
+      expect(subject[0].name).to eql("ruby")
+      expect(subject[0].version).to eql("1.2.3")
+      expect(subject[1].name).to eql("ruby")
+      expect(subject[1].version).to eql("2.0.0")
+      expect(subject[2].name).to eql("elixir")
+      expect(subject[2].version).to eql("1.0.0")
+    end
+
+    it "has the dependencies for each" do
+      expect(subject[0].dependencies).to include("build-essential" => ">= 1.2.2")
+      expect(subject[1].dependencies).to include("build-essential" => ">= 1.2.2")
+      expect(subject[2].dependencies).to be_empty
+    end
+
+    it "has the platforms for each" do
+      expect(subject[0].platforms).to be_empty
+      expect(subject[1].platforms).to be_empty
+      expect(subject[2].platforms).to include("CentOS" => "= 6.0.0")
+    end
+
+    it "has a location_path for each" do
+      subject.each do |remote|
+        expect(remote.location_path).to_not be_nil
+      end
+    end
+
+    it "has a location_type for each" do
+      subject.each do |remote|
+        expect(remote.location_type).to_not be_nil
+      end
+    end
+  end
+end

data/spec/unit/berkshelf/cli_spec.rb

@@ -13,8 +13,7 @@ module Berkshelf
     describe "#upload" do
       it "calls to upload with params if passed in cli" do
         expect(berksfile).to receive(:upload).with(cookbooks,
-          include(skip_syntax_check: true, freeze: false)
-        )
+          include(skip_syntax_check: true, freeze: false))
 
         subject.options[:skip_syntax_check] = true
         subject.options[:no_freeze]         = true

data/spec/unit/berkshelf/community_rest_spec.rb

@@ -68,7 +68,7 @@ describe Berkshelf::CommunityREST do
     let(:archive) { double("archive", path: "/foo/bar", unlink: true) }
 
     before do
-      allow(subject).to receive(:stream).with(any_args()).and_return(archive)
+      allow(subject).to receive(:stream).with(any_args).and_return(archive)
       allow(Berkshelf::CommunityREST).to receive(:unpack)
         .and_return("/some/path")
     end

data/spec/unit/berkshelf/core_ext/file_utils_spec.rb

@@ -7,12 +7,12 @@ describe FileUtils do
     let(:options) { {} }
 
     it "uses mv by default" do
-      expect(FileUtils).to receive(:old_mv).with(src, dest, options)
+      expect(FileUtils).to receive(:old_mv).with(src, dest, **options)
       FileUtils.mv(src, dest, options)
     end
 
     it "replaces mv with cp_r and rm_rf" do
-      expect(FileUtils).to receive(:cp_r).with(src, dest, options)
+      expect(FileUtils).to receive(:cp_r).with(src, dest, **options)
       expect(FileUtils).to receive(:rm_rf).with(src)
 
       FileUtils.mv(src, dest, options)

data/spec/unit/berkshelf/dependency_spec.rb

@@ -35,7 +35,7 @@ describe Berkshelf::Dependency do
       end
 
       context "given a location key :git" do
-        let(:url) { "git://url_to_git" }
+        let(:url) { "https://url_to_git" }
         let(:source) { described_class.new(berksfile, cookbook_name, git: url) }
 
         it "initializes a GitLocation for location" do
@@ -71,7 +71,7 @@ describe Berkshelf::Dependency do
         end
 
         context "given a group option containing an array of groups" do
-          let(:groups) { [ :development, :test ] }
+          let(:groups) { %i{development test} }
           let(:source) { described_class.new(berksfile, cookbook_name, group: groups) }
 
           it "assigns all the groups to the group attribute" do
@@ -95,24 +95,24 @@ describe Berkshelf::Dependency do
   describe "#add_group" do
     it "stores strings as symbols" do
       subject.add_group "foo"
-      expect(subject.groups).to eq([:default, :foo])
+      expect(subject.groups).to eq(%i{default foo})
     end
 
     it "does not store duplicate groups" do
       subject.add_group "bar"
       subject.add_group "bar"
       subject.add_group :bar
-      expect(subject.groups).to eq([:default, :bar])
+      expect(subject.groups).to eq(%i{default bar})
     end
 
     it "adds multiple groups" do
       subject.add_group "baz", "quux"
-      expect(subject.groups).to eq([:default, :baz, :quux])
+      expect(subject.groups).to eq(%i{default baz quux})
     end
 
     it "handles multiple groups as an array" do
       subject.add_group %w{baz quux}
-      expect(subject.groups).to eq([:default, :baz, :quux])
+      expect(subject.groups).to eq(%i{default baz quux})
     end
   end
 

data/spec/unit/berkshelf/downloader_spec.rb

@@ -5,14 +5,12 @@ module Berkshelf
     let(:berksfile) do
       double(Berksfile,
         lockfile: lockfile,
-        dependencies: []
-      )
+        dependencies: [])
     end
 
     let(:lockfile) do
       double(Lockfile,
-        graph: graph
-      )
+        graph: graph)
     end
 
     let(:graph) { double(Lockfile::Graph, locks: {}) }
@@ -124,15 +122,13 @@ module Berkshelf
             cookbook_copyright: "user",
             cookbook_email: "user@example.com",
             cookbook_license: "apachev2",
-            trusted_certs_dir: self_signed_crt_path
-          )
+            trusted_certs_dir: self_signed_crt_path)
         end
 
         let(:berkshelf_config) do
           double(Config,
             ssl:  double(verify: true),
-            chef: chef_config
-          )
+            chef: chef_config)
         end
 
         before do

data/spec/unit/berkshelf/location_spec.rb

@@ -11,7 +11,7 @@ module Berkshelf
       end
 
       it "finds a :git location by key" do
-        instance = described_class.init(dependency, git: "git://foo.com/meats/bacon.git")
+        instance = described_class.init(dependency, git: "https://foo.com/meats/bacon.git")
         expect(instance).to be_a(GitLocation)
       end
 

data/spec/unit/berkshelf/locations/base_spec.rb

@@ -46,8 +46,7 @@ module Berkshelf
         let(:cookbook) do
           double("cookbook",
             cookbook_name: "cookbook",
-            version: "0.1.0"
-          )
+            version: "0.1.0")
         end
 
         before do

data/spec/unit/berkshelf/locations/git_spec.rb

@@ -104,11 +104,10 @@ module Berkshelf
 
       context "when the repository is cached" do
         it "pulls a new version" do
-          allow(Dir).to receive(:chdir) { |args, &b| b.call } # Force eval the chdir block
-
+          cache_path = subject.send(:cache_path)
           allow(subject).to receive(:cached?).and_return(true)
           expect(subject).to receive(:git).with(
-            'fetch --force --tags https://repo.com "refs/heads/*:refs/heads/*"'
+            'fetch --force --tags https://repo.com "refs/heads/*:refs/heads/*"', cwd: cache_path.to_s
           )
           subject.install
         end
@@ -116,8 +115,6 @@ module Berkshelf
 
       context "when the revision is not cached" do
         it "clones the repository" do
-          allow(Dir).to receive(:chdir) { |args, &b| b.call } # Force eval the chdir block
-
           cache_path = subject.send(:cache_path)
           allow(subject).to receive(:cached?).and_return(false)
           expect(subject).to receive(:git).with(

data/spec/unit/berkshelf/locations/path_spec.rb

@@ -8,8 +8,7 @@ module Berkshelf
       double("dependency",
         name: "nginx",
         version_constraint: constraint,
-        berksfile: berksfile
-      )
+        berksfile: berksfile)
     end
     let(:path) { fixtures_path.join("cookbooks", "example_cookbook") }
     let(:relative_path) { Pathname.new("../../../fixtures/cookbooks/example_cookbook") }

data/spec/unit/berkshelf/lockfile_spec.rb

@@ -8,8 +8,7 @@ describe Berkshelf::Lockfile do
     let(:lock_path) { File.absolute_path("/path/to/Bacon") }
     let(:berksfile) do
       double("Berksfile",
-        filepath: lock_path
-      )
+        filepath: lock_path)
     end
 
     subject { described_class.from_berksfile(berksfile) }
@@ -77,8 +76,7 @@ describe Berkshelf::Lockfile do
         version: "1.0.0",
         location: "api",
         dependencies: {},
-        cached_cookbook: cookbook
-      )
+        cached_cookbook: cookbook)
       berksfile = double("berksfile", dependencies: [apt])
       subject.instance_variable_set(:@berksfile, berksfile)
       allow(subject).to receive(:find).with(apt).and_return(apt)
@@ -95,8 +93,7 @@ describe Berkshelf::Lockfile do
         version: "1.0.0",
         location: "api",
         dependencies: { "bacon" => "1.0.0" },
-        cached_cookbook: cookbook
-      )
+        cached_cookbook: cookbook)
       bacon = double(name: "bacon", version: "1.0.0", dependencies: {})
       berksfile = double("berksfile", dependencies: [apt])
       subject.instance_variable_set(:@berksfile, berksfile)
@@ -115,15 +112,13 @@ describe Berkshelf::Lockfile do
         version: "1.0.0",
         location: "api",
         dependencies: { "bacon" => "1.0.0" },
-        cached_cookbook: cookbook
-      )
+        cached_cookbook: cookbook)
       bacon = double("bacon",
         name: "bacon",
         version_constraint: Semverse::Constraint.new(">= 0.0.0"),
         version: "1.0.0",
         location: "api",
-        dependencies: { "apt" => "1.0.0" }
-      )
+        dependencies: { "apt" => "1.0.0" })
       berksfile = double("berksfile", dependencies: [apt])
       subject.instance_variable_set(:@berksfile, berksfile)
       allow(subject).to receive(:find).with(apt).and_return(apt)
@@ -141,8 +136,7 @@ describe Berkshelf::Lockfile do
         version: "1.0.0",
         location: "api",
         dependencies: { "bacon" => "1.0.0" },
-        cached_cookbook: cookbook
-      )
+        cached_cookbook: cookbook)
       berksfile = double("berksfile", dependencies: [apt])
       subject.instance_variable_set(:@berksfile, berksfile)
       allow(subject).to receive(:find).with(apt).and_return(apt)
@@ -177,8 +171,7 @@ describe Berkshelf::Lockfile do
         version: "1.0.0",
         location: "api",
         dependencies: {},
-        cached_cookbook: cookbook
-      )
+        cached_cookbook: cookbook)
       berksfile = double("berksfile", dependencies: [apt])
       subject.instance_variable_set(:@berksfile, berksfile)
       allow(subject).to receive(:find).with(apt).and_return(apt)
@@ -195,8 +188,7 @@ describe Berkshelf::Lockfile do
         version: "1.0.0",
         location: "api",
         dependencies: {},
-        cached_cookbook: cookbook
-      )
+        cached_cookbook: cookbook)
       apt_master = apt.dup
       allow(apt_master).to receive_messages(location: "github")
       allow(apt_master).to receive_messages(cached_cookbook: cookbook)
@@ -393,8 +385,7 @@ describe Berkshelf::Lockfile::Graph do
         name: "test-0.0.1",
         version: "0.0.1",
         cookbook_name: "test",
-        dependencies: {}
-      )
+        dependencies: {})
       subject.update([cookbook])
 
       expect(subject.locks.keys).to include(cookbook.cookbook_name)

data/spec/unit/berkshelf/ridley_compat_spec.rb

@@ -2,9 +2,9 @@ require "spec_helper"
 require "chef/cookbook_manifest"
 
 describe Berkshelf::RidleyCompat do
-  let(:opts) { Hash.new }
+  let(:opts) { {} }
 
-  subject { described_class.new(opts) }
+  subject { described_class.new(**opts) }
 
   context "default" do
     it "has a cookbook version_class" do