berkshelf 5.2.0 → 8.0.15

data/spec/unit/berkshelf/berkshelf/api_client/connection_spec.rb

@@ -0,0 +1,157 @@
+require "spec_helper"
+
+describe Berkshelf::APIClient::Connection do
+  let(:instance) { described_class.new("http://supermarket.getchef.com") }
+
+  describe "#universe" do
+    before do
+      body_response = %q{{"ruby":{"1.2.3":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"},"2.0.0":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}},"elixir":{"1.0.0":{"endpoint_priority":0,"platforms":{"CentOS":"= 6.0.0"},"dependencies":{},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}}}}
+
+      stub_request(:get, "http://supermarket.getchef.com/universe")
+        .to_return(status: 200, body: body_response, headers: { "Content-Type" => "application/json; charset=utf-8" })
+    end
+
+    subject { instance.universe }
+
+    it "returns an array of APIClient::RemoteCookbook" do
+      expect(subject).to be_a(Array)
+
+      subject.each do |remote|
+        expect(remote).to be_a(Berkshelf::APIClient::RemoteCookbook)
+      end
+    end
+
+    it "contains a item for each dependency" do
+      expect(subject.size).to eq(3)
+      expect(subject[0].name).to eql("ruby")
+      expect(subject[0].version).to eql("1.2.3")
+      expect(subject[1].name).to eql("ruby")
+      expect(subject[1].version).to eql("2.0.0")
+      expect(subject[2].name).to eql("elixir")
+      expect(subject[2].version).to eql("1.0.0")
+    end
+
+    it "has the dependencies for each" do
+      expect(subject[0].dependencies).to include("build-essential" => ">= 1.2.2")
+      expect(subject[1].dependencies).to include("build-essential" => ">= 1.2.2")
+      expect(subject[2].dependencies).to be_empty
+    end
+
+    it "has the platforms for each" do
+      expect(subject[0].platforms).to be_empty
+      expect(subject[1].platforms).to be_empty
+      expect(subject[2].platforms).to include("CentOS" => "= 6.0.0")
+    end
+
+    it "has a location_path for each" do
+      subject.each do |remote|
+        expect(remote.location_path).to_not be_nil
+      end
+    end
+
+    it "has a location_type for each" do
+      subject.each do |remote|
+        expect(remote.location_type).to_not be_nil
+      end
+    end
+  end
+
+  describe "disabling ssl validation on requests" do
+    let(:instance) { described_class.new("https://supermarket.getchef.com", ssl: { verify: false }) }
+
+    before do
+      body_response = %q{{"ruby":{"1.2.3":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"},"2.0.0":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}},"elixir":{"1.0.0":{"endpoint_priority":0,"platforms":{"CentOS":"= 6.0.0"},"dependencies":{},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}}}}
+
+      stub_request(:get, "https://supermarket.getchef.com/universe")
+        .to_return(status: 200, body: body_response, headers: { "Content-Type" => "application/json; charset=utf-8" })
+    end
+
+    subject { instance.universe }
+
+    it "correctly disables SSL validation" do
+      expect_any_instance_of(Net::HTTP).to receive(:use_ssl=).with(true).and_call_original
+      expect_any_instance_of(Net::HTTP).to receive(:verify_mode=).with(OpenSSL::SSL::VERIFY_NONE).and_call_original
+      expect(subject).to be_a(Array)
+    end
+  end
+
+  describe "enabling ssl validation on requests" do
+    let(:instance) { described_class.new("https://supermarket.getchef.com", ssl: { verify: true }) }
+
+    before do
+      body_response = %q{{"ruby":{"1.2.3":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"},"2.0.0":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}},"elixir":{"1.0.0":{"endpoint_priority":0,"platforms":{"CentOS":"= 6.0.0"},"dependencies":{},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}}}}
+
+      stub_request(:get, "https://supermarket.getchef.com/universe")
+        .to_return(status: 200, body: body_response, headers: { "Content-Type" => "application/json; charset=utf-8" })
+    end
+
+    subject { instance.universe }
+
+    it "correctly disables SSL validation" do
+      expect_any_instance_of(Net::HTTP).to receive(:use_ssl=).with(true).and_call_original
+      expect_any_instance_of(Net::HTTP).to receive(:verify_mode=).with(OpenSSL::SSL::VERIFY_PEER).and_call_original
+      expect(subject).to be_a(Array)
+    end
+  end
+
+  describe "enabling ssl validation by default" do
+    let(:instance) { described_class.new("https://supermarket.getchef.com") }
+
+    before do
+      body_response = %q{{"ruby":{"1.2.3":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"},"2.0.0":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}},"elixir":{"1.0.0":{"endpoint_priority":0,"platforms":{"CentOS":"= 6.0.0"},"dependencies":{},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}}}}
+
+      stub_request(:get, "https://supermarket.getchef.com/universe")
+        .to_return(status: 200, body: body_response, headers: { "Content-Type" => "application/json; charset=utf-8" })
+    end
+
+    subject { instance.universe }
+
+    it "correctly disables SSL validation" do
+      expect_any_instance_of(Net::HTTP).to receive(:use_ssl=).with(true).and_call_original
+      expect_any_instance_of(Net::HTTP).to receive(:verify_mode=).with(OpenSSL::SSL::VERIFY_PEER).and_call_original
+      expect(subject).to be_a(Array)
+    end
+  end
+
+  describe "non-200s" do
+    before do
+      Chef::Config[:http_retry_delay] = 0.001
+      Chef::Config[:http_retry_count] = 0
+    end
+
+    subject { instance.universe }
+
+    it "follows 301 redirects correctly" do
+      stub_request(:get, "http://supermarket.getchef.com/universe").to_return(status: 301, headers: { "Location" => "http://arglebargle.com/universe" })
+      body_response = %q{{"ruby":{"1.2.3":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"},"2.0.0":{"endpoint_priority":0,"platforms":{},"dependencies":{"build-essential":">= 1.2.2"},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}},"elixir":{"1.0.0":{"endpoint_priority":0,"platforms":{"CentOS":"= 6.0.0"},"dependencies":{},"location_type":"supermarket","location_path":"https://supermarket.getchef.com/"}}}}
+      stub_request(:get, "http://arglebargle.com/universe")
+        .to_return(status: 200, body: body_response, headers: { "Content-Type" => "application/json; charset=utf-8" })
+      expect(subject.size).to eq(3)
+    end
+
+    it "raises Berkshelf::APIClient::ServiceUnavailable for 500s" do
+      stub_request(:get, "http://supermarket.getchef.com/universe").to_return(status: 500, body: "Internal Server Error")
+      expect { subject }.to raise_error(Berkshelf::APIClient::ServiceUnavailable)
+    end
+
+    it "raises Berkshelf::APIClient::ServiceNotFound for 404s" do
+      stub_request(:get, "http://supermarket.getchef.com/universe").to_return(status: 404, body: "Not Found")
+      expect { subject }.to raise_error(Berkshelf::APIClient::ServiceNotFound)
+    end
+
+    it "raises Net::HTTPBadRequest for 400s" do
+      stub_request(:get, "http://supermarket.getchef.com/universe").to_return(status: 400, body: "Bad Request")
+      expect { subject }.to raise_error(Berkshelf::APIClient::BadResponse)
+    end
+
+    it "raises Berkshelf::APIClient::TimeoutError for timeouts" do
+      stub_request(:get, "http://supermarket.getchef.com/universe").to_timeout
+      expect { subject }.to raise_error(Berkshelf::APIClient::TimeoutError)
+    end
+
+    it "raises Berkshelf::APIClient::TimeoutError for timeouts" do
+      stub_request(:get, "http://supermarket.getchef.com/universe").to_raise(Errno::ECONNREFUSED)
+      expect { subject }.to raise_error(Berkshelf::APIClient::ServiceUnavailable)
+    end
+  end
+end

data/spec/unit/berkshelf/berkshelf/api_client/remote_cookbook_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+describe Berkshelf::APIClient::RemoteCookbook do
+  let(:name) { "ruby" }
+  let(:version) { "1.2.3" }
+  let(:dependencies) { double("dependencies") }
+  let(:platforms) { double("platforms") }
+  let(:location_type) { "chef_server" }
+  let(:location_path) { "http://localhost:8080" }
+
+  let(:attributes) do
+    { dependencies: dependencies, platforms: platforms, location_path: location_path, location_type: location_type }
+  end
+
+  subject { described_class.new(name, version, attributes) }
+
+  its(:name) { should eql(name) }
+  its(:version) { should eql(version) }
+  its(:dependencies) { should eql(dependencies) }
+  its(:platforms) { should eql(platforms) }
+  its(:location_type) { should eql(:chef_server) }
+  its(:location_path) { should eql(location_path) }
+end

data/spec/unit/berkshelf/berkshelf/api_client_spec.rb

@@ -0,0 +1,9 @@
+require "spec_helper"
+
+describe Berkshelf::APIClient do
+  describe "::new" do
+    it "returns an instance of Berkshelf::APIClient::Connection" do
+      expect(described_class.new("http://localhost:26210")).to be_a(Berkshelf::APIClient::Connection)
+    end
+  end
+end

data/spec/unit/berkshelf/cached_cookbook_spec.rb

@@ -1,48 +1,48 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Berkshelf::CachedCookbook do
   describe "ClassMethods" do
-    describe '::from_store_path' do
-      let(:path) { fixtures_path.join('cookbooks', 'example_cookbook-0.5.0') }
+    describe "::from_store_path" do
+      let(:path) { fixtures_path.join("cookbooks", "example_cookbook-0.5.0") }
       let(:cached) { described_class.from_path(path) }
 
-      it 'returns a CachedCookbook' do
+      it "returns a CachedCookbook" do
         expect(cached).to be_a(described_class)
       end
 
-      it 'sets a version number' do
-        expect(cached.version).to eq('0.5.0')
+      it "sets a version number" do
+        expect(cached.version).to eq("0.5.0")
       end
 
-      it 'sets the metadata.name value to the cookbook_name' do
-        expect(cached.metadata.name).to eq('example_cookbook')
+      it "sets the metadata.name value to the cookbook_name" do
+        expect(cached.metadata.name).to eq("example_cookbook")
       end
 
-      context 'given a path that does not contain a cookbook' do
-        it 'returns nil' do
+      context "given a path that does not contain a cookbook" do
+        it "returns nil" do
           expect(described_class.from_store_path(tmp_path)).to be_nil
         end
       end
 
-      context 'given a path that does not match the CachedCookbook dirname format' do
-        it 'returns nil' do
-          path = fixtures_path.join('cookbooks', 'example_cookbook')
+      context "given a path that does not match the CachedCookbook dirname format" do
+        it "returns nil" do
+          path = fixtures_path.join("cookbooks", "example_cookbook")
           expect(described_class.from_store_path(path)).to be_nil
         end
       end
 
-      context 'given an already cached cookbook' do
+      context "given an already cached cookbook" do
         let!(:cached) { described_class.from_store_path(path) }
 
-        it 'returns the cached cookbook instance' do
+        it "returns the cached cookbook instance" do
           expect(described_class.from_store_path(path)).to eq(cached)
         end
       end
     end
 
-    describe '::checksum' do
-      it 'returns a checksum of the given filepath' do
-        path = fixtures_path.join('cookbooks', 'example_cookbook-0.5.0', 'README.md')
+    describe "::checksum" do
+      it "returns a checksum of the given filepath" do
+        path = fixtures_path.join("cookbooks", "example_cookbook-0.5.0", "README.md")
         expected_md5 = if IO.binread(path).include?("\r\n")
                          # On windows, with git configured for auto crlf
                          "2414583f86c9eb68bdbb0be391939341"
@@ -52,53 +52,51 @@ describe Berkshelf::CachedCookbook do
         expect(described_class.checksum(path)).to eq(expected_md5)
       end
 
-      context 'given path does not exist' do
-        it 'raises an Errno::ENOENT error' do
-          expect {
-            described_class.checksum(fixtures_path.join('notexisting.file'))
-          }.to raise_error(Errno::ENOENT)
+      context "given path does not exist" do
+        it "raises an Errno::ENOENT error" do
+          expect do
+            described_class.checksum(fixtures_path.join("notexisting.file"))
+          end.to raise_error(Errno::ENOENT)
         end
       end
     end
   end
 
-  let(:dependencies) { { 'mysql' => '= 1.2.0', 'ntp' => '>= 0.0.0' } }
-  let(:recommendations) { { 'database' => '>= 0.0.0' } }
+  let(:dependencies) { { "mysql" => "= 1.2.0", "ntp" => ">= 0.0.0" } }
+  let(:recommendations) { { "database" => ">= 0.0.0" } }
   let(:path) do
     generate_cookbook(Berkshelf.cookbook_store.storage_path,
-      'sparkle', '0.1.0', dependencies: dependencies, recommendations: recommendations)
+      "sparkle", "0.1.0", dependencies: dependencies, recommendations: recommendations)
   end
 
   subject { Berkshelf::CachedCookbook.from_store_path(path) }
 
-  describe '#dependencies' do
-    it 'contains depends from the cookbook metadata' do
+  describe "#dependencies" do
+    it "contains depends from the cookbook metadata" do
       expect(subject.dependencies).to include(dependencies)
     end
 
-    it 'contains recommendations from the cookbook metadata' do
-      expect(subject.dependencies).to include(recommendations)
-    end
-
-    it 'returns a hash' do
+    it "returns a hash" do
       expect(subject.dependencies).to be_a(Hash)
     end
   end
 
-  describe '#pretty_hash' do
-    shared_examples 'a pretty_hash cookbook attribute' do |attribute, key|
+  describe "#pretty_hash" do
+    shared_examples "a pretty_hash string cookbook attribute" do |attribute, key|
       it "is not present when the `#{attribute}` attribute is nil" do
         allow(subject).to receive(attribute.to_sym).and_return(nil)
         expect(subject.pretty_hash).to_not have_key((key || attribute).to_sym)
       end
 
       it "is not present when the `#{attribute}` attribute is an empty string" do
-        allow(subject).to receive(attribute.to_sym).and_return('')
+        allow(subject).to receive(attribute.to_sym).and_return("")
         expect(subject.pretty_hash).to_not have_key((key || attribute).to_sym)
       end
+    end
 
-      it "is not present when the `#{attribute}` attribute is an empty array" do
-        allow(subject).to receive(attribute.to_sym).and_return([])
+    shared_examples "a pretty_hash hash cookbook attribute" do |attribute, key|
+      it "is not present when the `#{attribute}` attribute is nil" do
+        allow(subject).to receive(attribute.to_sym).and_return(nil)
         expect(subject.pretty_hash).to_not have_key((key || attribute).to_sym)
       end
 
@@ -108,18 +106,18 @@ describe Berkshelf::CachedCookbook do
       end
 
       it "is present when the `#{attribute}` attribute has a Hash value" do
-        allow(subject).to receive(attribute.to_sym).and_return(foo: 'bar')
+        allow(subject).to receive(attribute.to_sym).and_return(foo: "bar")
         expect(subject.pretty_hash).to have_key((key || attribute).to_sym)
       end
     end
 
-    it_behaves_like 'a pretty_hash cookbook attribute', 'cookbook_name', 'name'
-    it_behaves_like 'a pretty_hash cookbook attribute', 'version'
-    it_behaves_like 'a pretty_hash cookbook attribute', 'description'
-    it_behaves_like 'a pretty_hash cookbook attribute', 'maintainer', 'author'
-    it_behaves_like 'a pretty_hash cookbook attribute', 'maintainer_email', 'email'
-    it_behaves_like 'a pretty_hash cookbook attribute', 'license'
-    it_behaves_like 'a pretty_hash cookbook attribute', 'platforms'
-    it_behaves_like 'a pretty_hash cookbook attribute', 'dependencies'
+    it_behaves_like "a pretty_hash string cookbook attribute", "cookbook_name", "name"
+    it_behaves_like "a pretty_hash string cookbook attribute", "version"
+    it_behaves_like "a pretty_hash string cookbook attribute", "description"
+    it_behaves_like "a pretty_hash string cookbook attribute", "maintainer", "author"
+    it_behaves_like "a pretty_hash string cookbook attribute", "maintainer_email", "email"
+    it_behaves_like "a pretty_hash string cookbook attribute", "license"
+    it_behaves_like "a pretty_hash hash cookbook attribute", "platforms"
+    it_behaves_like "a pretty_hash hash cookbook attribute", "dependencies"
   end
 end

data/spec/unit/berkshelf/chef_repo_universe_spec.rb

@@ -0,0 +1,37 @@
+require "spec_helper"
+
+module Berkshelf
+  describe ChefRepoUniverse do
+    let(:fixture) { nil }
+    let(:fixture_path) { File.expand_path("../../../fixtures/#{fixture}", __FILE__) }
+    subject { described_class.new("file://#{fixture_path}", path: fixture_path).universe }
+
+    context "with cookbooks in ./" do
+      let(:fixture) { "cookbook-path" }
+
+      it "returns the correct universe" do
+        expect(subject.size).to eq 1
+        expect(subject[0].name).to eq "jenkins-config"
+        expect(subject[0].version).to eq "0.1.0"
+        expect(subject[0].dependencies).to eq "jenkins" => "~> 2.0"
+      end
+    end
+
+    context "with cookbooks in cookbooks/" do
+      let(:fixture) { "complex-cookbook-path" }
+
+      it "returns the correct universe" do
+        expect(subject.size).to eq 3
+        expect(subject[0].name).to eq "app"
+        expect(subject[0].version).to eq "1.2.3"
+        expect(subject[0].dependencies).to eq({})
+        expect(subject[1].name).to eq "jenkins"
+        expect(subject[1].version).to eq "2.0.1"
+        expect(subject[1].dependencies).to eq({})
+        expect(subject[2].name).to eq "jenkins-config"
+        expect(subject[2].version).to eq "0.1.0"
+        expect(subject[2].dependencies).to eq "jenkins" => "~> 2.0"
+      end
+    end
+  end
+end

data/spec/unit/berkshelf/cli_spec.rb

@@ -1,24 +1,23 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Berkshelf
   describe Cli do
     let(:subject) { described_class.new }
-    let(:berksfile) { double('Berksfile') }
-    let(:cookbooks) { ['mysql'] }
+    let(:berksfile) { double("Berksfile") }
+    let(:cookbooks) { ["mysql"] }
 
     before do
       allow(Berksfile).to receive(:from_options).and_return(berksfile)
     end
 
-    describe '#upload' do
-      it 'calls to upload with params if passed in cli' do
+    describe "#upload" do
+      it "calls to upload with params if passed in cli" do
         expect(berksfile).to receive(:upload).with(cookbooks,
-          include(skip_syntax_check: true, freeze: false)
-        )
+          include(skip_syntax_check: true, freeze: false))
 
         subject.options[:skip_syntax_check] = true
         subject.options[:no_freeze]         = true
-        subject.upload('mysql')
+        subject.upload("mysql")
       end
     end
   end