berkshelf 3.0.0.beta7 → 3.0.0.beta8

data/spec/unit/berkshelf/locations/git_location_spec.rb

@@ -1,126 +0,0 @@
-require 'spec_helper'
-
-describe Berkshelf::GitLocation do
-  let(:constraint) { double('comp-vconstraint', satisfies?: true) }
-  let(:dependency) { double('dep', name: "berkshelf-cookbook-fixture", version_constraint: constraint) }
-
-  describe "ClassMethods" do
-    describe "::new" do
-      it 'raises InvalidGitURI if given an invalid Git URI for options[:git]' do
-        expect {
-          described_class.new(dependency, git: '/something/on/disk')
-        }.to raise_error(Berkshelf::InvalidGitURI)
-      end
-    end
-  end
-
-  let(:storage_path) { Berkshelf::CookbookStore.instance.storage_path }
-  subject { described_class.new(dependency, git: 'git://github.com/RiotGames/berkshelf-cookbook-fixture.git') }
-
-  describe '#download' do
-    context 'when a local revision is present' do
-      let(:cached) { double('cached') }
-
-      before do
-        Berkshelf::Git.stub(:rev_parse).and_return('abcd1234')
-        described_class.any_instance.stub(:cached?).and_return(true)
-        described_class.any_instance.stub(:validate_cached).with(cached).and_return(cached)
-        Berkshelf::CachedCookbook.stub(:from_store_path).with(any_args()).and_return(cached)
-      end
-
-      it 'returns the cached cookbook' do
-        expect(subject.download).to eq(cached)
-      end
-    end
-
-    it 'returns an instance of Berkshelf::CachedCookbook' do
-      expect(subject.download).to be_a(Berkshelf::CachedCookbook)
-    end
-
-    it 'downloads the cookbook to the given destination' do
-      cached_cookbook = subject.download
-      ref = subject.ref
-
-      expect(storage_path).to have_structure {
-        directory "#{cached_cookbook.cookbook_name}-#{ref}" do
-          file 'metadata.rb'
-        end
-      }
-    end
-
-    context 'given no ref/branch/tag options is given' do
-      subject { described_class.new(dependency, git: 'git://github.com/RiotGames/berkshelf-cookbook-fixture.git') }
-
-      it 'sets the branch attribute to the HEAD revision of the cloned repo' do
-        subject.download
-        expect(subject.branch).to_not be_nil
-      end
-    end
-
-    context 'given a git repo that does not exist' do
-      before { dependency.stub(name: "doesnot_exist") }
-      subject { described_class.new(dependency, git: 'git://github.com/RiotGames/thisrepo_does_not_exist.git') }
-
-      it 'raises a GitError' do
-        Berkshelf::Git.stub(:git).and_raise(Berkshelf::GitError.new(''))
-        expect { subject.download }.to raise_error(Berkshelf::GitError)
-      end
-    end
-
-    context 'given a git repo that does not contain a cookbook' do
-      let(:fake_remote) { remote_path('not_a_cookbook') }
-      before { dependency.stub(name: "doesnot_exist") }
-      subject { described_class.new(dependency, git: "file://#{fake_remote}.git") }
-
-      it 'raises a CookbookNotFound error' do
-        Berkshelf::Git.stub(:clone).and_return {
-          FileUtils.mkdir_p(fake_remote)
-          Dir.chdir(fake_remote) { |dir| `git init && echo hi > README && git add README && git commit README -m 'README'`; dir }
-        }
-
-        expect { subject.download }.to raise_error(Berkshelf::CookbookNotFound)
-      end
-    end
-
-    context 'given the content at the Git repo does not satisfy the version constraint' do
-      before { constraint.stub(satisfies?: false) }
-      subject { described_class.new(dependency, git: 'git://github.com/RiotGames/berkshelf-cookbook-fixture.git') }
-
-      it 'raises a CookbookValidationFailure error' do
-        expect { subject.download }.to raise_error(Berkshelf::CookbookValidationFailure)
-      end
-    end
-
-    context 'given a value for tag' do
-      let(:tag) { 'v1.0.0' }
-
-      subject do
-        described_class.new(dependency, git: 'git://github.com/RiotGames/berkshelf-cookbook-fixture.git', tag: tag)
-      end
-
-      let(:cached) { subject.download }
-      let(:sha) { subject.ref }
-      let(:expected_path) { storage_path.join("#{cached.cookbook_name}-#{sha}") }
-
-      it 'returns a cached cookbook with a path that contains the ref' do
-        expect(cached.path).to eq(expected_path)
-      end
-    end
-
-    context 'give a value for branch' do
-      let(:branch) { 'master' }
-
-      subject do
-        described_class.new(dependency, git: 'git://github.com/RiotGames/berkshelf-cookbook-fixture.git',
-          branch: branch)
-      end
-      let(:cached) { subject.download }
-      let(:sha) { subject.ref }
-      let(:expected_path) { storage_path.join("#{cached.cookbook_name}-#{sha}") }
-
-      it 'returns a cached cookbook with a path that contains the ref' do
-        expect(cached.path).to eq(expected_path)
-      end
-    end
-  end
-end

data/spec/unit/berkshelf/locations/mercurial_location_spec.rb

@@ -1,131 +0,0 @@
-require 'spec_helper'
-
-describe Berkshelf::MercurialLocation do
-  include Berkshelf::RSpec::Mercurial
-
-  let(:cookbook_uri) { mercurial_origin_for('fake_cookbook', is_cookbook: true, tags: ["1.0.0"], branches: ["mybranch"]) }
-  let(:constraint) { double('comp-vconstraint', satisfies?: true) }
-  let(:dependency) { double('dep', name: "berkshelf-cookbook-fixture", version_constraint: constraint) }
-  let(:storage_path) { Berkshelf::CookbookStore.instance.storage_path }
-
-  describe '::initialize' do
-    it 'raises InvalidHgURI if given an invalid URI for options[:hg]' do
-      expect {
-        described_class.new(dependency, hg: '/something/on/disk')
-      }.to raise_error(Berkshelf::InvalidHgURI)
-    end
-  end
-
-  subject { described_class.new(dependency, hg: cookbook_uri) }
-
-  describe '#download' do
-    before do
-      clean_tmp_path
-      FileUtils.mkdir_p(storage_path)
-      cookbook_uri
-    end
-
-    context 'when a local revision is present' do
-      let(:cached) { double('cached') }
-
-      before do
-        Berkshelf::Mercurial.stub(:rev_parse).and_return('abcd1234')
-        described_class.any_instance.stub(:cached?).and_return(true)
-        described_class.any_instance.stub(:validate_cached).with(cached).and_return(cached)
-        Berkshelf::CachedCookbook.stub(:from_store_path).with(any_args()).and_return(cached)
-      end
-
-      it 'returns the cached cookbook' do
-        expect(subject.download).to eq(cached)
-      end
-    end
-
-    it 'returns an instance of Berkshelf::CachedCookbook' do
-      expect(subject.download).to be_a(Berkshelf::CachedCookbook)
-    end
-
-    it 'downloads the cookbook to the given destination' do
-      cached_cookbook = subject.download
-      rev = subject.rev
-
-      expect(storage_path).to have_structure {
-        directory "#{cached_cookbook.cookbook_name}-#{rev}" do
-          file 'metadata.rb'
-        end
-      }
-    end
-
-    context 'given no ref/branch/tag options is given' do
-      subject { described_class.new(dependency, hg: cookbook_uri) }
-
-      it 'sets the branch attribute to the default revision of the cloned repo' do
-        subject.download
-        expect(subject.branch).to_not be_nil
-      end
-    end
-
-    context 'given a repo that does not exist' do
-      before { dependency.stub(name: "doesnot_exist") }
-      subject { described_class.new(dependency, hg: 'http://thisdoesntexist.org/notarepo') }
-
-      it 'raises a MercurailError' do
-        Berkshelf::Mercurial.stub(:hg).and_raise(Berkshelf::MercurialError.new(''))
-        expect {
-          subject.download
-        }.to raise_error(Berkshelf::MercurialError)
-      end
-    end
-
-    context 'given a hg repo that does not contain a cookbook' do
-      let(:fake_remote) { mercurial_origin_for('not_a_cookbook', is_cookbook: false) }
-      subject { described_class.new(dependency, hg: fake_remote) }
-
-      it 'raises a CookbookNotFound error' do
-        expect {
-          subject.download
-        }.to raise_error(Berkshelf::CookbookNotFound)
-      end
-    end
-
-    context 'given the content at the repo does not satisfy the version constraint' do
-      before { constraint.stub(satisfies?: false) }
-      subject do
-        described_class.new(dependency,
-                                   hg: cookbook_uri
-        )
-      end
-
-      it 'raises a CookbookValidationFailure error' do
-        expect {
-          subject.download
-        }.to raise_error(Berkshelf::CookbookValidationFailure)
-      end
-    end
-
-    context 'given a value for tag' do
-      let(:tag) { '1.0.0' }
-      subject { described_class.new(dependency, hg: cookbook_uri, tag: tag) }
-
-      let(:cached) { subject.download }
-      let(:sha) { subject.rev }
-      let(:expected_path) { storage_path.join("#{cached.cookbook_name}-#{sha}") }
-
-      it 'returns a cached cookbook with a path that contains the ref' do
-        expect(cached.path).to eq(expected_path)
-      end
-    end
-
-    context 'give a value for branch' do
-      let(:branch) { 'mybranch' }
-      subject { described_class.new(dependency, hg: cookbook_uri, branch: branch) }
-
-      let(:cached) { subject.download }
-      let(:sha) { subject.rev }
-      let(:expected_path) { storage_path.join("#{cached.cookbook_name}-#{sha}") }
-
-      it 'returns a cached cookbook with a path that contains the ref' do
-        expect(cached.path).to eq(expected_path)
-      end
-    end
-  end
-end

data/spec/unit/berkshelf/locations/path_location_spec.rb

@@ -1,25 +0,0 @@
-require 'spec_helper'
-
-describe Berkshelf::PathLocation do
-  let(:constraint) { double('comp-vconstraint', satisfies?: true) }
-  let(:dependency) { double('dep', name: "nginx", version_constraint: constraint) }
-  let(:path) { fixtures_path.join('cookbooks', 'example_cookbook').to_s }
-
-  describe "ClassMethods" do
-    describe "::new" do
-      it 'assigns the value of :path to #path' do
-        location = described_class.new(dependency, path: path)
-        expect(location.path).to eq(path)
-      end
-    end
-  end
-
-  let(:options) { { path: path } }
-  let(:instance) { described_class.new(dependency, options) }
-
-  describe "#download" do
-    it "returns a CachedCookbook" do
-      expect(instance.download).to be_a(Berkshelf::CachedCookbook)
-    end
-  end
-end

data/spec/unit/berkshelf/mercurial_spec.rb

@@ -1,172 +0,0 @@
-require 'spec_helper'
-
-describe Berkshelf::Mercurial do
-  include Berkshelf::RSpec::Mercurial
-
-  let(:hg) { Berkshelf::Mercurial }
-
-  describe '::find_hg' do
-    it 'finds hg' do
-      expect(described_class.find_hg).to_not be_nil
-    end
-
-    it 'raises an error if mercurial cannot be not found' do
-      ENV.should_receive(:[]).with('PATH').and_return(String.new)
-
-      expect {
-        described_class.find_hg
-      }.to raise_error(Berkshelf::MercurialNotFound)
-    end
-  end
-
-  describe '::clone' do
-    let(:target) { clone_path('nginx') }
-
-    it 'clones the repository to the target path' do
-      origin_uri = mercurial_origin_for('nginx')
-
-      described_class.clone(origin_uri, target)
-
-      expect(target).to exist
-      expect(target).to be_directory
-    end
-  end
-
-  describe '::checkout' do
-    let(:repo_path) { clone_path('nginx') }
-    let(:repo) {
-      origin_uri = mercurial_origin_for('nginx', tags: ['1.0.1', '1.0.2'], branches: ['topic', 'next_topic'])
-      hg.clone(origin_uri, repo_path)
-    }
-
-    shared_examples 'able to checkout hg rev' do |test_rev|
-      it 'checks out the specified rev of the given repository' do
-        hg.checkout(repo, rev)
-
-        Dir.chdir repo_path do
-          test_rev ||= rev
-          expect(%x[hg id -r #{test_rev}].split(' ').first).to eq(%x[hg id -i].strip)
-        end
-      end
-    end
-
-    context 'with sha commit id' do
-      let(:rev) { id_for_rev('nginx', '1.0.1') }
-
-      it_behaves_like 'able to checkout hg rev'
-    end
-
-    context 'with tags' do
-      let(:rev) { '1.0.1' }
-
-      it_behaves_like 'able to checkout hg rev'
-
-      context 'after checking out another tag' do
-        let(:other_tag) { '1.0.2' }
-        before do
-          hg.checkout(repo, other_tag)
-          Dir.chdir repo_path do
-            shell_out "echo 'uncommitted change' >> content_file"
-          end
-        end
-
-        it_behaves_like 'able to checkout hg rev'
-      end
-    end
-
-    context 'with branches' do
-      let(:rev) { 'topic' }
-
-      it_behaves_like 'able to checkout hg rev', 'topic'
-
-      context 'after checking out another branch' do
-        let(:other_branch) { 'next_topic' }
-        before do
-          hg.checkout(repo, other_branch)
-          Dir.chdir repo_path do
-            shell_out "echo 'uncommitted change' >> content_file"
-          end
-        end
-
-        it_behaves_like 'able to checkout hg rev', 'topic'
-      end
-    end
-  end
-
-  describe '::rev_parse' do
-    let(:repo_path) { clone_path('nginx') }
-
-    before(:each) do
-      origin_uri = mercurial_origin_for('nginx', tags: ['1.1.1'])
-      described_class.clone(origin_uri, repo_path)
-      described_class.checkout(repo_path, id_for_rev('nginx', '1.1.1'))
-    end
-
-    it 'returns the ref for HEAD' do
-      rev = described_class.rev_parse(repo_path)
-      ref = id_for_rev('nginx', '1.1.1')
-
-      expect(rev).to eql(ref)
-    end
-  end
-
-  let(:https_uri) { 'https://hghub.com/reset/' }
-  let(:http_uri) { 'http://hghub.com/reset/' }
-  let(:invalid_uri) { '/something/on/disk' }
-
-  describe '::validate_uri' do
-    context 'given an invalid URI' do
-      it 'returns false' do
-        expect(described_class.validate_uri(invalid_uri)).to be_false
-      end
-    end
-
-    context 'given a HTTP URI' do
-      it 'returns true' do
-        expect(described_class.validate_uri(http_uri)).to be_true
-      end
-    end
-
-    context 'given a valid HTTPS URI' do
-      it 'returns true' do
-        expect(described_class.validate_uri(https_uri)).to be_true
-      end
-    end
-
-    context 'given an integer' do
-      it 'returns false' do
-        expect(described_class.validate_uri(123)).to be_false
-      end
-    end
-  end
-
-  describe '::validate_uri!' do
-    context 'given an invalid URI' do
-      it 'raises InvalidHgURI' do
-        expect {
-          described_class.validate_uri!(invalid_uri)
-        }.to raise_error(Berkshelf::InvalidHgURI)
-      end
-    end
-
-    context 'given a HTTP URI' do
-      it 'raises InvalidHgURI' do
-        expect(described_class.validate_uri!(http_uri)).to be_true
-      end
-    end
-
-    context 'given a valid HTTPS URI' do
-      it 'returns true' do
-        expect(described_class.validate_uri!(https_uri)).to be_true
-      end
-    end
-
-    context 'given an integer' do
-      it 'raises InvalidHgURI' do
-        expect {
-          described_class.validate_uri!(123)
-        }.to raise_error(Berkshelf::InvalidHgURI)
-      end
-    end
-  end
-end