berkshelf 1.4.6 → 2.0.0.beta

data/spec/unit/berkshelf/locations/site_location_spec.rb

@@ -1,19 +1,19 @@
 require 'spec_helper'
 
 describe Berkshelf::SiteLocation do
-  describe "#download" do
+  describe '#download' do
     pending
   end
 
-  describe "#target_version" do
+  describe '#target_version' do
     pending
   end
 
-  describe "#to_hash" do
+  describe '#to_hash' do
     pending
   end
 
-  describe "#to_s" do
+  describe '#to_s' do
     pending
   end
 end

data/spec/unit/berkshelf/lockfile_spec.rb

@@ -1,5 +1,189 @@
 require 'spec_helper'
 
 describe Berkshelf::Lockfile do
-  pending
+  let!(:content) { File.read(fixtures_path.join('lockfiles/default.lock')) }
+  let(:berksfile) { Berkshelf::Berksfile.new('Berksfile') }
+
+  before do
+    File.stub(:read).and_return(content)
+  end
+
+  describe '.initialize' do
+    it 'does not throw an exception' do
+      expect {
+        Berkshelf::Lockfile.new(berksfile)
+      }.to_not raise_error
+    end
+
+    it 'has the correct sha' do
+      expect(subject.sha).to eq('6b76225554cc1f7c0aea0f8b3f10c6743aeba67e')
+    end
+
+    it 'has the correct sources' do
+      expect(subject).to have_source 'build-essential'
+      expect(subject).to have_source 'chef-client'
+    end
+  end
+
+
+
+  subject { Berkshelf::Lockfile.new(berksfile) }
+
+  describe '#reset_sha!' do
+    it 'sets the sha to nil' do
+      expect { subject.reset_sha! }.to change { subject.sha }.to nil
+    end
+  end
+
+  describe '#sources' do
+    it 'returns an array' do
+      expect(subject.sources).to be_a(Array)
+    end
+  end
+
+  describe '#find' do
+    it 'returns a matching cookbook' do
+      expect(subject.find('build-essential').name).to eq 'build-essential'
+    end
+
+    it 'returns nil for a missing cookbook' do
+      expect(subject.find('foo')).to be_nil
+    end
+  end
+
+  describe '#has_source?' do
+    it 'returns true if a matching cookbook is found' do
+      expect(subject.has_source?('build-essential')).to be_true
+    end
+
+    it 'returns false if no matching cookbook is found' do
+      expect(subject.has_source?('foo')).to be_false
+    end
+  end
+
+  describe '#update' do
+    it 'resets the sources' do
+      subject.should_receive(:reset_sources!).once
+      subject.update([])
+    end
+
+    it 'updates the sha' do
+      expect {
+        subject.update([])
+      }.to change { subject.sha }
+    end
+
+    it 'appends each of the sources' do
+      source = double('source')
+      subject.should_receive(:append).with(source).once
+      subject.update([source])
+    end
+
+    it 'saves the file' do
+      subject.should_receive(:save).once
+      subject.update([])
+    end
+  end
+
+  describe '#add' do
+    let(:source) { double('source', name: 'build-essential') }
+
+    it 'adds the new source to the @sources instance variable' do
+      subject.add(source)
+      expect(subject).to have_source(source)
+    end
+
+    it 'does not add duplicate sources' do
+      5.times { subject.add(source) }
+      expect(subject).to have_source(source)
+    end
+  end
+
+  describe '#remove' do
+    let(:source) { double('source', name: 'build-essential') }
+
+    before do
+      subject.add(source)
+    end
+
+    it 'removes the source' do
+      subject.remove(source)
+      expect(subject).to_not have_source(source)
+    end
+
+    it 'raises an except if the source does not exist' do
+      expect {
+        subject.remove(nil)
+      }.to raise_error Berkshelf::CookbookNotFound
+    end
+  end
+
+  describe '#to_s' do
+    it 'returns a pretty-formatted string' do
+      expect(subject.to_s).to eq '#<Berkshelf::Lockfile Berksfile.lock>'
+    end
+  end
+
+  describe '#inspect' do
+    it 'returns a pretty-formatted, detailed string' do
+      expect(subject.inspect).to eq '#<Berkshelf::Lockfile Berksfile.lock, sources: [#<Berkshelf::CookbookSource: build-essential (>= 0.0.0), locked_version: 1.1.2, groups: [:default], location: default>, #<Berkshelf::CookbookSource: chef-client (>= 0.0.0), locked_version: 2.1.4, groups: [:default], location: default>]>'
+    end
+  end
+
+  describe '#to_hash' do
+    let(:hash) { subject.to_hash }
+
+    it 'has the `:sha` key' do
+      expect(hash).to have_key(:sha)
+    end
+
+    it 'has the `:sources` key' do
+      expect(hash).to have_key(:sources)
+    end
+  end
+
+  describe '#to_json' do
+    it 'dumps the #to_hash to JSON' do
+      JSON.should_receive(:pretty_generate).with(subject.to_hash, {})
+      subject.to_json
+    end
+  end
+
+  describe '#save' do
+    before { Berkshelf::Lockfile.send(:public, :save) }
+    let(:file) { double('file') }
+
+    before(:each) do
+      File.stub(:open).with('Berksfile.lock', 'w')
+    end
+
+    it 'saves itself to a file on disk' do
+      File.should_receive(:open).with(/(.+)\/Berksfile\.lock/, 'w').and_yield(file)
+      file.should_receive(:write).once
+      subject.save
+    end
+  end
+
+  describe '#reset_sources!' do
+    before { Berkshelf::Lockfile.send(:public, :reset_sources!) }
+
+    it 'sets the sources to an empty hash' do
+      expect {
+        subject.reset_sources!
+      }.to change { subject.sources }.to([])
+    end
+  end
+
+  describe '#cookbook_name' do
+    before { Berkshelf::Lockfile.send(:public, :cookbook_name) }
+
+    it 'accepts a cookbook source' do
+      source = double('source', name: 'build-essential', is_a?: true)
+      expect(subject.cookbook_name(source)).to eq 'build-essential'
+    end
+
+    it 'accepts a string' do
+      expect(subject.cookbook_name('build-essential')).to eq 'build-essential'
+    end
+  end
 end

data/spec/unit/berkshelf/logger_spec.rb

@@ -1,29 +1,11 @@
 require 'spec_helper'
 
 describe Berkshelf::Logger do
-  subject { described_class }
-
-  it "responds to :info" do
-    subject.should respond_to(:info)
-  end
-
-  it "responds to :warn" do
-    subject.should respond_to(:warn)
-  end
-
-  it "responds to :error" do
-    subject.should respond_to(:error)
-  end
-
-  it "responds to :fatal" do
-    subject.should respond_to(:fatal)
-  end
-
-  it "responds to :debug" do
-    subject.should respond_to(:debug)
-  end
-
-  it "responds to :deprecate" do
-    subject.should respond_to(:deprecate)
+  %w(info warn error fatal debug deprecate).each do |meth|
+    describe "##{meth}" do
+      it 'responds' do
+        expect(Berkshelf::Logger).to respond_to(meth.to_sym)
+      end
+    end
   end
 end

data/spec/unit/berkshelf/mixin/logging_spec.rb

@@ -2,19 +2,17 @@ require 'spec_helper'
 
 describe Berkshelf::Mixin::Logging do
   subject do
-    Class.new do
-      include Berkshelf::Mixin::Logging
-    end.new
+    Class.new { include Berkshelf::Mixin::Logging }.new
   end
 
-  describe "#log" do
-    it "returns the Berkshelf::Logger" do
-      subject.log.should eql(Berkshelf::Logger)
+  describe '#log' do
+    it 'returns the Berkshelf::Logger' do
+      expect(subject.log).to eq(Berkshelf::Logger)
     end
   end
 
-  describe "#log_exception" do
-    it "logs the exception and it's backtrace as fatal" do
+  describe '#log_exception' do
+    it 'logs the exception and backtrace as fatal' do
       ex = Exception.new('msg')
       ex.stub(:backtrace).and_return(['one', 'two'])
       subject.log.should_receive(:fatal).exactly(2).times

data/spec/unit/berkshelf/resolver_spec.rb

@@ -18,63 +18,57 @@ describe Berkshelf::Resolver, :chef_server, vcr: { record: :new_episodes, serial
     )
   end
 
-  describe "ClassMethods" do
-    subject { described_class }
-
-    describe "::initialize" do
-      it "adds the specified sources to the sources hash" do
-        resolver = subject.new(berksfile, sources: [source], skip_dependencies: true)
-
-        resolver.should have_source(source.name)
-      end
-
-      it "should not add dependencies if requested" do
-        resolver = subject.new(berksfile, sources: [source], skip_dependencies: true)
-
-        resolver.should_not have_source("nginx")
-      end
+  describe '.initialize' do
+    it 'adds the specified sources to the sources hash' do
+      resolver = Berkshelf::Resolver.new(berksfile, sources: [source], skip_dependencies: true)
+      expect(resolver).to have_source(source.name)
+    end
 
-      it "adds the dependencies of the source as sources" do
-        resolver = subject.new(berksfile, sources: [source])
+    it 'does not add dependencies if skipped' do
+      resolver = Berkshelf::Resolver.new(berksfile, sources: [source], skip_dependencies: true)
+      expect(resolver).to_not have_source('nginx')
+    end
 
-        resolver.should have_source("nginx")
-      end
+    it 'adds the dependencies of the source as sources' do
+      resolver = Berkshelf::Resolver.new(berksfile, sources: [source])
+      expect(resolver).to have_source('nginx')
     end
   end
 
-  subject { described_class.new(berksfile) }
 
-  describe "#add_source" do
+
+  subject { Berkshelf::Resolver.new(berksfile) }
+
+  describe '#add_source' do
     let(:package_version) { double('package-version', dependencies: Array.new) }
 
-    it "adds the source to the instance of resolver" do
+    it 'adds the source to the instance of resolver' do
       subject.add_source(source, false)
-
-      subject.sources.should include(source)
+      expect(subject.sources).to include(source)
     end
 
-    it "adds an artifact of the same name of the source to the graph" do
+    it 'adds an artifact of the same name of the source to the graph' do
       subject.graph.should_receive(:artifacts).with(source.name, source.cached_cookbook.version)
 
       subject.add_source(source, false)
     end
 
-    it "adds the dependencies of the source as packages to the graph" do
+    it 'adds the dependencies of the source as packages to the graph' do
       subject.should_receive(:add_source_dependencies).with(source)
 
       subject.add_source(source)
     end
 
-    it "raises a DuplicateSourceDefined exception if a source of the same name is added" do
+    it 'raises a DuplicateSourceDefined exception if a source of the same name is added' do
       subject.should_receive(:has_source?).with(source).and_return(true)
 
-      lambda {
+      expect {
         subject.add_source(source)
-      }.should raise_error(Berkshelf::DuplicateSourceDefined)
+      }.to raise_error(Berkshelf::DuplicateSourceDefined)
     end
 
-    context "when include_dependencies is false" do
-      it "does not try to include_dependencies" do
+    context 'when include_dependencies is false' do
+      it 'does not try to include_dependencies' do
         subject.should_not_receive(:add_source_dependencies)
 
         subject.add_source(source, false)
@@ -82,21 +76,25 @@ describe Berkshelf::Resolver, :chef_server, vcr: { record: :new_episodes, serial
     end
   end
 
-  describe "#get_source" do
+  describe '#get_source' do
     before { subject.add_source(source, false) }
 
-    context "given a string representation of the source to retrieve" do
-      it "returns the source of the same name" do
-        subject.get_source(source.name).should eql(source)
+    context 'given a string representation of the source to retrieve' do
+      it 'returns the source of the same name' do
+        expect(subject.get_source(source.name)).to eq(source)
       end
     end
   end
 
-  describe "#has_source?" do
+  describe '#has_source?' do
     before { subject.add_source(source, false) }
 
-    it "returns the source of the given name" do
-      subject.has_source?(source.name).should be_true
+    it 'returns true if the source exists' do
+      expect(subject.has_source?(source.name)).to be_true
+    end
+
+    it 'returns false if the source does not exist' do
+      expect(subject.has_source?('non-existent')).to be_false
     end
   end
 end

data/spec/unit/berkshelf/ui_spec.rb

@@ -1,30 +1,29 @@
 require 'spec_helper'
 
-
-describe Thor::Shell::Color do
+describe Thor::Base.shell do
   let(:stdout) { double('stdout') }
   let(:stderr) { double('stderr') }
 
   before do
-    Thor::Shell::Basic.any_instance.stub(:stdout).and_return(stdout)
-    Thor::Shell::Basic.any_instance.stub(:stderr).and_return(stderr)
+    described_class.any_instance.stub(:stdout).and_return(stdout)
+    described_class.any_instance.stub(:stderr).and_return(stderr)
   end
 
-  context '#mute!' do
+  describe '#mute!' do
     it 'sets @mute to true' do
       subject.mute!
       expect(subject.instance_variable_get(:@mute)).to be_true
     end
   end
 
-  context '#unmute!' do
+  describe '#unmute!' do
     it 'sets @mute to false' do
       subject.unmute!
       expect(subject.instance_variable_get(:@mute)).to be_false
     end
   end
 
-  context '#say' do
+  describe '#say' do
     context 'when quiet?' do
       before do
         subject.stub(:quiet?).and_return(true)
@@ -49,7 +48,7 @@ describe Thor::Shell::Color do
     end
   end
 
-  context '#say_status' do
+  describe '#say_status' do
     context 'when quiet?' do
       before do
         subject.stub(:quiet?).and_return(true)
@@ -74,7 +73,7 @@ describe Thor::Shell::Color do
     end
   end
 
-  context '#warn' do
+  describe '#warn' do
     context 'when quiet?' do
       before do
         subject.stub(:quiet?).and_return(true)
@@ -100,7 +99,7 @@ describe Thor::Shell::Color do
     end
   end
 
-  context '#deprecated' do
+  describe '#deprecated' do
     it 'prefixes the message with "[DEPRECATED]"' do
       subject.should_receive(:warn).with('[DEPRECATION] That was deprecated!')
       subject.deprecated 'That was deprecated!'