berkeley_library-tind 0.7.2 → 0.7.3

data/lib/berkeley_library/tind/marc/xml_reader.rb

@@ -15,7 +15,7 @@ module BerkeleyLibrary
         # ############################################################
         # Constant
 
-        COMMENT_TOTAL_RE = /Search-Engine-Total-Number-Of-Results: ([0-9]+)/.freeze
+        COMMENT_TOTAL_RE = /Search-Engine-Total-Number-Of-Results: ([0-9]+)/
 
         # ############################################################
         # Attributes

data/lib/berkeley_library/tind/marc.rb

@@ -1 +1 @@
-Dir.glob(File.expand_path('marc/*.rb', __dir__)).sort.each(&method(:require))
+Dir.glob(File.expand_path('marc/*.rb', __dir__)).each(&method(:require))

data/lib/berkeley_library/tind/module_info.rb

@@ -2,12 +2,12 @@ module BerkeleyLibrary
   module TIND
     class ModuleInfo
       NAME = 'berkeley_library-tind'.freeze
-      AUTHOR = 'David Moles'.freeze
-      AUTHOR_EMAIL = 'dmoles@berkeley.edu'.freeze
+      AUTHORS = ['David Moles', 'Yuchai Zhou', 'David Zuckerman'].freeze
+      AUTHOR_EMAILS = ['dmoles@berkeley.edu', 'zhouyu@berkeley.edu', 'dzuckerm@berkeley.edu'].freeze
       SUMMARY = 'TIND DA utilities for the UC Berkeley Library'.freeze
       DESCRIPTION = 'UC Berkeley Library utility gem for working with the TIND DA digital archive.'.freeze
       LICENSE = 'MIT'.freeze
-      VERSION = '0.7.2'.freeze
+      VERSION = '0.7.3'.freeze
       HOMEPAGE = 'https://github.com/BerkeleyLibrary/tind'.freeze
     end
   end

data/lib/berkeley_library/tind.rb

@@ -1,3 +1,3 @@
 require 'marc_extensions'
 
-Dir.glob(File.expand_path('tind/*.rb', __dir__)).sort.each(&method(:require))
+Dir.glob(File.expand_path('tind/*.rb', __dir__)).each(&method(:require))

data/lib/berkeley_library/util/ods/xml/namespace.rb

@@ -34,7 +34,8 @@ module BerkeleyLibrary
 
           class << self
             def for_prefix(prefix)
-              @by_prefix ||= Namespace.map { |ns| [ns.prefix, ns] }.to_h
+              # @by_prefix ||= Namespace.map { |ns| [ns.prefix, ns] }.to_h
+              @by_prefix ||= Namespace.to_h { |ns| [ns.prefix, ns] }
               @by_prefix[prefix.to_s]
             end
           end

data/lib/berkeley_library/util/ods/xml/office/automatic_styles.rb

@@ -145,7 +145,8 @@ module BerkeleyLibrary
               return add_cell_style if f == Style::Family::TABLE_CELL
               return add_column_style if f == Style::Family::TABLE_COLUMN
               return add_row_style if f == Style::Family::TABLE_ROW
-              return add_table_style if f == Style::Family::TABLE
+
+              add_table_style if f == Style::Family::TABLE
             end
 
             def next_name_for(family)

data/lib/berkeley_library/util/ods/xml/style/text_properties.rb

@@ -8,7 +8,7 @@ module BerkeleyLibrary
           class TextProperties < ElementNode
 
             FONT_WEIGHT_ATTRS = %w[font-weight font-weight-asian font-weight-complex].freeze
-            COLOR_RE = /^#[[:xdigit:]]{6}$/.freeze
+            COLOR_RE = /^#[[:xdigit:]]{6}$/
 
             attr_reader :color, :font_name, :language, :country, :font_weight
 

data/lib/berkeley_library/util/ods/xml/table/table_column.rb

@@ -23,11 +23,11 @@ module BerkeleyLibrary
               set_default_attributes!
             end
 
-            # rubocop:disable Naming/PredicateName
+            # rubocop:disable Naming/PredicatePrefix
             def has_styles?(column_style, default_cell_style)
               self.column_style == column_style && self.default_cell_style == default_cell_style
             end
-            # rubocop:enable Naming/PredicateName
+            # rubocop:enable Naming/PredicatePrefix
 
             private
 

data/lib/berkeley_library/util/ods/xml/text/p.rb

@@ -87,7 +87,8 @@ module BerkeleyLibrary
 
               return S.new(doc: doc) if c == ' '
               return Tab.new(doc: doc) if c == "\t"
-              return LineBreak.new(doc: doc) if c == "\n"
+
+              LineBreak.new(doc: doc) if c == "\n"
             end
           end
 

data/lib/berkeley_library/view

@@ -0,0 +1,339 @@
+Inspecting 98 files
+WWC.C..C.WCC....C..CC..C..C.W.....................C...W.C.CCCC.C.CC.CCCCCCCCCCC.CCCCCCCCCCCC.CCCCC
+
+Offenses:
+
+tind.rb:3:50: W: [Correctable] Lint/RedundantDirGlobSort: Remove redundant sort.
+Dir.glob(File.expand_path('tind/*.rb', __dir__)).sort.each(&method(:require))
+                                                 ^^^^
+tind/api.rb:1:49: W: [Correctable] Lint/RedundantDirGlobSort: Remove redundant sort.
+Dir.glob(File.expand_path('api/*.rb', __dir__)).sort.each(&method(:require))
+                                                ^^^^
+tind/api/api.rb:109:42: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          URIs.get(endpoint_uri, params: params, headers: headers)
+                                         ^^^^^^
+tind/api/api.rb:109:59: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          URIs.get(endpoint_uri, params: params, headers: headers)
+                                                          ^^^^^^^
+tind/api/api.rb:111:65: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          raise APIException.wrap(e, url: endpoint_uri, params: params)
+                                                                ^^^^^^
+tind/api/collection.rb:28:63: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          children.each { |c| c.each_descendant(include_self: include_self, &block) }
+                                                              ^^^^^^^^^^^^
+tind/api/search.rb:53:48: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          return to_enum(:each_result, freeze: freeze) unless block_given?
+                                               ^^^^^^
+tind/api/search.rb:55:34: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          perform_search(freeze: freeze, &block)
+                                 ^^^^^^
+tind/api/search.rb:63:61: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          params = search_id ? self.params.merge(search_id: search_id) : self.params
+                                                            ^^^^^^^^^
+tind/api/search.rb:65:61: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          perform_search(search_id: next_search_id, freeze: freeze, &block) if next_search_id
+                                                            ^^^^^^
+tind/api/search.rb:81:82: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          xml_reader = BerkeleyLibrary::TIND::MARC::XMLReader.read(body, freeze: freeze)
+                                                                                 ^^^^^^
+tind/export.rb:1:52: W: [Correctable] Lint/RedundantDirGlobSort: Remove redundant sort.
+Dir.glob(File.expand_path('export/*.rb', __dir__)).sort.each(&method(:require))
+                                                   ^^^^
+tind/export/column.rb:46:55: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          return to_enum(:each_value, include_header: include_header) unless block_given?
+                                                      ^^^^^^^^^^^^^^
+tind/export/column_group.rb:19:24: C: [Correctable] Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.
+        INDICATOR_RE = /^[0-9a-z ]$/i.freeze
+                       ^^^^^^^^^^^^^^^^^^^^^
+tind/export/column_group.rb:21:28: C: [Correctable] Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.
+        SUBFIELD_CODE_RE = /^[0-9a-z]$/.freeze
+                           ^^^^^^^^^^^^^^^^^^^
+tind/export/export.rb:29:72: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          exporter = exporter_for(collection, format, exportable_only: exportable_only)
+                                                                       ^^^^^^^^^^^^^^^
+tind/export/export.rb:41:67: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          export_format.exporter_for(collection, exportable_only: exportable_only)
+                                                                  ^^^^^^^^^^^^^^^
+tind/export/export_format.rb:15:63: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          return CSVExporter.new(collection, exportable_only: exportable_only) if self == ExportFormat::CSV
+                                                              ^^^^^^^^^^^^^^^
+tind/export/export_format.rb:16:63: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          return ODSExporter.new(collection, exportable_only: exportable_only) if self == ExportFormat::ODS
+                                                              ^^^^^^^^^^^^^^^
+tind/export/exporter.rb:94:51: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            results = API::Search.new(collection: collection).each_result(freeze: true)
+                                                  ^^^^^^^^^^
+tind/export/exporter.rb:98:80: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            Export::Table.from_records(results, freeze: true, exportable_only: exportable_only)
+                                                                               ^^^^^^^^^^^^^^^
+tind/export/ods_exporter.rb:77:51: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          styles.find_or_create_cell_style(color: color, font_weight: font_weight, wrap: wrap)
+                                                  ^^^^^
+tind/export/ods_exporter.rb:77:71: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          styles.find_or_create_cell_style(color: color, font_weight: font_weight, wrap: wrap)
+                                                                      ^^^^^^^^^^^
+tind/export/ods_exporter.rb:77:90: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          styles.find_or_create_cell_style(color: color, font_weight: font_weight, wrap: wrap)
+                                                                                         ^^^^
+tind/export/ods_exporter.rb:128:87: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            cell_style = find_or_create_cell_style(color: color_for(col_index), wrap: wrap)
+                                                                                      ^^^^
+tind/export/table.rb:27:65: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          @column_groups = ColumnGroupList.new(exportable_only: exportable_only)
+                                                                ^^^^^^^^^^^^^^^
+tind/export/table.rb:41:40: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            Table.new(exportable_only: exportable_only).tap do |table|
+                                       ^^^^^^^^^^^^^^^
+tind/mapping.rb:1:53: W: [Correctable] Lint/RedundantDirGlobSort: Remove redundant sort.
+Dir.glob(File.expand_path('mapping/*.rb', __dir__)).sort.each(&method(:require))
+                                                    ^^^^
+tind/mapping/tind_marc.rb:110:59: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            add_tindfield(new_fls, f, excluding_subfield: excluding_subfield)
+                                                          ^^^^^^^^^^^^^^^^^^
+tind/marc.rb:1:50: W: [Correctable] Lint/RedundantDirGlobSort: Remove redundant sort.
+Dir.glob(File.expand_path('marc/*.rb', __dir__)).sort.each(&method(:require))
+                                                 ^^^^
+tind/marc/xml_reader.rb:18:28: C: [Correctable] Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.
+        COMMENT_TOTAL_RE = /Search-Engine-Total-Number-Of-Results: ([0-9]+)/.freeze
+                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+tind/marc/xml_reader.rb:66:33: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            new(source, freeze: freeze)
+                                ^^^^^^
+tind/module_info.rb:5:17: C: [Correctable] Style/MutableConstant: Freeze mutable objects assigned to constants.
+      AUTHORS = ['David Moles'.freeze, 'Yucha Zhou'.freeze, 'David Zuckerman'.freeze]
+                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+tind/module_info.rb:6:23: C: [Correctable] Style/MutableConstant: Freeze mutable objects assigned to constants.
+      AUTHOR_EMAILS = ['dmoles@berkeley.edu'.freeze, 'zhouyu@berkeley.edu'.freeze, 'dzuckerm@berkeley.edu'.freeze]
+                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+util/ods/spreadsheet.rb:23:63: C: [Correctable] Style/HashSyntax: Omit the hash value.
+          content.document_content.add_table(name, protected: protected)
+                                                              ^^^^^^^^^
+util/ods/xml/content_doc.rb:20:68: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            @document_content ||= Office::DocumentContent.new(doc: doc)
+                                                                   ^^^
+util/ods/xml/document_node.rb:20:49: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            return write_xml_to_string(compact: compact) unless out
+                                                ^^^^^^^
+util/ods/xml/document_node.rb:21:54: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            return write_xml_to_stream(out, compact: compact) if out.respond_to?(:write)
+                                                     ^^^^^^^
+util/ods/xml/document_node.rb:23:45: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            write_xml_to_file(out, compact: compact)
+                                            ^^^^^^^
+util/ods/xml/document_node.rb:46:49: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              write_xml_to_stream(out, compact: compact)
+                                                ^^^^^^^
+util/ods/xml/document_node.rb:51:73: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            File.open(path, 'wb') { |f| write_xml_to_stream(f, compact: compact) }
+                                                                        ^^^^^^^
+util/ods/xml/loext/table_protection.rb:10:54: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:loext, 'table-protection', doc: doc)
+                                                     ^^^
+util/ods/xml/manifest/manifest.rb:14:49: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:manifest, 'manifest', doc: doc)
+                                                ^^^
+util/ods/xml/manifest_doc.rb:20:55: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            @manifest ||= Manifest::Manifest.new(doc: doc)
+                                                      ^^^
+util/ods/xml/office/automatic_styles.rb:18:55: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:office, 'automatic-styles', doc: doc)
+                                                      ^^^
+util/ods/xml/office/automatic_styles.rb:39:83: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              add_style(Style::CellStyle.new(name, protected, color, font_weight: font_weight, wrap: wrap, styles: self))
+                                                                                  ^^^^^^^^^^^
+util/ods/xml/office/automatic_styles.rb:39:102: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              add_style(Style::CellStyle.new(name, protected, color, font_weight: font_weight, wrap: wrap, styles: self))
+                                                                                                     ^^^^
+util/ods/xml/office/automatic_styles.rb:82:66: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              existing_style = find_cell_style(protected, color: color, font_weight: font_weight, wrap: wrap)
+                                                                 ^^^^^
+util/ods/xml/office/automatic_styles.rb:82:86: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              existing_style = find_cell_style(protected, color: color, font_weight: font_weight, wrap: wrap)
+                                                                                     ^^^^^^^^^^^
+util/ods/xml/office/automatic_styles.rb:82:105: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              existing_style = find_cell_style(protected, color: color, font_weight: font_weight, wrap: wrap)
+                                                                                                        ^^^^
+util/ods/xml/office/automatic_styles.rb:85:66: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              add_cell_style(nil, protected, color, font_weight: font_weight, wrap: wrap)
+                                                                 ^^^^^^^^^^^
+util/ods/xml/office/automatic_styles.rb:85:85: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              add_cell_style(nil, protected, color, font_weight: font_weight, wrap: wrap)
+                                                                                    ^^^^
+util/ods/xml/office/body.rb:10:43: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:office, 'body', doc: doc)
+                                          ^^^
+util/ods/xml/office/document_content.rb:27:55: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:office, 'document-content', doc: doc)
+                                                      ^^^
+util/ods/xml/office/document_content.rb:37:45: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              @scripts ||= Scripts.new(doc: doc)
+                                            ^^^
+util/ods/xml/office/document_content.rb:41:67: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              @font_face_decls ||= Office::FontFaceDecls.new(doc: doc)
+                                                                  ^^^
+util/ods/xml/office/document_content.rb:45:70: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              @automatic_styles ||= Office::AutomaticStyles.new(doc: doc)
+                                                                     ^^^
+util/ods/xml/office/document_content.rb:49:105: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              new_table = XML::Table::Table.new(name, table_style, styles: automatic_styles, protected: protected)
+                                                                                                        ^^^^^^^^^
+util/ods/xml/office/document_content.rb:54:61: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              @spreadsheet ||= Office::Spreadsheet.new(doc: doc)
+                                                            ^^^
+util/ods/xml/office/document_content.rb:58:39: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              @body ||= Body.new(doc: doc).tap { |body| body.add_child(spreadsheet) }
+                                      ^^^
+util/ods/xml/office/document_styles.rb:14:54: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:office, 'document-styles', doc: doc)
+                                                     ^^^
+util/ods/xml/office/document_styles.rb:31:48: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              add_child(FontFaceDecls.new(doc: doc))
+                                               ^^^
+util/ods/xml/office/document_styles.rb:32:41: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              add_child(Styles.new(doc: doc))
+                                        ^^^
+util/ods/xml/office/font_face_decls.rb:11:54: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:office, 'font-face-decls', doc: doc)
+                                                     ^^^
+util/ods/xml/office/font_face_decls.rb:23:49: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              Style::FontFace.default_face(doc: doc)
+                                                ^^^
+util/ods/xml/office/scripts.rb:10:46: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:office, 'scripts', doc: doc)
+                                             ^^^
+util/ods/xml/office/spreadsheet.rb:11:50: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:office, 'spreadsheet', doc: doc)
+                                                 ^^^
+util/ods/xml/office/spreadsheet.rb:15:71: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              @named_expressions ||= Table::NamedExpressions.new(doc: doc)
+                                                                      ^^^
+util/ods/xml/office/styles.rb:13:45: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:office, 'styles', doc: doc)
+                                            ^^^
+util/ods/xml/office/styles.rb:22:72: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              add_child(Style::Style.new('Default', 'table-cell', doc: doc))
+                                                                       ^^^
+util/ods/xml/office/styles.rb:27:53: C: [Correctable] Style/HashSyntax: Omit the hash value.
+                Style::ParagraphProperties.new(doc: doc),
+                                                    ^^^
+util/ods/xml/office/styles.rb:28:95: C: [Correctable] Style/HashSyntax: Omit the hash value.
+                Style::TextProperties.new(font_name: Style::FontFace::DEFAULT_FONT_FACE, doc: doc)
+                                                                                              ^^^
+util/ods/xml/office/styles.rb:30:58: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              Style::DefaultStyle.new('table-cell', doc: doc).tap do |ds|
+                                                         ^^^
+util/ods/xml/style/cell_style.rb:50:81: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              children << TableCellProperties.new(protected?, wrap: wrap?, doc: doc)
+                                                                                ^^^
+util/ods/xml/style/cell_style.rb:51:53: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              children << TextProperties.new(color: color, font_weight: font_weight, doc: doc) if custom_text_properties?
+                                                    ^^^^^
+util/ods/xml/style/cell_style.rb:51:73: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              children << TextProperties.new(color: color, font_weight: font_weight, doc: doc) if custom_text_properties?
+                                                                        ^^^^^^^^^^^
+util/ods/xml/style/cell_style.rb:51:91: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              children << TextProperties.new(color: color, font_weight: font_weight, doc: doc) if custom_text_properties?
+                                                                                          ^^^
+util/ods/xml/style/column_style.rb:29:65: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              children << TableColumnProperties.new(width, doc: doc)
+                                                                ^^^
+util/ods/xml/style/default_style.rb:14:51: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:style, 'default-style', doc: doc)
+                                                  ^^^
+util/ods/xml/style/font_face.rb:14:47: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:style, 'font-face', doc: doc)
+                                              ^^^
+util/ods/xml/style/font_face.rb:24:113: C: [Correctable] Style/HashSyntax: Omit the hash value.
+                FontFace.new(FontFace::DEFAULT_FONT_FACE, family_generic: 'swiss', font_pitch: 'variable', doc: doc)
+                                                                                                                ^^^
+util/ods/xml/style/paragraph_properties.rb:15:58: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:style, 'paragraph-properties', doc: doc)
+                                                         ^^^
+util/ods/xml/style/row_style.rb:30:63: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              children << TableRowProperties.new(height, doc: doc)
+                                                              ^^^
+util/ods/xml/style/style.rb:15:43: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:style, 'style', doc: doc)
+                                          ^^^
+util/ods/xml/style/table_cell_properties.rb:12:59: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:style, 'table-cell-properties', doc: doc)
+                                                          ^^^
+util/ods/xml/style/table_column_properties.rb:12:58: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:style, 'table-row-properties', doc: doc)
+                                                         ^^^
+util/ods/xml/style/table_properties.rb:10:54: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:style, 'table-properties', doc: doc)
+                                                     ^^^
+util/ods/xml/style/table_row_properties.rb:12:61: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:style, 'table-column-properties', doc: doc)
+                                                            ^^^
+util/ods/xml/style/table_style.rb:20:52: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              children << TableProperties.new(doc: doc)
+                                                   ^^^
+util/ods/xml/style/text_properties.rb:11:24: C: [Correctable] Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.
+            COLOR_RE = /^#[[:xdigit:]]{6}$/.freeze
+                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
+util/ods/xml/style/text_properties.rb:17:53: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:style, 'text-properties', doc: doc)
+                                                    ^^^
+util/ods/xml/styles_doc.rb:20:66: C: [Correctable] Style/HashSyntax: Omit the hash value.
+            @document_styles ||= Office::DocumentStyles.new(doc: doc)
+                                                                 ^^^
+util/ods/xml/table/named_expressions.rb:10:55: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:table, 'named-expressions', doc: doc)
+                                                      ^^^
+util/ods/xml/table/table.rb:166:57: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              add_child(LOExt::TableProtection.new(doc: doc))
+                                                        ^^^
+util/ods/xml/table/table_cell.rb:14:86: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super('table-cell', 'number-columns-repeated', number_repeated, table: table)
+                                                                                     ^^^^^
+util/ods/xml/table/table_cell.rb:25:72: C: [Correctable] Style/HashSyntax: Omit the hash value.
+                TableCell.new(nil, cell_style, number_repeated, table: table)
+                                                                       ^^^^^
+util/ods/xml/table/table_cell.rb:38:56: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              children << XML::Text::P.new(value, doc: doc) if value
+                                                       ^^^
+util/ods/xml/table/table_column.rb:19:88: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super('table-column', 'number-columns-repeated', number_repeated, table: table)
+                                                                                       ^^^^^
+util/ods/xml/table/table_row.rb:25:82: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super('table-row', 'number-rows-repeated', number_repeated, table: table)
+                                                                                 ^^^^^
+util/ods/xml/table/table_row.rb:36:108: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              explicit_cells[column_index] = TableCell.new(value, cell_style || default_cell_style, table: table)
+                                                                                                           ^^^^^
+util/ods/xml/table/table_row.rb:127:91: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              empty_cell = TableCell.repeat_empty(num_repeats, default_cell_style, table: table)
+                                                                                          ^^^^^
+util/ods/xml/text/p.rb:24:38: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:text, 'p', doc: doc)
+                                     ^^^
+util/ods/xml/text/p.rb:88:33: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              return S.new(doc: doc) if c == ' '
+                                ^^^
+util/ods/xml/text/p.rb:89:35: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              return Tab.new(doc: doc) if c == "\t"
+                                  ^^^
+util/ods/xml/text/p.rb:90:41: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              return LineBreak.new(doc: doc) if c == "\n"
+                                        ^^^
+util/ods/xml/text/p.rb:99:38: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:text, 's', doc: doc)
+                                     ^^^
+util/ods/xml/text/p.rb:105:40: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:text, 'tab', doc: doc)
+                                       ^^^
+util/ods/xml/text/p.rb:111:47: C: [Correctable] Style/HashSyntax: Omit the hash value.
+              super(:text, 'line-break', doc: doc)
+                                              ^^^
+
+98 files inspected, 108 offenses detected, 108 offenses autocorrectable
+
+The following RuboCop extension libraries are installed but not loaded in config:
+  * rubocop-rake
+  * rubocop-rspec
+
+You can opt out of this message by adding the following to your config (see https://docs.rubocop.org/rubocop/extensions.html#extension-suggestions for more options):
+  AllCops:
+    SuggestExtensions: false

data/spec/berkeley_library/tind/api/collection_spec.rb

@@ -64,7 +64,7 @@ module BerkeleyLibrary
               .with(headers: { 'Authorization' => 'Token not-a-real-api-key' })
               .to_return(status: 200, body: collections_json)
 
-            actual_names = Collection.each_collection.each_with_object([]) { |c, arr| arr << c.name }
+            actual_names = Collection.each_collection.with_object([]) { |c, arr| arr << c.name }
             expect(actual_names).to contain_exactly(*expected_names)
           end
         end

data/spec/berkeley_library/tind/api/search_spec.rb

@@ -45,7 +45,7 @@ module BerkeleyLibrary
               results = []
               enum = search.each_result
               expect(enum).to be_a(Enumerable)
-              enum.each { |r| results << r }
+              enum.map { |r| results << r }
               expect(results.size).to eq(5)
             end
 
@@ -131,7 +131,8 @@ module BerkeleyLibrary
               results = []
               enum = search.each_result
               expect(enum).to be_a(Enumerable)
-              enum.each { |r| results << r }
+              # enum.each { |r| results << r }
+              enum.map { |r| results << r }
               expect(results.size).to eq(expected_count)
             end
 

data/spec/berkeley_library/tind/config_spec.rb

@@ -10,13 +10,13 @@ module BerkeleyLibrary
         @base_uri_orig = Config.instance_variable_get(:@base_uri)
         Config.instance_variable_set(:@base_uri, nil)
 
-        @base_url_orig = ENV['LIT_TIND_BASE_URL']
+        @base_url_orig = ENV.fetch('LIT_TIND_BASE_URL', nil)
         ENV['LIT_TIND_BASE_URL'] = env_base_url
 
         @api_key_orig = Config.instance_variable_get(:@api_key)
         Config.instance_variable_set(:@api_key, nil)
 
-        @api_key_env_orig = ENV['LIT_TIND_API_KEY']
+        @api_key_env_orig = ENV.fetch('LIT_TIND_API_KEY', nil)
         ENV['LIT_TIND_API_KEY'] = env_api_key
       end
 
@@ -41,11 +41,13 @@ module BerkeleyLibrary
         it 'returns a URI from Rails config if present' do
           expect(defined?(Rails)).to be_nil
 
-          Object.send(:const_set, 'Rails', OpenStruct.new)
-          Rails.application = OpenStruct.new
+          Object.send(:const_set, 'Rails', Struct.new(:application).new)
+          Rails.application = Struct.new(:config).new
 
           url = 'tind-test.example.edu'
-          config = OpenStruct.new(tind_base_uri: url)
+          Conf = Struct.new(:tind_base_uri)
+          config = Conf.new(url)
+
           Rails.application.config = config
 
           ENV['LIT_TIND_BASE_URL'] = nil
@@ -68,11 +70,12 @@ module BerkeleyLibrary
         it 'returns an API key from the Rails config if present' do
           expect(defined?(Rails)).to be_nil
 
-          Object.send(:const_set, 'Rails', OpenStruct.new)
-          Rails.application = OpenStruct.new
+          Object.send(:const_set, 'Rails', Struct.new(:application).new)
+          Rails.application = Struct.new(:config).new
 
           api_key = 'test-api-key'
-          config = OpenStruct.new(tind_api_key: api_key)
+          Conf = Struct.new(:tind_api_key)
+          config = Conf.new(api_key)
           Rails.application.config = config
 
           ENV['LIT_TIND_API_KEY'] = nil

data/spec/berkeley_library/tind/export/config_spec.rb

@@ -31,7 +31,7 @@ module BerkeleyLibrary
         before(:each) do
           @env_orig = {}
           env_vars.each do |v|
-            @env_orig[v] = ENV[v]
+            @env_orig[v] = ENV.fetch(v, nil)
             ENV[v] = nil
           end
           @inst_orig = {}
@@ -79,11 +79,11 @@ module BerkeleyLibrary
               format_digits: 'ODS_FORMAT_DIGITS_DEFAULT'
             }
 
-            expected = env_vars_by_attr.map do |attr, var|
+            expected = env_vars_by_attr.to_h do |attr, var|
               value = 2 * Config.send(attr)
               ENV[var] = value.to_s
               [attr, value]
-            end.to_h
+            end
 
             inst_vars.each do |v|
               Config.remove_instance_variable(v) if Config.instance_variable_defined?(v)

data/spec/berkeley_library/tind/mapping/alma_spec.rb

@@ -3,25 +3,35 @@ require 'spec_helper'
 module BerkeleyLibrary
   module TIND
     module Mapping
+
       describe Alma do
         let(:alma_obj) { Alma.new('spec/data/mapping/record.xml') }
+        let(:alma_obj_missing) { Alma.new('spec/data/mapping/record_missing_control.xml') }
 
         it 'control field value' do
           expect(alma_obj.control_field.tag).to eq '008'
         end
 
         it 'control field value' do
-          expect(alma_obj.control_field.tag).to eq '008'
+          expect(alma_obj_missing.control_field).to be nil
         end
 
         it '880 field' do
           expect(alma_obj.field_880('245-01/$1')['6']).to eq '245-01/$1'
         end
 
+        it 'expects 880 field to be nil if no $6' do
+          expect(alma_obj_missing.field_880('fake_value')).to be nil
+        end
+
         it 'regular field' do
           expect(alma_obj.field('245').tag).to eq '245'
         end
 
+        it 'expects non mapped field to be nil' do
+          expect(alma_obj.field('99182')).to be nil
+        end
+
       end
     end
   end

data/spec/berkeley_library/tind/mapping/csv_mapper_spec.rb

@@ -6,8 +6,8 @@ module BerkeleyLibrary
     module Mapping
       describe CsvMapper do
         let(:dummy_class) { Class.new { extend CsvMapper } }
-        let(:from_tag) { %w[100 110 111 242 245 246 250 255 260 264 300 351 490 500 502 505 507 520 522 524 536 541 545 546 600 610 611 630 650 651 655 700 710 711 720 752 773 907] }
-        let(:rules_keys) { %i[tag_100 tag_110 tag_111 tag_242 tag_245 tag_246 tag_250 tag_255 tag_260 tag_264 tag_300 tag_351 tag_490 tag_500 tag_502 tag_505 tag_507 tag_520 tag_522 tag_524 tag_536 tag_541 tag_545 tag_546 tag_600 tag_610 tag_611 tag_630 tag_650 tag_651 tag_655 tag_700 tag_710 tag_711 tag_720 tag_752 tag_773 tag_907] }
+        let(:from_tag) { %w[100 110 111 242 245 246 250 255 260 264 300 351 490 500 502 505 507 520 522 524 536 541 545 546 561 600 610 611 630 650 651 655 700 710 711 720 752 773 907] }
+        let(:rules_keys) { %i[tag_100 tag_110 tag_111 tag_242 tag_245 tag_246 tag_250 tag_255 tag_260 tag_264 tag_300 tag_351 tag_490 tag_500 tag_502 tag_505 tag_507 tag_520 tag_522 tag_524 tag_536 tag_541 tag_545 tag_546 tag_561 tag_600 tag_610 tag_611 tag_630 tag_650 tag_651 tag_655 tag_700 tag_710 tag_711 tag_720 tag_752 tag_773 tag_907] }
 
         it 'get origin tags' do
           expect(dummy_class.from_tags).to eq from_tag

data/spec/berkeley_library/tind/mapping/field_catalog_util_spec.rb

@@ -78,7 +78,7 @@ module BerkeleyLibrary
             selected_field_tags << '001'
             fields = qualified_alm_record.fields.select { |f| selected_field_tags.include? f.tag }
             BerkeleyLibrary::TIND::Mapping::AlmaBase.including_origin_tags = %w[255 650]
-            expect(fields_to_map(fields).map(&:tag)).to eq %w[001 255 650 650 880]  # return: Two 650 fields, one 880 field with subfield6 = '650'
+            expect(fields_to_map(fields).map(&:tag)).to eq %w[001 255 650 650 880] # return: Two 650 fields, one 880 field with subfield6 = '650'
           end
 
           context 'only excluding origin tags are defined ' do

data/spec/berkeley_library/tind/mapping/tind_field_spec.rb

@@ -14,7 +14,7 @@ module BerkeleyLibrary
         it 'Field 035 derived from mms_id' do
           f = TindField.f_035_from_alma_id('991085821143406532', 'cu_news')
           expect(f.tag).to eq '035'
-          expect(f['a']).to eq  '(cu_news)991085821143406532'
+          expect(f['a']).to eq '(cu_news)991085821143406532'
         end
 
         it 'Field 245$p' do
@@ -26,8 +26,8 @@ module BerkeleyLibrary
         it 'Field FFT' do
           f = TindField.f_fft('http://host/image.tif', 'news')
           expect(f.tag).to eq 'FFT'
-          expect(f['a']).to eq  'http://host/image.tif'
-          expect(f['d']).to eq  'news'
+          expect(f['a']).to eq 'http://host/image.tif'
+          expect(f['d']).to eq 'news'
         end
 
         it 'Field 902$d' do
@@ -40,7 +40,7 @@ module BerkeleyLibrary
         it 'Field 902$n' do
           f = TindField.f_902_n('YZ')
           expect(f.tag).to eq '902'
-          expect(f['n']).to eq  'YZ'
+          expect(f['n']).to eq 'YZ'
         end
 
         it 'Field 982$p' do