berkeley_library-alma 0.0.3 → 0.0.6

data/spec/lib/berkeley_library/alma/sru/xml_reader_spec.rb

@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+module BerkeleyLibrary
+  module Alma
+    module SRU
+      describe XMLReader do
+        let(:sru_xml_1) { File.read('spec/data/availability-sru-page-1.xml') }
+        let(:sru_xml_2) { File.read('spec/data/availability-sru-page-2.xml') }
+
+        let(:reader) { XMLReader.read(sru_xml_2) }
+        let(:expected_ids) { %w[991008719659706532 991005668209706532 991008363529706532 991008402049706532 991008719819706532] }
+
+        it 'reads the records' do
+          records = reader.to_a
+          expect(records.size).to eq(expected_ids.size)
+          expect(records.map(&:record_id)).to eq(expected_ids)
+        end
+
+        describe :new do
+          it 'raises an error for unreadable sources' do
+            not_xml = Object.new
+            expect { XMLReader.read(not_xml) }.to raise_error(ArgumentError)
+          end
+        end
+
+        describe :num_records do
+          it 'returns the <numberOfRecords/> value' do
+            reader.first # make sure we've gotten far enough in the doc to parse
+            expect(reader.num_records).to eq(15)
+          end
+        end
+
+        describe :last_record_position do
+          it 'returns the (1-indexed) position of the most recent record' do
+            position_base = 11
+            reader.each_with_index do |_, i|
+              expect(reader.last_record_position).to eq(position_base + i)
+            end
+          end
+        end
+
+        describe :last_record_id do
+          it 'returns the ID of the most recent record' do
+            reader.each do |record|
+              expect(reader.last_record_id).to eq(record.record_id)
+            end
+          end
+        end
+
+        describe :next_record_position do
+          it 'returns nil if there is no next page' do
+            reader.to_a # read all records
+            expect(reader.next_record_position).to be_nil
+          end
+
+          it 'returns the record position of the next page' do
+            reader = XMLReader.read(sru_xml_1)
+            reader.to_a # read all records
+            expect(reader.next_record_position).to eq(11)
+          end
+        end
+
+        describe :records_yielded do
+          it 'returns the number of records yielded' do
+            expect(reader.records_yielded).to eq(0)
+            reader.each_with_index do |_, i|
+              expect(reader.records_yielded).to eq(i)
+            end
+            expect(reader.records_yielded).to eq(5)
+          end
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -31,26 +31,17 @@ require 'berkeley_library/alma'
 # ------------------------------------------------------------
 # Utility methods
 
-def sru_url_for(record_id)
-  sru_url_base = 'https://berkeley.alma.exlibrisgroup.com/view/sru/01UCS_BER?version=1.2&operation=searchRetrieve&query='
-
-  if BerkeleyLibrary::Alma::Constants::ALMA_RECORD_RE =~ record_id
-    "#{sru_url_base}alma.mms_id%3D#{record_id}"
-  elsif BerkeleyLibrary::Alma::Constants::MILLENNIUM_RECORD_RE =~ record_id
-    full_bib_number = BerkeleyLibrary::Alma::BibNumber.new(record_id).to_s
-    "#{sru_url_base}alma.local_field_996%3D#{full_bib_number}"
-  else
-    raise ArgumentError, "Unknown record ID type: #{record_id}"
-  end
+def sru_url_for(index, value)
+  "https://berkeley.alma.exlibrisgroup.com/view/sru/01UCS_BER?version=1.2&operation=searchRetrieve&query=#{index}%3D#{value}"
 end
 
 def sru_data_path_for(record_id)
   "spec/data/#{record_id}-sru.xml"
 end
 
-def stub_sru_request(record_id)
-  sru_url = sru_url_for(record_id)
-  marc_xml_path = sru_data_path_for(record_id)
+def stub_sru_request(index, value)
+  sru_url_ = sru_url_for(index, value)
+  marc_xml_path = sru_data_path_for(value)
 
-  stub_request(:get, sru_url).to_return(status: 200, body: File.read(marc_xml_path))
+  stub_request(:get, sru_url_).to_return(status: 200, body: File.read(marc_xml_path))
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: berkeley_library-alma
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.6
 platform: ruby
 authors:
 - David Moles
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-03 00:00:00.000000000 Z
+date: 2022-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: berkeley_library-logging
@@ -47,7 +47,7 @@ dependencies:
         version: '0.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.1.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -57,7 +57,7 @@ dependencies:
         version: '0.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.1.2
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -269,12 +269,16 @@ files:
 - bin/alma-mms-lookup
 - docker-compose.yml
 - lib/berkeley_library/alma.rb
+- lib/berkeley_library/alma/barcode.rb
 - lib/berkeley_library/alma/bib_number.rb
 - lib/berkeley_library/alma/config.rb
 - lib/berkeley_library/alma/constants.rb
 - lib/berkeley_library/alma/mms_id.rb
 - lib/berkeley_library/alma/module_info.rb
 - lib/berkeley_library/alma/record_id.rb
+- lib/berkeley_library/alma/sru.rb
+- lib/berkeley_library/alma/sru/sru.rb
+- lib/berkeley_library/alma/sru/xml_reader.rb
 - rakelib/bundle.rake
 - rakelib/coverage.rake
 - rakelib/gem.rake
@@ -282,12 +286,19 @@ files:
 - rakelib/spec.rake
 - spec/.rubocop.yml
 - spec/data/991054360089706532-sru.xml
-- spec/data/b11082434-sru.xml
+- spec/data/C084093187-sru.xml
+- spec/data/availability-sru-page-1.xml
+- spec/data/availability-sru-page-2.xml
+- spec/data/availability-sru.xml
+- spec/data/b110824349-sru.xml
 - spec/data/bibs_with_check_digits.txt
+- spec/lib/berkeley_library/alma/barcode_spec.rb
 - spec/lib/berkeley_library/alma/bib_number_spec.rb
 - spec/lib/berkeley_library/alma/config_spec.rb
 - spec/lib/berkeley_library/alma/mms_id_spec.rb
 - spec/lib/berkeley_library/alma/record_id_spec.rb
+- spec/lib/berkeley_library/alma/sru/sru_spec.rb
+- spec/lib/berkeley_library/alma/sru/xml_reader_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/BerkeleyLibrary/alma
 licenses:
@@ -315,10 +326,17 @@ summary: Alma/Primo utilities for the UC Berkeley Library
 test_files:
 - spec/.rubocop.yml
 - spec/data/991054360089706532-sru.xml
-- spec/data/b11082434-sru.xml
+- spec/data/C084093187-sru.xml
+- spec/data/availability-sru-page-1.xml
+- spec/data/availability-sru-page-2.xml
+- spec/data/availability-sru.xml
+- spec/data/b110824349-sru.xml
 - spec/data/bibs_with_check_digits.txt
+- spec/lib/berkeley_library/alma/barcode_spec.rb
 - spec/lib/berkeley_library/alma/bib_number_spec.rb
 - spec/lib/berkeley_library/alma/config_spec.rb
 - spec/lib/berkeley_library/alma/mms_id_spec.rb
 - spec/lib/berkeley_library/alma/record_id_spec.rb
+- spec/lib/berkeley_library/alma/sru/sru_spec.rb
+- spec/lib/berkeley_library/alma/sru/xml_reader_spec.rb
 - spec/spec_helper.rb