berater 0.6.0 → 0.8.0

data/spec/test_mode_spec.rb

@@ -1,35 +1,20 @@
-describe Berater::TestMode, order: :defined do
-  let(:reset_test_mode) { true }
-
-  after do
-    Berater.test_mode = nil if reset_test_mode
-  end
-
-  context 'after test_mode.rb was required, but not used' do
-    let(:reset_test_mode) { false }
-
-    it 'has already been loaded by "berater/rspec", unfortunately' do
-      expect {
-        expect { Berater.test_mode }.to raise_error(NoMethodError)
-      }.to fail
+describe Berater::TestMode do
+  context 'after test_mode.rb has been loaded' do
+    it 'monkey patches Berater' do
+      expect(Berater).to respond_to(:test_mode)
     end
 
     it 'defaults to off' do
       expect(Berater.test_mode).to be nil
     end
 
-    it 'did not prepend .new yet' do
-      expect(Berater::Limiter.singleton_class.ancestors).not_to include(described_class)
-    end
-
-    it 'prepends when first turned on' do
-      Berater.test_mode = :pass
-
-      expect(Berater::Limiter.singleton_class.ancestors).to include(described_class)
+    it 'prepends Limiter subclasses' do
+      expect(Berater::Unlimiter.ancestors).to include(Berater::Limiter::TestMode)
+      expect(Berater::Inhibitor.ancestors).to include(Berater::Limiter::TestMode)
     end
 
     it 'preserves the original functionality via super' do
-      expect { Berater::Limiter.new }.to raise_error(NotImplementedError)
+      expect { Berater::Limiter.new }.to raise_error(NoMethodError)
     end
   end
 
@@ -50,31 +35,53 @@ describe Berater::TestMode, order: :defined do
     it 'validates input' do
       expect { Berater.test_mode = :foo }.to raise_error(ArgumentError)
     end
-  end
 
-  shared_examples 'it always works, without redis' do
-    before do
-      Berater.redis = nil
-      expect_any_instance_of(Berater::LuaScript).not_to receive(:eval)
+    it 'works no matter when limiter was created' do
+      limiter = Berater::Unlimiter.new
+      expect(limiter).not_to be_overloaded
+
+      Berater.test_mode = :fail
+      expect(limiter).to be_overloaded
+    end
+
+    it 'supports a generic expectation' do
+      Berater.test_mode = :pass
+      expect_any_instance_of(Berater::Limiter).to receive(:limit)
+      Berater::Unlimiter.new.limit
     end
+  end
 
-    it_behaves_like 'it is not overloaded'
+  describe '.reset' do
+    before { Berater.test_mode = :pass }
 
-    it 'always works' do
-      10.times { subject.limit }
+    it 'resets test_mode' do
+      expect(Berater.test_mode).to be :pass
+      Berater.reset
+      expect(Berater.test_mode).to be nil
     end
   end
 
-  shared_examples 'it never works, without redis' do
+  shared_examples 'it supports test_mode' do
     before do
+      # without hitting Redis
       Berater.redis = nil
       expect_any_instance_of(Berater::LuaScript).not_to receive(:eval)
     end
 
-    it_behaves_like 'it is overloaded'
+    context 'with test_mode = :pass' do
+      before { Berater.test_mode = :pass }
+
+      it_behaves_like 'it is not overloaded'
+
+      it 'always works' do
+        10.times { subject.limit }
+      end
+    end
+
+    context 'with test_mode = :fail' do
+      before { Berater.test_mode = :fail }
 
-    it 'never works' do
-      expect { subject }.to be_overloaded
+      it_behaves_like 'it is overloaded'
     end
   end
 
@@ -84,23 +91,10 @@ describe Berater::TestMode, order: :defined do
     context 'when test_mode = nil' do
       before { Berater.test_mode = nil }
 
-      it { is_expected.to be_a Berater::Unlimiter }
-      it_behaves_like 'it always works, without redis'
-    end
-
-    context 'when test_mode = :pass' do
-      before { Berater.test_mode = :pass }
-
-      it { is_expected.to be_a Berater::Unlimiter }
-      it_behaves_like 'it always works, without redis'
+      it_behaves_like 'it is not overloaded'
     end
 
-    context 'when test_mode = :fail' do
-      before { Berater.test_mode = :fail }
-
-      it { is_expected.to be_a Berater::Unlimiter }
-      it_behaves_like 'it never works, without redis'
-    end
+    it_behaves_like 'it supports test_mode'
   end
 
   describe 'Inhibitor' do
@@ -109,42 +103,18 @@ describe Berater::TestMode, order: :defined do
     context 'when test_mode = nil' do
       before { Berater.test_mode = nil }
 
-      it { is_expected.to be_a Berater::Inhibitor }
-      it_behaves_like 'it never works, without redis'
-    end
-
-    context 'when test_mode = :pass' do
-      before { Berater.test_mode = :pass }
-
-      it { is_expected.to be_a Berater::Inhibitor }
-      it_behaves_like 'it always works, without redis'
+      it_behaves_like 'it is overloaded'
     end
 
-    context 'when test_mode = :fail' do
-      before { Berater.test_mode = :fail }
-
-      it { is_expected.to be_a Berater::Inhibitor }
-      it_behaves_like 'it never works, without redis'
-    end
+    it_behaves_like 'it supports test_mode'
   end
 
   describe 'RateLimiter' do
     subject { Berater::RateLimiter.new(:key, 1, :second) }
 
-    shared_examples 'a RateLimiter' do
-      it { is_expected.to be_a Berater::RateLimiter }
-
-      it 'checks arguments' do
-        expect {
-          Berater::RateLimiter.new(:key, 1)
-        }.to raise_error(ArgumentError)
-      end
-    end
-
     context 'when test_mode = nil' do
       before { Berater.test_mode = nil }
 
-      it_behaves_like 'a RateLimiter'
       it_behaves_like 'it is not overloaded'
 
       it 'works per usual' do
@@ -154,19 +124,7 @@ describe Berater::TestMode, order: :defined do
       end
     end
 
-    context 'when test_mode = :pass' do
-      before { Berater.test_mode = :pass }
-
-      it_behaves_like 'a RateLimiter'
-      it_behaves_like 'it always works, without redis'
-    end
-
-    context 'when test_mode = :fail' do
-      before { Berater.test_mode = :fail }
-
-      it_behaves_like 'a RateLimiter'
-      it_behaves_like 'it never works, without redis'
-    end
+    it_behaves_like 'it supports test_mode'
   end
 
   describe 'ConcurrencyLimiter' do
@@ -175,8 +133,6 @@ describe Berater::TestMode, order: :defined do
     context 'when test_mode = nil' do
       before { Berater.test_mode = nil }
 
-      it { is_expected.to be_a Berater::ConcurrencyLimiter }
-
       it_behaves_like 'it is not overloaded'
 
       it 'works per usual' do
@@ -186,21 +142,7 @@ describe Berater::TestMode, order: :defined do
       end
     end
 
-    context 'when test_mode = :pass' do
-      before { Berater.test_mode = :pass }
-
-      it { is_expected.to be_a Berater::ConcurrencyLimiter }
-
-      it_behaves_like 'it always works, without redis'
-    end
-
-    context 'when test_mode = :fail' do
-      before { Berater.test_mode = :fail }
-
-      it { is_expected.to be_a Berater::ConcurrencyLimiter }
-
-      it_behaves_like 'it never works, without redis'
-    end
+    it_behaves_like 'it supports test_mode'
   end
 
 end

data/spec/unlimiter_spec.rb

@@ -1,9 +1,11 @@
 describe Berater::Unlimiter do
+  subject { described_class.new }
+
   it_behaves_like 'a limiter', described_class.new
 
   describe '.new' do
     it 'initializes without any arguments or options' do
-      expect(described_class.new).to be_a described_class
+      is_expected.to be_a described_class
     end
 
     it 'initializes with any arguments and options' do
@@ -11,14 +13,12 @@ describe Berater::Unlimiter do
     end
 
     it 'has default values' do
-      expect(described_class.new.key).to be :unlimiter
-      expect(described_class.new.redis).to be Berater.redis
+      expect(subject.key).to be :unlimiter
+      expect(subject.redis).to be Berater.redis
     end
   end
 
   describe '#limit' do
-    subject { described_class.new }
-
     it_behaves_like 'it is not overloaded'
 
     it 'is never overloaded' do
@@ -27,4 +27,10 @@ describe Berater::Unlimiter do
       end
     end
   end
+
+  describe '#to_s' do
+    it do
+      expect(subject.to_s).to include described_class.to_s
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: berater
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Daniel Pepper
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-07 00:00:00.000000000 Z
+date: 2021-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -138,6 +138,7 @@ files:
 - lib/berater/rate_limiter.rb
 - lib/berater/rspec.rb
 - lib/berater/rspec/matchers.rb
+- lib/berater/static_limiter.rb
 - lib/berater/test_mode.rb
 - lib/berater/unlimiter.rb
 - lib/berater/utils.rb
@@ -152,6 +153,7 @@ files:
 - spec/matchers_spec.rb
 - spec/rate_limiter_spec.rb
 - spec/riddle_spec.rb
+- spec/static_limiter_spec.rb
 - spec/test_mode_spec.rb
 - spec/unlimiter_spec.rb
 - spec/utils_spec.rb
@@ -190,5 +192,6 @@ test_files:
 - spec/utils_spec.rb
 - spec/berater_spec.rb
 - spec/limiter_spec.rb
+- spec/static_limiter_spec.rb
 - spec/inhibitor_spec.rb
 - spec/unlimiter_spec.rb