beniya 0.5.1 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6110d8a673eee02088b1d95fac741e95b4d470cbb5b5bb5826b3e6ac65893890
-  data.tar.gz: 9030f59ba585966f29faa34eb2d450cff37f836431368ac5e4b2a0bb011e0cb2
+  metadata.gz: eabacf1e9c20898106af324c8275d857b209150badec6518d211a1820a78778f
+  data.tar.gz: 4e43ee255191fdad616db68a320d77f326e7fb925932145cdf6e528a4f6f67ef
 SHA512:
-  metadata.gz: 06a6a371c75c3c36125f26ae556893c32e4e9d0eba25ebd6f14e20e9957408fed671ace6d587f0d98477ad8e5f856373fcb4b0eae9ec3b23e60840f8c8298dbf
-  data.tar.gz: cb5d756ba159db9ecc9018b6fb44c9b0f05d8a213668e686653c09963406cde6ccf136993e259fa88d2d0b9528001e456d9e3b9b1a0cf139e4ddc1f6e8baa72f
+  metadata.gz: 19f7fba9a329ca1dae8b3fa1d63898af7e0f16030bbf60cb8e8b10d5af02d4e2bbba783fef30df30e2c212fef06bb07628b9122139d0c50a093752f4a2bdb0a0
+  data.tar.gz: d3a21a8322852750a2410145ffbd63d4c0ed72c7ae5485b6763f68d192872f05a4b7ddea62900ca910c21e04252347bcbcd679b2c1b5fbbe7721734fea8db2d8

data/CHANGELOG.md

@@ -7,6 +7,31 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.6.0] - 2025-01-XX
+
+### Added
+- **🚀 zoxide Integration**: Complete zoxide directory history navigation functionality
+- **z Key Navigation**: Press `z` key to display zoxide movement history and navigate to frequently used directories
+- **Smart History Display**: Frequency-based directory sorting with up to 20 history entries
+- **Interactive Selection UI**: Modern floating window for intuitive history selection
+- **Fast Number Key Selection**: Direct directory selection using number keys 1-20
+- **Health Check Enhancement**: zoxide installation status and version checking with `beniya -c`
+- **Multi-platform Installation Support**: Automated installation instructions for macOS and Linux
+- **Graceful Fallback**: Proper handling when zoxide is not installed or history is empty
+
+### Changed
+- **Footer Help Updates**: Added `z:zoxide` to key binding display in both English and Japanese
+- **External Tools Documentation**: Updated README with zoxide installation and usage instructions
+- **Health Check System**: Extended to include zoxide as optional dependency with platform-specific guidance
+- **Error Messaging**: Improved user guidance for zoxide-related issues
+
+### Technical Details
+- New zoxide integration methods in `KeybindHandler` class
+- Extended `HealthChecker` with zoxide version checking
+- Comprehensive test suite for zoxide functionality
+- Safe path escaping using Ruby's Shellwords module
+- **Detailed changelog**: [CHANGELOG_v0.6.0.md](./CHANGELOG_v0.6.0.md)
+
 ## [0.5.0] - 2025-09-20
 
 ### Added
@@ -99,6 +124,8 @@ For detailed information, see [CHANGELOG_v0.4.0.md](./CHANGELOG_v0.4.0.md)
 
 ## Release Links
 
+- [v0.6.0 Detailed Release Notes](./CHANGELOG_v0.6.0.md) - zoxide Integration and Enhanced Health Checking
+- [v0.5.0 Detailed Release Notes](./CHANGELOG_v0.5.0.md) - Bookmark System Implementation
 - [v0.4.0 Detailed Release Notes](./CHANGELOG_v0.4.0.md) - Comprehensive changelog with technical details
 - [GitHub Releases](https://github.com/masisz/beniya/releases) - Download releases and view release history
 - [Installation Guide](./README.md#installation) - How to install beniya

data/CHANGELOG_v0.6.0.md

@@ -0,0 +1,182 @@
+# CHANGELOG - beniya v0.6.0
+
+**Release Date**: 2025-09-28
+
+## 🚀 New Features
+
+### zoxide Integration
+
+- **zoxide History Navigation with z Key**: Press `z` key to display zoxide movement history and quickly navigate to previously visited directories
+- **Smart History Display**: Frequently used directories appear at the top of the list
+- **Interactive Selection UI**: Floating window displays up to 20 history entries
+- **Fast Selection with Number Keys**: Select directories directly using number keys 1-20
+- **Abbreviated Path Display**: Home directory displayed as `~` with nicely formatted long paths
+- **Graceful Handling**: Proper handling when zoxide is not installed or history is empty
+
+### Health Check Enhancement
+
+- **zoxide Check Addition**: Check zoxide installation status and version with `beniya -c`
+- **Installation Instructions**: Detailed platform-specific (macOS/Linux) installation instructions
+
+## 🎨 UI/UX Improvements
+
+### User Interface
+
+- **Footer Help Updates**:
+  - English version: Added `z:zoxide` to key binding list
+  - Japanese version: Added `z:zoxide` to key binding list
+- **zoxide History Selection Dialog**: Intuitive floating window for history selection
+- **Improved Error Messages**: Clear guidance when zoxide is not installed
+
+## 📖 Documentation Updates
+
+### README Updates
+
+**Japanese Version (README.md)**:
+
+- New zoxide integration features section
+- Added `z:zoxide` to key bindings list
+- Detailed explanation of zoxide overview and installation methods
+- Added zoxide to required external tools list
+- Clarified purpose of each tool
+
+**English Version (README_EN.md)**:
+
+- New zoxide Integration Features section
+- Added `z:zoxide integration` to Key Bindings
+- Detailed zoxide explanation and installation instructions
+- Expanded Required External Tools section
+- Clarified Tool Usage
+
+### Added Documentation Content
+
+- **Detailed explanation of zoxide history navigation features**
+- **Usage examples and workflows**
+- **Overview of zoxide**
+- **Platform-specific installation methods**
+- **Requirements and limitations**
+
+## 🔧 Technical Improvements
+
+### Architecture
+
+- **KeybindHandler Class Extension**: Added zoxide-related methods
+  - `zoxide_available?`: Check zoxide availability
+  - `get_zoxide_history`: Get and parse zoxide history
+  - `show_zoxide_menu`: Display history in floating window
+  - `select_from_zoxide_history`: Interactive history selection
+  - `navigate_to_zoxide_directory`: Navigate to selected directory
+
+### HealthChecker Class Extension
+
+- **check_zoxide Method**: Version checking and status verification for zoxide
+- **install_instruction_for Method Extension**: Added installation instructions for zoxide
+
+### Configuration System
+
+- **Multi-language Message Support**:
+  - `health.zoxide`: Support for both English and Japanese
+  - Updated footer help messages
+
+## 🧪 Testing
+
+### New Tests Added
+
+- **zoxide Integration Tests** (`test/test_zoxide_integration.rb`):
+  - zoxide availability tests
+  - History retrieval functionality tests
+  - UI display tests
+  - Directory navigation tests
+  - Error handling tests
+
+- **Health Check Test Extensions**:
+  - `test_check_zoxide`: zoxide check functionality tests
+  - `test_install_instruction_for_zoxide`: Installation instruction tests
+
+## 📦 Dependencies
+
+### New Dependencies
+
+- **zoxide**: Directory history functionality (optional)
+  - macOS: `brew install zoxide`
+  - Ubuntu/Debian: `apt install zoxide`
+  - Others: [Official Documentation](https://github.com/ajeetdsouza/zoxide#installation)
+
+### Dependency Updates
+
+- **Shellwords Module**: Used for path escaping (Ruby standard library)
+
+## 🔄 Compatibility
+
+### Backward Compatibility
+
+- **No Impact on Existing Features**: No changes to existing key bindings or functionality
+- **Configuration File Compatibility**: Existing configuration files can be used as-is
+- **Optional Feature**: All existing features work normally even without zoxide
+
+### Platform Support
+
+- **macOS**: Full support (installation via Homebrew recommended)
+- **Linux**: Full support (via package managers)
+- **Windows**: Basic compatibility (zoxide installation methods need separate verification)
+
+## ⚡ Performance
+
+### Optimizations
+
+- **Efficient History Retrieval**: Optimal use of zoxide query commands
+- **Memory Usage**: History display limited to maximum 20 entries
+- **Responsiveness**: Fast floating window rendering
+
+## 🐛 Bug Fixes
+
+### Fixed Issues
+
+- **zoxide Output Format Support**: Correctly retrieve scored output with `zoxide query --list --score`
+- **Empty History Handling**: Proper message display when no history exists
+- **Path Escaping**: Safe handling of paths with special characters
+
+## 🔮 Future Plans
+
+### Planned for Next Version
+
+- **zoxide Integration Update History Recording**: Automatically record directory movements within beniya to zoxide
+- **Customizable History Display Count**: Adjust display count via configuration file
+- **History Filtering**: Filter history by specific patterns
+
+## 📝 Usage Examples
+
+### Basic Usage
+
+```bash
+# Launch beniya
+beniya
+
+# Press z key to display zoxide history
+# Enter displayed number (1-20) to navigate to directory
+# Press ESC to cancel
+```
+
+### Health Check
+
+```bash
+# Check all dependencies including zoxide
+beniya -c
+
+# Example output:
+# ✓ zoxide (directory history) zoxide 0.9.8
+```
+
+## 🙏 Acknowledgments
+
+Main contributions in this version:
+
+- **zoxide**: [ajeetdsouza/zoxide](https://github.com/ajeetdsouza/zoxide) - Excellent directory navigation tool
+- **Ruby Standard Library**: Utilization of Shellwords module
+
+---
+
+**Note**: This version is the initial implementation of zoxide integration features. We welcome feedback and improvement suggestions.
+
+**GitHub Issues**: [https://github.com/masisz/beniya/issues](https://github.com/masisz/beniya/issues)
+

data/README.md

@@ -111,6 +111,12 @@ beniya --help           # ヘルプメッセージを表示
 | `b`       | ブックマークメニューを表示   |
 | `1`-`9`   | 対応する番号のブックマークに移動 |
 
+#### zoxide連携機能
+
+| キー | 機能                               |
+| ---- | ---------------------------------- |
+| `z`  | zoxide履歴からディレクトリを選択移動 |
+
 #### システム操作
 
 | キー | 機能         |
@@ -225,22 +231,68 @@ beniya起動時のディレクトリが**ベースディレクトリ**として
 - beniya再起動後もブックマーク情報が保持される
 - JSONファイルを直接編集することも可能
 
+### zoxide連携機能の詳細
+
+#### zoxide履歴移動 (`z`)
+
+- **スマート履歴**: zoxideが記録したディレクトリ移動履歴を表示
+- **フリークエンシー順**: よく使用するディレクトリほど上位に表示
+- **インタラクティブ選択**: フローティングウィンドウで履歴を選択
+- **高速ナビゲーション**: 数字キーで直接ディレクトリを選択
+- **パス省略表示**: ホームディレクトリを`~`で表示し見やすく
+
+#### 使用例
+
+```
+1. z → zoxide履歴メニューを表示
+2. 1-20 → 表示された番号でディレクトリを選択
+3. ESC → キャンセルして元の画面に戻る
+```
+
+#### zoxideについて
+
+[zoxide](https://github.com/ajeetdsouza/zoxide)は、ディレクトリ移動履歴を学習するスマートなcdコマンドです。
+
+```bash
+# zoxideのインストール
+# macOS (Homebrew)
+brew install zoxide
+
+# Ubuntu/Debian
+apt install zoxide
+
+# その他のインストール方法は公式ドキュメントを参照
+# https://github.com/ajeetdsouza/zoxide#installation
+```
+
+#### 動作要件
+
+- zoxideがシステムにインストールされている必要があります
+- zoxideが無効な場合は適切なメッセージが表示されます
+- 履歴が空の場合も適切にハンドリングされます
+
 ### 必要な外部ツール
 
-検索機能を使用するには、以下のツールが必要です:
+検索機能・履歴機能を使用するには、以下のツールが必要です:
 
 ```bash
 # macOS (Homebrew)
-brew install fzf rga
+brew install fzf rga zoxide
 
 # Ubuntu/Debian
-apt install fzf
+apt install fzf zoxide
 # rgaは別途インストールが必要: https://github.com/phiresky/ripgrep-all
 
 # その他のLinuxディストリビューション
 # パッケージマネージャーまたは手動インストールが必要
 ```
 
+#### 各ツールの用途
+
+- **fzf**: ファイル名検索機能（`s`キー）
+- **rga**: ファイル内容検索機能（`F`キー）  
+- **zoxide**: ディレクトリ履歴移動機能（`z`キー）
+
 ## 設定
 
 ### 色設定（カスタマイズ）

data/README_EN.md

@@ -105,6 +105,19 @@ beniya --help           # Show help message
 | `f` | File name search with fzf (with preview) |
 | `F` | File content search with rga             |
 
+#### Bookmark Functions
+
+| Key     | Function                        |
+| ------- | ------------------------------- |
+| `b`     | Show bookmark menu              |
+| `1`-`9` | Go to corresponding bookmark    |
+
+#### zoxide Integration
+
+| Key | Function                           |
+| --- | ---------------------------------- |
+| `z` | Select directory from zoxide history |
+
 #### System Operations
 
 | Key | Function    |
@@ -198,22 +211,89 @@ The directory where beniya starts becomes the **base directory**, which serves a
 - Searches PDFs, Word documents, text in images, and more
 - Filter results with fzf and jump to specific lines
 
+### Bookmark Features
+
+#### Bookmark Operations (`b`)
+
+- **Add Bookmark**: `[A]` - Add current directory to bookmarks
+- **List Bookmarks**: `[L]` - Display registered bookmarks
+- **Remove Bookmark**: `[R]` - Remove a bookmark
+- **Number Jump**: `1-9` - Jump directly to corresponding bookmark
+
+#### Quick Navigation (`1`-`9`)
+
+- Jump directly to bookmarks without going through the bookmark menu
+- Supports up to 9 bookmarks
+- Bookmark information is displayed at the top of the screen
+
+#### Bookmark Persistence
+
+- Bookmark information is automatically saved to `~/.config/beniya/bookmarks.json`
+- Bookmark information is preserved after beniya restarts
+- JSON file can be edited directly
+
+### zoxide Integration Features
+
+#### zoxide History Navigation (`z`)
+
+- **Smart History**: Display directory navigation history recorded by zoxide
+- **Frequency Order**: More frequently used directories appear higher in the list
+- **Interactive Selection**: Select from history using floating window
+- **Quick Navigation**: Select directories directly with number keys
+- **Abbreviated Path Display**: Home directory shown as `~` for readability
+
+#### Usage Example
+
+```
+1. z → Display zoxide history menu
+2. 1-20 → Select directory by displayed number
+3. ESC → Cancel and return to original screen
+```
+
+#### About zoxide
+
+[zoxide](https://github.com/ajeetdsouza/zoxide) is a smart cd command that learns your directory navigation habits.
+
+```bash
+# Installing zoxide
+# macOS (Homebrew)
+brew install zoxide
+
+# Ubuntu/Debian
+apt install zoxide
+
+# For other installation methods, see official documentation
+# https://github.com/ajeetdsouza/zoxide#installation
+```
+
+#### Requirements
+
+- zoxide must be installed on the system
+- Appropriate message is displayed when zoxide is not available
+- Empty history is handled gracefully
+
 ### Required External Tools
 
-The following tools are required for search functionality:
+The following tools are required for search and history functionality:
 
 ```bash
 # macOS (Homebrew)
-brew install fzf rga
+brew install fzf rga zoxide
 
 # Ubuntu/Debian
-apt install fzf
+apt install fzf zoxide
 # rga requires separate installation: https://github.com/phiresky/ripgrep-all
 
 # Other Linux distributions
 # Installation via package manager or manual installation required
 ```
 
+#### Tool Usage
+
+- **fzf**: File name search functionality (`f` key)
+- **rga**: File content search functionality (`F` key)
+- **zoxide**: Directory history navigation functionality (`z` key)
+
 ## Configuration
 
 ### Color Configuration (Customization)

data/lib/beniya/application.rb

@@ -2,6 +2,9 @@
 
 module Beniya
   class Application
+    # Error display constants
+    BACKTRACE_LINES = 5  # Number of backtrace lines to show
+
     def initialize(start_directory = Dir.pwd)
       @start_directory = File.expand_path(start_directory)
       # Load configuration including language settings
@@ -22,7 +25,7 @@ module Beniya
       puts "\n\n#{ConfigLoader.message('app.interrupted')}"
     rescue StandardError => e
       puts "\n#{ConfigLoader.message('app.error_occurred')}: #{e.message}"
-      puts e.backtrace.first(5).join("\n")
+      puts e.backtrace.first(BACKTRACE_LINES).join("\n")
     end
   end
 end

data/lib/beniya/config.rb

@@ -43,8 +43,8 @@ module Beniya
         'ui.operation_prompt' => 'Operation: ',
 
         # Help text
-        'help.full' => 'j/k:move h:back l:enter o:open g/G:top/bottom r:refresh f:filter s:search F:content a/A:create m/p/x:ops b:bookmark 1-9:goto q:quit',
-        'help.short' => 'j/k:move h:back l:enter o:open f:filter s:search b:bookmark 1-9:goto q:quit',
+        'help.full' => 'j/k:move h:back l:enter o:open g/G:top/bottom r:refresh f:filter s:search F:content a/A:create m/p/x:ops b:bookmark z:zoxide 1-9:goto q:quit',
+        'help.short' => 'j/k:move h:back l:enter o:open f:filter s:search b:bookmark z:zoxide 1-9:goto q:quit',
 
         # Health check messages
         'health.title' => 'beniya Health Check',
@@ -52,6 +52,7 @@ module Beniya
         'health.required_gems' => 'Required gems',
         'health.fzf' => 'fzf (file search)',
         'health.rga' => 'rga (content search)',
+        'health.zoxide' => 'zoxide (directory history)',
         'health.file_opener' => 'System file opener',
         'health.summary' => 'Summary:',
         'health.ok' => 'OK',
@@ -111,8 +112,8 @@ module Beniya
         'ui.operation_prompt' => '操作: ',
 
         # Help text
-        'help.full' => 'j/k:移動 h:戻る l:入る o:開く g/G:先頭/末尾 r:更新 f:絞込 s:検索 F:内容 a/A:作成 m/p/x:操作 b:ブックマーク 1-9:移動 q:終了',
-        'help.short' => 'j/k:移動 h:戻る l:入る o:開く f:絞込 s:検索 b:ブックマーク 1-9:移動 q:終了',
+        'help.full' => 'j/k:移動 h:戻る l:入る o:開く g/G:先頭/末尾 r:更新 f:絞込 s:検索 F:内容 a/A:作成 m/p/x:操作 b:ブックマーク z:zoxide 1-9:移動 q:終了',
+        'help.short' => 'j/k:移動 h:戻る l:入る o:開く f:絞込 s:検索 b:ブックマーク z:zoxide 1-9:移動 q:終了',
 
         # Health check messages
         'health.title' => 'beniya ヘルスチェック',
@@ -120,6 +121,7 @@ module Beniya
         'health.required_gems' => '必須 gem',
         'health.fzf' => 'fzf (ファイル検索)',
         'health.rga' => 'rga (内容検索)',
+        'health.zoxide' => 'zoxide (ディレクトリ履歴)',
         'health.file_opener' => 'システムファイルオープナー',
         'health.summary' => 'サマリー:',
         'health.ok' => 'OK',

data/lib/beniya/file_preview.rb

@@ -6,6 +6,13 @@ module Beniya
     DEFAULT_MAX_LINES = 50
     MAX_LINE_LENGTH = 500
 
+    # Binary detection constants
+    BINARY_SAMPLE_SIZE = 512
+    PRINTABLE_CHAR_THRESHOLD = 32
+    CONTROL_CHAR_TAB = 9
+    CONTROL_CHAR_NEWLINE = 10
+    CONTROL_CHAR_CARRIAGE_RETURN = 13
+
     def initialize
       # future: hold syntax highlight settings etc.
     end
@@ -19,7 +26,7 @@ module Beniya
 
       begin
         # binary file detection
-        sample = File.binread(file_path, [file_size, 512].min)
+        sample = File.binread(file_path, [file_size, BINARY_SAMPLE_SIZE].min)
         return binary_response(file_path) if binary_file?(sample)
 
         # process as text file
@@ -44,8 +51,9 @@ module Beniya
 
     def binary_file?(sample)
       return false if sample.empty?
-      
-      binary_chars = sample.bytes.count { |byte| byte < 32 && ![9, 10, 13].include?(byte) }
+
+      allowed_control_chars = [CONTROL_CHAR_TAB, CONTROL_CHAR_NEWLINE, CONTROL_CHAR_CARRIAGE_RETURN]
+      binary_chars = sample.bytes.count { |byte| byte < PRINTABLE_CHAR_THRESHOLD && !allowed_control_chars.include?(byte) }
       (binary_chars.to_f / sample.bytes.length) > BINARY_THRESHOLD
     end
 

data/lib/beniya/health_checker.rb

@@ -20,6 +20,7 @@ module Beniya
         { name: ConfigLoader.message('health.required_gems'), method: :check_required_gems },
         { name: ConfigLoader.message('health.fzf'), method: :check_fzf },
         { name: ConfigLoader.message('health.rga'), method: :check_rga },
+        { name: ConfigLoader.message('health.zoxide'), method: :check_zoxide },
         { name: ConfigLoader.message('health.file_opener'), method: :check_file_opener }
       ]
 
@@ -118,6 +119,23 @@ module Beniya
       end
     end
 
+    def check_zoxide
+      if system("which zoxide > /dev/null 2>&1")
+        version = `zoxide --version 2>/dev/null`.strip
+        {
+          status: :ok,
+          message: version,
+          details: nil
+        }
+      else
+        {
+          status: :warning,
+          message: "zoxide #{ConfigLoader.message('health.tool_not_found')}",
+          details: install_instruction_for('zoxide')
+        }
+      end
+    end
+
     def check_file_opener
       case RUBY_PLATFORM
       when /darwin/
@@ -160,6 +178,8 @@ module Beniya
           "#{ConfigLoader.message('health.install_brew')} fzf"
         when 'rga'
           "#{ConfigLoader.message('health.install_brew')} rga"
+        when 'zoxide'
+          "#{ConfigLoader.message('health.install_brew')} zoxide"
         end
       when /linux/
         case tool
@@ -167,6 +187,8 @@ module Beniya
           "#{ConfigLoader.message('health.install_apt')} fzf (Ubuntu/Debian) or check your package manager"
         when 'rga'
           ConfigLoader.message('health.rga_releases')
+        when 'zoxide'
+          "#{ConfigLoader.message('health.install_apt')} zoxide (Ubuntu/Debian) or check your package manager"
         end
       else
         ConfigLoader.message('health.install_guide')