bender-bot 0.4.5 → 0.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dea2fba9600c9e3c69175188361d1ecc25963afa
-  data.tar.gz: 6d5dd7070e5be5f27054644d232cec5f128ba01a
+  metadata.gz: 58f5e9eb88fccfcfe2bce294fa9b02014914bae8
+  data.tar.gz: 187c3ff59ad753e5650dc55d44cd6a9532cd3549
 SHA512:
-  metadata.gz: 6012bac14aed3d48856287d444e94f08b45d69cd15f2cb032bb5c0f92f2bfc65a5e0f1df2c84706926850da9edb80496bb2e17f4774fb91d6c0ff8394a8f5771
-  data.tar.gz: 894f41cec02c47f13f3d02d00d1c9bb7c9b542d0a2acb6c4cf6523c34b01634183a3066938e96fc3a2fbaea8c965e65d14500f0b93e5680d59424f873b07e1a7
+  metadata.gz: 52c15e7f21716d9eb37e046d703f79bafd80f186dd570bc2e071b7b974b194c8be6c79a8e37bb926d61d2046e65d3d9eff28de2e8af79c521740e6554db38aab
+  data.tar.gz: 3f6bf43edeba4acabbeeec4aac527153da167f8be8ef53e06b4089043328f45c2a433f587e5ca8850485c592bc89f52c0a2c6ac0511960f753f0d38319960332

data/VERSION

@@ -1 +1 @@
-0.4.5
+0.4.6

data/lib/bender/bot.rb

@@ -99,7 +99,6 @@ class BenderBot
     @sender    = sender
     @message   = message
 
-    severity_field = SHOW_FIELDS.key 'Severity'
     severities = Hash.new { |h,k| h[k] = [] }
 
 
@@ -131,7 +130,7 @@ class BenderBot
         unless status =~ /resolved|closed/i
           '%s (%s - %s) [%s]: %s' % [
             incident_link(i),
-            short_severity(i['fields'][severity_field]['value']),
+            short_severity(i['fields'][SEVERITY_FIELD]['value']),
             normalize_value(i['fields']['status']),
             friendly_date(i['fields']['created']),
             i['fields']['summary']
@@ -162,7 +161,7 @@ class BenderBot
             i['fields']['summary']
           ]
 
-          sev  = i['fields'][severity_field]['value']
+          sev  = i['fields'][SEVERITY_FIELD]['value']
           severities[sev] << repr
           statuses[status] += 1
         end

data/lib/bender/helpers.rb

@@ -30,6 +30,7 @@ module Helpers
     'updated' => 'Updated'
   }
 
+  SEVERITY_FIELD = SHOW_FIELDS.key('Severity')
 
   QUOTES = [
     'Bite my shiny metal ass!',

data/lib/bender/main.rb

@@ -177,14 +177,19 @@ module Bender
       new_room = room.get_room
 
       open_incidents = incidents.select do |i|
-        status = normalize_value i['fields']['status']
-        !(status =~ /resolved|closed/i)
+        status    = normalize_value i['fields']['status']
+        severity  = short_severity(i['fields'][SEVERITY_FIELD]['value']),
+        is_open   = !(status =~ /resolved|closed/i)
+        is_severe = severity =~ /(SEV1|SEV2)/i
+        is_open && is_severe
       end
 
+      log.warn open_incidents: open_incidents
+
       @room_name  ||= bot.store['primary_room_name']  || new_room['name']
       @room_topic ||= bot.store['primary_room_topic'] || new_room['topic']
 
-      @open = 1 unless defined? @open
+      @open = nil unless defined? @open
 
       log.info \
         primary_room_name: bot.store['primary_room_name'],
@@ -196,9 +201,9 @@ module Bender
         open: @open
 
       if open_incidents.empty?
-        if @open
+        if @open.nil? || @open > 0
           new_room['name'] = '[NONE] Production Incident'
-          new_room['topic'] = 'Good news everyone! No open incidents at the moment'
+          new_room['topic'] = 'Good news everyone! No high-severity incidents at the moment'
           begin
             room.update_room(new_room)
           rescue NoMethodError
@@ -209,14 +214,14 @@ module Bender
         @open = 0
 
       else
-        if @open.zero?
+        if @open.nil? || @open.zero?
           @room_name = new_room['name']
           @room_topic = new_room['topic']
         end
 
         unless @open == open_incidents.size
           new_room['name'] = '[IN PROGRESS] Production Incident'
-          tha_news = open_incidents.size == 1 ? "There's an open incident" : "There are #{open_incidents.size} open incidents"
+          tha_news = open_incidents.size == 1 ? "There's a high-severity incident" : "There are #{open_incidents.size} high-severity incidents"
           new_room['topic'] = "Terrible news everyone! #{tha_news}"
           begin
             room.update_room(new_room)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bender-bot
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.4.6
 platform: ruby
 authors:
 - Sean Clemmer