belvo 1.3.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2451a25febe9bcc2e507d13977720f0886f89da8ff9e65d639846ca029717a53
-  data.tar.gz: 0ab5eb4ff9f6196ebc876011f3485e4bcba7a7888cbd20264f0abaaf9380e158
+  metadata.gz: cb2779e82bc56e77377b9c0a11c349fcf2b9e344d094004f8fd4314a3e3e47ba
+  data.tar.gz: 269766531d31fb9e9b33481024bf47ff534b93a2703210d419e382cb1b93b125
 SHA512:
-  metadata.gz: 0ecbbb2a7c36121c8f9bfffdb5dddc4e4d2eb9065e3405ae0574736c808b2d24796c292dfc98a2b50d3431875d8b25bf6db5aea9946f765f5a1dca3acf5fd4d9
-  data.tar.gz: 90490528e75a6cca01484b74094c750368191b726ad36530912c27dc560c49ae85b19856cb462947d6da9f07bce3eff5169265cb206e07a938eead59d3bd9ab1
+  metadata.gz: c7ceb92b9b07ce906f29a71459849f9bef5171ca6028f82e78e0c34404804cf0d591fdcc80684dbdb7623eaa43735d6438d9ed58e39bcfe568384cf65c13ec9a
+  data.tar.gz: a999b7ddb4701aee56cc9da5bcc254efd0b73c5a4195685d219b1b099588af2f161e3810f7b5ed18bfd61bab82bf16987e39f648095f354657042cfd3352a935

data/.github/workflows/danger-pr-reviews-custom.yml

@@ -0,0 +1,52 @@
+name: Run Danger (Custom)
+
+on: [pull_request]
+
+jobs:
+  build:
+    name: Run Danger (Custom)
+    runs-on: ubuntu-latest
+    if: ${{ github.actor != 'dependabot[bot]' }}
+
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 50
+
+      # Setup ruby
+      - name: Set up Ruby 3.2
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.2
+          bundler-cache: true
+
+      # Install the right bundler version
+      - name: Install bundler
+        run: gem install bundler
+
+      # Cache dependencies
+      - name: Cache ruby dependencies
+        id: cache-ruby
+        uses: actions/cache@v3
+        with:
+          path: vendor/bundle
+          key: union-gems-${{ hashFiles('**/Gemfile.lock') }}
+          restore-keys: |
+            union-gems-
+
+      # Install dependencies on cache miss
+      - name: Install ruby dependencies
+        if: steps.cache-ruby.outputs.cache-hit != 'true'
+        run: |
+          bundle config --local without "documentation"
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+
+      # Run danger
+      - name: Run danger
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          bundle config path vendor/bundle
+          bundle exec danger --dangerfile=Dangerfile.custom

data/.github/workflows/danger-pr-reviews.yml

@@ -6,18 +6,20 @@ jobs:
   build:
     name: Run Danger
     runs-on: ubuntu-latest
+    if: ${{ github.actor != 'dependabot[bot]' }}
 
     steps:
       - name: Checkout Code
         uses: actions/checkout@v2
         with:
-          fetch-depth: 10
+          fetch-depth: 50
 
       # Setup ruby
-      - name: Set up Ruby 2.6
-        uses: actions/setup-ruby@v1
+      - name: Set up Ruby 3.2
+        uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.6
+          ruby-version: 3.2
+          bundler-cache: true
 
       # Install the right bundler version
       - name: Install bundler
@@ -26,18 +28,21 @@ jobs:
       # Cache dependencies
       - name: Cache ruby dependencies
         id: cache-ruby
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           path: vendor/bundle
           key: union-gems-${{ hashFiles('**/Gemfile.lock') }}
           restore-keys: |
             union-gems-
+
       # Install dependencies on cache miss
       - name: Install ruby dependencies
         if: steps.cache-ruby.outputs.cache-hit != 'true'
         run: |
+          bundle config --local without "documentation"
           bundle config path vendor/bundle
-          bundle install --jobs 4 --retry 3 --without=documentation
+          bundle install --jobs 4 --retry 3
+
       # Run danger
       - name: Run danger
         env:
@@ -45,4 +50,3 @@ jobs:
         run: |
           bundle config path vendor/bundle
           bundle exec danger
-

data/.github/workflows/generate-docs.yml

@@ -11,9 +11,10 @@ jobs:
       - name: Checkout Belvo Ruby SDK repo
         uses: actions/checkout@v2
       - name: Set up Ruby
-        uses: actions/setup-ruby@v1
+        uses: ruby/setup-ruby@v1
         with:
-          ruby-version: "2.7"
+          ruby-version: 3.2
+          bundler-cache: true
       - name: Install required gem dependencies
         run: gem install yard --no-document
       - name: Build RUBY SDK docs with YARD

data/Dangerfile

@@ -1,21 +1,27 @@
-# rubocop:disable all
-# Mainly to encourage writing up some reasoning about the PR, rather than
-# just leaving a title
-fail "Please provide a short summary in the PR description :page_with_curl:" if github.pr_body.length < 10
+# frozen_string_literal: true
 
-# The title should include the correct prefix tag
-if !github.pr_title.match(/^\[(?:Fixed|Added|Changed|Removed|Security|Other)\]/)
-	fail "Please provide a valid PR title label: [Added]/[Fixed]/[Changed]/[Removed]/[Security]/[Other]"
+##########################################################################
+# THIS FILE IS OWNED BY SECURITY CHANGES TO THIS FILE ARE MADE CENTRALLY #
+#          CONTACT SECURITY@BELVO.COM or SLACK #ASK-SECURITY             #
+##########################################################################
+
+# Provide a description
+if github.pr_body.length < 10
+  raise 'Please provide a short summary in the PR description :page_with_curl:'
 end
 
-# The title should include the JIRA ticket unless is a dependabot PR
-if github.pr_labels.include?("dependencies")
-	message ("PR autogenerated by dependabot")
-elsif !github.pr_title.match(/^\[.*\]\s?\[BEL-\d+\]/)
-	fail "Please provide a valid Jira ticket ID associated to this PR: [BEL-XXXX]. If you do not have any associated Jira ticket, just use [BEL-XXXX]"
+# The title has to include a JIRA ticket unless is a dependabot PR or SNYK
+if github.pr_labels.include?('dependencies')
+  message 'PR autogenerated by dependabot'
+elsif github.pr_title =~ /\[Snyk\]/
+  message 'PR generated by Snyk'
+elsif github.pr_title !~ /\[[A-Z]{1,10}-[0-9]{1,5}\]/
+  raise 'Please provide a valid Jira ticket ID associated to this PR'\
+   '(e.g. [BEL-XXXXX]'
 end
 
-warn("PR is classed as Work in Progress", sticky: false) if github.pr_title.include? "[WIP]"
+if github.pr_title.include? '[WIP]'
+  warn('PR is classed as Work in Progress', sticky: false)
+end
 
-message("One approval required for merging :smiley_cat: :smiley_cat:")
-# rubocop:enable all
+message('One approval required for merging')

data/Dangerfile.custom

@@ -0,0 +1,6 @@
+# The PR title should include the correct label
+if !github.pr_title.match(/\[Snyk\]/) &&
+	!github.pr_labels.include?("dependencies") &&
+	!github.pr_title.match(/^\[(?:Added|Changed|Docs|Fixed|Migrations|Other|Removed|Security)\]/)
+	fail "Please provide a valid PR title label: [Added]/[Changed]/[Docs]/[Fixed]/[Migrations]/[Other]/[Removed]/[Security]."
+end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    belvo (1.3.0)
+    belvo (1.5.0)
       faraday
       faraday_middleware
       typhoeus

data/lib/belvo/options.rb

@@ -215,15 +215,11 @@ module Belvo
   class InvestmentsPortfolioOptions < Faraday::Options.new(:token, :save_data)
   end
 
-  # @!class InvestmentsTransactionOptions < Faraday::Options
-  # Contains configurable properties of an InvestmentsTransaction
-  # @!attribute date_to [rw] Date string (YYYY-MM-DD)
+  # @!class EmploymentRecordsOptions < Faraday::Options
+  # Contains configurable properties of an Employment Record
   # @!attribute save_data [rw] Should data be persisted or not.
-  # @!attribute token [rw] OTP token required by the institution
-  class InvestmentsTransactionOptions < Faraday::Options.new(
-    :date_to,
-    :token,
-    :save_data
-  )
+  # @!attribute attach_pdf [rw] Should the PDF file be included in the
+  #   response or not.
+  class EmploymentRecordsOptions < Faraday::Options.new(:save_data, :attach_pdf)
   end
 end

data/lib/belvo/resources.rb

@@ -656,29 +656,26 @@ module Belvo
     end
   end
 
-  # A InvestmentsTransaction gets the existing transactions for an instrument
-  class InvestmentsTransaction < Resource
+  # Employment records
+  class EmploymentRecords < Resource
     def initialize(session)
       super(session)
-      @endpoint = 'investments/transactions/'
+      @endpoint = 'api/employment-records/'
     end
 
-    # Retrieve investments transactions from an existing link
+    # Retrieve employment records from an existing government link
     # @param link [String] Link UUID
-    # @param date_from [String] Date string (YYYY-MM-DD)
-    # @param options [InvestmentsTransactionOptions] Configurable properties
-    # @return [Hash] created investments transactions details
+    # @param options [EmploymentRecordsOptions] Configurable properties
+    # @return [Hash] created employment records details
     # @raise [RequestError] If response code is different than 2XX
-    def retrieve(link:, date_from:, options: nil)
-      options = InvestmentsTransactionOptions.from(options)
-      date_to = options.date_to || Date.today.to_s
+    def retrieve(link:, options: nil)
+      options = EmploymentRecordsOptions.from(options)
       body = {
         link: link,
-        date_from: date_from,
-        date_to: date_to,
-        token: options.token,
-        save_data: options.save_data || true
+        save_data: options.save_data || true,
+        attach_pdf: options.attach_pdf
       }.merge(options)
+
       body = clean body: body
       @session.post(@endpoint, body)
     end

data/lib/belvo/version.rb

@@ -2,5 +2,5 @@
 
 module Belvo
   # belvo-ruby current version
-  VERSION = '1.3.0'
+  VERSION = '1.5.0'
 end

data/lib/belvo.rb

@@ -140,10 +140,10 @@ module Belvo
       @investments_portfolio = InvestmentsPortfolio.new @session
     end
 
-    # Provides access to InvestmentsTransaction resource
-    # @return [InvestmentsTransaction]
-    def investments_transaction
-      @investments_transaction = InvestmentsTransaction.new @session
+    # Provides access to EmploymentRecords resource
+    # @return [EmploymentRecords]
+    def employment_records
+      @employment_records = EmploymentRecords.new @session
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: belvo
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.5.0
 platform: ruby
 authors:
 - Belvo Finance S.L.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-11-16 00:00:00.000000000 Z
+date: 2023-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -151,6 +151,7 @@ files:
 - ".github/CODEOWNERS"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".github/pull_request_template.md"
+- ".github/workflows/danger-pr-reviews-custom.yml"
 - ".github/workflows/danger-pr-reviews.yml"
 - ".github/workflows/generate-docs.yml"
 - ".gitignore"
@@ -158,6 +159,7 @@ files:
 - ".rubocop.yml"
 - CODE_OF_CONDUCT.md
 - Dangerfile
+- Dangerfile.custom
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -173,6 +175,7 @@ files:
 - lib/belvo/resources.rb
 - lib/belvo/utils.rb
 - lib/belvo/version.rb
+- specs.4.8.gz
 homepage: https://github.com/belvo-finance/belvo-ruby
 licenses:
 - MIT
@@ -195,7 +198,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.11
+rubygems_version: 3.3.26
 signing_key: 
 specification_version: 4
 summary: The Ruby gem for the Belvo API